Integrated: 8304478: Initial nroff manpage generation for JDK 22

2023-06-19 Thread David Holmes
On Wed, 14 Jun 2023 04:53:58 GMT, David Holmes wrote: > Updated the version to 22-ea and year to 2024. > > The following unpublished changes will also be included in this update: > - [JDK-8290626](https://bugs.openjdk.org/browse/JDK-8290626): keytool manpage > contains a special character > -

Re: RFR: 8304478: Initial nroff manpage generation for JDK 22

2023-06-19 Thread David Holmes
On Wed, 14 Jun 2023 04:53:58 GMT, David Holmes wrote: > Updated the version to 22-ea and year to 2024. > > The following unpublished changes will also be included in this update: > - [JDK-8290626](https://bugs.openjdk.org/browse/JDK-8290626): keytool manpage > contains a special character > -

Re: RFR: 8304478: Initial nroff manpage generation for JDK 22

2023-06-19 Thread David Holmes
On Wed, 14 Jun 2023 04:53:58 GMT, David Holmes wrote: > Updated the version to 22-ea and year to 2024. > > The following unpublished changes will also be included in this update: > - [JDK-8290626](https://bugs.openjdk.org/browse/JDK-8290626): keytool manpage > contains a special character > -

Re: RFR: 8304478: Initial nroff manpage generation for JDK 22 [v2]

2023-06-19 Thread David Holmes
> Updated the version to 22-ea and year to 2024. > > The following unpublished changes will also be included in this update: > - [JDK-8290626](https://bugs.openjdk.org/browse/JDK-8290626): keytool manpage > contains a special character > -

Integrated: 8310105: LoongArch64 builds are broken after JDK-8304913

2023-06-19 Thread Ao Qi
On Thu, 15 Jun 2023 04:40:59 GMT, Ao Qi wrote: > LoongArch64 Zero builds are broken after > [JDK-8304913](https://bugs.openjdk.org/browse/JDK-8304913): > > jdk.tools.jlink.plugin.PluginException: ModuleTarget is malformed: No enum > constant jdk.internal.util.Architecture.LOONGARCH64 > at >

Re: RFR: 8281658: Add a security category to the java -XshowSettings option [v5]

2023-06-19 Thread Sean Coffey
On Mon, 19 Jun 2023 18:21:49 GMT, Roger Riggs wrote: >> @RogerRiggs - do you mean to print nothing in the "bad command input" >> scenario ? The current -XshowSettings launch behaviour prints all data if a >> bad value is passed to it. I was mimicking this for security subcommands. >> >> Are

Re: RFR: 8281658: Add a security category to the java -XshowSettings option [v7]

2023-06-19 Thread Sean Coffey
> New functionality in the -XshowSettings menu to display relevant information > about JDK security configuration Sean Coffey has updated the pull request incrementally with one additional commit since the last revision: Don't allow bad subcommand values for security component -

Re: RFR: 8310105: LoongArch64 builds are broken after JDK-8304913 [v2]

2023-06-19 Thread Ao Qi
> LoongArch64 Zero builds are broken after > [JDK-8304913](https://bugs.openjdk.org/browse/JDK-8304913): > > jdk.tools.jlink.plugin.PluginException: ModuleTarget is malformed: No enum > constant jdk.internal.util.Architecture.LOONGARCH64 > at >

Integrated: 8310019: MIPS builds are broken after JDK-8304913

2023-06-19 Thread Roger Riggs
On Wed, 14 Jun 2023 15:04:41 GMT, Roger Riggs wrote: > Add mipsel and mips64el to the Architecture enum. > (Later to be backported to JDK 21) This pull request has now been integrated. Changeset: 33c6ec9d Author:Roger Riggs URL:

Re: RFR: 8281658: Add a security category to the java -XshowSettings option [v5]

2023-06-19 Thread Roger Riggs
On Mon, 19 Jun 2023 16:11:12 GMT, Sean Coffey wrote: >> src/java.base/share/classes/sun/launcher/SecuritySettings.java line 66: >> >>> 64: ostream.println("Unrecognized security subcommand. See >>> \"java -X\" for help"); >>> 65: ostream.println("Printing all

Re: RFR: 8281658: Add a security category to the java -XshowSettings option [v4]

2023-06-19 Thread Alan Bateman
On Fri, 16 Jun 2023 11:23:48 GMT, Alan Bateman wrote: >> Sean Coffey has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Refactor out security code to helper class >> - Print aliases. Order Provider type/service output. > >

Re: RFR: JDK-8308398 Move SunEC crypto provider into java.base

2023-06-19 Thread Anthony Scarpino
On Tue, 13 Jun 2023 20:36:28 GMT, Anthony Scarpino wrote: > Hi, > > I need a code review for moving the contents of the jdk.crypto.ec module into > java.base. This moves the SunEC JCE Provider (Elliptic Curve) into > java.base. EC has always been separate from the base module/pkg because

Re: RFR: 8281658: Add a security category to the java -XshowSettings option [v5]

2023-06-19 Thread Sean Coffey
On Sat, 17 Jun 2023 01:51:36 GMT, Weijun Wang wrote: >> Sean Coffey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Pass PrintStream to security helper > > src/java.base/share/classes/sun/launcher/SecuritySettings.java line 93: > >>

Re: RFR: 8281658: Add a security category to the java -XshowSettings option [v4]

2023-06-19 Thread Sean Coffey
On Fri, 16 Jun 2023 11:23:48 GMT, Alan Bateman wrote: >> Sean Coffey has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Refactor out security code to helper class >> - Print aliases. Order Provider type/service output. > >

Re: RFR: 8281658: Add a security category to the java -XshowSettings option [v5]

2023-06-19 Thread Sean Coffey
On Fri, 16 Jun 2023 15:15:59 GMT, Roger Riggs wrote: >> Sean Coffey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Pass PrintStream to security helper > > src/java.base/share/classes/sun/launcher/SecuritySettings.java line 66: > >>

Re: RFR: 8281658: Add a security category to the java -XshowSettings option [v6]

2023-06-19 Thread Sean Coffey
> New functionality in the -XshowSettings menu to display relevant information > about JDK security configuration Sean Coffey has updated the pull request incrementally with two additional commits since the last revision: - restore more informative help message - Split long properties for ;

RFR: 8309937: Add @sealedGraph for some Panama FFM interfaces

2023-06-19 Thread Per Minborg
Hi all, This pull request contains a backport of commit [b412fc79](https://github.com/openjdk/jdk/commit/b412fc79c3c2548df10918090beedaf6b2d08d96) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Per Minborg on 16 Jun 2023 and was

Re: RFR: 8310242: Clarify the name parameter to Class::forName [v4]

2023-06-19 Thread Chen Liang
On Sat, 17 Jun 2023 13:56:15 GMT, Alan Bateman wrote: > This changes look okay but they do make me wonder if we should add a note to > the 2-arg Class.forName to make it clear that it does not allow class names > for array types, the class name has to be a binary name. In its specification:

Re: RFR: JDK-8310265: (process) jspawnhelper should not use argv[0] [v2]

2023-06-19 Thread Volker Simonis
On Mon, 19 Jun 2023 06:07:26 GMT, Thomas Stuefe wrote: >> Reported by [jarabe...@gmail.com](mailto:jarabe...@gmail.com) [1] >> >> jspawnhelper uses argv[0] to receive the fd string from the parent. That >> breaks with conventions and trips over certain tools like binfmt_misc. >> >> For

Re: RFR: 8310187: Improve Generational ZGC jtreg testing [v3]

2023-06-19 Thread Thomas Stuefe
On Mon, 19 Jun 2023 06:55:52 GMT, Axel Boldt-Christmas wrote: >> The current implementation for testing generational ZGC with jtreg is >> implemented with a filter on the mode flag `ZGenerational`. Because of this >> only environments which set this flag explicitly will run most of the tests.

Re: RFR: JDK-8310265: (process) jspawnhelper should not use argv[0] [v2]

2023-06-19 Thread Thomas Stuefe
On Mon, 19 Jun 2023 06:07:26 GMT, Thomas Stuefe wrote: >> Reported by [jarabe...@gmail.com](mailto:jarabe...@gmail.com) [1] >> >> jspawnhelper uses argv[0] to receive the fd string from the parent. That >> breaks with conventions and trips over certain tools like binfmt_misc. >> >> For

Re: RFR: JDK-8310265: (process) jspawnhelper should not use argv[0] [v2]

2023-06-19 Thread Thomas Stuefe
On Mon, 19 Jun 2023 06:07:26 GMT, Thomas Stuefe wrote: >> Reported by [jarabe...@gmail.com](mailto:jarabe...@gmail.com) [1] >> >> jspawnhelper uses argv[0] to receive the fd string from the parent. That >> breaks with conventions and trips over certain tools like binfmt_misc. >> >> For

Re: RFR: JDK-8310265: (process) jspawnhelper should not use argv[0] [v2]

2023-06-19 Thread Aleksey Shipilev
On Mon, 19 Jun 2023 06:07:26 GMT, Thomas Stuefe wrote: >> Reported by [jarabe...@gmail.com](mailto:jarabe...@gmail.com) [1] >> >> jspawnhelper uses argv[0] to receive the fd string from the parent. That >> breaks with conventions and trips over certain tools like binfmt_misc. >> >> For

Re: RFR: 8310187: Improve Generational ZGC jtreg testing [v2]

2023-06-19 Thread Alan Bateman
On Mon, 19 Jun 2023 07:06:00 GMT, Axel Boldt-Christmas wrote: > > Hmmm... hopefully `vm.gc.ZSingelgen` is really `vm.gc.ZSinglegen`. If so > > you might want to fix the PR description. > > What part are you worried about? When would `vm.gc.ZSingelgen` be invalid? > > Also what part of the PR

Re: RFR: 8310187: Improve Generational ZGC jtreg testing [v2]

2023-06-19 Thread Axel Boldt-Christmas
On Fri, 16 Jun 2023 20:31:28 GMT, Daniel D. Daugherty wrote: > Hmmm... hopefully `vm.gc.ZSingelgen` is really `vm.gc.ZSinglegen`. If so you > might want to fix the PR description. What part are you worried about? When would `vm.gc.ZSingelgen` be invalid? Also what part of the PR requires

Re: RFR: 8310187: Improve Generational ZGC jtreg testing [v2]

2023-06-19 Thread Axel Boldt-Christmas
On Sat, 17 Jun 2023 13:24:24 GMT, Alan Bateman wrote: >> Axel Boldt-Christmas has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix wrong ZGenerational flag in VectorRebracket128Test.java > >

Re: RFR: 8310187: Improve Generational ZGC jtreg testing [v3]

2023-06-19 Thread Axel Boldt-Christmas
> The current implementation for testing generational ZGC with jtreg is > implemented with a filter on the mode flag `ZGenerational`. Because of this > only environments which set this flag explicitly will run most of the tests. > So they get missed in Github Actions and for developers running

Re: RFR: JDK-8308398 Move SunEC crypto provider into java.base

2023-06-19 Thread Alan Bateman
On Mon, 19 Jun 2023 05:46:34 GMT, Anthony Scarpino wrote: > From what I was told, the native library was one of the reasons it was not in > the base pkg before modularization and just remained so afterwards. Maybe you are thinking about the size of libsunec or non-technical issues that meant

Re: RFR: JDK-8310265: (process) jspawnhelper should not use argv[0] [v2]

2023-06-19 Thread Thomas Stuefe
> Reported by [jarabe...@gmail.com](mailto:jarabe...@gmail.com) [1] > > jspawnhelper uses argv[0] to receive the fd string from the parent. That > breaks with conventions and trips over certain tools like binfmt_misc. > > For details, see linked ML discussion. > > [1]

Re: jspawnhelper's sometimes problematic use of argv0

2023-06-19 Thread Thomas Stüfe
Thank you Daniel. Comment's fixed. Cheers, Thomas On Sun, Jun 18, 2023 at 2:25 AM Daniel Jarabek wrote: > Hi Thomas, > > Thank you for this quick fix! > > I have tested (after much difficultly getting cross compilation to work - > a good learning experience) and this fix works for me. Using