On Fri, 26 May 2023 14:56:57 GMT, Adam Sotona wrote:
> Classfile context object and multi-state options have been discussed at
> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html
> This patch implements the proposed changes in Classfile API and fixes all
> affected code
On Mon, 26 Jun 2023 16:47:46 GMT, Adam Sotona wrote:
>> Classfile context object and multi-state options have been discussed at
>> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html
>> This patch implements the proposed changes in Classfile API and fixes all
>> affected
On Tue, 27 Jun 2023 03:39:30 GMT, Naoto Sato wrote:
>> Replacing the ambiguous `dash` with `hyphen-minus` for more clarity. There
>> are other locations than `ISO_LOCAL_DATE` that have the same description.
>> Those are corrected too.
>
> Naoto Sato has updated the pull request incrementally
On Mon, 26 Jun 2023 22:02:28 GMT, Chen Liang wrote:
>> This patch touches java.lang.reflect and java.lang.invoke packages. It
>> replaces instanceof + cast with pattern matching and updates
>> Array.newInstance().getClass() patterns with arrayType() for obtaining array
>> types of a class.
>
On Tue, 27 Jun 2023 03:39:30 GMT, Naoto Sato wrote:
>> Replacing the ambiguous `dash` with `hyphen-minus` for more clarity. There
>> are other locations than `ISO_LOCAL_DATE` that have the same description.
>> Those are corrected too.
>
> Naoto Sato has updated the pull request incrementally
> Also fixed the bug with NPE in `IndirectVarHandle::isAccessModeSupported`.
>
> A few implementation-detail methods in VarHandle are now documented with the
> implied constraints to avoid subtle problems in the future. Changed
> `IndirectVarHandle` to call `asDirect` lazily to accomodate the
> Replacing the ambiguous `dash` with `hyphen-minus` for more clarity. There
> are other locations than `ISO_LOCAL_DATE` that have the same description.
> Those are corrected too.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
On Mon, 26 Jun 2023 09:57:31 GMT, 温绍锦 wrote:
>> By optimizing the implementation of java.lang.Long#fastUUID, the performance
>> of the java.util.UUID#toString method can be significantly improved.
>>
>> The following are the test results of JMH:
>>
>> Benchmark Mode Cnt
On Mon, 26 Jun 2023 20:25:40 GMT, Mandy Chung wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [7db2f087](https://github.com/openjdk/jdk/commit/7db2f08756b0aa1d79cdd2356ed42aa5ab8bc58b)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The commit
On Mon, 26 Jun 2023 23:02:29 GMT, Mandy Chung wrote:
>> Hi all,
>>
>> This pull request contains a backport of commit
>> [7db2f087](https://github.com/openjdk/jdk/commit/7db2f08756b0aa1d79cdd2356ed42aa5ab8bc58b)
>> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>>
>> The
On Mon, 26 Jun 2023 09:57:31 GMT, 温绍锦 wrote:
>> By optimizing the implementation of java.lang.Long#fastUUID, the performance
>> of the java.util.UUID#toString method can be significantly improved.
>>
>> The following are the test results of JMH:
>>
>> Benchmark Mode Cnt
> This PR updates the spec of `Lookup::findClass` to reflect the current
> behavior that requires a binary name or a string representing an array class
> in the form as returned by `Class::getName`.
>
> `test/jdk/java/lang/invoke/accessClassAndFindClass/TestFindClass.java`
> already covers
> Apparently method handle linking doesn't impose extra checks on constructor
> invocation, so the special logic for the serialization constructor to call
> superclass constructor in MagicAccessorImpl can be removed altogether with
> old core reflection implementation.
>
> Serialization and
> Hi all,
>
> This pull request contains a backport of commit
> [7db2f087](https://github.com/openjdk/jdk/commit/7db2f08756b0aa1d79cdd2356ed42aa5ab8bc58b)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The commit being backported was authored by Mandy Chung on 26 Jun
> Hi,
>
> I need a code review for moving the contents of the jdk.crypto.ec module into
> java.base. This moves the SunEC JCE Provider (Elliptic Curve) into
> java.base. EC has always been separate from the base module/pkg because of
> its dependence on a native library. That library was
On Mon, 26 Jun 2023 09:57:31 GMT, 温绍锦 wrote:
>> By optimizing the implementation of java.lang.Long#fastUUID, the performance
>> of the java.util.UUID#toString method can be significantly improved.
>>
>> The following are the test results of JMH:
>>
>> Benchmark Mode Cnt
On Mon, 26 Jun 2023 22:33:35 GMT, Mandy Chung wrote:
>> "component descriptor" tried to refer to both parameter types and return
>> type descriptors. How about "produce identical class descriptors in method
>> descriptors?"
>
> `MethodType::descriptorString` refers to method descriptor and
>
Hi all,
This pull request contains a backport of commit
[a197ee79](https://github.com/openjdk/jdk/commit/a197ee797b3580d9f85636522587d3f6418dff6a)
from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. This is a
doc-only typo fix.
The commit being backported was authored by Chen
On Mon, 26 Jun 2023 22:30:20 GMT, Chen Liang wrote:
>> Why can't just say "identical descriptor strings"? It's unclear what
>> "component descriptor" is.
>
> "component descriptor" tried to refer to both parameter types and return type
> descriptors. How about "produce identical class
On Mon, 26 Jun 2023 22:17:16 GMT, Chen Liang wrote:
>> src/java.base/share/classes/java/lang/invoke/MethodType.java line 1229:
>>
>>> 1227: *
>>> 1228: * @apiNote
>>> 1229: * This is not a strict inverse of {@link
>>> #fromMethodDescriptorString
>>
>> Re-reading this, I think
On Mon, 26 Jun 2023 22:27:57 GMT, Mandy Chung wrote:
>> * Two distinct classes which share a common name but have different class
>> loaders
>> * produce identical component descriptors in descriptor strings.
>>
>> Does this sound good? This also addresses alan's wording concerns.
>
> Why
On Mon, 26 Jun 2023 18:32:30 GMT, Jonathan Gibbons wrote:
> Please review a trivial update to remove a redundant `@since` tag.
This pull request has now been integrated.
Changeset: 46add3f8
Author:Jonathan Gibbons
URL:
On Mon, 26 Jun 2023 18:53:42 GMT, Mandy Chung wrote:
>> Chen Liang has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains ten additional
>> commits
> The API specification for descriptorString not being a strict inverse of
> Class::forName and MethodType::fromDescriptorString are not entirely correct.
>
> 1. Class::descriptorString was never an inverse of Class::forName, which
> takes a binary name instead. The note about different class
On Mon, 26 Jun 2023 21:58:41 GMT, Chen Liang wrote:
>> Hi all,
>>
>> This pull request contains a backport of commit
>> [7db2f087](https://github.com/openjdk/jdk/commit/7db2f08756b0aa1d79cdd2356ed42aa5ab8bc58b)
>> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>>
>> The
On Sat, 24 Jun 2023 01:07:48 GMT, Chen Liang wrote:
> https://docs.oracle.com/en/java/javase/20/docs/api/java.base/java/lang/constant/MethodTypeDesc.html
>
> These 3 typos are discovered while browsing the online documentation. It
> probably doesn't need a CSR for it doesn't change the
On Mon, 26 Jun 2023 18:28:06 GMT, Mandy Chung wrote:
>> Chen Liang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> simplify equals by replacing if with and operators
>
> src/java.base/share/classes/java/lang/invoke/MethodType.java line
On Mon, 26 Jun 2023 20:54:42 GMT, Andrey Turbanov wrote:
>> Chen Liang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> simplify equals by replacing if with and operators
>
> src/java.base/share/classes/java/lang/invoke/MemberName.java
> This patch touches java.lang.reflect and java.lang.invoke packages. It
> replaces instanceof + cast with pattern matching and updates
> Array.newInstance().getClass() patterns with arrayType() for obtaining array
> types of a class.
Chen Liang has updated the pull request incrementally with
On Mon, 26 Jun 2023 20:25:40 GMT, Mandy Chung wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [7db2f087](https://github.com/openjdk/jdk/commit/7db2f08756b0aa1d79cdd2356ed42aa5ab8bc58b)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The commit
This PR updates the spec of `Lookup::findClass` to reflect the current behavior
that requires a binary name or a string representing an array class in the form
as returned by `Class::getName`.
`test/jdk/java/lang/invoke/accessClassAndFindClass/TestFindClass.java` already
covers the test
On Mon, 26 Jun 2023 21:21:41 GMT, Mandy Chung wrote:
> A trivial fix to correct the expected result to be `Inner[].class`. I
> missed the rerun of the test to verify the last-minute edit to the test by
> JDK-8310242.
This pull request has now been integrated.
Changeset: 7c6a28fd
Author:
On Mon, 26 Jun 2023 21:21:41 GMT, Mandy Chung wrote:
> A trivial fix to correct the expected result to be `Inner[].class`. I
> missed the rerun of the test to verify the last-minute edit to the test by
> JDK-8310242.
Thumbs up. This is a trivial fix.
-
PR Comment:
On Mon, 26 Jun 2023 21:21:41 GMT, Mandy Chung wrote:
> A trivial fix to correct the expected result to be `Inner[].class`. I
> missed the rerun of the test to verify the last-minute edit to the test by
> JDK-8310242.
Looks good.
-
Marked as reviewed by dholmes (Reviewer).
PR
On Mon, 26 Jun 2023 21:21:41 GMT, Mandy Chung wrote:
> A trivial fix to correct the expected result to be `Inner[].class`. I
> missed the rerun of the test to verify the last-minute edit to the test by
> JDK-8310242.
thanks for the prompt review.
-
PR Comment:
A trivial fix to correct the expected result to be `Inner[].class`. I missed
the rerun of the test to verify the last-minute edit to the test by JDK-8310242.
-
Commit messages:
- JDK-8310922: java/lang/Class/forName/ForNameNames.java fails after being
added by JDK-8310242
Remove 2 malformed problem list entries. These entries are considered malformed
according to [1] since they are missing a bug number.
The `java/foreign/callarranger/TestAarch64CallArranger.java` test was removed,
and the `java/foreign/TestLargeSegmentCopy.java` disables x86 in the jtreg test
On Mon, 26 Jun 2023 13:51:25 GMT, Chen Liang wrote:
>> This patch touches java.lang.reflect and java.lang.invoke packages. It
>> replaces instanceof + cast with pattern matching and updates
>> Array.newInstance().getClass() patterns with arrayType() for obtaining array
>> types of a class.
>
On Fri, 23 Jun 2023 11:32:04 GMT, Christian Stein wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [4bf78162](https://github.com/openjdk/jdk/commit/4bf78162c52564645af79b8324b69d89102dc024)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The commit
Hi all,
This pull request contains a backport of commit
[7db2f087](https://github.com/openjdk/jdk/commit/7db2f08756b0aa1d79cdd2356ed42aa5ab8bc58b)
from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
The commit being backported was authored by Mandy Chung on 26 Jun 2023 and was
On Mon, 26 Jun 2023 13:51:25 GMT, Chen Liang wrote:
>> This patch touches java.lang.reflect and java.lang.invoke packages. It
>> replaces instanceof + cast with pattern matching and updates
>> Array.newInstance().getClass() patterns with arrayType() for obtaining array
>> types of a class.
>
On Mon, 26 Jun 2023 18:28:47 GMT, Naoto Sato wrote:
>> Remove a redundant comparison in java.time `OffsetDateTime.compareTo()`.
>> If the `compareInstant` utility method returns 0 (equal), it compares the
>> `LocalDateTime`.
>> However, `compareInstant` has already done that comparison; if it
On Thu, 22 Jun 2023 19:03:03 GMT, Roger Riggs wrote:
> Remove a redundant comparison in java.time `OffsetDateTime.compareTo()`.
> If the `compareInstant` utility method returns 0 (equal), it compares the
> `LocalDateTime`.
> However, `compareInstant` has already done that comparison; if it
On Thu, 22 Jun 2023 19:03:03 GMT, Roger Riggs wrote:
> Remove a redundant comparison in java.time `OffsetDateTime.compareTo()`.
> If the `compareInstant` utility method returns 0 (equal), it compares the
> `LocalDateTime`.
> However, `compareInstant` has already done that comparison; if it
On Sat, 24 Jun 2023 01:07:48 GMT, Chen Liang wrote:
> https://docs.oracle.com/en/java/javase/20/docs/api/java.base/java/lang/constant/MethodTypeDesc.html
>
> These 3 typos are discovered while browsing the online documentation. It
> probably doesn't need a CSR for it doesn't change the
On Mon, 26 Jun 2023 13:51:25 GMT, Chen Liang wrote:
>> This patch touches java.lang.reflect and java.lang.invoke packages. It
>> replaces instanceof + cast with pattern matching and updates
>> Array.newInstance().getClass() patterns with arrayType() for obtaining array
>> types of a class.
>
On Fri, 16 Jun 2023 19:58:08 GMT, Mandy Chung wrote:
> This PR clarifies the spec of the 3-arg Class::forName regarding the format
> of the name for an array type which is of the form: one or more of "[" +
> binary name of the element type + ";'.
This pull request has now been integrated.
On Tue, 31 Jan 2023 11:40:43 GMT, Sergey Tsypanov wrote:
> `ResourceBundle.CacheKey.equals()` and `Bundles.CacheKey.equals()` are quire
> outdated. This simple clean-up modernizes them.
This pull request has now been integrated.
Changeset: 297c7996
Author:Sergey Tsypanov
Committer: Pavel
On Wed, 7 Dec 2022 09:24:24 GMT, Jaikiran Pai wrote:
>> I'm not sure what the conventional move here would be. Adding them to the
>> problem list doesn't seem to make the failures go away in GHA at least. I
>> can exclude them with `@requires` as well.
>
> Hello Jorn,
>
>> Adding them to the
On Mon, 26 Jun 2023 18:32:30 GMT, Jonathan Gibbons wrote:
> Please review a trivial update to remove a redundant `@since` tag.
Marked as reviewed by iris (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/14662#pullrequestreview-1499227762
On Mon, 26 Jun 2023 18:32:30 GMT, Jonathan Gibbons wrote:
> Please review a trivial update to remove a redundant `@since` tag.
Marked as reviewed by darcy (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/14662#pullrequestreview-1499215438
On Mon, 26 Jun 2023 13:00:31 GMT, Lance Andersen wrote:
> Hi all,
>
> Please review this trivial change which adds the `@since` javadoc tag to the
> various ` java.sql `and `java.sql.rowset` packages.
>
> Best
> Lance
Marked as reviewed by bpb (Reviewer).
-
PR Review:
On Mon, 26 Jun 2023 13:00:31 GMT, Lance Andersen wrote:
> Hi all,
>
> Please review this trivial change which adds the `@since` javadoc tag to the
> various ` java.sql `and `java.sql.rowset` packages.
>
> Best
> Lance
Marked as reviewed by darcy (Reviewer).
-
PR Review:
On Mon, 26 Jun 2023 18:32:30 GMT, Jonathan Gibbons wrote:
> Please review a trivial update to remove a redundant `@since` tag.
Marked as reviewed by bpb (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/14662#pullrequestreview-1499208126
On Mon, 26 Jun 2023 18:44:42 GMT, Pavel Rappo wrote:
>> make/data/charsetmapping/charsets line 149:
>>
>>> 147: package sun.nio.cs
>>> 148: typesbcs
>>> 149: histname ISO8859_2
>>
>> Should this column be re-aligned with the longer name?
>
> I thought about it before publishing
On Thu, 22 Jun 2023 01:38:05 GMT, Chen Liang wrote:
>> The API specification for descriptorString not being a strict inverse of
>> Class::forName and MethodType::fromDescriptorString are not entirely correct.
>>
>> 1. Class::descriptorString was never an inverse of Class::forName, which
>>
On Mon, 26 Jun 2023 18:32:30 GMT, Jonathan Gibbons wrote:
> Please review a trivial update to remove a redundant `@since` tag.
Marked as reviewed by naoto (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/14662#pullrequestreview-1499185740
On Mon, 26 Jun 2023 18:31:06 GMT, Jens Lidestrom wrote:
>> Please review this cleanup PR to normalize names of identifiers which are
>> Java variables/fields or tokens in text files. Those names either contain a
>> pronoun that is very rarely used in code, or seem like they contain such a
>>
On Mon, 26 Jun 2023 13:00:31 GMT, Lance Andersen wrote:
> Hi all,
>
> Please review this trivial change which adds the `@since` javadoc tag to the
> various ` java.sql `and `java.sql.rowset` packages.
>
> Best
> Lance
LGTM
-
Marked as reviewed by naoto (Reviewer).
PR Review:
On Fri, 23 Jun 2023 16:43:32 GMT, Jatin Bhateja wrote:
> Backing out shuffle related overhaul done with
> [JDK-8304450](https://bugs.openjdk.org/browse/JDK-8304450), we saw
> significant performance degradation in VectorAPI JMH micros and some of our
> internal benchmarks. Following two
On Mon, 26 Jun 2023 18:32:30 GMT, Jonathan Gibbons wrote:
> Please review a trivial update to remove a redundant `@since` tag.
Marked as reviewed by lancea (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/14662#pullrequestreview-1499179572
On Mon, 26 Jun 2023 18:21:07 GMT, Roger Riggs wrote:
>> Please review this cleanup PR to normalize names of identifiers which are
>> Java variables/fields or tokens in text files. Those names either contain a
>> pronoun that is very rarely used in code, or seem like they contain such a
>>
On Mon, 26 Jun 2023 13:00:31 GMT, Lance Andersen wrote:
> Hi all,
>
> Please review this trivial change which adds the `@since` javadoc tag to the
> various ` java.sql `and `java.sql.rowset` packages.
>
> Best
> Lance
Marked as reviewed by iris (Reviewer).
-
PR Review:
Please review a trivial update to remove a redundant `@since` tag.
-
Commit messages:
- JDK-8310909: java.io.InvalidObjectException has redundant `@since` tag
Changes: https://git.openjdk.org/jdk/pull/14662/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=14662=00
Issue:
On Mon, 26 Jun 2023 14:07:03 GMT, Pavel Rappo wrote:
> Please review this cleanup PR to normalize names of identifiers which are
> Java variables/fields or tokens in text files. Those names either contain a
> pronoun that is very rarely used in code, or seem like they contain such a
>
Hi all,
Please review this trivial change which adds the `@since` javadoc tag to the
various ` java.sql `and `java.sql.rowset` packages.
Best
Lance
-
Commit messages:
- Remove empty line
- Add @since to package-info.java
Changes: https://git.openjdk.org/jdk/pull/14652/files
On Thu, 22 Jun 2023 19:03:03 GMT, Roger Riggs wrote:
> Remove a redundant comparison in java.time `OffsetDateTime.compareTo()`.
> If the `compareInstant` utility method returns 0 (equal), it compares the
> `LocalDateTime`.
> However, `compareInstant` has already done that comparison; if it
On Mon, 26 Jun 2023 17:31:29 GMT, Naoto Sato wrote:
> Fixing the `/ by zero` exception with tick durations less than a millisecond.
Marked as reviewed by rriggs (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/14657#pullrequestreview-1499140711
On Mon, 26 Jun 2023 14:07:03 GMT, Pavel Rappo wrote:
> Please review this cleanup PR to normalize names of identifiers which are
> Java variables/fields or tokens in text files. Those names either contain a
> pronoun that is very rarely used in code, or seem like they contain such a
>
On Mon, 26 Jun 2023 14:07:03 GMT, Pavel Rappo wrote:
> Please review this cleanup PR to normalize names of identifiers which are
> Java variables/fields or tokens in text files. Those names either contain a
> pronoun that is very rarely used in code, or seem like they contain such a
>
On Mon, 26 Jun 2023 17:31:29 GMT, Naoto Sato wrote:
> Fixing the `/ by zero` exception with tick durations less than a millisecond.
Marked as reviewed by iris (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/14657#pullrequestreview-1499116940
Please review this cleanup PR to normalize names of identifiers which are Java
variables/fields or tokens in text files. Those names either contain a pronoun
that is very rarely used in code, or seem like they contain such a pronoun,
which, in fact, they don't. Either way, the goal is to
On Mon, 26 Jun 2023 14:57:11 GMT, Roger Riggs wrote:
>> The internal enum jdk.internal.util.Architecture does not provide
>> information about the big or little endianness or the address size (64 or 32
>> bits). The endian-ness and address size are intrinsic to the architecture.
>>
>> The
Fixing the `/ by zero` exception with tick durations less than a millisecond.
-
Commit messages:
- refactor return statement
- 8310232: java.time.Clock$TickClock.millis() fails in runtime when tick is 1
microsecond
Changes: https://git.openjdk.org/jdk/pull/14657/files
Webrev:
On Fri, 23 Jun 2023 16:43:32 GMT, Jatin Bhateja wrote:
> Backing out shuffle related overhaul done with
> [JDK-8304450](https://bugs.openjdk.org/browse/JDK-8304450), we saw
> significant performance degradation in VectorAPI JMH micros and some of our
> internal benchmarks. Following two
On Thu, 22 Jun 2023 11:51:15 GMT, Matthias Baesken wrote:
>> Currently, a number of tests fail on macOS because they miss the core file
>> (e.g. serviceability/sa/TestJmapCore.java).
>> The reason is that configure detects on some setups that codesign does not
>> work ("checking if debug mode
> When the default Locale is `tr`, the jmod and jimage commands have the
> following problems:
>
> * The jmod command does not correctly recognize the `list` mode typed in
> lowercase;
> * The jimage command cannot obtain the help information of the `list` mode.
Glavo has updated the pull
> Added a new method `newStringLatin1NoRepl` to the `JavaLangAccess`.
>
> Reasons:
>
> * Most use cases of `newStringNoRepl` use `ISO_8859_1` as the charset,
> creating a new shortcut can make writing shorter;
> * Since all possible values of `byte` are legal Latin-1 characters,
>
> Using `ByteArrayLittleEndian` is simpler and faster.
>
> `make test TEST="micro:java.util.zip.ZipFileOpen"`:
>
>
> Benchmark (size) Mode Cnt Score Error Units
> - ZipFileOpen.openCloseZipFile 512 avgt 15 39052.832 ± 107.496 ns/op
> +
> `ByteArray` and `ByteArrayLittleEndian` are very useful tool classes that can
> be used in many places to performance tuning.
>
> Currently they are implemented by `VarHandle`, so using them may have some
> impact on startup time.
>
> This PR reimplements them using `Unsafe`, which reduces
On Fri, 23 Jun 2023 11:32:04 GMT, Christian Stein wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [4bf78162](https://github.com/openjdk/jdk/commit/4bf78162c52564645af79b8324b69d89102dc024)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The commit
On Mon, 26 Jun 2023 09:46:08 GMT, Sergey Tsypanov wrote:
>> `ResourceBundle.CacheKey.equals()` and `Bundles.CacheKey.equals()` are quire
>> outdated. This simple clean-up modernizes them.
>
> Sergey Tsypanov has updated the pull request incrementally with one
> additional commit since the last
On Mon, 26 Jun 2023 14:56:34 GMT, Chen Liang wrote:
> I ran `make docs-classfile-api-javadoc`
Thanks for pointing this out. The makefile patches accidentally fell into this
PR.
> One thing of note is that the JDK itself has a `@sealedGraph` taglet to
> render the sealed class hierarchy of
> Classfile context object and multi-state options have been discussed at
> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html
> This patch implements the proposed changes in Classfile API and fixes all
> affected code across JDK sources and tests.
>
> Please review.
>
>
On Mon, 26 Jun 2023 15:40:39 GMT, Maurizio Cimadamore
wrote:
>> The API changes look great. I like the instance usages of ClassFile, and how
>> CF is now used in a centralized fashion to double down as a cache/option
>> store (and entry point for transformation). Seems like a step in a good
On Fri, 23 Jun 2023 16:30:15 GMT, Brian Burkhalter wrote:
> Add `package-info.java` for package `jdk.nio.mapmode`.
This pull request has now been integrated.
Changeset: d32eb015
Author:Brian Burkhalter
URL:
https://git.openjdk.org/jdk/commit/d32eb015f056b09fa9ae99a2a84b7056cd3d9259
On Mon, 26 Jun 2023 16:02:57 GMT, Chen Liang wrote:
> This is just a copycat of the original newStringNoRepl, which should be
> fixed; newStringUTF8NoRepl has no such issue.
Unfortunately, the behavior of `newStringUTF8NoRepl` is not the same as that of
`newStringNoRepl`, as it actually
> Added a new method `newStringLatin1NoRepl` to the `JavaLangAccess`.
>
> Reasons:
>
> * Most use cases of `newStringNoRepl` use `ISO_8859_1` as the charset,
> creating a new shortcut can make writing shorter;
> * Since all possible values of `byte` are legal Latin-1 characters,
>
On Mon, 26 Jun 2023 15:25:08 GMT, Glavo wrote:
> Added a new method `newStringLatin1NoRepl` to the `JavaLangAccess`.
>
> Reasons:
>
> * Most use cases of `newStringNoRepl` use `ISO_8859_1` as the charset,
> creating a new shortcut can make writing shorter;
> * Since all possible values of
On Mon, 26 Jun 2023 15:25:08 GMT, Glavo wrote:
> Added a new method `newStringLatin1NoRepl` to the `JavaLangAccess`.
>
> Reasons:
>
> * Most use cases of `newStringNoRepl` use `ISO_8859_1` as the charset,
> creating a new shortcut can make writing shorter;
> * Since all possible values of
Added a new method `newStringLatin1NoRepl` to the `JavaLangAccess`.
Reasons:
* Most use cases of `newStringNoRepl` use `ISO_8859_1` as the charset, creating
a new shortcut can make writing shorter;
* Since all possible values of `byte` are legal Latin-1 characters,
`newStringLatin1NoRepl`
On Mon, 26 Jun 2023 15:40:39 GMT, Maurizio Cimadamore
wrote:
> Also, another observation: the number of updates snippets in javadoc seems
> rather low for something that touches the main entry point by which client
> interacts with classfiles. This seems a sign of perhaps not having many end
On Mon, 26 Jun 2023 09:57:31 GMT, 温绍锦 wrote:
>> By optimizing the implementation of java.lang.Long#fastUUID, the performance
>> of the java.util.UUID#toString method can be significantly improved.
>>
>> The following are the test results of JMH:
>>
>> Benchmark Mode Cnt
On Mon, 26 Jun 2023 13:33:38 GMT, Adam Sotona wrote:
>> Classfile context object and multi-state options have been discussed at
>> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html
>> This patch implements the proposed changes in Classfile API and fixes all
>> affected
On Mon, 26 Jun 2023 15:39:15 GMT, Maurizio Cimadamore
wrote:
> The API changes look great. I like the instance usages of ClassFile, and how
> CF is now used in a centralized fashion to double down as a cache/option
> store (and entry point for transformation). Seems like a step in a good
>
On Mon, 26 Jun 2023 09:57:31 GMT, 温绍锦 wrote:
>> By optimizing the implementation of java.lang.Long#fastUUID, the performance
>> of the java.util.UUID#toString method can be significantly improved.
>>
>> The following are the test results of JMH:
>>
>> Benchmark Mode Cnt
On Mon, 26 Jun 2023 14:40:08 GMT, Roger Riggs wrote:
> The implementation should do its best whether or not CompactStrings is true
> or false. (Until the time it is deprecated and remove). Throwing an internal
> error is not an option.
I understand that we must provide a working
On Mon, 26 Jun 2023 13:33:38 GMT, Adam Sotona wrote:
>> Classfile context object and multi-state options have been discussed at
>> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-May/000321.html
>> This patch implements the proposed changes in Classfile API and fixes all
>> affected
On Thu, 22 Jun 2023 19:24:37 GMT, Roger Riggs wrote:
>> The internal enum jdk.internal.util.Architecture does not provide
>> information about the big or little endianness or the address size (64 or 32
>> bits). The endian-ness and address size are intrinsic to the architecture.
>>
>> The
> The internal enum jdk.internal.util.Architecture does not provide information
> about the big or little endianness or the address size (64 or 32 bits). The
> endian-ness and address size are intrinsic to the architecture.
>
> The values of the enum are extended to separately identify the big
1 - 100 of 142 matches
Mail list logo
