Re: RFR: 8311207: Optimization for j.u.UUID.toString

2023-06-30 Thread 温绍锦
On Sat, 1 Jul 2023 03:06:31 GMT, Chen Liang wrote: >> ![image](https://github.com/openjdk/jdk/assets/1166785/38c75145-b685-4c4e-a53a-97f8c44778e3) >> >> it's enabled > >> > @wenshao I have made my suggestions into a patch for you: >> > [wenshao#1](https://github.com/wenshao/jdk/pull/1) Feel fre

Re: RFR: 8311207: Optimization for j.u.UUID.toString

2023-06-30 Thread 温绍锦
On Sat, 1 Jul 2023 03:06:31 GMT, Chen Liang wrote: >> ![image](https://github.com/openjdk/jdk/assets/1166785/38c75145-b685-4c4e-a53a-97f8c44778e3) >> >> it's enabled > >> > @wenshao I have made my suggestions into a patch for you: >> > [wenshao#1](https://github.com/wenshao/jdk/pull/1) Feel fre

Re: RFR: 8311207: Optimization for j.u.UUID.toString [v3]

2023-06-30 Thread 温绍锦
> [PR 14578 ](https://github.com/openjdk/jdk/pull/14578) still has unresolved > discussions, continue to make improvements. > > # Benchmark Result > > > sh make/devkit/createJMHBundle.sh > bash configure --with-jmh=build/jmh/jars > make test TEST="micro:java.util.UUIDBench.toString" > > > ##

Re: RFR: 8311207: Optimization for j.u.UUID.toString

2023-06-30 Thread 温绍锦
On Sat, 1 Jul 2023 03:06:31 GMT, Chen Liang wrote: >> ![image](https://github.com/openjdk/jdk/assets/1166785/38c75145-b685-4c4e-a53a-97f8c44778e3) >> >> it's enabled > >> > @wenshao I have made my suggestions into a patch for you: >> > [wenshao#1](https://github.com/wenshao/jdk/pull/1) Feel fre

Re: RFR: 8311207: Optimization for j.u.UUID.toString

2023-06-30 Thread Chen Liang
On Sat, 1 Jul 2023 02:40:22 GMT, 温绍锦 wrote: >> [PR 14578 ](https://github.com/openjdk/jdk/pull/14578) still has unresolved >> discussions, continue to make improvements. >> >> # Benchmark Result >> >> >> sh make/devkit/createJMHBundle.sh >> bash configure --with-jmh=build/jmh/jars >> make tes

Re: RFR: 8311207: Optimization for j.u.UUID.toString

2023-06-30 Thread 温绍锦
On Sat, 1 Jul 2023 02:40:22 GMT, 温绍锦 wrote: >> [PR 14578 ](https://github.com/openjdk/jdk/pull/14578) still has unresolved >> discussions, continue to make improvements. >> >> # Benchmark Result >> >> >> sh make/devkit/createJMHBundle.sh >> bash configure --with-jmh=build/jmh/jars >> make tes

Re: RFR: 8311207: Optimization for j.u.UUID.toString [v2]

2023-06-30 Thread 温绍锦
> [PR 14578 ](https://github.com/openjdk/jdk/pull/14578) still has unresolved > discussions, continue to make improvements. > > # Benchmark Result > > > sh make/devkit/createJMHBundle.sh > bash configure --with-jmh=build/jmh/jars > make test TEST="micro:java.util.UUIDBench.toString" > > > ##

Re: RFR: 8311207: Optimization for j.u.UUID.toString

2023-06-30 Thread Chen Liang
On Sat, 1 Jul 2023 02:40:22 GMT, 温绍锦 wrote: >> [PR 14578 ](https://github.com/openjdk/jdk/pull/14578) still has unresolved >> discussions, continue to make improvements. >> >> # Benchmark Result >> >> >> sh make/devkit/createJMHBundle.sh >> bash configure --with-jmh=build/jmh/jars >> make tes

[jdk21] Integrated: 8309819: Clarify API note in Class::getName and MethodType::toMethodDescriptorString

2023-06-30 Thread Chen Liang
On Sat, 1 Jul 2023 00:45:32 GMT, Chen Liang wrote: > Hi all, > > This pull request contains a backport of commit > [8c8e9d91](https://github.com/openjdk/jdk/commit/8c8e9d911d388f6ee621ed4d322efc56a9876708) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being

[jdk21] Integrated: 8310838: Correct range notations in MethodTypeDesc specification

2023-06-30 Thread Chen Liang
On Mon, 26 Jun 2023 22:28:23 GMT, Chen Liang wrote: > Hi all, > > This pull request contains a backport of commit > [a197ee79](https://github.com/openjdk/jdk/commit/a197ee797b3580d9f85636522587d3f6418dff6a) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. This is a > doc-only

Re: RFR: 8311207: Optimization for j.u.UUID.toString

2023-06-30 Thread 温绍锦
On Sat, 1 Jul 2023 01:44:15 GMT, 温绍锦 wrote: > [PR 14578 ](https://github.com/openjdk/jdk/pull/14578) still has unresolved > discussions, continue to make improvements. > > # Benchmark Result > > > sh make/devkit/createJMHBundle.sh > bash configure --with-jmh=build/jmh/jars > make test TEST="m

Re: [jdk21] RFR: 8310838: Correct range notations in MethodTypeDesc specification

2023-06-30 Thread Mandy Chung
On Mon, 26 Jun 2023 22:28:23 GMT, Chen Liang wrote: > Hi all, > > This pull request contains a backport of commit > [a197ee79](https://github.com/openjdk/jdk/commit/a197ee797b3580d9f85636522587d3f6418dff6a) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. This is a > doc-only

Re: RFR: 8311207: Optimization for j.u.UUID.toString

2023-06-30 Thread Chen Liang
On Sat, 1 Jul 2023 02:33:11 GMT, 温绍锦 wrote: > > Is using `Unsafe` directly consistently faster than using ByteArray? It > > should have similar performance as ByteArray's VarHandle is simply a > > wrapper around Unsafe's put/get methods. > > Using Unsafe on aliyun_ecs_c8i.xlarge and MacBookPro

Re: RFR: 8311207: Optimization for j.u.UUID.toString

2023-06-30 Thread 温绍锦
On Sat, 1 Jul 2023 02:09:36 GMT, Chen Liang wrote: > Is using `Unsafe` directly consistently faster than using ByteArray? It > should have similar performance as ByteArray's VarHandle is simply a wrapper > around Unsafe's put/get methods. Using Unsafe on aliyun_ecs_c8i.xlarge and MacBookPro M1

Re: RFR: 8311207: Optimization for j.u.UUID.toString

2023-06-30 Thread Chen Liang
On Sat, 1 Jul 2023 01:44:15 GMT, 温绍锦 wrote: > [PR 14578 ](https://github.com/openjdk/jdk/pull/14578) still has unresolved > discussions, continue to make improvements. > > # Benchmark Result > > > sh make/devkit/createJMHBundle.sh > bash configure --with-jmh=build/jmh/jars > make test TEST="m

Re: RFR: 8311207: Optimization for j.u.UUID.toString

2023-06-30 Thread Chen Liang
On Sat, 1 Jul 2023 01:44:15 GMT, 温绍锦 wrote: > [PR 14578 ](https://github.com/openjdk/jdk/pull/14578) still has unresolved > discussions, continue to make improvements. > > # Benchmark Result > > > sh make/devkit/createJMHBundle.sh > bash configure --with-jmh=build/jmh/jars > make test TEST="m

Re: RFR: JDK-8310502 : Optimization for j.l.Long.fastUUID() [v34]

2023-06-30 Thread 温绍锦
On Sat, 1 Jul 2023 00:01:57 GMT, Jie Fu wrote: >> can you create a new issue and i continue improving? > >> can you create a new issue and i continue improving? > > Filed: https://bugs.openjdk.org/browse/JDK-8311207 @liach @RogerRiggs continue discussion in [PR 14745](https://github.com/openjd

RFR: 8311207: Optimization for j.u.UUID.toString

2023-06-30 Thread 温绍锦
[PR 14578 ](https://github.com/openjdk/jdk/pull/14578) still has unresolved discussions, continue to make improvements. # Benchmark Result sh make/devkit/createJMHBundle.sh bash configure --with-jmh=build/jmh/jars make test TEST="micro:java.util.UUIDBench.toString" ## 1. [aliyun_ecs_c8i.xlar

Re: [jdk21] RFR: 8309819: Clarify API note in Class::getName and MethodType::toMethodDescriptorString

2023-06-30 Thread Chen Liang
On Sat, 1 Jul 2023 00:45:32 GMT, Chen Liang wrote: > Hi all, > > This pull request contains a backport of commit > [8c8e9d91](https://github.com/openjdk/jdk/commit/8c8e9d911d388f6ee621ed4d322efc56a9876708) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being

Re: RFR: JDK-6361826: (reflect) provide method for mapping strings to class object for primitive types

2023-06-30 Thread Mandy Chung
On Fri, 30 Jun 2023 20:57:54 GMT, Joe Darcy wrote: > Going over some old issues and found this RFE, posting without any tests or a > CSR first to get some feedback on the overall API. The descriptor string "I", "J", etc possible but not for "int", "long", "byte" etc which are keywords and can

Re: [jdk21] RFR: 8309819: Clarify API note in Class::getName and MethodType::toMethodDescriptorString

2023-06-30 Thread Mandy Chung
On Sat, 1 Jul 2023 00:45:32 GMT, Chen Liang wrote: > Hi all, > > This pull request contains a backport of commit > [8c8e9d91](https://github.com/openjdk/jdk/commit/8c8e9d911d388f6ee621ed4d322efc56a9876708) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being

Re: List extending Collection/SequencedCollection

2023-06-30 Thread Joseph D. Darcy
Hi Ryan, Apropos of this discussion, I happened to recently give a talk to the JCP that in part covered behavioral compatibility in the JDK: https://jcp.org/aboutJava/communityprocess/ec-public/materials/2023-06-13/JCP-EC-Public-Agenda-June-2023.html https://jcp.org/aboutJava/communityprocess/

[jdk21] RFR: 8309819: Clarify API note in Class::getName and MethodType::toMethodDescriptorString

2023-06-30 Thread Chen Liang
Hi all, This pull request contains a backport of commit [8c8e9d91](https://github.com/openjdk/jdk/commit/8c8e9d911d388f6ee621ed4d322efc56a9876708) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Chen Liang on 30 Jun 2023 and was revie

Re: RFR: JDK-6361826: (reflect) provide method for mapping strings to class object for primitive types

2023-06-30 Thread Chen Liang
On Fri, 30 Jun 2023 20:57:54 GMT, Joe Darcy wrote: > Going over some old issues and found this RFE, posting without any tests or a > CSR first to get some feedback on the overall API. `ClassDesc.of()` already takes a binary name; another JVM programming language may declare a class with `int`

Re: RFR: JDK-6361826: (reflect) provide method for mapping strings to class object for primitive types

2023-06-30 Thread Mandy Chung
On Fri, 30 Jun 2023 20:57:54 GMT, Joe Darcy wrote: > Going over some old issues and found this RFE, posting without any tests or a > CSR first to get some feedback on the overall API. An alternative is to extend `ClassDesc::of` to accept the name of primitive types: ClassDesc.of("int

Re: RFR: JDK-8310502 : Optimization for j.l.Long.fastUUID() [v34]

2023-06-30 Thread Jie Fu
On Fri, 30 Jun 2023 21:12:11 GMT, 温绍锦 wrote: > can you create a new issue and i continue improving? Filed: https://bugs.openjdk.org/browse/JDK-8311207 - PR Review Comment: https://git.openjdk.org/jdk/pull/14578#discussion_r1248348302

Re: RFR: JDK-6361826: (reflect) provide method for mapping strings to class object for primitive types

2023-06-30 Thread Chen Liang
On Fri, 30 Jun 2023 20:57:54 GMT, Joe Darcy wrote: > Going over some old issues and found this RFE, posting without any tests or a > CSR first to get some feedback on the overall API. The main downside of throwing an exception is that exception stack trace filling is very costly. If this API i

Integrated: 8309819: Clarify API note in Class::getName and MethodType::toMethodDescriptorString

2023-06-30 Thread Chen Liang
On Mon, 12 Jun 2023 07:58:29 GMT, Chen Liang wrote: > The API specification for descriptorString not being a strict inverse of > Class::forName and MethodType::fromDescriptorString are not entirely correct. > > 1. Class::descriptorString was never an inverse of Class::forName, which > takes a

Re: RFR: 6983726: Reimplement MethodHandleProxies.asInterfaceInstance [v19]

2023-06-30 Thread Mandy Chung
On Thu, 29 Jun 2023 03:16:15 GMT, Chen Liang wrote: >> As John Rose has pointed out in this issue, the current j.l.r.Proxy based >> implementation of MethodHandleProxies.asInterface has a few issues: >> 1. Exposes too much information via Proxy supertype (and WrapperInstance >> interface) >> 2.

Re: RFR: 6983726: Reimplement MethodHandleProxies.asInterfaceInstance [v19]

2023-06-30 Thread Mandy Chung
On Thu, 29 Jun 2023 03:16:15 GMT, Chen Liang wrote: >> As John Rose has pointed out in this issue, the current j.l.r.Proxy based >> implementation of MethodHandleProxies.asInterface has a few issues: >> 1. Exposes too much information via Proxy supertype (and WrapperInstance >> interface) >> 2.

Re: RFR: JDK-6361826: (reflect) provide method for mapping strings to class object for primitive types

2023-06-30 Thread Joe Darcy
On Fri, 30 Jun 2023 20:57:54 GMT, Joe Darcy wrote: > Going over some old issues and found this RFE, posting without any tests or a > CSR first to get some feedback on the overall API. Besides whether or not the method itself is worth adding, I think the main design question if on a name that i

Re: RFR: JDK-8310502 : Optimization for j.l.Long.fastUUID() [v34]

2023-06-30 Thread 温绍锦
On Thu, 29 Jun 2023 13:45:09 GMT, Roger Riggs wrote: >> 温绍锦 has updated the pull request incrementally with two additional commits >> since the last revision: >> >> - fix comments typo >> - Update full name > > src/java.base/share/classes/java/util/HexDigits.java line 108: > >> 106: * C

Re: RFR: JDK-6361826: (reflect) provide method for mapping strings to class object for primitive types

2023-06-30 Thread Joe Darcy
On Fri, 30 Jun 2023 20:57:54 GMT, Joe Darcy wrote: > Going over some old issues and found this RFE, posting without any tests or a > CSR first to get some feedback on the overall API. Not present in the PR as written, but it would be possible to introduce a sealed interface PrimitiveType that

RFR: JDK-6361826: (reflect) provide method for mapping strings to class object for primitive types

2023-06-30 Thread Joe Darcy
Going over some old issues and found this RFE, posting without any tests or a CSR first to get some feedback on the overall API. - Commit messages: - JDK-6361826: (reflect) provide method for mapping strings to class object for primitive types Changes: https://git.openjdk.org/jdk/

Re: RFR: 8301341: LinkedTransferQueue does not respect timeout for poll() [v5]

2023-06-30 Thread Doug Lea
> This now uses Thread.isVirtual to distinguish spin vs immediate block cases, > enabling re-introduction of spin control from the previous version, removing > anomalies like this one. Doug Lea has updated the pull request incrementally with one additional commit since the last revision: Fix

Re: RFR: 8301341: LinkedTransferQueue does not respect timeout for poll() [v3]

2023-06-30 Thread Doug Lea
On Fri, 30 Jun 2023 13:00:27 GMT, Doug Lea wrote: >> src/java.base/share/classes/java/util/concurrent/LinkedTransferQueue.java >> line 115: >> >>> 113: * indicating whether to act as some form of offer, put, poll, >>> 114: * take, or transfer (each possibly with timeout), as described

Re: RFR: 8301341: LinkedTransferQueue does not respect timeout for poll() [v4]

2023-06-30 Thread Doug Lea
> This now uses Thread.isVirtual to distinguish spin vs immediate block cases, > enabling re-introduction of spin control from the previous version, removing > anomalies like this one. Doug Lea has updated the pull request with a new target base due to a merge or a rebase. The incremental webre

Re: RFR: 8254566: Clarify the spec of ClassLoader::getClassLoadingLock for non-parallel capable loader [v3]

2023-06-30 Thread Joe Darcy
On Fri, 30 Jun 2023 18:12:18 GMT, Mandy Chung wrote: >> The spec of `ClassLoader::getClassLoadingLock` is unclear that this method >> is intended for parallel-capable class loader implementations to provide an >> alternate implementation. For non-parallel-capable class loaders, this >> metho

Re: RFR: 8254566: Clarify the spec of ClassLoader::getClassLoadingLock for non-parallel capable loader [v3]

2023-06-30 Thread Mandy Chung
> The spec of `ClassLoader::getClassLoadingLock` is unclear that this method is > intended for parallel-capable class loader implementations to provide an > alternate implementation. For non-parallel-capable class loaders, this > method should return this `ClassLoader` object. The javadoc us

Re: RFR: JDK-8310913 Move ReferencedKeyMap to jdk.internal so it may be shared [v2]

2023-06-30 Thread Mandy Chung
On Thu, 29 Jun 2023 18:24:33 GMT, Jim Laskey wrote: >> java.lang.runtime.ReferencedKeyMap was introduced to provide a concurrent >> caching scheme for Carrier objects. The technique used is generally useful >> for a variety of caching schemes and is being moved to be shared in other >> parts o

Re: [jdk21] RFR: 8310380: Handle problems in core-related tests on macOS when codesign tool does not work

2023-06-30 Thread Chris Plummer
On Fri, 30 Jun 2023 12:35:27 GMT, Matthias Baesken wrote: > 8310380: Handle problems in core-related tests on macOS when codesign tool > does not work Marked as reviewed by cjplummer (Reviewer). - PR Review: https://git.openjdk.org/jdk21/pull/87#pullrequestreview-1507621309

Re: RFR: 8310923: Refactor Currency tests to use JUnit [v6]

2023-06-30 Thread Lance Andersen
On Fri, 30 Jun 2023 16:49:22 GMT, Justin Lu wrote: >> Please review this PR which refactors Currency tests to use JUnit. >> >> The most significant change occurs in `ValidateISO4217.java`. Other changes >> to this file excluding the JUnit refactoring include >> >> - Tests are no longer depende

Re: RFR: 8310923: Refactor Currency tests to use JUnit [v6]

2023-06-30 Thread Naoto Sato
On Fri, 30 Jun 2023 16:49:22 GMT, Justin Lu wrote: >> Please review this PR which refactors Currency tests to use JUnit. >> >> The most significant change occurs in `ValidateISO4217.java`. Other changes >> to this file excluding the JUnit refactoring include >> >> - Tests are no longer depende

Re: RFR: 8310923: Refactor Currency tests to use JUnit [v5]

2023-06-30 Thread Justin Lu
On Fri, 30 Jun 2023 16:22:16 GMT, Naoto Sato wrote: >> Justin Lu has updated the pull request incrementally with five additional >> commits since the last revision: >> >> - Further clarification regarding minor undefined currencies >> - Review: Rename MinorUndefinedCodes.java to NoMinorUnitCu

Re: RFR: 8310923: Refactor Currency tests to use JUnit [v6]

2023-06-30 Thread Justin Lu
> Please review this PR which refactors Currency tests to use JUnit. > > The most significant change occurs in `ValidateISO4217.java`. Other changes > to this file excluding the JUnit refactoring include > > - Tests are no longer dependent on each other (order of execution does not > matter) >

Re: RFR: 8310923: Refactor Currency tests to use JUnit [v5]

2023-06-30 Thread Naoto Sato
On Fri, 30 Jun 2023 07:50:50 GMT, Justin Lu wrote: >> Please review this PR which refactors Currency tests to use JUnit. >> >> The most significant change occurs in `ValidateISO4217.java`. Other changes >> to this file excluding the JUnit refactoring include >> >> - Tests are no longer depende

Integrated: 8310987: Missing @since tag(s) in java/util/logging/ErrorManager.java

2023-06-30 Thread Daniel Fuchs
On Fri, 30 Jun 2023 09:06:20 GMT, Daniel Fuchs wrote: > Please find here a trivial doc fix to add a missing `@since 1.4` to the > java.util.logging.ErrorManager class. This pull request has now been integrated. Changeset: e8ff74c7 Author:Daniel Fuchs URL: https://git.openjdk.org/jd

Re: jpackage code signing identity

2023-06-30 Thread Alan Snyder
I would still like to hear from someone on the jpackage team about this issue... > On Jun 25, 2023, at 8:21 AM, Alan Snyder wrote: > > I’m having trouble using the code signing feature of jpackage for macOS. > > The problem appears to be here: > > result = MacBaseInstallerBundler.findKey( >

Re: RFR: 8310987: Missing @since tag(s) in java/util/logging/ErrorManager.java

2023-06-30 Thread Iris Clark
On Fri, 30 Jun 2023 09:06:20 GMT, Daniel Fuchs wrote: > Please find here a trivial doc fix to add a missing `@since 1.4` to the > java.util.logging.ErrorManager class. Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/14725#pullrequestreview-1507

Re: RFR: 8311043: Remove trailing blank lines in source files

2023-06-30 Thread Daniel D . Daugherty
On Wed, 28 Jun 2023 16:54:51 GMT, Leo Korinth wrote: > Remove trailing "blank" lines in source files. > > I like to use global-whitespace-cleanup-mode, but I can not use it if the > files are "dirty" to begin with. This fix will make more files "clean". I > also considered adding a check for t

RFR: 8311175: Move BufWriter::asByteBuffer to BufWriterImpl

2023-06-30 Thread Chen Liang
As discussed on the mailing list https://mail.openjdk.org/pipermail/classfile-api-dev/2023-June/000381.html, BufWriter::asByteBuffer has a behavior not suitable for API and is only used by internal StackMapGenerator/StackCounter, so it will be converted to an internal API. Somehow the ByteBuff

Re: RFR: 8310929: Optimization for Integer.toString [v8]

2023-06-30 Thread 温绍锦
> Optimization for: > Integer.toString > Long.toString > StringBuilder#append(int) > > # Benchmark Result > > > sh make/devkit/createJMHBundle.sh > bash configure --with-jmh=build/jmh/jars > make test TEST="micro:java.lang.Integers.toString*" > make test TEST="micro:java.lang.Longs.toString*"

RFR: 8311172: Classfile.PREVIEW_MINOR_VERSION doesn't match that read from class files

2023-06-30 Thread Chen Liang
`Classfile.PREVIEW_MINOR_VERSION`, currently -1, is correct when passed to `ClassBuilder::withVersion`, but is incorrect when compared to `ClassModel::minorVersion`, which only sets the bits of 2 lowest bytes to 1 (65536). Discovered when trying to replace an asserted preview minor version with

Re: RFR: 8294969: Convert jdk.jdeps javap to use the Classfile API [v8]

2023-06-30 Thread Adam Sotona
> javap uses proprietary com.sun.tools.classfile library to parse class files. > > This patch converts javap to use Classfile API. > > Please review. > > Thanks, > Adam Adam Sotona has updated the pull request incrementally with one additional commit since the last revision: added DydnamicC

Re: RFR: 8301341: LinkedTransferQueue does not respect timeout for poll() [v3]

2023-06-30 Thread Doug Lea
On Fri, 30 Jun 2023 12:54:37 GMT, Viktor Klang wrote: >> Doug Lea has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Overhaul LTQ and SQ to use common blocking and matching mechanics > > src/java.base/share/classes/java/util/concurrent/Link

Re: RFR: 8301341: LinkedTransferQueue does not respect timeout for poll() [v3]

2023-06-30 Thread Viktor Klang
On Thu, 29 Jun 2023 22:53:10 GMT, Doug Lea wrote: >> This now uses Thread.isVirtual to distinguish spin vs immediate block cases, >> enabling re-introduction of spin control from the previous version, removing >> anomalies like this one. > > Doug Lea has updated the pull request incrementally w

Re: RFR: 8311085: Remove implementation detail writeTo from LocalVariable(Type) [v3]

2023-06-30 Thread Chen Liang
On Fri, 30 Jun 2023 00:51:42 GMT, Chen Liang wrote: >> `LocalVariable` and `LocalVariableType` includes `writeTo(BufWriter)`, which >> should be implementation details. >> >> See >> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-June/000381.html >> for context. >> >> This patch mo

[jdk21] RFR: 8310380: Handle problems in core-related tests on macOS when codesign tool does not work

2023-06-30 Thread Matthias Baesken
8310380: Handle problems in core-related tests on macOS when codesign tool does not work - Commit messages: - Backport 39c104df44f17c1d65e35becd4272f73e2c6610c Changes: https://git.openjdk.org/jdk21/pull/87/files Webrev: https://webrevs.openjdk.org/?repo=jdk21&pr=87&range=00 Iss

Re: RFR: 8311085: Remove implementation detail writeTo from LocalVariable(Type) [v3]

2023-06-30 Thread Brian Goetz
On Fri, 30 Jun 2023 00:51:42 GMT, Chen Liang wrote: >> `LocalVariable` and `LocalVariableType` includes `writeTo(BufWriter)`, which >> should be implementation details. >> >> See >> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-June/000381.html >> for context. >> >> This patch mo

Integrated: JDK-8311026: Some G1 specific tests do not set -XX:+UseG1GC

2023-06-30 Thread Matthias Baesken
On Fri, 30 Jun 2023 08:11:47 GMT, Matthias Baesken wrote: > Most G1 tests set -XX:+UseG1GC, but a few (e.g. > gc/g1/TestVerificationInConcurrentCycle.java) miss that. > This is usually just fine and no problem because G1 is the default anyway. > However in some cases, where a custom JVM changes

Re: RFR: JDK-8311026: Some G1 specific tests do not set -XX:+UseG1GC

2023-06-30 Thread Matthias Baesken
On Fri, 30 Jun 2023 08:11:47 GMT, Matthias Baesken wrote: > Most G1 tests set -XX:+UseG1GC, but a few (e.g. > gc/g1/TestVerificationInConcurrentCycle.java) miss that. > This is usually just fine and no problem because G1 is the default anyway. > However in some cases, where a custom JVM changes

Re: RFR: JDK-8310550: Adjust references to rt.jar [v3]

2023-06-30 Thread Matthias Baesken
> There are a few references to rt.jar in comments and in the codebase itself. > Some of them might be removed or adjusted. Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision: remove import - Changes: - all: https://g

Re: RFR: JDK-8311026: Some G1 specific tests do not set -XX:+UseG1GC

2023-06-30 Thread Thomas Schatzl
On Fri, 30 Jun 2023 08:11:47 GMT, Matthias Baesken wrote: > Most G1 tests set -XX:+UseG1GC, but a few (e.g. > gc/g1/TestVerificationInConcurrentCycle.java) miss that. > This is usually just fine and no problem because G1 is the default anyway. > However in some cases, where a custom JVM changes

Re: RFR: 8310929: Optimization for Integer.toString [v7]

2023-06-30 Thread 温绍锦
> Optimization for: > > Integer.toString > Long.toString > StringBuilder#append(int) > > > # Benchmark Result > > > sh make/devkit/createJMHBundle.sh > bash configure --with-jmh=build/jmh/jars > make test TEST="micro:java.lang.Integers.toString*" > make test TEST="micro:java.lang.Longs.toStri

Re: RFR: 8310929: Optimization for Integer.toString [v6]

2023-06-30 Thread 温绍锦
> Optimization for: > > Integer.toString > Long.toString > StringBuilder#append(int) > > > # Benchmark Result > > > sh make/devkit/createJMHBundle.sh > bash configure --with-jmh=build/jmh/jars > make test TEST="micro:java.lang.Integers.toString*" > make test TEST="micro:java.lang.Longs.toStri

Re: RFR: 8310929: Optimization for Integer.toString [v5]

2023-06-30 Thread 温绍锦
On Fri, 30 Jun 2023 06:26:53 GMT, 温绍锦 wrote: >> Optimization for: >> >> Integer.toString >> Long.toString >> StringBuilder#append(int) >> >> >> # Benchmark Result >> >> >> sh make/devkit/createJMHBundle.sh >> bash configure --with-jmh=build/jmh/jars >> make test TEST="micro:java.lang.Integer

Re: RFR: 8311030: ResourceBundle.handleKeySet() is racy

2023-06-30 Thread Sergey Tsypanov
On Fri, 30 Jun 2023 08:30:45 GMT, Raffaello Giulietti wrote: > In the end, this PR is not about fixing a race, as the title seems to suggest > (the original code is correct), but to avoid a volatile read, right? Yeah, probably I was wrong in my conclusion. Should I rename the ticket?

Re: RFR: 8310987: Missing @since tag(s) in java/util/logging/ErrorManager.java

2023-06-30 Thread Lance Andersen
On Fri, 30 Jun 2023 09:06:20 GMT, Daniel Fuchs wrote: > Please find here a trivial doc fix to add a missing `@since 1.4` to the > java.util.logging.ErrorManager class. Marked as reviewed by lancea (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/14725#pullrequestreview-15

Re: RFR: JDK-8310550: Adjust references to rt.jar [v2]

2023-06-30 Thread Matthias Baesken
On Wed, 28 Jun 2023 13:22:20 GMT, Matthias Baesken wrote: >>> Hi Alan, regarding usage of class VM I get 'package jdk.internal.misc is >>> declared in module java.base, which does not export it to module java.sql' >>> Is there any concern to export it as well to module java.sql ? And btw did >

Re: RFR: JDK-8310550: Adjust references to rt.jar [v2]

2023-06-30 Thread Matthias Baesken
> There are a few references to rt.jar in comments and in the codebase itself. > Some of them might be removed or adjusted. Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision: Adjust comment in src/java.sql/share/classes/java/sql/Dri

Re: RFR: 8294969: Convert jdk.jdeps javap to use the Classfile API [v7]

2023-06-30 Thread Adam Sotona
> javap uses proprietary com.sun.tools.classfile library to parse class files. > > This patch converts javap to use Classfile API. > > Please review. > > Thanks, > Adam Adam Sotona has updated the pull request incrementally with one additional commit since the last revision: extended ClassR

RFR: 8310987: Missing @since tag(s) in java/util/logging/ErrorManager.java

2023-06-30 Thread Daniel Fuchs
Please find here a trivial doc fix to add a missing `@since 1.4` to the java.util.logging.ErrorManager class. - Commit messages: - 8310987 Changes: https://git.openjdk.org/jdk/pull/14725/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=14725&range=00 Issue: https://bugs.op

Re: RFR: 8311030: ResourceBundle.handleKeySet() is racy

2023-06-30 Thread Raffaello Giulietti
On Wed, 28 Jun 2023 11:05:11 GMT, Sergey Tsypanov wrote: > Double-checked locking should rely on local variable to avoid racy reads from > volatile field. True. I was mislead because the return statement does not appear in the changeset (the line is textually the same, although it has a differ

Re: RFR: JDK-8311026: Some G1 specific tests do not set -XX:+UseG1GC

2023-06-30 Thread Serguei Spitsyn
On Fri, 30 Jun 2023 08:11:47 GMT, Matthias Baesken wrote: > Most G1 tests set -XX:+UseG1GC, but a few (e.g. > gc/g1/TestVerificationInConcurrentCycle.java) miss that. > This is usually just fine and no problem because G1 is the default anyway. > However in some cases, where a custom JVM changes

RFR: JDK-8311026: Some G1 specific tests do not set -XX:+UseG1GC

2023-06-30 Thread Matthias Baesken
Most G1 tests set -XX:+UseG1GC, but a few (e.g. gc/g1/TestVerificationInConcurrentCycle.java) miss that. This is usually just fine and no problem because G1 is the default anyway. However in some cases, where a custom JVM changes the default GC, those tests start to fail which is not really neces

RFR: 8310818: Refactor more Locale tests to use JUnit

2023-06-30 Thread Justin Lu
Please review this PR which refactors additional tests in Locale to use JUnit. If a test was named bugNNN.java, it was renamed to something more descriptive. Below is a list of all the changes - Refactor and Rename Bug4175998Test.java as ISO639.java - Refactor and Rename Bug8001562.java as

Re: RFR: 8310923: Refactor Currency tests to use JUnit [v4]

2023-06-30 Thread Justin Lu
On Thu, 29 Jun 2023 23:07:14 GMT, Naoto Sato wrote: >> Justin Lu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Remove unusued JUnit imports from ValidateISO4217.java > > test/jdk/java/util/Currency/MinorUndefinedCodes.java line 27: >

Re: RFR: 8310923: Refactor Currency tests to use JUnit [v5]

2023-06-30 Thread Justin Lu
> Please review this PR which refactors Currency tests to use JUnit. > > The most significant change occurs in `ValidateISO4217.java`. Other changes > to this file excluding the JUnit refactoring include > > - Tests are no longer dependent on each other (order of execution does not > matter) >

Re: RFR: 8310923: Refactor Currency tests to use JUnit [v4]

2023-06-30 Thread Justin Lu
On Thu, 29 Jun 2023 22:38:21 GMT, Naoto Sato wrote: >> Justin Lu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Remove unusued JUnit imports from ValidateISO4217.java > > test/jdk/java/util/Currency/CurrencyNameProviderTest.java line 43

Re: RFR: 8310923: Refactor Currency tests to use JUnit [v4]

2023-06-30 Thread Justin Lu
On Thu, 29 Jun 2023 23:24:06 GMT, Naoto Sato wrote: >> Justin Lu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Remove unusued JUnit imports from ValidateISO4217.java > > test/jdk/java/util/Currency/ValidateISO4217.java line 82: > >> 8