On Wed, 30 Aug 2023 11:31:20 GMT, Mark Sheppard wrote:
> So you could create a single createJavaProcessBuilder with add an additional
> parameter boolean addTestOpts e.g.
createJavaProcessBuilder(List command, boolean addTestOpts) { ... }
@msheppar that is actually where we started, and it was
On Thu, 6 Jul 2023 05:20:14 GMT, 温绍锦 wrote:
>> # Benchmark Result
>>
>>
>> sh make/devkit/createJMHBundle.sh
>> bash configure --with-jmh=build/jmh/jars
>> make test TEST="micro:java.lang.StringUpperLower.*"
>>
>>
>>
>> ## 1.
>>
On Tue, 18 Jul 2023 01:49:17 GMT, 温绍锦 wrote:
>> Optimization for:
>> Integer.toString
>> Long.toString
>> StringBuilder#append(int)
>>
>> # Benchmark Result
>>
>>
>> sh make/devkit/createJMHBundle.sh
>> bash configure --with-jmh=build/jmh/jars
>> make test
On Mon, 28 Aug 2023 21:14:53 GMT, Justin Lu wrote:
> Please review this PR which updates some exceptions in j.util.Currency to
> have an explicit error message (as opposed to nothing).
>
> The exceptions are thrown when the ISO 4217/3166 currency/country codes are
> in an invalid form, or do
> Fixes https://bugs.openjdk.org/browse/JDK-8315383
Oliver Kopp has updated the pull request incrementally with one additional
commit since the last revision:
Remove obsolete imports
-
Changes:
- all: https://git.openjdk.org/jdk/pull/15495/files
- new:
> This is stemming from the PR: https://github.com/openjdk/jdk/pull/14211 where
> aggressive GC can cause NPE in `BaseLocale$Key` class. I refactored the
> in-house cache with WeakHashMap, and removed the Key class as it is no longer
> needed (thus the original NPE will no longer be possible).
Loom added a special filtering of Continuation.yield0 in stack walker. After
the initial implementation, JDK-8304919 marks the yielding and entering methods
with `@Hidden` and hidden frames are filtered by stack walker by default.
With `@Hidden` the special filtering should not be needed.
On Wed, 30 Aug 2023 06:40:40 GMT, Chen Liang wrote:
>> Naoto Sato has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 29 commits:
>>
>> - Merge branch 'master' of https://git.openjdk.org/jdk into
>> JDK-8309622-Cache-BaseLocale
>>
> 8314491: Linux: jexec launched via PATH fails to find java
Vladimir Petko has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by the merge/rebase. The pull request contains ten additional
commits
On Wed, 30 Aug 2023 19:07:53 GMT, Oliver Kopp wrote:
> Fixes https://bugs.openjdk.org/browse/JDK-8315383
Looks good. Thanks for catching this.
There are a few unused imports in JLinkDedupTestBatchSizeOne.java. Can you
remove them as you are in that file?
-
Marked as reviewed
Fixes https://bugs.openjdk.org/browse/JDK-8315383
-
Commit messages:
- 8315383: jlink SystemModulesPlugin incorrectly parses the options
Changes: https://git.openjdk.org/jdk/pull/15495/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=15495=00
Issue:
On Tue, 29 Aug 2023 21:42:28 GMT, Justin Lu wrote:
>> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8314607)
>> which clarifies the behavior of patterns in regards to the max integer
>> digits in j.text.DecimalFormat.
>>
>> The current specification (of `applyPattern`)
On Wed, 30 Aug 2023 15:31:27 GMT, Alan Bateman wrote:
>> src/java.base/share/classes/java/lang/StackStreamFactory.java line 694:
>>
>>> 692: // no method information is available; should just filter
>>> 693: // "Continuation::yield0".
>>> 694: return
On Wed, 30 Aug 2023 09:23:55 GMT, Leo Korinth wrote:
>> Rename createJavaProcessBuilder so that it is not used by mistake instead of
>> createTestJvm.
>>
>> I have used the following sed script: `find -name "*.java" | xargs -n 1 sed
>> -i -e
>>
On Tue, 29 Aug 2023 20:09:37 GMT, Justin Lu wrote:
>> Please review this PR and [CSR
>> ](https://bugs.openjdk.org/browse/JDK-8314974)which clarifies behavior for
>> BreakIterator instances when text has not been set.
>>
>> For example, calling `BreakIterator.getWordInstance().next();` has
On Wed, 30 Aug 2023 09:23:55 GMT, Leo Korinth wrote:
>> Rename createJavaProcessBuilder so that it is not used by mistake instead of
>> createTestJvm.
>>
>> I have used the following sed script: `find -name "*.java" | xargs -n 1 sed
>> -i -e
>>
On Wed, 30 Aug 2023 07:09:34 GMT, Alan Bateman wrote:
> The updated proposal/javadoc looks good, just in two minds on whether the
> overload with the varargs should be added. The Set.of factory methods make is
> really easy to use the existing getInstance(Set) method.
Indeed, Set.of factory
On Tue, 29 Aug 2023 20:23:24 GMT, Vladimir Kozlov wrote:
>> The shared library approach is being followed currently as an initial
>> implementation to demonstrate the value of AVX512 sorting. This will be
>> followed up in future with support for Windows as well.
>> If it is ok with you, the
On Tue, 29 Aug 2023 08:30:10 GMT, Christoph Langer wrote:
>> It seems that ProcessHandle.info() returns **DOMAIN/USERNAME** on Windows
>> but System.getProperty("user.name") only the **USERNAME**.
>> You can get **DOMAIN** and **USERNAME** on **Windows** by calling:
>>
On Wed, 30 Aug 2023 15:03:27 GMT, Daniel Fuchs wrote:
>> Mandy Chung has updated the pull request incrementally with three additional
>> commits since the last revision:
>>
>> - update mode to be int rather than long
>> - update tests
>> - Review feedback on javadoc
>
>
On Tue, 29 Aug 2023 20:51:56 GMT, Mandy Chung wrote:
>> 8268829: Provide an optimized way to walk the stack with Class object only
>>
>> `StackWalker::walk` creates one `StackFrame` per frame and the current
>> implementation
>> allocates one `StackFrameInfo` and one `MemberName` objects per
On Wed, 30 Aug 2023 08:48:09 GMT, Alan Bateman wrote:
>>> > > Hi, We already have correctness tests. See
>>> > > test/jdk/java/util/Arrays/Sorting.java
>>> > > The latest version you can find in PR
>>> > > https://github.com/openjdk/jdk/pull/13568/files
>>> >
>>> >
>>> > Does
On Wed, 30 Aug 2023 09:23:55 GMT, Leo Korinth wrote:
>> Rename createJavaProcessBuilder so that it is not used by mistake instead of
>> createTestJvm.
>>
>> I have used the following sed script: `find -name "*.java" | xargs -n 1 sed
>> -i -e
>>
On Wed, 30 Aug 2023 08:48:09 GMT, Alan Bateman wrote:
> > Hi Vladimir, Just verified that the test/jdk/java/util/Arrays/Sorting.java
> > is triggering the intrinsic without additional flags
>
> Just to add that Sorting.java has short and long run modes. The default when
> running with jtreg
On Wed, 30 Aug 2023 13:20:15 GMT, Alan Bateman wrote:
> > Hi Can anyone help me to review this PR @sormuras @asotona or any other
> > reviewer?
>
> I think you first need to make a case for changing the CyclicBarrier API as
> opposed to dealing with the phases in your BarrierAction or using
On Wed, 30 Aug 2023 12:02:12 GMT, chenggwang wrote:
> Hi Can anyone help me to review this PR @sormuras @asotona or any other
> reviewer?
I think you first need to make a case for changing the CyclicBarrier API as
opposed to dealing with the phases in your BarrierAction or using the Phaser
On Wed, 23 Aug 2023 15:41:16 GMT, Sean Coffey wrote:
> Recursive initialization calls possible during loading of LoggerFinder
> service.
>
> This fix detects the recursive call and returns a temporary LoggerFinder that
> is backed by a lazy logger. Automated test case developed to simulate
> This pull request updates Classfile API snippets and examples and adds
> missing javadoc.
>
> Please review.
>
> Thanks,
> Adam
Adam Sotona has updated the pull request incrementally with one additional
commit since the last revision:
fixing javadoc
-
Changes:
- all:
> This pull request updates Classfile API snippets and examples and adds
> missing javadoc.
>
> Please review.
>
> Thanks,
> Adam
Adam Sotona has updated the pull request incrementally with one additional
commit since the last revision:
fixing javadoc
-
Changes:
- all:
On Fri, 11 Aug 2023 02:33:05 GMT, chenggwang wrote:
> Sorry, my description in Issue JDK-8314194(which I submitted) is ambiguous
> and makes you think of Phaser. My intention is that each generation of
> CyclicBarrier barrierCommand can change. Let me give you a scenario
> For example, the
On Mon, 28 Aug 2023 16:31:06 GMT, Lance Andersen wrote:
> Hi all,
>
> Please review this PR which updates zlib from 1.2.13 to 1.3 in openJDK
>
> The [Zlib Data Compression Library](https://github.com/madler/zlib ) has
> released Zlib 1.3 on August 18, 2023.
>
> There are a [small number of
On Wed, 30 Aug 2023 09:23:55 GMT, Leo Korinth wrote:
>> Rename createJavaProcessBuilder so that it is not used by mistake instead of
>> createTestJvm.
>>
>> I have used the following sed script: `find -name "*.java" | xargs -n 1 sed
>> -i -e
>>
On Wed, 23 Aug 2023 23:50:29 GMT, Qing Xiao wrote:
> Migrate jdk.jlink StringSharingPlugin to use new classfile library
This pull request has now been integrated.
Changeset: e29f0c2d
Author:Qing Xiao
Committer: Adam Sotona
URL:
> This pull request updates Classfile API snippets and examples and adds
> missing javadoc.
>
> Please review.
>
> Thanks,
> Adam
Adam Sotona has updated the pull request incrementally with two additional
commits since the last revision:
- fixing javadoc
- fixing javadoc
-
On Wed, 30 Aug 2023 09:49:39 GMT, Sergey Tsypanov wrote:
> Assuming that the value written into `in` is always `-1` we can rid
> synchronized block in favour of guarding `in = - 1` with writing into
> volatile `closedByReader `:
>
> public void close() throws IOException {
>
On Fri, 11 Aug 2023 02:33:05 GMT, chenggwang wrote:
> Sorry, my description in Issue JDK-8314194(which I submitted) is ambiguous
> and makes you think of Phaser. My intention is that each generation of
> CyclicBarrier barrierCommand can change. Let me give you a scenario
> For example, the
> * improved mixed insertion sort (makes whole sorting faster)
> * introduced Radix which sort shows several times boost of performance and
> has linear complexity instead of n*ln(n)
> * improved merging sort for almost sorted data
> * optimized parallel sorting
> * improved step for pivot
Assuming that the value written into `in` is always `-1` we can rid
synchronized block in favour of guarding `in = - 1` with writing into volatile
`closedByReader `:
public void close() throws IOException {
closedByReader = true;
synchronized (this) {
in = -1;
}
}
-->
> * improved mixed insertion sort (makes whole sorting faster)
> * introduced Radix which sort shows several times boost of performance and
> has linear complexity instead of n*ln(n)
> * improved merging sort for almost sorted data
> * optimized parallel sorting
> * improved step for pivot
> Rename createJavaProcessBuilder so that it is not used by mistake instead of
> createTestJvm.
>
> I have used the following sed script: `find -name "*.java" | xargs -n 1 sed
> -i -e
> "s/createJavaProcessBuilder(/createJavaProcessBuilderIgnoreTestJavaOpts(/g"`
>
> Then I have manually
On Tue, 29 Aug 2023 15:31:03 GMT, Sean Coffey wrote:
>> Recursive initialization calls possible during loading of LoggerFinder
>> service.
>>
>> This fix detects the recursive call and returns a temporary LoggerFinder
>> that is backed by a lazy logger. Automated test case developed to
On Wed, 30 Aug 2023 00:37:26 GMT, Srinivas Vamsi Parasa
wrote:
> Hi Vladimir, Just verified that the test/jdk/java/util/Arrays/Sorting.java is
> triggering the intrinsic without additional flags
Just to add that Sorting.java has short and long run modes. The default when
running with jtreg
On Tue, 29 Aug 2023 17:31:00 GMT, Alan Bateman wrote:
> > @AlanBateman Gentle ping.
>
> On my list, it's a lot to get through and a number of aspects to this that I
> think will require refinement and discussion.
Thanks for the heads-up! Your input is much appreciated.
-
PR
On Mon, 14 Aug 2023 20:23:13 GMT, Aleksey Shipilev wrote:
>> `Collections.rotate` method contains a bug. This method throws
>> IndexOutOfBoundsException on arrays larger than $2^{30}$ elements. The way
>> to reproduce:
>>
>> final int size = (1 << 30) + 1;
>> final List list = new
On Wed, 30 Aug 2023 03:15:18 GMT, Mikhailo Seledtsov
wrote:
>> Container ecosystem is growing. It would be beneficial to define custom
>> command to figure out whether a specific test host or environment allows for
>> container testing. This enhancement seeks to make the command used by jtreg
On Tue, 29 Aug 2023 16:45:12 GMT, Roger Riggs wrote:
>> I don't think this is the best change across so many files.
>> It gives a very ugly name to a common test function and affects a very large
>> number of tests.
>
>> @RogerRiggs If it is only the name you want changed, maybe you can offer a
On Tue, 29 Aug 2023 20:51:56 GMT, Mandy Chung wrote:
>> 8268829: Provide an optimized way to walk the stack with Class object only
>>
>> `StackWalker::walk` creates one `StackFrame` per frame and the current
>> implementation
>> allocates one `StackFrameInfo` and one `MemberName` objects per
On Tue, 29 Aug 2023 12:10:34 GMT, Matthias Baesken wrote:
>> We have some failures in TreeTest.java where the expected number of child
>> processes is differing from what we really get. It would be good to have
>> more output to analyze these cases.
>
> Matthias Baesken has updated the pull
On Tue, 29 Aug 2023 07:51:59 GMT, Matthias Baesken wrote:
> We have some failures in TreeTest.java where the expected number of child
> processes is differing from what we really get. It would be good to have more
> output to analyze these cases.
This pull request has now been integrated.
On Tue, 1 Aug 2023 20:21:11 GMT, Naoto Sato wrote:
>> This is stemming from the PR: https://github.com/openjdk/jdk/pull/14211
>> where aggressive GC can cause NPE in `BaseLocale$Key` class. I refactored
>> the in-house cache with WeakHashMap, and removed the Key class as it is no
>> longer
50 matches
Mail list logo
