On Wed, 13 Sep 2023 12:27:39 GMT, Soumadipta Roy wrote:
>> This test is running in tier1, and takes about 400 seconds to complete.
>> Thus, it drags the execution time of tier1 on large machines. The commit
>> includes changing the sequential run of test cases in
>> java/util/concurrent/tck/JS
On Thu, 7 Sep 2023 16:22:18 GMT, Soumadipta Roy wrote:
>> test/jdk/java/util/concurrent/tck/JSR166TestCase.java line 45:
>>
>>> 43: * @modules java.management
>>> 44: * @run junit/othervm/timeout=1000 JSR166TestCase
>>> 45: * @run junit/othervm/timeout=1000 -Djava.security.manager=allow
>>>
Hi Simone,
On 13/09/2023 4:16 pm, Simone Bordet wrote:
Hi,
On Tue, Sep 12, 2023 at 11:44 PM David Holmes wrote:
Hi Simone,
Thanks for the logs. Unfortunately they shed no light on what is
happening. There is no sign of the MutableHttpFields class starting
actual initialization, though we ca
On Wed, 13 Sep 2023 18:52:21 GMT, ExE Boss wrote:
>> In many scenarios, DateTimeFormatter::format is a slower operation.
>>
>> For example, the following business scenarios
>> 1. The json library
>> gson/jackson/[fastjson2](https://github.com/alibaba/fastjson2) formats
>> Instant/LocalDate/L
On Wed, 13 Sep 2023 14:56:15 GMT, 温绍锦 wrote:
> In many scenarios, DateTimeFormatter::format is a slower operation.
>
> For example, the following business scenarios
> 1. The json library
> gson/jackson/[fastjson2](https://github.com/alibaba/fastjson2) formats
> Instant/LocalDate/LocalTime/Lo
On Wed, 13 Sep 2023 14:56:15 GMT, 温绍锦 wrote:
> In many scenarios, DateTimeFormatter::format is a slower operation.
>
> For example, the following business scenarios
> 1. The json library
> gson/jackson/[fastjson2](https://github.com/alibaba/fastjson2) formats
> Instant/LocalDate/LocalTime/Lo
In many scenarios, DateTimeFormatter::format is a slower operation.
For example, the following business scenarios
1. The json library
gson/jackson/[fastjson2](https://github.com/alibaba/fastjson2) formats
Instant/LocalDate/LocalTime/LocalDateTime/ZonedDateTim into strings.
2. In data integrati
On Wed, 13 Sep 2023 23:00:23 GMT, Srinivas Vamsi Parasa
wrote:
>> The goal is to develop faster sort routines for x86_64 CPUs by taking
>> advantage of AVX512 instructions. This enhancement provides an order of
>> magnitude speedup for Arrays.sort() using int, long, float and double arrays.
>>
> The goal is to develop faster sort routines for x86_64 CPUs by taking
> advantage of AVX512 instructions. This enhancement provides an order of
> magnitude speedup for Arrays.sort() using int, long, float and double arrays.
>
> This PR shows upto ~7x improvement for 32-bit datatypes (int, floa
On Wed, 13 Sep 2023 15:43:45 GMT, Pavel Rappo wrote:
> This is a simple PR to fix a few typos in the doc comments of
> java.io.StreamTokenizer. When reviewing it, please double-check my proposal
> for L481. For this, you should ideally read the complete comment to the
> `lowerCaseMode` method.
On Wed, 13 Sep 2023 12:39:00 GMT, Pavel Rappo wrote:
> This modernizes an example to use the extended for-statement introduced in
> JDK 1.5.
>
> I understand that StringTokenizer is a legacy class. But legacy or not, a
> class shouldn't promote older constructs when newer fit better. Especiall
On Wed, 13 Sep 2023 21:22:43 GMT, 温绍锦 wrote:
> Based on the use cases cited, if your library needs specific performance
> improvements for specific formats, they should be done in that library.
Not only JSON libraries, toString optimization of Date/Instant/LocalDateTime
and other classes will
On Wed, 13 Sep 2023 14:22:35 GMT, 温绍锦 wrote:
>> improve date toString performance, includes:
>>
>> java.util.Date.toString
>> java.util.Date.toGMTString
>> java.time.Instant.toString
>> java.time.LocalDate.toString
>> java.time.LocalDateTime.toString
>> java.time.LocalTime.toString
>
> 温绍锦 has u
On Wed, 13 Sep 2023 19:21:34 GMT, Roger Riggs wrote:
> Based on the use cases cited, if your library needs specific performance
> improvements for specific formats, they should be done in that library.
I already do this in [fastjson2](https://github.com/alibaba/fastjson2) for now,
but more lib
On Wed, 6 Sep 2023 13:36:22 GMT, Claes Redestad wrote:
> This PR seeks to improve formatting of hex digits using `java.util.HexFormat`
> somewhat.
>
> This is achieved getting rid of a couple of lookup tables, caching the result
> of `HexFormat.of().withUpperCase()`, and removing tiny allocati
On Fri, 8 Sep 2023 10:32:40 GMT, Claes Redestad wrote:
>> This PR seeks to improve formatting of hex digits using
>> `java.util.HexFormat` somewhat.
>>
>> This is achieved getting rid of a couple of lookup tables, caching the
>> result of `HexFormat.of().withUpperCase()`, and removing tiny all
On Wed, 13 Sep 2023 20:21:20 GMT, Justin Lu wrote:
>> Please review this PR which is a continuation of
>> [JDK-6453901](https://bugs.openjdk.org/browse/JDK-6453901) to remove unused
>> code from the _sun.util.Calendar_ classes.
>>
>> `forceStandardTime` is always false.
>>
>> In addition, `lo
> Please review this PR which is a continuation of
> [JDK-6453901](https://bugs.openjdk.org/browse/JDK-6453901) to remove unused
> code from the _sun.util.Calendar_ classes.
>
> `forceStandardTime` is always false.
>
> In addition, `locale` is never by used by _CalendarDate_ or any inheritors
On Tue, 22 Aug 2023 19:18:35 GMT, Justin Lu wrote:
> Please review this PR and associated
> [CSR](https://bugs.openjdk.org/browse/JDK-8314546) which expands on the
> `java.text.ChoiceFormat` specification regarding its pattern.
>
> `j.text.ChoiceFormat` provides an example pattern in the class
> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8315720)
> which refines the spec of `equals()` and `hashCode()` in `java.text.Format`
> related classes.
>
> The current spec for most of these methods is either "_Overrides
> _" or are incomplete/wrong (i.e. see `ChoiceFor
This PR is to incorporate the latest Unicode 15.1, which was released
yesterday. Besides the usual character data update, an upgraded implementation
of RegEx which reflects the Indic Consonant Break specified in the latest
Unicode Annex #29 ("Unicode Text Segmentation") is included. A correspond
On Wed, 13 Sep 2023 19:46:08 GMT, Justin Lu wrote:
>> Please review this PR which is a continuation of
>> [JDK-6453901](https://bugs.openjdk.org/browse/JDK-6453901) to remove unused
>> code from the _sun.util.Calendar_ classes.
>>
>> `forceStandardTime` is always false.
>>
>> In addition, `lo
On Fri, 8 Sep 2023 10:32:40 GMT, Claes Redestad wrote:
>> This PR seeks to improve formatting of hex digits using
>> `java.util.HexFormat` somewhat.
>>
>> This is achieved getting rid of a couple of lookup tables, caching the
>> result of `HexFormat.of().withUpperCase()`, and removing tiny all
On Tue, 12 Sep 2023 10:49:38 GMT, Jorn Vernee wrote:
>> This patch contains the implementation of the foreign linker & memory API
>> JEP for Java 22. The initial patch is composed of commits brought over
>> directly from the [panama-foreign
>> repo](https://github.com/openjdk/panama-foreign).
On Wed, 13 Sep 2023 19:40:04 GMT, Justin Lu wrote:
>> Please review this PR which is a continuation of
>> [JDK-6453901](https://bugs.openjdk.org/browse/JDK-6453901) to remove unused
>> code from the _sun.util.Calendar_ classes.
>>
>> `forceStandardTime` is always false.
>>
>> In addition, `lo
> Please review this PR which is a continuation of
> [JDK-6453901](https://bugs.openjdk.org/browse/JDK-6453901) to remove unused
> code from the _sun.util.Calendar_ classes.
>
> `forceStandardTime` is always false.
>
> In addition, `locale` is never by used by _CalendarDate_ or any inheritors
> On Sep 13, 2023, at 2:27 PM, Michael Hall wrote:
>
>
>
>> On Sep 13, 2023, at 2:21 PM, Alexey Semenyuk
>> wrote:
>>
>> jpoackage requires at least Wix v3.0. If it doesn't recognize Wix4, it is a
>> bug.
>>
>> - Alexey
>>
>> On 9/12/2023 6:50 PM, Michael Hall wrote:
>>> Curiosity. I w
On Wed, 13 Sep 2023 14:22:35 GMT, 温绍锦 wrote:
>> improve date toString performance, includes:
>>
>> java.util.Date.toString
>> java.util.Date.toGMTString
>> java.time.Instant.toString
>> java.time.LocalDate.toString
>> java.time.LocalDateTime.toString
>> java.time.LocalTime.toString
>
> 温绍锦 has u
> On Sep 13, 2023, at 2:21 PM, Alexey Semenyuk
> wrote:
>
> jpoackage requires at least Wix v3.0. If it doesn't recognize Wix4, it is a
> bug.
>
> - Alexey
>
> On 9/12/2023 6:50 PM, Michael Hall wrote:
>> Curiosity. I was setting up a new Windows 10 VirtualBox image to do
>> jpackage. It
On Wed, 13 Sep 2023 14:22:35 GMT, 温绍锦 wrote:
>> improve date toString performance, includes:
>>
>> java.util.Date.toString
>> java.util.Date.toGMTString
>> java.time.Instant.toString
>> java.time.LocalDate.toString
>> java.time.LocalDateTime.toString
>> java.time.LocalTime.toString
>
> 温绍锦 has u
jpoackage requires at least Wix v3.0. If it doesn't recognize Wix4, it
is a bug.
- Alexey
On 9/12/2023 6:50 PM, Michael Hall wrote:
Curiosity. I was setting up a new Windows 10 VirtualBox image to do jpackage.
It told me I needed Wix. First I needed dotnet to install wix. I then got a Wix
v4
On Wed, 13 Sep 2023 12:51:19 GMT, Per Minborg wrote:
>> This PR proposes to use hexadecimal representation for a memory segment
>> address rather than a decimal one.
>
> Per Minborg has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Change fr
On Wed, 13 Sep 2023 18:40:07 GMT, Mandy Chung wrote:
>> This reimplements
>> `sun.reflect.ReflectionFactory::newConstructorForSerialization` with method
>> handles.
>>
>> This API currently generates the bytecode which fails the verification
>> because `new C; invokespecial A()` where the giv
On Wed, 13 Sep 2023 18:12:15 GMT, Naoto Sato wrote:
> Looks good to me, although I did not look at each l10n file, but sampled
> some. Thanks for tackling this conversion.
Thanks for the review; (In addition to testing), I ran a script to verify only
white space escape sequences exist in JDK .
> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8315720)
> which refines the spec of `equals()` and `hashCode()` in `java.text.Format`
> related classes.
>
> The current spec for most of these methods is either "_Overrides
> _" or are incomplete/wrong (i.e. see `ChoiceFor
> This reimplements
> `sun.reflect.ReflectionFactory::newConstructorForSerialization` with method
> handles.
>
> This API currently generates the bytecode which fails the verification
> because `new C; invokespecial A()` where the given class `C` and invoke a
> no-arg constructor of `C`'s firs
On Wed, 13 Sep 2023 17:52:13 GMT, Justin Lu wrote:
> Please review this PR which is a continuation of
> [JDK-6453901](https://bugs.openjdk.org/browse/JDK-6453901) to remove unused
> code from the _sun.util.Calendar_ classes.
>
> `forceStandardTime` is always false.
>
> In addition, `locale` i
On Wed, 13 Sep 2023 17:38:28 GMT, Justin Lu wrote:
>> JDK .properties files still use ISO-8859-1 encoding with escape sequences.
>> It would improve readability to see the native characters instead of escape
>> sequences (especially for the L10n process). The majority of files changed
>> are l
Please review this PR which is a continuation of
[JDK-6453901](https://bugs.openjdk.org/browse/JDK-6453901) to remove unused
code from the _sun.util.Calendar_ classes.
`forceStandardTime` is always false.
In addition, `locale` is never by used by _CalendarDate_ or any inheritors and
can be rem
> This PR improves IllegalAccessException message thrown by `Lookup::findXXX`
> APIs if the method's variable arity modifier bit is set and
> `asVarargsCollector` fails. It will increase the exception message thrown by
> asVarargsCollector`.
Mandy Chung has updated the pull request incremental
> JDK .properties files still use ISO-8859-1 encoding with escape sequences. It
> would improve readability to see the native characters instead of escape
> sequences (especially for the L10n process). The majority of files changed
> are localized resource files.
>
> This change converts the Un
On Mon, 14 Aug 2023 20:23:13 GMT, Aleksey Shipilev wrote:
>> `Collections.rotate` method contains a bug. This method throws
>> IndexOutOfBoundsException on arrays larger than $2^{30}$ elements. The way
>> to reproduce:
>>
>> final int size = (1 << 30) + 1;
>> final List list = new ArrayList<>(
On Wed, 13 Sep 2023 05:08:58 GMT, Chen Liang wrote:
>> Mandy Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> use member (not method handle)
>
> src/java.base/share/classes/java/lang/invoke/MethodHandle.java line 1722:
>
>> 1720:
> This PR improves IllegalAccessException message thrown by `Lookup::findXXX`
> APIs if the method's variable arity modifier bit is set and
> `asVarargsCollector` fails. It will increase the exception message thrown by
> asVarargsCollector`.
Mandy Chung has updated the pull request incremental
> Addresses Jdk 8288899 : java/util/concurrent/ExecutorService/CloseTest.java
> failed with "InterruptedException: sleep interrupted" and related issues.
>
> This is a major ForkJoin update (and hard to review -- sorry) that finally
> addresses incompatibilities between ExecutorService and ForkJ
This is a simple PR to fix a few typos in the doc comments of
java.io.StreamTokenizer. When reviewing it, please double-check my proposal for
L481. For this, you should ideally read the complete comment to the
`lowerCaseMode` method. Thanks!
-
Commit messages:
- Initial commit
Ch
On Wed, 13 Sep 2023 11:26:30 GMT, Sean Coffey wrote:
> Some log messages from the test may be dropped if the bootstraplogger is in
> use at time of log call. (bootstap logger logs at INFO level, the security
> event logger logs at DEBUG level)
>
> Modify the test to use a patched EventHelper c
On Wed, 13 Sep 2023 11:26:30 GMT, Sean Coffey wrote:
> Some log messages from the test may be dropped if the bootstraplogger is in
> use at time of log call. (bootstap logger logs at INFO level, the security
> event logger logs at DEBUG level)
>
> Modify the test to use a patched EventHelper c
> improve date toString performance, includes:
>
> java.util.Date.toString
> java.util.Date.toGMTString
> java.time.Instant.toString
> java.time.LocalDate.toString
> java.time.LocalDateTime.toString
> java.time.LocalTime.toString
温绍锦 has updated the pull request incrementally with one additional
On Tue, 12 Sep 2023 22:53:34 GMT, Claes Redestad wrote:
>> The reason for not using off++ is that it can be executed out of order,
>> which may result in better performance.
>
> I don't think that would outweigh the extra branch and the increased code
> size. I'd opt for simplicity.
I've simpl
On Wed, 13 Sep 2023 02:17:00 GMT, 温绍锦 wrote:
>> 1. Reduce duplicate stringSize code
>> 2. Move java.lang.StringLatin1.getChars to
>> jdk.internal.util.DecimalDigits::getCharLatin1，not only java.lang, other
>> packages also need to use this method
>
> 温绍锦 has updated the pull request incremental
> 1. Reduce duplicate stringSize code
> 2. Move java.lang.StringLatin1.getChars to
> jdk.internal.util.DecimalDigits::getCharLatin1，not only java.lang, other
> packages also need to use this method
温绍锦 has updated the pull request incrementally with one additional commit since
the last revision
> Addresses Jdk 8288899 : java/util/concurrent/ExecutorService/CloseTest.java
> failed with "InterruptedException: sleep interrupted" and related issues.
>
> This is a major ForkJoin update (and hard to review -- sorry) that finally
> addresses incompatibilities between ExecutorService and ForkJ
On Mon, 11 Sep 2023 21:17:27 GMT, Per Minborg wrote:
> This PR proposes to use hexadecimal representation for a memory segment
> address rather than a decimal one.
This pull request has now been integrated.
Changeset: f9ab115a
Author:Per Minborg
URL:
https://git.openjdk.org/jdk/com
> This PR proposes to use hexadecimal representation for a memory segment
> address rather than a decimal one.
Per Minborg has updated the pull request incrementally with one additional
commit since the last revision:
Change from limit to byteSize in MS::toString
-
Changes:
-
Some log messages from the test may be dropped if the bootstraplogger is in use
at time of log call. (bootstap logger logs at INFO level, the security event
logger logs at DEBUG level)
Modify the test to use a patched EventHelper class to let it log at INFO level
also, ensuring the bootstrap lo
This modernizes an example to use the extended for-statement introduced in JDK
1.5.
I understand that StringTokenizer is a legacy class. But legacy or not, a class
shouldn't promote older constructs when newer fit better. Especially when
advising on preferred alternatives to itself.
That said,
On Thu, 7 Sep 2023 16:08:16 GMT, Martin Buchholz wrote:
> Hello Soumadipta - pleased to "meet" you.
>
> If the intent is to split the tests into relatively more and less important
> variants for placing into separate tiers, that should be clear from the
> @summary's in the tests.
Hi @Martin-B
> This test is running in tier1, and takes about 400 seconds to complete. Thus,
> it drags the execution time of tier1 on large machines. The commit includes
> changing the sequential run of test cases in
> java/util/concurrent/tck/JSR166TestCase.java to the best possible combination
> of paral
On Sat, 1 Jul 2023 01:44:15 GMT, 温绍锦 wrote:
> [PR 14578 ](https://github.com/openjdk/jdk/pull/14578) still has unresolved
> discussions, continue to make improvements.
>
> # Benchmark Result
>
>
> sh make/devkit/createJMHBundle.sh
> bash configure --with-jmh=build/jmh/jars
> make test TEST="m
60 matches
Mail list logo
