VarHandle implementations have many static fields and methods that can be
pulled to the common superclass to avoid repeated initialization and code
duplication.
In addition, the Unsafe-based Buffer field access are replaced by usage of
public methods or JavaNioAccess.
-
Commit
On Wed, 20 Sep 2023 21:51:19 GMT, Brian Burkhalter wrote:
>> Add a `finally` block to delete the created files.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8315960: Address additional reviewer comments
Now that
On Wed, 20 Sep 2023 22:46:16 GMT, Srinivas Vamsi Parasa
wrote:
> Hi Vladimir,
>
> Just trying to understand: is there a reason to use
> `DualPivotQuicksort_RadixForParallel.java` and
> `DualPivotQuicksort_RadixForAll.java`?
>
> Would it not be sufficient to do the following two runs:
>
>
On Mon, 18 Sep 2023 23:00:09 GMT, Mandy Chung wrote:
> `JVM_MoreStackWalk` has a bug that always assumes that the Java frame
> stream is currently at the frame decoded in the last patch and so always
> advances to the next frame before filling in the new batch of stack frame.
> However
> Like #12077, this uses JDK's internal utilities to speed up ASCII reading in
> Class files, where most identifiers, from conventions to attribute names, are
> ASCII. See the JBS issue for more in-depth explanations.
>
> Before: (Master)
>
> Benchmark Mode Cnt
On Wed, 20 Sep 2023 16:12:36 GMT, Naoto Sato wrote:
>> Fixing a test case that fails in some time zones. Making sure the test is
>> run in `UTC` zone will fix the issue. Confirmed the fix by manually setting
>> machine's time zone to Europe/Dublin.
>
> Naoto Sato has updated the pull request
On Wed, 20 Sep 2023 23:48:13 GMT, Brian Burkhalter wrote:
>> In the Windows implementation of java.io.File.getCanonicalPath, strip any
>> long path or UNC prefix before canonicalizing the remainder of the pathname.
>
> Brian Burkhalter has updated the pull request incrementally with one
>
On Tue, 29 Aug 2023 22:01:22 GMT, Mikhailo Seledtsov
wrote:
> Container ecosystem is growing. It would be beneficial to define custom
> command to figure out whether a specific test host or environment allows for
> container testing. This enhancement seeks to make the command used by jtreg
>
> In the Windows implementation of java.io.File.getCanonicalPath, strip any
> long path or UNC prefix before canonicalizing the remainder of the pathname.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8287843: Move prefix
On Wed, 20 Sep 2023 16:12:36 GMT, Naoto Sato wrote:
>> Fixing a test case that fails in some time zones. Making sure the test is
>> run in `UTC` zone will fix the issue. Confirmed the fix by manually setting
>> machine's time zone to Europe/Dublin.
>
> Naoto Sato has updated the pull request
On Wed, 20 Sep 2023 17:19:42 GMT, Srinivas Vamsi Parasa
wrote:
>> The goal is to develop faster sort routines for x86_64 CPUs by taking
>> advantage of AVX512 instructions. This enhancement provides an order of
>> magnitude speedup for Arrays.sort() using int, long, float and double arrays.
Please review this PR which converts some tests under _Calendar_ to use JUnit.
These tests either previously used the internal _IntlTest_, or used no
framework at all.
Any files named BugXXX.java will be renamed after review.
-
Commit messages:
- Separate data generation and
> On Windows, do not return `true` from the `java.io.File` methods
> `setReadable(boolean, boolean)` and `setExecutable(boolean, boolean)` if the
> file does not exist.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8316000:
On Wed, 20 Sep 2023 22:10:16 GMT, Justin Lu wrote:
> Please review this PR, which updates the exception message for
> java.text.DateFormatSymbols.setZoneStrings
>
> `setZoneStrings()` takes a multi dimensional array as input. If any row does
> not have a length of at least 5, an
On Wed, 20 Sep 2023 17:19:42 GMT, Srinivas Vamsi Parasa
wrote:
>> The goal is to develop faster sort routines for x86_64 CPUs by taking
>> advantage of AVX512 instructions. This enhancement provides an order of
>> magnitude speedup for Arrays.sort() using int, long, float and double arrays.
Please review this PR, which updates the exception message for
java.text.DateFormatSymbols.setZoneStrings
`setZoneStrings()` takes a multi dimensional array as input. If any row does
not have a length of at least 5, an _IllegalArgumentException_ is thrown. The
exception should indicate why it
On Wed, 20 Sep 2023 16:12:36 GMT, Naoto Sato wrote:
>> Fixing a test case that fails in some time zones. Making sure the test is
>> run in `UTC` zone will fix the issue. Confirmed the fix by manually setting
>> machine's time zone to Europe/Dublin.
>
> Naoto Sato has updated the pull request
On Wed, 20 Sep 2023 15:42:27 GMT, Brian Burkhalter wrote:
>> test/jdk/java/io/File/TempDirDoesNotExist.java line 153:
>>
>>> 151: @ParameterizedTest
>>> 152: @MethodSource("tempDirSource")
>>> 153: public void existingMessage(int exitValue, String errorMsg,
>>
>> `exitValue` is
> Add a `finally` block to delete the created files.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8315960: Address additional reviewer comments
-
Changes:
- all: https://git.openjdk.org/jdk/pull/15757/files
-
On Wed, 20 Sep 2023 21:18:43 GMT, Roger Riggs wrote:
>> Brian Burkhalter has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8315960: Fix indentation
>
> test/jdk/java/io/File/TempDirDoesNotExist.java line 98:
>
>> 96:
On Wed, 20 Sep 2023 16:33:56 GMT, Paul Sandoz wrote:
> I think its definitely a better fit, but another aspect of my previous
> comment was wondering if we need a radix sort if the vectorized quicksort
> implementation is fast enough. IMO we need to compare performance results
> with the
On Tue, 19 Sep 2023 21:45:13 GMT, Brian Burkhalter wrote:
>> Add a `finally` block to delete the created files.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8315960: Fix indentation
On Wed, 20 Sep 2023 17:19:42 GMT, Srinivas Vamsi Parasa
wrote:
>> The goal is to develop faster sort routines for x86_64 CPUs by taking
>> advantage of AVX512 instructions. This enhancement provides an order of
>> magnitude speedup for Arrays.sort() using int, long, float and double arrays.
Hello Andrew,
The bootcycle-images target is AFAIK just a test. It's certainly not
meant to be the authoritative way of building the JDK. Using JDK N-1 as
bootjdk is the official way of producing a JDK of version JDK N. For
convenience, and because it should work, we also allow JDK N. Vendors
On Wed, 20 Sep 2023 18:10:17 GMT, Brian Burkhalter wrote:
>> In the Windows implementation of java.io.File.getCanonicalPath, strip any
>> long path or UNC prefix before canonicalizing the remainder of the pathname.
>
> Brian Burkhalter has updated the pull request incrementally with one
>
On Wed, 20 Sep 2023 18:00:40 GMT, Coleen Phillimore wrote:
>> Please review this trivial change to remove the UseHeavyMonitors develop
>> option, in favor of the now non-experimental LockingMode=LM_MONITOR (0)
>> option. Tested with tier1 locally.
>
> Coleen Phillimore has updated the pull
On Wed, 20 Sep 2023 17:36:06 GMT, Coleen Phillimore wrote:
> Please review this trivial change to remove the UseHeavyMonitors develop
> option, in favor of the now non-experimental LockingMode=LM_MONITOR (0)
> option. Tested with tier1 locally.
This pull request has now been integrated.
On Wed, 20 Sep 2023 18:47:33 GMT, Brian Burkhalter wrote:
> > File::isAbsolute, it looks like it will return true for input like
> > `\\\?\\foo` but it will be treated by toAbsolutePath as a relative path.
>
> Right on:
Ideally the prefix would be removed at the front door, meaning when
On Wed, 20 Sep 2023 18:00:40 GMT, Coleen Phillimore wrote:
>> Please review this trivial change to remove the UseHeavyMonitors develop
>> option, in favor of the now non-experimental LockingMode=LM_MONITOR (0)
>> option. Tested with tier1 locally.
>
> Coleen Phillimore has updated the pull
On Wed, 20 Sep 2023 18:00:40 GMT, Coleen Phillimore wrote:
>> Please review this trivial change to remove the UseHeavyMonitors develop
>> option, in favor of the now non-experimental LockingMode=LM_MONITOR (0)
>> option. Tested with tier1 locally.
>
> Coleen Phillimore has updated the pull
On Wed, 20 Sep 2023 18:00:40 GMT, Coleen Phillimore wrote:
>> Please review this trivial change to remove the UseHeavyMonitors develop
>> option, in favor of the now non-experimental LockingMode=LM_MONITOR (0)
>> option. Tested with tier1 locally.
>
> Coleen Phillimore has updated the pull
On Wed, 20 Sep 2023 18:42:31 GMT, Alan Bateman wrote:
> File::isAbsolute, it looks like it will return true for input like
> `\\\?\\foo` but it will be treated by toAbsolutePath as a relative path.
Right on:
jshell> File f = new File("\\\?\\foo")
f ==> \?\foo
jshell> f.isAbsolute()
$2 ==>
On Wed, 20 Sep 2023 18:10:17 GMT, Brian Burkhalter wrote:
>> In the Windows implementation of java.io.File.getCanonicalPath, strip any
>> long path or UNC prefix before canonicalizing the remainder of the pathname.
>
> Brian Burkhalter has updated the pull request incrementally with one
>
On Wed, 20 Sep 2023 18:00:40 GMT, Coleen Phillimore wrote:
>> Please review this trivial change to remove the UseHeavyMonitors develop
>> option, in favor of the now non-experimental LockingMode=LM_MONITOR (0)
>> option. Tested with tier1 locally.
>
> Coleen Phillimore has updated the pull
On Wed, 20 Sep 2023 07:26:02 GMT, Alan Bateman wrote:
> the one-arg WinNTFileSystem.resolve may be the right place to check for the
> prefix
So changed in a8726fbb8a070388f2b9756ee88c746b12c18397 which also adds a couple
of test cases. Perhaps some cases should be added to the
> In the Windows implementation of java.io.File.getCanonicalPath, strip any
> long path or UNC prefix before canonicalizing the remainder of the pathname.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8287843: Move \\?\ prefix
> Please review this trivial change to remove the UseHeavyMonitors develop
> option, in favor of the now non-experimental LockingMode=LM_MONITOR (0)
> option. Tested with tier1 locally.
Coleen Phillimore has updated the pull request incrementally with one
additional commit since the last
On Wed, 20 Sep 2023 17:36:06 GMT, Coleen Phillimore wrote:
> Please review this trivial change to remove the UseHeavyMonitors develop
> option, in favor of the now non-experimental LockingMode=LM_MONITOR (0)
> option. Tested with tier1 locally.
Changes requested by dcubed (Reviewer).
Please review this trivial change to remove the UseHeavyMonitors develop
option, in favor of the now non-experimental LockingMode=LM_MONITOR (0) option.
Tested with tier1 locally.
-
Commit messages:
- 8315869: UseHeavyMonitors not used
Changes:
On Wed, 13 Sep 2023 20:15:09 GMT, Naoto Sato wrote:
> This PR is to incorporate the latest Unicode 15.1, which was released
> yesterday. Besides the usual character data update, an upgraded
> implementation of RegEx which reflects the Indic Conjunct Break specified in
> the latest [Unicode
On Wed, 20 Sep 2023 07:18:55 GMT, iaroslavski wrote:
> ... and suggestion to improve naming: there are inconsistent new names:
> pivotIndices, indexPivot1 and indexPivot2. I think names pivotIndices,
> pivotIndex1 and pivotIndex2 will be better. Do you agree?
Please see the variable names
> The goal is to develop faster sort routines for x86_64 CPUs by taking
> advantage of AVX512 instructions. This enhancement provides an order of
> magnitude speedup for Arrays.sort() using int, long, float and double arrays.
>
> This PR shows upto ~7x improvement for 32-bit datatypes (int,
On Wed, 20 Sep 2023 07:00:23 GMT, Justin Lu wrote:
>> Please review this PR which restricts sub-classing of the internal calendar
>> system in sun.util.calendar to only the existing implementations. Drive by
>> cleanup included.
>>
>> As the implementation is long-standing and complete with
On Wed, 20 Sep 2023 08:54:55 GMT, Andrey Turbanov wrote:
>> Justin Lu has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - cleanup CalendarDate after revert
>> - Revert "Replace sprintf0d with Formatter"
>>
>>This reverts commit
On Wed, 20 Sep 2023 16:27:19 GMT, Srinivas Vamsi Parasa
wrote:
> This API was suggested to me and was already reviewed by others.
Confirming so, this was my suggestion. We use the _double-register_ addressing
mode (as commonly applied in unsafe), thereby the intrinsic is capable of being
On Fri, 15 Sep 2023 20:17:17 GMT, Paul Sandoz wrote:
>>> Alan, you mentioned that DualPivotQuicksort will need detailed review. Can
>>> we go ahead and start reviewing? Laurent checked performance, JMH results
>>> look fine.
>>
>> As before, I think the main question with this change is
Fix Javadoc links for Stream.mapMulti, Stream.MapMultiInt,
Stream.mapMultiToInt, Stream.mapMultiToLong and Stream.mapMultiToDouble.
-
Commit messages:
- Fix Javadoc links for Stream.mapMulti.
Changes: https://git.openjdk.org/jdk/pull/15794/files
Webrev:
On Mon, 18 Sep 2023 18:09:57 GMT, Mourad Abbay wrote:
> Fix Javadoc links for Stream.mapMulti, Stream.MapMultiInt,
> Stream.mapMultiToInt, Stream.mapMultiToLong and Stream.mapMultiToDouble.
Note to others. I suggested @mabbay pick up the dropped
On Tue, 19 Sep 2023 01:57:44 GMT, Srinivas Vamsi Parasa
wrote:
>> The goal is to develop faster sort routines for x86_64 CPUs by taking
>> advantage of AVX512 instructions. This enhancement provides an order of
>> magnitude speedup for Arrays.sort() using int, long, float and double arrays.
On Wed, 20 Sep 2023 07:35:40 GMT, Chen Liang wrote:
>> 5 Constant Pool entries, namely ConstantDynamicEntry, InvokeDynamicEntry,
>> FieldRefEntry, MethodRefEntry, and InterfaceMethodRefEntry should have a
>> typeSymbol() API to return the nominal/symbolic descriptor (ClassDesc or
>>
On Wed, 20 Sep 2023 16:12:36 GMT, Naoto Sato wrote:
>> Fixing a test case that fails in some time zones. Making sure the test is
>> run in `UTC` zone will fix the issue. Confirmed the fix by manually setting
>> machine's time zone to Europe/Dublin.
>
> Naoto Sato has updated the pull request
On Tue, 19 Sep 2023 18:30:10 GMT, Qing Xiao wrote:
>> Modified all tests under lib-test/jdk to use JUnit
>
> Qing Xiao has updated the pull request incrementally with three additional
> commits since the last revision:
>
> - Update
> Fixing a test case that fails in some time zones. Making sure the test is run
> in `UTC` zone will fix the issue. Confirmed the fix by manually setting
> machine's time zone to Europe/Dublin.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last
On Wed, 20 Sep 2023 04:29:00 GMT, Daniel Jeliński wrote:
>> Brian Burkhalter has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8315960: Fix indentation
>
> test/jdk/java/io/File/TempDirDoesNotExist.java line 153:
>
>> 151:
Hi Magnus,
So yes, jrt-fs.jar can be different between a normal build and a bootcycle
build, which is where I sort of came in here... For example, building say
jdk-21 using a jdk-20 bootjdk, you will find that there is an extra inner
class in the standard build of jrt-fs.jar, due to the fact that
On Wed, 20 Sep 2023 14:41:59 GMT, Jorn Vernee wrote:
>> Daniel Jeliński has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove unused define
>
> src/java.base/windows/native/libjava/java_props_md.c line 214:
>
>> 212: HRESULT
On Mon, 18 Sep 2023 18:10:12 GMT, Daniel Jeliński wrote:
>> Please review this patch that makes java.dll load shell32.dll earlier.
>> Delay-loading requires some additional code (delayimp.lib), and offers no
>> benefits since we always load shell32 during JVM startup.
>>
>> Other than
On 2023-09-20 09:38, Andrew Leonard wrote:
Thanks Alan,
So different gcc, glibc, Xcode,.. agree, they need to be the same for
identical bits.
However, at the moment using the same toolchains, if you do a standard
product build,
and then a bootcycle build, of the same source, jrt-fs.jar will
On Tue, 6 Jun 2023 19:39:31 GMT, Tim Prinzing wrote:
> The socket read/write JFR events currently use instrumentation of java.base
> code using templates in the jdk.jfr modules. This results in some java.base
> code residing in the jdk.jfr module which is undesirable.
>
> JDK19 added static
On Tue, 19 Sep 2023 20:51:41 GMT, Tim Prinzing wrote:
> The existing JFR tests TestSocketChannelEvents and TestSocketEvents in
> jdk.jfr.event.io verify the events are still emitted as expected.
Thanks Tim. Should 8308995 be listed in the `@bug` clause of these two tests?
-
PR
On Wed, 20 Sep 2023 11:21:51 GMT, Daniel Fuchs wrote:
> Thanks Tim. Should 8308995 be listed in the `@bug` clause of these two tests?
I don't think so as these tests are just used to check that changes haven't
broken anything.
-
PR Comment:
On Mon, 18 Sep 2023 23:00:09 GMT, Mandy Chung wrote:
> `JVM_MoreStackWalk` has a bug that always assumes that the Java frame
> stream is currently at the frame decoded in the last patch and so always
> advances to the next frame before filling in the new batch of stack frame.
> However
On Tue, 19 Sep 2023 18:30:10 GMT, Qing Xiao wrote:
>> Modified all tests under lib-test/jdk to use JUnit
>
> Qing Xiao has updated the pull request incrementally with three additional
> commits since the last revision:
>
> - Update
Like #12077, this uses JDK's internal utilities to speed up ASCII reading in
Class files, where most identifiers, from conventions to attribute names, are
ASCII. See the JBS issue for more in-depth explanations.
Before: (Master)
Benchmark Mode CntScore Error
On Wed, 20 Sep 2023 07:00:23 GMT, Justin Lu wrote:
>> Please review this PR which restricts sub-classing of the internal calendar
>> system in sun.util.calendar to only the existing implementations. Drive by
>> cleanup included.
>>
>> As the implementation is long-standing and complete with
On Tue, 19 Sep 2023 22:48:20 GMT, Brian Burkhalter wrote:
>> On Windows, do not return `true` from the `java.io.File` methods
>> `setReadable(boolean, boolean)` and `setExecutable(boolean, boolean)` if the
>> file does not exist.
>
> Brian Burkhalter has updated the pull request incrementally
> 5 Constant Pool entries, namely ConstantDynamicEntry, InvokeDynamicEntry,
> FieldRefEntry, MethodRefEntry, and InterfaceMethodRefEntry should have a
> typeSymbol() API to return the nominal/symbolic descriptor (ClassDesc or
> MethodTypeDesc).
>
> This API is not added to NameAndTypeEntry
Thanks Alan,
So different gcc, glibc, Xcode,.. agree, they need to be the same for
identical bits.
However, at the moment using the same toolchains, if you do a standard
product build,
and then a bootcycle build, of the same source, jrt-fs.jar will differ.
I'll do some investigation of the make
On Fri, 30 Jun 2023 02:42:08 GMT, Chen Liang wrote:
>> 5 Constant Pool entries, namely ConstantDynamicEntry, InvokeDynamicEntry,
>> FieldRefEntry, MethodRefEntry, and InterfaceMethodRefEntry should have a
>> typeSymbol() API to return the nominal/symbolic descriptor (ClassDesc or
>>
On Wed, 20 Sep 2023 02:14:48 GMT, Brian Burkhalter wrote:
> It could be that if after stripping the `\\\?\` prefix the result is relative
> or drive-relative, then it should first be resolved in the same way before
> proceeding.
Right, which is why the one-arg WinNTFileSystem.resolve may be
On Wed, 20 Sep 2023 06:04:26 GMT, Per Minborg wrote:
>> This PR outlines a solution for making immutable maps `@ValueBased` by
>> removing cacheing of certain values in `AbstractMap`.
>>
>> By removing these caching fields in `AbstractMap`, we can make the immutable
>> maps `@ValueBased` and
On Fri, 15 Sep 2023 20:17:17 GMT, Paul Sandoz wrote:
>>> Alan, you mentioned that DualPivotQuicksort will need detailed review. Can
>>> we go ahead and start reviewing? Laurent checked performance, JMH results
>>> look fine.
>>
>> As before, I think the main question with this change is
On Tue, 19 Sep 2023 01:57:44 GMT, Srinivas Vamsi Parasa
wrote:
>> The goal is to develop faster sort routines for x86_64 CPUs by taking
>> advantage of AVX512 instructions. This enhancement provides an order of
>> magnitude speedup for Arrays.sort() using int, long, float and double arrays.
On Tue, 19 Sep 2023 21:44:00 GMT, iaroslavski wrote:
>> Srinivas Vamsi Parasa has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Update DualPivotQuicksort.java
>> - Rename arraySort and arrayPartition Java methods to sort and partition.
> Please review this PR which restricts sub-classing of the internal calendar
> system in sun.util.calendar to only the existing implementations. Drive by
> cleanup included.
>
> As the implementation is long-standing and complete with no intent for future
> sub-classing, the CalendarSystem
> This PR outlines a solution for making immutable maps `@ValueBased` by
> removing cacheing of certain values in `AbstractMap`.
>
> By removing these caching fields in `AbstractMap`, we can make the immutable
> maps `@ValueBased` and at the same time, performance is likely improved
> because
76 matches
Mail list logo
