> Please review this PR to use modern APIs and language features to simplify
> equals, hashCode, and compareTo for BigInteger. If you have any performance
> concerns, please raise them.
>
> This PR is cherry-picked from a bigger, not-yet-published PR, to test the
> waters. That latter PR will
On Mon, 6 Nov 2023 20:22:43 GMT, Mandy Chung wrote:
>> This is a regression caused by JDK-8302791. IAE should be thrown when an
>> interface is not visible to the given class loader but NPE is thrown instead
>> when the loader is null. The boot loader has no name and so the fix will
>>
On Mon, 30 Oct 2023 16:16:52 GMT, Ryan Wallace wrote:
> Hi all,
>
> Please review this fix for jar tool not producing archive if there is a
> missing file supplied. Fix is to throw an exception and exit processing when
> a missing file is supplied. Current behaviour will recognise missing
On Tue, 7 Nov 2023 03:20:45 GMT, Alexey Semenyuk wrote:
> Remove `-Xmx512m` from the jtreg `@run` command as @AlanBateman suggested
Can you confirm that debug builds are passing with -XX:+UseZGC now?
-
PR Comment: https://git.openjdk.org/jdk/pull/16535#issuecomment-1797889256
> Xalan 2.7.3: merge minor changes from the upstream project.
>
> Test: existing XML tests pass
Joe Wang has updated the pull request incrementally with one additional commit
since the last revision:
remove commented out block in ExsltDatetime
-
Changes:
- all:
On Tue, 7 Nov 2023 01:43:21 GMT, Lance Andersen wrote:
>> Joe Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> remove commented out block in ExsltDatetime
>
>
On Tue, 7 Nov 2023 03:20:45 GMT, Alexey Semenyuk wrote:
> Remove `-Xmx512m` from the jtreg `@run` command as @AlanBateman suggested
Looks good.
-
Marked as reviewed by almatvee (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/16535#pullrequestreview-1716751895
On Tue, 7 Nov 2023 03:20:45 GMT, Alexey Semenyuk wrote:
> Remove `-Xmx512m` from the jtreg `@run` command as @AlanBateman suggested
@sashamatveev , @AlanBateman please review
-
PR Comment: https://git.openjdk.org/jdk/pull/16535#issuecomment-1797631432
Remove `-Xmx512m` from the jtreg `@run` command as @AlanBateman suggested
-
Commit messages:
- 8319338: tools/jpackage/share/RuntimeImageTest.java fails with -XX:+UseZGC
Changes: https://git.openjdk.org/jdk/pull/16535/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=16535=00
On Tue, 7 Nov 2023 02:30:55 GMT, Chen Liang wrote:
>> `jdk.lambda.vm.InterfaceAccessFlagsTest` uses `ClassToInterfaceConverter` to
>> mechanically convert a classfile for a Class into an in-memory class
>> representation of an equivalent Interface. `testPrivateMethodCall` tests
>> to invoke
On Mon, 6 Nov 2023 19:26:26 GMT, Mandy Chung wrote:
> `jdk.lambda.vm.InterfaceAccessFlagsTest` uses `ClassToInterfaceConverter` to
> mechanically convert a classfile for a Class into an in-memory class
> representation of an equivalent Interface. `testPrivateMethodCall` tests to
> invoke a
On Mon, 6 Nov 2023 22:41:17 GMT, Erik Gahlin wrote:
>> src/java.base/share/classes/jdk/internal/event/ThrowableTracer.java line 44:
>>
>>> 42:
>>> 43: public static void traceError(Class clazz, String message) {
>>> 44: if (OutOfMemoryError.class.isAssignableFrom(clazz)) {
>>
>>
On Mon, 6 Nov 2023 22:52:47 GMT, Joe Wang wrote:
> Xalan 2.7.3: merge minor changes from the upstream project.
>
> Test: existing XML tests pass
src/java.xml/share/classes/com/sun/org/apache/xalan/internal/lib/ExsltDatetime.java
line 104:
> 102:
>
> j.u.Formatter now prints "%tF" (iso standard date) and the result is
> incorrect when processing year < 0 or year >
Shaojin Wen has updated the pull request incrementally with one additional
commit since the last revision:
use DecimalFormatSymbols#getMinusSign
-
Changes:
On Mon, 6 Nov 2023 18:33:46 GMT, Sandhya Viswanathan
wrote:
> This is not a masked operation so every lane of dst will be written through
> pinsrw/pinsrb. An vpxor before is not required.
xor here clears the intermediate vector after each iteration, this is
eventually ORs with destination.
On Mon, 6 Nov 2023 23:58:11 GMT, Sergey Bylokhov wrote:
> > So we have somewhere around a fixed 125ms startup cost for the FFM case -
> > as measured on my Mac,
> > but only 35-40ms of that is attributable to the specific needs of layout.
>
> That looks unfortunate. I guess if we will start to
On Mon, 6 Nov 2023 22:52:47 GMT, Joe Wang wrote:
> Xalan 2.7.3: merge minor changes from the upstream project.
>
> Test: existing XML tests pass
Marked as reviewed by iris (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/16532#pullrequestreview-1716553613
On Mon, 6 Nov 2023 14:55:54 GMT, Shaojin Wen wrote:
>> j.u.Formatter now prints "%tF" (iso standard date) and the result is
>> incorrect when processing year < 0 or year >
>
> Shaojin Wen has updated the pull request incrementally with one additional
> commit since the last revision:
>
>
On Mon, 6 Nov 2023 23:28:30 GMT, Phil Race wrote:
>So we have somewhere around a fixed 125ms startup cost for the FFM case - as
>measured on my Mac,
but only 35-40ms of that is attributable to the specific needs of layout.
That looks unfortunate. I guess if we will start to use ffm in other
Xalan 2.7.3: merge minor changes from the upstream project.
Test: existing XML tests pass
-
Commit messages:
- 8305814: Update Xalan Java to 2.7.3
Changes: https://git.openjdk.org/jdk/pull/16532/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=16532=00
Issue:
On Mon, 6 Nov 2023 18:52:05 GMT, Sergey Bylokhov wrote:
> Since we plan to import it into jdk22, do you have some performance data to
> share? any positive or negative effects of this migration?
There's three phases - (1) startup, (2) warmup and (3) warmed up performance.
JNI has minimal
On Fri, 3 Nov 2023 20:40:11 GMT, Justin Lu wrote:
> Please review this PR which clarifies the definition of a _cancelled_ task in
> _j.util.Timer::purge_ and _j.util.Timer::cancel_.
>
> Timer::purge claims that its return value is the number of tasks in the queue
> that were cancelled. This
> Could I have a review of a PR that removes the bytecode instrumentation for
> the exception events.
>
> Testing: jdk/jdk/jfr + tier1 + tier2
Erik Gahlin has updated the pull request incrementally with one additional
commit since the last revision:
Remove SecurityException and
On Mon, 6 Nov 2023 15:49:02 GMT, Alan Bateman wrote:
>> Could I have a review of a PR that removes the bytecode instrumentation for
>> the exception events.
>>
>> Testing: jdk/jdk/jfr + tier1 + tier2
>
> src/java.base/share/classes/jdk/internal/event/ThrowableTracer.java line 37:
>
>> 35:
> Limit native memory allocation and move write loop from the native layer into
> Java. This change should make the OOME reported in the issue much less likely.
Brian Burkhalter has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the
Updated jdk_core_manual test groups.
-
Commit messages:
- JDK-8311961 Update Manual Test Groups for ATR JDK22
Changes: https://git.openjdk.org/jdk/pull/16531/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=16531=00
Issue: https://bugs.openjdk.org/browse/JDK-8311961
Stats:
On Mon, 6 Nov 2023 20:08:45 GMT, Per Minborg wrote:
>> This PR proposes to reformat all the JavaDocs for the FFM API. This would
>> bring the FFM API docs more in line with the existing Java documentation
>> (see below). Occasional drive-by fixes are also included in this PR (such
>> as
This PR proposes to reformat a small number of code line for better appearance.
-
Commit messages:
- Reformat some code
Changes: https://git.openjdk.org/jdk/pull/16529/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=16529=00
Issue: https://bugs.openjdk.org/browse/JDK-8319563
This PR proposes to remove two `permits` declarations where the line overflows
the stipulated maximum column with. Also, it proposes to harmonize the layout
of `permit` formatting so they are the the same throughout the API.
This PR might be perceived as over worked but I think it nice to get
This PR proposes to reformat some method parameters in the FFM API. The
proposed changes are a bit opinion based eve though there are some underlying
principles.
-
Commit messages:
- Harmonize method parameter layouts
Changes: https://git.openjdk.org/jdk/pull/16527/files
Webrev:
On Mon, 6 Nov 2023 20:47:06 GMT, Jan Lahoda wrote:
>> For code like:
>>
>> enum E {A {}, B {} }
>> Object o = E.A;
>> switch (o) {
>> case E.A -> System.err.println(o);
>> default -> System.err.println("default");
>> }
>>
>>
>> The result is `default`, not `A`, due to incorrect
On Mon, 6 Nov 2023 19:01:38 GMT, Vicente Romero wrote:
>> This method is also used in the `typeSwitch` (i.e. ordinary pattern matching
>> switch, which may contain qualified enum constants intermixed with
>> patterns), and so the `value` may be any object. If it is not an Enum, we
>> can
> For code like:
>
> enum E {A {}, B {} }
> Object o = E.A;
> switch (o) {
> case E.A -> System.err.println(o);
> default -> System.err.println("default");
> }
>
>
> The result is `default`, not `A`, due to incorrect classes being compared.
> Thanks for @liach for noting the solution
> This is a regression caused by JDK-8302791. IAE should be thrown when an
> interface is not visible to the given class loader but NPE is thrown instead
> when the loader is null. The boot loader has no name and so the fix will
> print `null` in the exception message.
>
> This PR proposes to reformat all the JavaDocs for the FFM API. This would
> bring the FFM API docs more in line with the existing Java documentation (see
> below). Occasional drive-by fixes are also included in this PR (such as
> spelling and capitalization).
>
> I am aware this PR will (if
On Mon, 6 Nov 2023 19:46:40 GMT, Alan Bateman wrote:
>> This is a regression caused by JDK-8302791. IAE should be thrown when an
>> interface is not visible to the given class loader but NPE is thrown instead
>> when the loader is null. The boot loader has no name and so the fix will
>>
On Mon, 6 Nov 2023 19:53:03 GMT, Jim Laskey wrote:
>> Address changes from JEP 445 to JEP 463.
>>
>> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class.
>>
>> - Don't mark class on read.
>>
>> - Remove reflection and annotation processing related to unnamed classes.
>>
>> -
On Mon, 6 Nov 2023 19:12:28 GMT, Mandy Chung wrote:
> This is a regression caused by JDK-8302791. IAE should be thrown when an
> interface is not visible to the given class loader but NPE is thrown instead
> when the loader is null. The boot loader has no name and so the fix will
> print
On Sun, 12 Mar 2023 21:28:59 GMT, null wrote:
>> Sorting:
>>
>> - adopt radix sort for sequential and parallel sorts on
>> int/long/float/double arrays (almost random and length > 6K)
>> - fix tryMergeRuns() to better handle case when the last run is a single
>> element
>> - minor javadoc and
> Address changes from JEP 445 to JEP 463.
>
> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class.
>
> - Don't mark class on read.
>
> - Remove reflection and annotation processing related to unnamed classes.
>
> - Simplify main method search.
Jim Laskey has updated the pull
`jdk.lambda.vm.InterfaceAccessFlagsTest` uses `ClassToInterfaceConverter` to
mechanically convert a classfile for a Class into an in-memory class
representation of an equivalent Interface. `testPrivateMethodCall` tests to
invoke a private method. Before nestmates, invoking a private class
This is a regression caused by JDK-8302791. IAE should be thrown when an
interface is not visible to the given class loader but NPE is thrown instead
when the loader is null. The boot loader has no name and so the fix will
print `null` in the exception message.
On Mon, 6 Nov 2023 18:51:59 GMT, Jan Lahoda wrote:
>> src/java.base/share/classes/java/lang/runtime/SwitchBootstraps.java line 397:
>>
>>> 395:
>>> 396: try {
>>> 397: if (!(value instanceof Enum enumValue)) {
>>
>> this code seems to be here with the only purpose
On Fri, 3 Nov 2023 22:44:39 GMT, Sandhya Viswanathan
wrote:
>> Jatin Bhateja has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Restricting masked sub-word gather to AVX512 target to align with integral
>> gather support.
>
>
On Sun, 5 Nov 2023 12:58:57 GMT, Jatin Bhateja wrote:
>> src/hotspot/cpu/x86/c2_MacroAssembler_x86.cpp line 1606:
>>
>>> 1604: void C2_MacroAssembler::vpgather8b_offset(BasicType elem_bt,
>>> XMMRegister dst, Register base, Register idx_base,
>>> 1605:
On Mon, 6 Nov 2023 18:12:10 GMT, Vicente Romero wrote:
>> Jan Lahoda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Re-ordering tests as suggested.
>
> src/java.base/share/classes/java/lang/runtime/SwitchBootstraps.java line 397:
>
>>
On Wed, 25 Oct 2023 23:42:08 GMT, Phil Race wrote:
>> 8318364: Add an FFM-based implementation of harfbuzz OpenType layout
>
> Phil Race has updated the pull request incrementally with one additional
> commit since the last revision:
>
> indentation
Since we plan to import it into jdk22, do
On Mon, 6 Nov 2023 07:34:38 GMT, Jan Lahoda wrote:
>> For code like:
>>
>> enum E {A {}, B {} }
>> Object o = E.A;
>> switch (o) {
>> case E.A -> System.err.println(o);
>> default -> System.err.println("default");
>> }
>>
>>
>> The result is `default`, not `A`, due to incorrect
On Mon, 6 Nov 2023 17:35:31 GMT, Per Minborg wrote:
>> This PR proposes to reformat all the JavaDocs for the FFM API. This would
>> bring the FFM API docs more in line with the existing Java documentation
>> (see below). Occasional drive-by fixes are also included in this PR (such
>> as
On Mon, 6 Nov 2023 17:35:31 GMT, Per Minborg wrote:
>> This PR proposes to reformat all the JavaDocs for the FFM API. This would
>> bring the FFM API docs more in line with the existing Java documentation
>> (see below). Occasional drive-by fixes are also included in this PR (such
>> as
> This PR proposes to reformat all the JavaDocs for the FFM API. This would
> bring the FFM API docs more in line with the existing Java documentation (see
> below). Occasional drive-by fixes are also included in this PR (such as
> spelling and capitalization).
>
> I am aware this PR will (if
> This PR proposes to reformat all the JavaDocs for the FFM API. This would
> bring the FFM API docs more in line with the existing Java documentation (see
> below). Occasional drive-by fixes are also included in this PR (such as
> spelling and capitalization).
>
> I am aware this PR will (if
> This PR proposes to reformat all the JavaDocs for the FFM API. This would
> bring the FFM API docs more in line with the existing Java documentation (see
> below). Occasional drive-by fixes are also included in this PR (such as
> spelling and capitalization).
>
> I am aware this PR will (if
On Sat, 4 Nov 2023 00:07:33 GMT, Chen Liang wrote:
>> Strings, after construction, are immutable but may be constructed from
>> mutable arrays of bytes, characters, or integers.
>> The string constructors should guard against the effects of mutating the
>> arrays during construction that might
On Mon, 30 Oct 2023 18:34:44 GMT, Roger Riggs wrote:
> Strings, after construction, are immutable but may be constructed from
> mutable arrays of bytes, characters, or integers.
> The string constructors should guard against the effects of mutating the
> arrays during construction that might
On Sun, 5 Nov 2023 13:32:20 GMT, ExE Boss wrote:
>> Strings, after construction, are immutable but may be constructed from
>> mutable arrays of bytes, characters, or integers.
>> The string constructors should guard against the effects of mutating the
>> arrays during construction that might
On Mon, 30 Oct 2023 18:34:44 GMT, Roger Riggs wrote:
> Strings, after construction, are immutable but may be constructed from
> mutable arrays of bytes, characters, or integers.
> The string constructors should guard against the effects of mutating the
> arrays during construction that might
On Mon, 30 Oct 2023 18:34:44 GMT, Roger Riggs wrote:
> Strings, after construction, are immutable but may be constructed from
> mutable arrays of bytes, characters, or integers.
> The string constructors should guard against the effects of mutating the
> arrays during construction that might
Strings, after construction, are immutable but may be constructed from mutable
arrays of bytes, characters, or integers.
The string constructors should guard against the effects of mutating the arrays
during construction that might invalidate internal invariants for the correct
behavior of
On Mon, 6 Nov 2023 00:50:22 GMT, Claes Redestad wrote:
> I suggest we go ahead and integrate this, file an RFE to re-examine the
> division-by-constant in C2, then re-evaluate these `isLeapYear` micros in
> that new environment.
These are good improvements and are beneficial with or without
> This PR proposes to reformat all the JavaDocs for the FFM API. This would
> bring the FFM API docs more in line with the existing Java documentation (see
> below). Occasional drive-by fixes are also included in this PR (such as
> spelling and capitalization).
>
> I am aware this PR will (if
On Fri, 3 Nov 2023 23:22:27 GMT, Claes Redestad wrote:
>> https://github.com/cassioneri/eaf suggest this code for leap year
>> calculation:
>>
>> public static boolean isLeap(long year) {
>> int d = year % 100 != 0 ? 4 : 16;
>> return (year & (d - 1)) == 0;
>> }
>>
>>
On Tue, 3 Oct 2023 07:47:30 GMT, Gergö Barany wrote:
> This test requires certain methods to be compiled, but without `-Xbatch` the
> compiler races against the test code, which can lead to intermittent failures.
Marked as reviewed by never (Reviewer).
-
PR Review:
On Tue, 3 Oct 2023 07:47:30 GMT, Gergö Barany wrote:
> This test requires certain methods to be compiled, but without `-Xbatch` the
> compiler races against the test code, which can lead to intermittent failures.
Marked as reviewed by dnsimon (Reviewer).
-
PR Review:
On Fri, 3 Nov 2023 12:19:07 GMT, Erik Gahlin wrote:
> Could I have a review of a PR that removes the bytecode instrumentation for
> the exception events.
>
> Testing: jdk/jdk/jfr + tier1 + tier2
src/java.base/share/classes/jdk/internal/event/ThrowableTracer.java line 37:
> 35: private
Could I have a review of a PR that removes the bytecode instrumentation for the
exception events.
Testing: jdk/jdk/jfr + tier1 + tier2
-
Commit messages:
- Remove Throwable and Error from instrumentation list
- Initial
Changes: https://git.openjdk.org/jdk/pull/16493/files
On Mon, 6 Nov 2023 11:28:23 GMT, Ryan Wallace wrote:
> I had a look and its been in since JDK 9
> (https://bugs.openjdk.org/browse/JDK-8158295) but haven’t found any mention
> of this as a specific desired behaviour so I am going with just noticed now.
> Its not a major blocker as the user
On Fri, 3 Nov 2023 00:10:48 GMT, Jorn Vernee wrote:
> - Add linker note about packed structs.
> - Relax language a bit to avoid implying that only listed layouts are
> supported.
This pull request has now been integrated.
Changeset: cdf33735
Author:Jorn Vernee
URL:
> This PR proposes to reformat all the JavaDocs for the FFM API. This would
> bring the FFM API docs more in line with the existing Java documentation (see
> below). Occasional drive-by fixes are also included in this PR (such as
> spelling and capitalization).
>
> I am aware this PR will (if
On Mon, 6 Nov 2023 11:41:23 GMT, Maurizio Cimadamore
wrote:
> You might also want to look into the MethodHandles XYZCoordinates combinators
> (as they have also been added as part of FFM). And, also,
> `ModuleLayer::Controller::enableNativeAccess`,
> `Module::isNativeAccessEnabled` and
On Mon, 6 Nov 2023 13:27:40 GMT, Jorn Vernee wrote:
> FWIW, I've been sticking to a soft 120 character limit per line when writing
> javadoc. Why should we use 90 columns specifically?
>
> > It is also customary to use double spaces when starting a new sentence.
>
> I thought this was the
> j.u.Formatter now prints "%tF" (iso standard date) and the result is
> incorrect when processing year < 0 or year >
Shaojin Wen has updated the pull request incrementally with one additional
commit since the last revision:
revert localize change
-
Changes:
- all:
On Fri, 3 Nov 2023 12:40:48 GMT, Jim Laskey wrote:
>> Address changes from JEP 445 to JEP 463.
>>
>> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class.
>>
>> - Don't mark class on read.
>>
>> - Remove reflection and annotation processing related to unnamed classes.
>>
>> -
On Fri, 3 Nov 2023 12:40:48 GMT, Jim Laskey wrote:
>> Address changes from JEP 445 to JEP 463.
>>
>> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class.
>>
>> - Don't mark class on read.
>>
>> - Remove reflection and annotation processing related to unnamed classes.
>>
>> -
On Fri, 3 Nov 2023 12:40:48 GMT, Jim Laskey wrote:
>> Address changes from JEP 445 to JEP 463.
>>
>> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class.
>>
>> - Don't mark class on read.
>>
>> - Remove reflection and annotation processing related to unnamed classes.
>>
>> -
On Tue, 31 Oct 2023 07:43:43 GMT, Leo Korinth wrote:
> Changing from `Class c` to `Class c` removes two warnings.
Thanks!
-
PR Comment: https://git.openjdk.org/jdk/pull/16431#issuecomment-1794831441
On Tue, 31 Oct 2023 07:43:43 GMT, Leo Korinth wrote:
> Changing from `Class c` to `Class c` removes two warnings.
This pull request has now been integrated.
Changeset: 1c2ea1d2
Author:Leo Korinth
URL:
https://git.openjdk.org/jdk/commit/1c2ea1d27b1895dca3b30073e3516978083dc70a
On Mon, 6 Nov 2023 10:10:41 GMT, Per Minborg wrote:
>> This PR proposes to reformat all the JavaDocs for the FFM API. This would
>> bring the FFM API docs more in line with the existing Java documentation
>> (see below). Occasional drive-by fixes are also included in this PR (such
>> as
On Mon, 30 Oct 2023 17:26:53 GMT, Yakov Shafranovich wrote:
> The various Zip/Jar-file related Java APIs have some long-standing
> differences or peculiarities with respect to the ZIP-file specification or
> compared to other implementations which should be documented in the API-doc.
> This
On Mon, 6 Nov 2023 10:13:14 GMT, Per Minborg wrote:
>> Jorn Vernee has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add 'strict'
>>
>> Co-authored-by: Maurizio Cimadamore
>> <54672762+mcimadam...@users.noreply.github.com>
>
> Can
On Fri, 3 Nov 2023 12:40:48 GMT, Jim Laskey wrote:
>> Address changes from JEP 445 to JEP 463.
>>
>> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class.
>>
>> - Don't mark class on read.
>>
>> - Remove reflection and annotation processing related to unnamed classes.
>>
>> -
On Sat, 4 Nov 2023 13:26:04 GMT, Alan Bateman wrote:
>> Jim Laskey has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains six additional
>> commits
> Update String Templates for a second preview. With the addition of
>
> - Expression type and throws are determined from the `process` method of the
> processor type and not the processor type.
>
> - Qualified `STR` and `RAW` are treated the same as unqualified `STR` and
> `RAW` .
>
> - Raw
On Mon, 30 Oct 2023 16:16:52 GMT, Ryan Wallace wrote:
> Hi all,
>
> Please review this fix for jar tool not producing archive if there is a
> missing file supplied. Fix is to throw an exception and exit processing when
> a missing file is supplied. Current behaviour will recognise missing
On Mon, 6 Nov 2023 10:10:41 GMT, Per Minborg wrote:
>> This PR proposes to reformat all the JavaDocs for the FFM API. This would
>> bring the FFM API docs more in line with the existing Java documentation
>> (see below). Occasional drive-by fixes are also included in this PR (such
>> as
On Fri, 3 Nov 2023 23:22:27 GMT, Claes Redestad wrote:
>> https://github.com/cassioneri/eaf suggest this code for leap year
>> calculation:
>>
>> public static boolean isLeap(long year) {
>> int d = year % 100 != 0 ? 4 : 16;
>> return (year & (d - 1)) == 0;
>> }
>>
>>
On Mon, 30 Oct 2023 16:16:52 GMT, Ryan Wallace wrote:
> Hi all,
>
> Please review this fix for jar tool not producing archive if there is a
> missing file supplied. Fix is to throw an exception and exit processing when
> a missing file is supplied. Current behaviour will recognise missing
On Mon, 6 Nov 2023 06:00:20 GMT, Chen Liang wrote:
> Observed this erroneous implementation while browsing, and included a quick
> test against javac output class file to confirm the correct implementation.
> @asotona Please take a look.
Good catch, thanks for the fix.
-
Marked
On Fri, 3 Nov 2023 18:16:17 GMT, Jorn Vernee wrote:
>> - Add linker note about packed structs.
>> - Relax language a bit to avoid implying that only listed layouts are
>> supported.
>
> Jorn Vernee has updated the pull request incrementally with one additional
> commit since the last revision:
> This PR proposes to reformat all the JavaDocs for the FFM API. This would
> bring the FFM API docs more in line with the existing Java documentation (see
> below). Occasional drive-by fixes are also included in this PR (such as
> spelling and capitalization).
>
> I am aware this PR will (if
On Mon, 30 Oct 2023 16:16:52 GMT, Ryan Wallace wrote:
> Hi all,
>
> Please review this fix for jar tool not producing archive if there is a
> missing file supplied. Fix is to throw an exception and exit processing when
> a missing file is supplied. Current behaviour will recognise missing
On Mon, 6 Nov 2023 02:34:21 GMT, Quan Anh Mai wrote:
> >
>
> I have filed
> [JDK-8319451](https://bugs.openjdk.org/projects/JDK/issues/JDK-8319451). I
> would suggest waiting for this bug to be resolved before proceeding with this
> PR.
Nice analysis!
While I'm sure we need to
Hi all,
Please review this fix for jar tool not producing archive if there is a missing
file supplied. Fix is to throw an exception and exit processing when a missing
file is supplied. Current behaviour will recognise missing file as an error but
continue processing and not produce the
On Mon, 6 Nov 2023 08:08:34 GMT, Per Minborg wrote:
>> This PR proposes to reformat all the JavaDocs for the FFM API. This would
>> bring the FFM API docs more in line with the existing Java documentation
>> (see below). Occasional drive-by fixes are also included in this PR (such
>> as
On Mon, 6 Nov 2023 08:08:34 GMT, Per Minborg wrote:
>> This PR proposes to reformat all the JavaDocs for the FFM API. This would
>> bring the FFM API docs more in line with the existing Java documentation
>> (see below). Occasional drive-by fixes are also included in this PR (such
>> as
On Mon, 6 Nov 2023 08:53:55 GMT, Maurizio Cimadamore
wrote:
>> Per Minborg has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains five additional
>>
On Mon, 6 Nov 2023 08:08:34 GMT, Per Minborg wrote:
>> This PR proposes to reformat all the JavaDocs for the FFM API. This would
>> bring the FFM API docs more in line with the existing Java documentation
>> (see below). Occasional drive-by fixes are also included in this PR (such
>> as
> VarHandle implementations have many static fields and methods that can be
> pulled to the common superclass to avoid repeated initialization and code
> duplication.
>
> In addition, the Unsafe-based Buffer field access are replaced by usage of
> public methods or JavaNioAccess.
Chen Liang
> This PR proposes to reformat all the JavaDocs for the FFM API. This would
> bring the FFM API docs more in line with the existing Java documentation (see
> below). Occasional drive-by fixes are also included in this PR (such as
> spelling and capitalization).
>
> I am aware this PR will (if
99 matches
Mail list logo
