Re: RFR: JDK-8317799 : AIX PPC64: FFI symbol lookup doesn't find symbols [v7]

2023-11-21 Thread Jorn Vernee
On Tue, 21 Nov 2023 19:30:30 GMT, suchismith1993 wrote: >> The math library in AIX specifically, is a static archive. Doing a -lm wont >> suffice, because when the symbols are looked up using dlsym or accessing >> native code through Java, it will lead to failures. >> Hence we had to come up

Re: RFR: JDK-8317799 : AIX PPC64: FFI symbol lookup doesn't find symbols [v7]

2023-11-21 Thread suchismith1993
On Tue, 21 Nov 2023 19:30:30 GMT, suchismith1993 wrote: >> The math library in AIX specifically, is a static archive. Doing a -lm wont >> suffice, because when the symbols are looked up using dlsym or accessing >> native code through Java, it will lead to failures. >> Hence we had to come up

Re: RFR: 8319872: AArch64: [vectorapi] Implementation of unsigned (zero extended) casts [v2]

2023-11-21 Thread Eric Liu
On Tue, 21 Nov 2023 13:29:32 GMT, Eric Liu wrote: >> Got it. I will fix it soon. Thanks! > > compiler/vectorapi and jdk/incubator/vector passed. Full test is running. I > would report the result when it has been finished. Full jtreg passed without new failure. - PR Review

Re: RFR: 8319872: AArch64: [vectorapi] Implementation of unsigned (zero extended) casts [v4]

2023-11-21 Thread Eric Liu
> Vector API defines zero-extend operations [1], which are going to be > intrinsified and generated to `VectorUCastNode` by C2. This patch adds > backend implementation for `VectorUCastNode` on AArch64. > > The micro benchmark shows significant performance improvement. In my test > machine

Re: RFR: JDK-8317799 : AIX PPC64: FFI symbol lookup doesn't find symbols [v7]

2023-11-21 Thread Jorn Vernee
On Tue, 21 Nov 2023 19:30:30 GMT, suchismith1993 wrote: >> The math library in AIX specifically, is a static archive. Doing a -lm wont >> suffice, because when the symbols are looked up using dlsym or accessing >> native code through Java, it will lead to failures. >> Hence we had to come up

Re: RFR: JDK-8317799 : AIX PPC64: FFI symbol lookup doesn't find symbols [v7]

2023-11-21 Thread David Holmes
On Tue, 21 Nov 2023 19:30:30 GMT, suchismith1993 wrote: >> The math library in AIX specifically, is a static archive. Doing a -lm wont >> suffice, because when the symbols are looked up using dlsym or accessing >> native code through Java, it will lead to failures. >> Hence we had to come up

Integrated: 8320131: Zero build fails on macOS after JDK-8254693

2023-11-21 Thread Hao Sun
On Wed, 22 Nov 2023 02:06:29 GMT, Hao Sun wrote: > The fix is trivial. We should include the standard C header `stdlib.h` [1], > rather than non-standard one `malloc.h`. > > [1] https://en.cppreference.com/w/c/memory/malloc This pull request has now been integrated. Changeset: b3616c9a

Re: RFR: 8320131: Zero build fails on macOS after JDK-8254693

2023-11-21 Thread Hao Sun
On Wed, 22 Nov 2023 02:06:29 GMT, Hao Sun wrote: > The fix is trivial. We should include the standard C header `stdlib.h` [1], > rather than non-standard one `malloc.h`. > > [1] https://en.cppreference.com/w/c/memory/malloc Thanks for your reviews. - PR Comment:

Re: RFR: 8311906: Improve robustness of String constructors with mutable array inputs [v12]

2023-11-21 Thread Roger Riggs
> Strings, after construction, are immutable but may be constructed from > mutable arrays of bytes, characters, or integers. > The string constructors should guard against the effects of mutating the > arrays during construction that might invalidate internal invariants for the > correct

Re: RFR: 8310159: Bulk copy with Unsafe::arrayCopy is slower compared to memcpy [v6]

2023-11-21 Thread Sandhya Viswanathan
On Tue, 21 Nov 2023 21:03:20 GMT, Steve Dohrmann wrote: >> Update: the XorTest::xor results shown in this message used test code from >> PR commit 7cc272e862791 which was based on Maurizio Cimadamore's commit >> a788f066af17. The XorTest has since been updated and XorTest::copy is no >>

Re: RFR: 8320131: Zero build fails on macOS after JDK-8254693

2023-11-21 Thread Jorn Vernee
On Wed, 22 Nov 2023 02:06:29 GMT, Hao Sun wrote: > The fix is trivial. We should include the standard C header `stdlib.h` [1], > rather than non-standard one `malloc.h`. > > [1] https://en.cppreference.com/w/c/memory/malloc Thanks. - Marked as reviewed by jvernee (Reviewer). PR

Re: RFR: 8320131: Zero build fails on macOS after JDK-8254693

2023-11-21 Thread David Holmes
On Wed, 22 Nov 2023 02:06:29 GMT, Hao Sun wrote: > The fix is trivial. We should include the standard C header `stdlib.h` [1], > rather than non-standard one `malloc.h`. > > [1] https://en.cppreference.com/w/c/memory/malloc Looks good and trivial. Thanks for fixing. - Marked as

RFR: 8320131: Zero build fails on macOS after JDK-8254693

2023-11-21 Thread Hao Sun
The fix is trivial. We should include the standard C header `stdlib.h` [1], rather than non-standard one `malloc.h`. [1] https://en.cppreference.com/w/c/memory/malloc - Commit messages: - 8320131: Zero build fails on macOS after JDK-8254693 Changes:

Re: RFR: 8318776: Require supports_cx8 to always be true [v4]

2023-11-21 Thread David Holmes
On Tue, 21 Nov 2023 16:58:21 GMT, Aleksey Shipilev wrote: >> This looks great! > >> Thanks for the review @fisk ! I have to wait for a few Zero related PRs to >> get integrated then re-merge, before I can integrate. > > Zero patches were pushed, please re-merge. I checked current mainline

Re: RFR: 8319872: AArch64: [vectorapi] Implementation of unsigned (zero extended) casts [v3]

2023-11-21 Thread Eric Liu
On Tue, 21 Nov 2023 15:07:48 GMT, Andrew Haley wrote: >> Eric Liu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> add _sve_xunpk & remove dead code >> >> Change-Id: Ic19836feb8a73ea7e65443794f2a0eb1363f6e2f > >

Re: RFR: 8318776: Require supports_cx8 to always be true [v5]

2023-11-21 Thread David Holmes
> As discussed in JBS all platforms (some tweaks to Zero are in progress) > actually do support `cx8` i.e. 64-bit compare-and-exchange, so we can strip > out the locked-based alternatives to using it and just add a guarantee that > it is true at runtime. And all platforms except some ARM

Re: RFR: 8312425: [vectorapi] AArch64: Optimize vector math operations with SLEEF [v3]

2023-11-21 Thread Xiaohong Gong
On Wed, 22 Nov 2023 00:05:26 GMT, Paul Sandoz wrote: > Have you considered the possibility of copying the sleef source to the > OpenJDK repository and thereby it becomes part of the build process? I don't > know how straightforward that is technically and IANAL but I think it's worth >

Re: RFR: 8312425: [vectorapi] AArch64: Optimize vector math operations with SLEEF [v3]

2023-11-21 Thread Xiaohong Gong
On Tue, 21 Nov 2023 18:14:41 GMT, Paul Sandoz wrote: > > This looks good. As far as I can tell the choice you've made of accuracy > > matches what we need to meet the spec. > > Same here . Sinh/cosh/tanh/expm1 are specified to be within 2.5 ulps of the > exact result, but i believe sleef does

Re: RFR: 8318650: Optimized subword gather for x86 targets. [v7]

2023-11-21 Thread Quan Anh Mai
On Wed, 15 Nov 2023 02:17:58 GMT, Jatin Bhateja wrote: >> Hi All, >> >> This patch optimizes sub-word gather operation for x86 targets with AVX2 and >> AVX512 features. >> >> Following is the summary of changes:- >> >> 1) Intrinsify sub-word gather with high performance backend

Re: RFR: 8312425: [vectorapi] AArch64: Optimize vector math operations with SLEEF [v3]

2023-11-21 Thread Paul Sandoz
On Wed, 15 Nov 2023 01:32:00 GMT, Xiaohong Gong wrote: >> Currently the vector floating-point math APIs like >> `VectorOperators.SIN/COS/TAN...` are not intrinsified on AArch64 platform, >> which causes large performance gap on AArch64. Note that those APIs are >> optimized by C2 compiler on

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref

2023-11-21 Thread Roger Riggs
On Mon, 13 Nov 2023 22:31:16 GMT, Brent Christian wrote: > Classes in the `java.lang.ref` package would benefit from an update to bring > the spec in line with how the VM already behaves. The changes would focus on > _happens-before_ edges at some key points during reference processing. > > A

Re: RFR: JDK-8317799 : AIX PPC64: FFI symbol lookup doesn't find symbols [v7]

2023-11-21 Thread Magnus Ihse Bursie
On Tue, 21 Nov 2023 19:30:30 GMT, suchismith1993 wrote: >> The math library in AIX specifically, is a static archive. Doing a -lm wont >> suffice, because when the symbols are looked up using dlsym or accessing >> native code through Java, it will lead to failures. >> Hence we had to come up

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref

2023-11-21 Thread Roger Riggs
On Wed, 15 Nov 2023 22:31:35 GMT, Stuart Marks wrote: >> Classes in the `java.lang.ref` package would benefit from an update to bring >> the spec in line with how the VM already behaves. The changes would focus on >> _happens-before_ edges at some key points during reference processing. >> >>

Re: RFR: 8310159: Bulk copy with Unsafe::arrayCopy is slower compared to memcpy [v5]

2023-11-21 Thread Steve Dohrmann
On Tue, 21 Nov 2023 01:14:49 GMT, Sandhya Viswanathan wrote: >> Steve Dohrmann has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains ten commits: >> >> - Merge branch 'master' into memcpy >> - Update full name >>Previous commit

Re: RFR: JDK-8319662 ForkJoinPool trims worker threads too slowly [v3]

2023-11-21 Thread Viktor Klang
On Tue, 21 Nov 2023 17:12:39 GMT, Doug Lea wrote: >> This update cascades timeouts to trim subsequent workers after the first >> keepAlive inactive period. > > Doug Lea has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the

Re: RFR: 8319668: Fixup of jar filename typo in BadFactoryTest.sh

2023-11-21 Thread Eirik Bjorsnos
On Thu, 9 Nov 2023 16:49:41 GMT, Gaurav Chaudhari wrote: > The file test/jdk/javax/script/JDK_8196959/BadFactoryTest.sh contains a typo. > When running without security manager, the test references 'badfactoty.jar' > instead of 'badfactory.jar'. This change addresses this by correcting the jar

Re: RFR: 8310159: Bulk copy with Unsafe::arrayCopy is slower compared to memcpy [v6]

2023-11-21 Thread Steve Dohrmann
> Update: the XorTest::xor results shown in this message used test code from PR > commit 7cc272e862791 which was based on Maurizio Cimadamore's commit > a788f066af17. The XorTest has since been updated and XorTest::copy is no > longer needed and has been removed from this pull request. See

Re: RFR: 8310159: Bulk copy with Unsafe::arrayCopy is slower compared to memcpy [v5]

2023-11-21 Thread Steve Dohrmann
On Tue, 21 Nov 2023 01:10:40 GMT, Sandhya Viswanathan wrote: >> Steve Dohrmann has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains ten commits: >> >> - Merge branch 'master' into memcpy >> - Update full name >>Previous commit

Re: RFR: JDK-8315458 Implement JEP 463: Implicitly Declared Classes and Instance Main Method (Second Preview) [v31]

2023-11-21 Thread Jonathan Gibbons
On Tue, 21 Nov 2023 18:51:55 GMT, Jim Laskey wrote: > The comments are attached to the modifiers (first thing it encounters.) I’m > sure the javadoc toolset has a method that gets the comments from the right > thing. In the AST created by the parser, doc comments should be attached to

Re: RFR: 8310994: Add JFR event for selection operations

2023-11-21 Thread Alan Bateman
On Fri, 17 Nov 2023 16:22:55 GMT, Tim Prinzing wrote: > Added mirror event with static methods: jdk.internal.event.SelectionEvent > that provides the duration of select calls and the count of how many keys are > available. > > Emit the event from SelectorImpl::lockAndDoSelect > > Test at

RFR: 8310994: Add JFR event for selection operations

2023-11-21 Thread Tim Prinzing
Added mirror event with static methods: jdk.internal.event.SelectionEvent that provides the duration of select calls and the count of how many keys are available. Emit the event from SelectorImpl::lockAndDoSelect Test at jdk.jfr.event.io.TestSelectionEvents - Commit messages: -

Re: RFR: 8319668: Fixup of jar filename typo in BadFactoryTest.sh

2023-11-21 Thread Eirik Bjorsnos
On Tue, 21 Nov 2023 16:36:26 GMT, Alan Bateman wrote: >> The file test/jdk/javax/script/JDK_8196959/BadFactoryTest.sh contains a >> typo. When running without security manager, the test references >> 'badfactoty.jar' instead of 'badfactory.jar'. This change addresses this by >> correcting the

Re: RFR: 8319668: Fixup of jar filename typo in BadFactoryTest.sh

2023-11-21 Thread Gaurav Chaudhari
On Tue, 21 Nov 2023 16:36:26 GMT, Alan Bateman wrote: > Looks okay. This test is begging to be re-written in Java, maybe some day. > > I assume the copyright header will be updated before this change is > integrated. Hi @AlanBateman, do I have to update the copyright year to 2023 manually and

Re: RFR: 8318650: Optimized subword gather for x86 targets. [v7]

2023-11-21 Thread Jatin Bhateja
On Wed, 15 Nov 2023 02:17:58 GMT, Jatin Bhateja wrote: >> Hi All, >> >> This patch optimizes sub-word gather operation for x86 targets with AVX2 and >> AVX512 features. >> >> Following is the summary of changes:- >> >> 1) Intrinsify sub-word gather with high performance backend

Re: RFR: JDK-8319569: Several java/util tests should be updated to accept VM flags [v3]

2023-11-21 Thread Lance Andersen
On Mon, 20 Nov 2023 19:15:18 GMT, Justin Lu wrote: >> Please review this PR which allows these _j.util_ tests to launch new JVM >> processes with VM flags, >> >> This is primarily done using by switching to >> `ProcessTools::createTestJavaProcessBuilder`. > > Justin Lu has updated the pull

Re: RFR: JDK-8315458 Implement JEP 463: Implicitly Declared Classes and Instance Main Method (Second Preview) [v31]

2023-11-21 Thread Jim Laskey
On Tue, 21 Nov 2023 19:16:06 GMT, Alan Bateman wrote: >> Jim Laskey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update Class.java > > src/java.base/share/classes/java/lang/Class.java line 4823: > >> 4821: * signatures in a

Re: RFR: JDK-8317799 : AIX PPC64: FFI symbol lookup doesn't find symbols [v7]

2023-11-21 Thread suchismith1993
> The math library in AIX specifically, is a static archive. Doing a -lm wont > suffice, because when the symbols are looked up using dlsym or accessing > native code through Java, it will lead to failures. > Hence we had to come up with a list of symbols to allow math library symbols > to be

Re: RFR: JDK-8317799 : AIX PPC64: FFI symbol lookup doesn't find symbols [v7]

2023-11-21 Thread Martin Doerr
On Tue, 21 Nov 2023 19:30:30 GMT, suchismith1993 wrote: >> The math library in AIX specifically, is a static archive. Doing a -lm wont >> suffice, because when the symbols are looked up using dlsym or accessing >> native code through Java, it will lead to failures. >> Hence we had to come up

Re: RFR: JDK-8315458 Implement JEP 463: Implicitly Declared Classes and Instance Main Method (Second Preview) [v31]

2023-11-21 Thread Alan Bateman
On Tue, 21 Nov 2023 17:52:49 GMT, Jim Laskey wrote: >> Address changes from JEP 445 to JEP 463. >> >> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class. >> >> - Don't mark class on read. >> >> - Remove reflection and annotation processing related to unnamed classes. >> >> -

Re: RFR: JDK-8315458 Implement JEP 463: Implicitly Declared Classes and Instance Main Method (Second Preview) [v31]

2023-11-21 Thread Pavel Rappo
On Tue, 21 Nov 2023 18:59:51 GMT, Pavel Rappo wrote: > I'll try to figure out more. So this method seems to be a proximate-ish cause for that behaviour: `JavacParser.topLevelMethodOrFieldDeclaration`. If it gets `null` or comment to attach to `JCTree.JCMethodDecl` later depends on the

Re: RFR: JDK-8315458 Implement JEP 463: Implicitly Declared Classes and Instance Main Method (Second Preview) [v31]

2023-11-21 Thread Pavel Rappo
On Tue, 21 Nov 2023 18:51:55 GMT, Jim Laskey wrote: > I’m sure the javadoc toolset has a method that gets the comments from the > right thing. That's exactly where those comments disappear from, javadoc. Comments of normal class methods and comments of methods of implicitly declared class

Re: RFR: JDK-8315458 Implement JEP 463: Implicitly Declared Classes and Instance Main Method (Second Preview) [v31]

2023-11-21 Thread Jim Laskey
On Tue, 21 Nov 2023 17:52:49 GMT, Jim Laskey wrote: >> Address changes from JEP 445 to JEP 463. >> >> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class. >> >> - Don't mark class on read. >> >> - Remove reflection and annotation processing related to unnamed classes. >> >> -

Re: RFR: JDK-8315458 Implement JEP 463: Implicitly Declared Classes and Instance Main Method (Second Preview) [v19]

2023-11-21 Thread Pavel Rappo
On Tue, 21 Nov 2023 12:58:42 GMT, Jim Laskey wrote: >> @JimLaskey, in my experiments for JDK-8308715 (Create a mechanism for >> Implicitly Declared Class javadoc), I found that >> `javax.lang.model.util.Elements.getOrigin` reports `Origin.EXPLICIT` for the >> implicitly declared class and

Re: RFR: 8312425: [vectorapi] AArch64: Optimize vector math operations with SLEEF [v3]

2023-11-21 Thread Paul Sandoz
On Mon, 23 Oct 2023 09:02:35 GMT, Xiaohong Gong wrote: > This looks good. As far as I can tell the choice you've made of accuracy > matches what we need to meet the spec. Same here . Sinh/cosh/tanh/expm1 are specified to be within 2.5 ulps of the exact result, but i believe sleef does not

Re: RFR: JDK-8317799 : AIX PPC64: FFI symbol lookup doesn't find symbols [v6]

2023-11-21 Thread Martin Doerr
On Tue, 21 Nov 2023 17:54:08 GMT, suchismith1993 wrote: >> src/java.base/aix/native/libsyslookup/syslookup.c line 30: >> >>> 28: #include >>> 29: #include >>> 30: #include >> >> Are string.h and stdlib.h needed? I can't see them in the comments below. > > string.h is needed for strlen. Let

Re: RFR: JDK-8317799 : AIX PPC64: FFI symbol lookup doesn't find symbols [v6]

2023-11-21 Thread Martin Doerr
On Tue, 21 Nov 2023 17:49:43 GMT, suchismith1993 wrote: >> The math library in AIX specifically, is a static archive. Doing a -lm wont >> suffice, because when the symbols are looked up using dlsym or accessing >> native code through Java, it will lead to failures. >> Hence we had to come up

Re: RFR: JDK-8317799 : AIX PPC64: FFI symbol lookup doesn't find symbols [v6]

2023-11-21 Thread suchismith1993
On Tue, 21 Nov 2023 17:50:04 GMT, Martin Doerr wrote: >> suchismith1993 has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Comments >> - Change comments > > src/java.base/aix/native/libsyslookup/syslookup.c line 30: > >> 28: #include

Re: RFR: JDK-8315458 Implement JEP 463: Implicitly Declared Classes and Instance Main Method (Second Preview) [v31]

2023-11-21 Thread Jim Laskey
> Address changes from JEP 445 to JEP 463. > > - Move from a SYNTHETIC unnamed class to a MANDATED implicit class. > > - Don't mark class on read. > > - Remove reflection and annotation processing related to unnamed classes. > > - Simplify main method search. Jim Laskey has updated the pull

Integrated: 8318364: Add an FFM-based implementation of harfbuzz OpenType layout

2023-11-21 Thread Phil Race
On Tue, 29 Aug 2023 22:04:40 GMT, Phil Race wrote: > 8318364: Add an FFM-based implementation of harfbuzz OpenType layout This pull request has now been integrated. Changeset: f69e6653 Author:Phil Race URL: https://git.openjdk.org/jdk/commit/f69e6653f86a7dd781db6c8523f114c0d3f7ccbc

Re: RFR: JDK-8317799 : AIX PPC64: FFI symbol lookup doesn't find symbols [v6]

2023-11-21 Thread suchismith1993
> The math library in AIX specifically, is a static archive. Doing a -lm wont > suffice, because when the symbols are looked up using dlsym or accessing > native code through Java, it will lead to failures. > Hence we had to come up with a list of symbols to allow math library symbols > to be

Re: RFR: 8319571: Update jni/nullCaller/NullCallerTest.java to accept flags or mark as flagless [v2]

2023-11-21 Thread Tim Prinzing
> Marked as flagless. Tim Prinzing has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: - use

Re: RFR: 8303374: Compiler Implementation for Primitive types in patterns, instanceof, and switch (Preview) [v33]

2023-11-21 Thread Aggelos Biboudis
> This is the proposed patch for Primitive types in patterns, instanceof, and > switch (Preview). > > Draft spec here: https://cr.openjdk.org/~abimpoudis/instanceof/latest/ Aggelos Biboudis has updated the pull request with a new target base due to a merge or a rebase. The pull request now

Re: RFR: JDK-8319662 ForkJoinPool trims worker threads too slowly [v3]

2023-11-21 Thread Doug Lea
> This update cascades timeouts to trim subsequent workers after the first > keepAlive inactive period. Doug Lea has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull

Integrated: 8317742: ISO Standard Date Format implementation consistency on DateTimeFormatter and String.format

2023-11-21 Thread Shaojin Wen
On Tue, 3 Oct 2023 21:37:46 GMT, Shaojin Wen wrote: > j.u.Formatter now prints "%tF" (iso standard date) and the result is > incorrect when processing year < 0 or year > This pull request has now been integrated. Changeset: 61d81d64 Author:Shaojin Wen Committer: Naoto Sato URL:

Re: RFR: 8318776: Require supports_cx8 to always be true [v4]

2023-11-21 Thread Aleksey Shipilev
On Tue, 21 Nov 2023 06:03:38 GMT, Erik Österlund wrote: >> David Holmes has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Remove unnecessary includes of vm_version.hpp. >> Fix copyright years. > > This looks great! > Thanks for the

Re: RFR: 8319668: Fixup of jar filename typo in BadFactoryTest.sh

2023-11-21 Thread Alan Bateman
On Thu, 9 Nov 2023 16:49:41 GMT, Gaurav Chaudhari wrote: > The file test/jdk/javax/script/JDK_8196959/BadFactoryTest.sh contains a typo. > When running without security manager, the test references 'badfactoty.jar' > instead of 'badfactory.jar'. This change addresses this by correcting the jar

Re: RFR: JDK-8315458 Implement JEP 463: Implicitly Declared Classes and Instance Main Method (Second Preview) [v30]

2023-11-21 Thread Alan Bateman
On Mon, 20 Nov 2023 20:45:22 GMT, Jim Laskey wrote: >> Address changes from JEP 445 to JEP 463. >> >> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class. >> >> - Don't mark class on read. >> >> - Remove reflection and annotation processing related to unnamed classes. >> >> -

Re: RFR: 8311906: Improve robustness of String constructors with mutable array inputs [v11]

2023-11-21 Thread Roger Riggs
> Strings, after construction, are immutable but may be constructed from > mutable arrays of bytes, characters, or integers. > The string constructors should guard against the effects of mutating the > arrays during construction that might invalidate internal invariants for the > correct

Re: RFR: 8319577: x86_64 AVX2 intrinsics for Arrays.sort methods (int, float arrays) [v2]

2023-11-21 Thread Dalibor Topic
On Thu, 16 Nov 2023 07:09:31 GMT, David Holmes wrote: >> Srinivas Vamsi Parasa has updated the pull request with a new target base >> due to a merge or a rebase. The incremental webrev excludes the unrelated >> changes brought in by the merge/rebase. The pull request contains 11 >> additional

Re: RFR: 8319872: AArch64: [vectorapi] Implementation of unsigned (zero extended) casts [v3]

2023-11-21 Thread Andrew Haley
On Tue, 21 Nov 2023 13:24:34 GMT, Eric Liu wrote: >> Vector API defines zero-extend operations [1], which are going to be >> intrinsified and generated to `VectorUCastNode` by C2. This patch adds >> backend implementation for `VectorUCastNode` on AArch64. >> >> The micro benchmark shows

Re: RFR: JDK-8319662 ForkJoinPool trims worker threads too slowly [v2]

2023-11-21 Thread Doug Lea
On Mon, 20 Nov 2023 14:28:15 GMT, Viktor Klang wrote: >> It would be better, but absolute-time Unsafe.park only operates at >> millisecond accuracy (and even at that may misfire early, requiring >> TIMEOUT_SLOP.) > > I was thinking more about cases where system clock moves backwards in time.

Re: RFR: 8319872: AArch64: [vectorapi] Implementation of unsigned (zero extended) casts [v3]

2023-11-21 Thread Andrew Haley
On Tue, 21 Nov 2023 13:24:34 GMT, Eric Liu wrote: >> Vector API defines zero-extend operations [1], which are going to be >> intrinsified and generated to `VectorUCastNode` by C2. This patch adds >> backend implementation for `VectorUCastNode` on AArch64. >> >> The micro benchmark shows

Re: RFR: JDK-8315458 Implement JEP 463: Implicitly Declared Classes and Instance Main Method (Second Preview) [v19]

2023-11-21 Thread Joe Darcy
On Tue, 21 Nov 2023 10:38:36 GMT, Pavel Rappo wrote: >> Look at the spec https://bugs.openjdk.org/browse/JDK-8319252 under 7.3 >> Compilation Units. >> >> - It is not abstract (8.1.1.1 ⇗). >> - It is final (8.1.1.2 ⇗). >> - It is a member of an unnamed package (7.4.2 ⇗) and **has package

Re: RFR: JDK-8319662 ForkJoinPool trims worker threads too slowly [v2]

2023-11-21 Thread Doug Lea
> This update cascades timeouts to trim subsequent workers after the first > keepAlive inactive period. Doug Lea has updated the pull request incrementally with one additional commit since the last revision: tweak cascades; reinstate an @Contended; resolve JDK-8319498 -

Re: RFR: 8312425: [vectorapi] AArch64: Optimize vector math operations with SLEEF [v3]

2023-11-21 Thread Magnus Ihse Bursie
On Mon, 20 Nov 2023 01:47:34 GMT, Xiaohong Gong wrote: >> make/autoconf/lib-vmath.m4 line 92: >> >>> 90: [] >>> 91: ) >>> 92: AC_MSG_RESULT([${SVE_FEATURE_SUPPORT}]) >> >> What is this test even for? I can't see any usage of SVE_FEATURE_SUPPORT >> outside this

RFR: 8320360: ClassFile.parse: Some defect class files cause unexpected exceptions to be thrown

2023-11-21 Thread Adam Sotona
ClassFile API throws `IndexOutOfBoundsException` when classfile structure is corrupted so the parser attempts to read beyond the classfile bounds. General contract is that only `IllegalArgumentException` or its subclasses is expected when parser fails. This patch wraps

Re: RFR: JDK-8317799 : AIX PPC64: FFI symbol lookup doesn't find symbols [v5]

2023-11-21 Thread Martin Doerr
On Tue, 21 Nov 2023 13:01:50 GMT, suchismith1993 wrote: >> The math library in AIX specifically, is a static archive. Doing a -lm wont >> suffice, because when the symbols are looked up using dlsym or accessing >> native code through Java, it will lead to failures. >> Hence we had to come up

Re: RFR: JDK-8317799 : AIX PPC64: FFI symbol lookup doesn't find symbols [v5]

2023-11-21 Thread Magnus Ihse Bursie
On Tue, 21 Nov 2023 13:01:50 GMT, suchismith1993 wrote: >> The math library in AIX specifically, is a static archive. Doing a -lm wont >> suffice, because when the symbols are looked up using dlsym or accessing >> native code through Java, it will lead to failures. >> Hence we had to come up

Re: RFR: 8319872: AArch64: [vectorapi] Implementation of unsigned (zero extended) casts [v2]

2023-11-21 Thread Eric Liu
On Mon, 20 Nov 2023 09:26:43 GMT, Eric Liu wrote: >> src/hotspot/cpu/aarch64/c2_MacroAssembler_aarch64.cpp line 1415: >> >>> 1413: break; >>> 1414: case S: >>> 1415: (this->*unpklo)(dst, H, src); >> >> AS above: try making` is_unsigned` a parameter. > > Got it. I will fix it

Re: RFR: 8319872: AArch64: [vectorapi] Implementation of unsigned (zero extended) casts [v3]

2023-11-21 Thread Eric Liu
> Vector API defines zero-extend operations [1], which are going to be > intrinsified and generated to `VectorUCastNode` by C2. This patch adds > backend implementation for `VectorUCastNode` on AArch64. > > The micro benchmark shows significant performance improvement. In my test > machine

Re: RFR: JDK-8317799 : AIX PPC64: FFI symbol lookup doesn't find symbols [v5]

2023-11-21 Thread Martin Doerr
On Tue, 21 Nov 2023 13:01:50 GMT, suchismith1993 wrote: >> The math library in AIX specifically, is a static archive. Doing a -lm wont >> suffice, because when the symbols are looked up using dlsym or accessing >> native code through Java, it will lead to failures. >> Hence we had to come up

Re: RFR: 8318971:Better Error Handling for Jar Tool Processing of "@File" [v4]

2023-11-21 Thread Ryan Wallace
> Hi all, > > Please review this fix for jar tool not producing an archive if there is a > missing file supplied. > The current behaviour will recognise missing files as an error but continue > processing, > creating a temporary archive and then deleting it without moving to the > current

Re: RFR: JDK-8317799 : AIX PPC64: FFI symbol lookup doesn't find symbols [v5]

2023-11-21 Thread suchismith1993
> The math library in AIX specifically, is a static archive. Doing a -lm wont > suffice, because when the symbols are looked up using dlsym or accessing > native code through Java, it will lead to failures. > Hence we had to come up with a list of symbols to allow math library symbols > to be

Re: RFR: JDK-8315458 Implement JEP 463: Implicitly Declared Classes and Instance Main Method (Second Preview) [v19]

2023-11-21 Thread Jim Laskey
On Tue, 21 Nov 2023 10:38:36 GMT, Pavel Rappo wrote: >> Look at the spec https://bugs.openjdk.org/browse/JDK-8319252 under 7.3 >> Compilation Units. >> >> - It is not abstract (8.1.1.1 ⇗). >> - It is final (8.1.1.2 ⇗). >> - It is a member of an unnamed package (7.4.2 ⇗) and **has package

Re: RFR: JDK-8317799 : AIX PPC64: FFI symbol lookup doesn't find symbols [v4]

2023-11-21 Thread suchismith1993
> The math library in AIX specifically, is a static archive. Doing a -lm wont > suffice, because when the symbols are looked up using dlsym or accessing > native code through Java, it will lead to failures. > Hence we had to come up with a list of symbols to allow math library symbols > to be

Re: RFR: JDK-8317799 : AIX PPC64: FFI symbol lookup doesn't find symbols [v3]

2023-11-21 Thread Martin Doerr
On Tue, 21 Nov 2023 11:52:23 GMT, suchismith1993 wrote: >> The math library in AIX specifically, is a static archive. Doing a -lm wont >> suffice, because when the symbols are looked up using dlsym or accessing >> native code through Java, it will lead to failures. >> Hence we had to come up

Re: RFR: JDK-8317799 : AIX PPC64: FFI symbol lookup doesn't find symbols [v3]

2023-11-21 Thread suchismith1993
> The math library in AIX specifically, is a static archive. Doing a -lm wont > suffice, because when the symbols are looked up using dlsym or accessing > native code through Java, it will lead to failures. > Hence we had to come up with a list of symbols to allow math library symbols > to be

Re: RFR: JDK-8317799 : AIX PPC64: FFI symbol lookup doesn't find symbols [v2]

2023-11-21 Thread Martin Doerr
On Tue, 21 Nov 2023 11:21:40 GMT, suchismith1993 wrote: >> The math library in AIX specifically, is a static archive. Doing a -lm wont >> suffice, because when the symbols are looked up using dlsym or accessing >> native code through Java, it will lead to failures. >> Hence we had to come up

Re: RFR: JDK-8317799 : AIX PPC64: FFI symbol lookup doesn't find symbols [v2]

2023-11-21 Thread suchismith1993
> The math library in AIX specifically, is a static archive. Doing a -lm wont > suffice, because when the symbols are looked up using dlsym or accessing > native code through Java, it will lead to failures. > Hence we had to come up with a list of symbols to allow math library symbols > to be

Re: RFR: 8318776: Require supports_cx8 to always be true [v4]

2023-11-21 Thread David Holmes
On Tue, 21 Nov 2023 06:03:38 GMT, Erik Österlund wrote: >> David Holmes has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Remove unnecessary includes of vm_version.hpp. >> Fix copyright years. > > This looks great! Thanks for the

Re: RFR: JDK-8315458 Implement JEP 463: Implicitly Declared Classes and Instance Main Method (Second Preview) [v19]

2023-11-21 Thread Pavel Rappo
On Wed, 15 Nov 2023 15:54:26 GMT, Jim Laskey wrote: >> Jim Laskey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Filter abstract main methods and search interfaces for default main >> methods. > > Look at the spec

Re: RFR: 8308753: Class-File API transition to Preview [v30]

2023-11-21 Thread Adam Sotona
> Classfile API is an internal library under package `jdk.internal.classfile`  > in JDK 21. > This pull request turns the Classfile API into a preview feature and moves it > into `java.lang.classfile`. > It repackages all uses across JDK and tests and adds lots of missing Javadoc. > > This PR

Integrated: 8320222: Wrong bytecode accepted, and StackMap table generated

2023-11-21 Thread Adam Sotona
On Thu, 16 Nov 2023 10:00:44 GMT, Adam Sotona wrote: > Stack map generator in ClassFile API performs only minimal checks in favour > of performance. > However it led to situations where it generates invalid stack maps for > corrupted code. > This patch adds basic checks of stack when two

Re: RFR: 8319123: Implement JEP 461: Stream Gatherers (Preview) [v13]

2023-11-21 Thread Viktor Klang
> This Pull-Request implements [JEP-461](https://openjdk.org/jeps/461) Viktor Klang has updated the pull request incrementally with one additional commit since the last revision: Javadoc clarifications for Gatherer type parameters, correcting descriptions of Integrator type parameters,

Integrated: 8304446: javap --system flag doesn't override system APIs

2023-11-21 Thread Adam Sotona
On Thu, 2 Nov 2023 13:49:17 GMT, Adam Sotona wrote: > Javap ignores --system option when searching for JDK classes. > This patch prepends search over JDK system modules. > > Please review. > > Thanks, > Adam This pull request has now been integrated. Changeset: 604d29a8 Author:Adam

Re: RFR: 8320222: Wrong bytecode accepted, and StackMap table generated [v2]

2023-11-21 Thread Jan Lahoda
On Mon, 20 Nov 2023 17:17:15 GMT, Adam Sotona wrote: >> Stack map generator in ClassFile API performs only minimal checks in favour >> of performance. >> However it led to situations where it generates invalid stack maps for >> corrupted code. >> This patch adds basic checks of stack when two

Re: RFR: 8304446: javap --system flag doesn't override system APIs [v3]

2023-11-21 Thread Jan Lahoda
On Fri, 10 Nov 2023 08:38:09 GMT, Adam Sotona wrote: >> Javap ignores --system option when searching for JDK classes. >> This patch prepends search over JDK system modules. >> >> Please review. >> >> Thanks, >> Adam > > Adam Sotona has updated the pull request incrementally with one additional

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref

2023-11-21 Thread Viktor Klang
On Mon, 13 Nov 2023 22:31:16 GMT, Brent Christian wrote: > Classes in the `java.lang.ref` package would benefit from an update to bring > the spec in line with how the VM already behaves. The changes would focus on > _happens-before_ edges at some key points during reference processing. > > A

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref

2023-11-21 Thread Viktor Klang
On Wed, 15 Nov 2023 22:33:03 GMT, Stuart Marks wrote: >> Classes in the `java.lang.ref` package would benefit from an update to bring >> the spec in line with how the VM already behaves. The changes would focus on >> _happens-before_ edges at some key points during reference processing. >> >>