Re: RFR: 8322802: Add testing for ZipFile.getEntry respecting the 'Language encoding' flag [v3]

2024-01-01 Thread Jaikiran Pai
On Mon, 1 Jan 2024 14:29:50 GMT, Eirik Bjørsnøs wrote: >> Please review this test-only PR which adds test coverage for >> `ZipFile.getEntry` under certain charset conditions. >> >> When `ZipFile.getEntry` is called for an entry which has the `Language >> encoding flag` general purpose bit

Re: RFR: 8321540: ClassSignature.parseFrom() throws StringIndexOutOfBoundsException for invalid signatures

2024-01-01 Thread Jaikiran Pai
On Mon, 11 Dec 2023 15:17:49 GMT, Adam Sotona wrote: > ClassFile API models and parses signatures, however parsing of the signatures > mostly throws IIOBE when it fails. > This patch improves SignaturesImpl parsing methods implementation and errors > handling and adds relevant negative tests.

Re: RFR: 8320360: ClassFile.parse: Some defect class files cause unexpected exceptions to be thrown [v2]

2024-01-01 Thread Jaikiran Pai
On Thu, 7 Dec 2023 07:53:58 GMT, Adam Sotona wrote: >> ClassFile API throws `IndexOutOfBoundsException` when classfile structure is >> corrupted so the parser attempts to read beyond the classfile bounds. >> General contract is that only `IllegalArgumentException` or its subclasses >> is

Re: RFR: 8322027: One XMLStreamException constructor fails to initialize cause

2024-01-01 Thread Jaikiran Pai
On Wed, 13 Dec 2023 20:06:03 GMT, Archie Cobbs wrote: > One of the three `XMLStreamException` constructors that takes a `Throwable` > fails to pass it to the superclass constructor. > > This simple patch fixes that omission. > > It's worth considering if there is any code out there that is

Withdrawn: JDK-8266431: Dual-Pivot Quicksort improvements (Radix sort)

2024-01-01 Thread duke
On Sat, 8 May 2021 20:54:48 GMT, Vladimir Yaroslavskiy wrote: > Sorting: > > - adopt radix sort for sequential and parallel sorts on int/long/float/double > arrays (almost random and length > 6K) > - fix tryMergeRuns() to better handle case when the last run is a single > element > - minor

Re: The default java.library.path on Linux does not include the library paths in the mulitarch-spec

2024-01-01 Thread David Holmes
Hi Glavo, On 24/12/2023 4:18 am, Glavo wrote: Hi, There are already many Linux distributions that are following the multiarch-spec[1] and adding the following paths to the default library path list: * /usr/local/lib/ * /lib/ * /usr/lib/ But OpenJDK doesn't add these paths to the

Withdrawn: 8316641: VarHandle template classes can share code in the base class

2024-01-01 Thread duke
On Thu, 21 Sep 2023 05:43:20 GMT, Chen Liang wrote: > VarHandle implementations have many static fields and methods that can be > pulled to the common superclass to avoid repeated initialization and code > duplication. > > In addition, the Unsafe-based Buffer field access are replaced by

RFR: 8313739: ZipOutputStream.close() should always close the wrapped stream

2024-01-01 Thread Eirik Bjørsnøs
Please consider this PR which makes `DeflaterOutputStream.close()` always close its wrapped output stream. Currently, closing of the wrapped output stream happens outside the finally block where `finish()` is called. If `finish()` throws, this means the wrapped stream will not be closed. This

Re: RFR: 8319463: ClassSignature should have superclass and superinterfaces as ClassTypeSig [v2]

2024-01-01 Thread Chen Liang
On Mon, 4 Dec 2023 15:23:07 GMT, Chen Liang wrote: >> Discovered while writing a test for #16513 that >> `ClassSignature.superclassSignature()` does not return a `ClassTypeSig`, yet >> [JVM >> Spec](https://docs.oracle.com/javase/specs/jvms/se21/html/jvms-4.html#jvms-4.7.9.1-4100) >>

Withdrawn: 8319463: ClassSignature should have superclass and superinterfaces as ClassTypeSig

2024-01-01 Thread duke
On Mon, 6 Nov 2023 06:41:22 GMT, Chen Liang wrote: > Discovered while writing a test for #16513 that > `ClassSignature.superclassSignature()` does not return a `ClassTypeSig`, yet > [JVM > Spec](https://docs.oracle.com/javase/specs/jvms/se21/html/jvms-4.html#jvms-4.7.9.1-4100) > requires it

Re: RFR: 8318650: Optimized subword gather for x86 targets. [v10]

2024-01-01 Thread Jatin Bhateja
> Hi All, > > This patch optimizes sub-word gather operation for x86 targets with AVX2 and > AVX512 features. > > Following is the summary of changes:- > > 1) Intrinsify sub-word gather using hybrid algorithm which initially > partially unrolls scalar loop to accumulates values from gather

Re: RFR: 8322802: Add testing for ZipFile.getEntry respecting the 'Language encoding' flag [v3]

2024-01-01 Thread Eirik Bjørsnøs
> Please review this test-only PR which adds test coverage for > `ZipFile.getEntry` under certain charset conditions. > > When `ZipFile.getEntry` is called for an entry which has the `Language > encoding flag` general purpose bit flag set, then `ZipCoder.UTF8` is used > unconditionally, even

Re: RFR: 8322802: Add testing for ZipFile.getEntry respecting the 'Language encoding' flag [v2]

2024-01-01 Thread Eirik Bjørsnøs
On Mon, 1 Jan 2024 08:35:17 GMT, Alan Bateman wrote: > So I think create a new issue for the test work or else change the title on > this one. Filed a new issue [JDK-8322802](https://bugs.openjdk.org/browse/JDK-8322802) for tracking this PR. - PR Comment:

Re: RFR: 7009069: ZipFile.getEntry(String name) does NOT respect the "language encoding flag" [v2]

2024-01-01 Thread Alan Bateman
On Sun, 31 Dec 2023 23:25:51 GMT, Eirik Bjørsnøs wrote: >> Please review this test-only PR which adds test coverage for >> `ZipFile.getEntry` under certain charset conditions. >> >> When `ZipFile.getEntry` is called for an entry which has the `Language >> encoding flag` general purpose bit