RFR: 8322332: Add API to access ZipEntry.extraAttributes

2024-05-11 Thread xiaotaonan
Add API to access ZipEntry.extraAttributes - Commit messages: - Add API to access ZipEntry.extraAttributes Changes: https://git.openjdk.org/jdk/pull/19204/files Webrev: https://webrevs.openjdk.org/?repo=jdk=19204=00 Issue: https://bugs.openjdk.org/browse/JDK-8322332 Stats: 17

Re: RFR: 8331855: Convert jdk.jdeps jdeprscan and jdeps to use the Classfile API [v2]

2024-05-11 Thread Chen Liang
> Summary of the changes: > - Moved `com.sun.tools.classfile.Dependency` and `Dependencies` to jdeps; > they are exclusively used by jdeps in sources, and they are not used in any > tests too. This will ease the removal of `com.sun.tools.classfile` later. > - A few visitor patterns have been

Withdrawn: 8322332: Add API to access ZipEntry.extraAttributes

2024-05-11 Thread xiaotaonan
On Sun, 12 May 2024 02:21:55 GMT, xiaotaonan wrote: > Add API to access ZipEntry.extraAttributes This pull request has been closed without being integrated. - PR: https://git.openjdk.org/jdk/pull/19202

RFR: 8322332: Add API to access ZipEntry.extraAttributes

2024-05-11 Thread xiaotaonan
Add API to access ZipEntry.extraAttributes - Commit messages: - Add API to access ZipEntry.extraAttributes Changes: https://git.openjdk.org/jdk/pull/19202/files Webrev: https://webrevs.openjdk.org/?repo=jdk=19202=00 Issue: https://bugs.openjdk.org/browse/JDK-8322332 Stats: 16

Re: RFR: 8322732: ForkJoinPool may underutilize cores in async mode

2024-05-11 Thread Viktor Klang
On Tue, 7 May 2024 22:50:18 GMT, Doug Lea wrote: > This set of changes address causes of poor utilization with small numbers of > cores due to overly aggressive contention avoidance. A number of further > adjustments were needed to still avoid most contention effects in deployments > with

Re: RFR: 8322732: ForkJoinPool may underutilize cores in async mode

2024-05-11 Thread Viktor Klang
On Tue, 7 May 2024 22:50:18 GMT, Doug Lea wrote: > This set of changes address causes of poor utilization with small numbers of > cores due to overly aggressive contention avoidance. A number of further > adjustments were needed to still avoid most contention effects in deployments > with

Re: RFR: 8322732: ForkJoinPool may underutilize cores in async mode

2024-05-11 Thread Viktor Klang
On Tue, 7 May 2024 22:50:18 GMT, Doug Lea wrote: > This set of changes address causes of poor utilization with small numbers of > cores due to overly aggressive contention avoidance. A number of further > adjustments were needed to still avoid most contention effects in deployments > with

Re: RFR: 8322732: ForkJoinPool may underutilize cores in async mode

2024-05-11 Thread Viktor Klang
On Tue, 7 May 2024 22:50:18 GMT, Doug Lea wrote: > This set of changes address causes of poor utilization with small numbers of > cores due to overly aggressive contention avoidance. A number of further > adjustments were needed to still avoid most contention effects in deployments > with

Re: RFR: 8322732: ForkJoinPool may underutilize cores in async mode

2024-05-11 Thread Viktor Klang
On Tue, 7 May 2024 22:50:18 GMT, Doug Lea wrote: > This set of changes address causes of poor utilization with small numbers of > cores due to overly aggressive contention avoidance. A number of further > adjustments were needed to still avoid most contention effects in deployments > with

RFR: 8331855: Convert jdk.jdeps jdeprscan and jdeps to use the Classfile API

2024-05-11 Thread Chen Liang
Summary of the changes: - Moved `com.sun.tools.classfile.Dependency` and `Dependencies` to jdeps; they are exclusively used by jdeps in sources, and they are not used in any tests too. This will ease the removal of `com.sun.tools.classfile` later. - A few visitor patterns have been rewritten

Re: RFR: 8331876: JFR: Move file read and write events to java.base [v3]

2024-05-11 Thread Erik Gahlin
On Fri, 10 May 2024 00:43:32 GMT, Stuart Marks wrote: >> Its purpose is to avoid loading the FileReadEvent class. When the class is >> loaded, JFR will add fields and in some circumstances do other things. I >> don't think the cost is high, but it may add up if the number of events >>

Integrated: 8278255: Add more warning text in ReentrantLock and ReentrantReadWriteLock

2024-05-11 Thread Viktor Klang
On Fri, 26 Apr 2024 11:43:06 GMT, Viktor Klang wrote: > This is an attempt to be more clear about recommendations on Lock usage. This pull request has now been integrated. Changeset: 5053b70a Author:Viktor Klang URL:

Re: RFR: 8331876: JFR: Move file read and write events to java.base [v3]

2024-05-11 Thread Alan Bateman
On Thu, 9 May 2024 16:02:02 GMT, Erik Gahlin wrote: >> The field is only used once and a VarHandle implementation loads three >> additional classes during startup and in my measurements add about 0.6 ms to >> startup. > > A compromise between performance and readability is: > > if

Re: RFR: 8278255: Add more warning text in ReentrantLock and ReentrantReadWriteLock [v2]

2024-05-11 Thread Alan Bateman
On Sat, 27 Apr 2024 11:52:18 GMT, Viktor Klang wrote: >> This is an attempt to be more clear about recommendations on Lock usage. > > Viktor Klang has updated the pull request incrementally with one additional > commit since the last revision: > > Update >

Re: RFR: 8331876: JFR: Move file read and write events to java.base [v3]

2024-05-11 Thread Alan Bateman
On Thu, 9 May 2024 11:19:14 GMT, Erik Gahlin wrote: >> Hi, >> >> Could I have a review of a change that moves the jdk.FileRead and >> jdk.FileWrite events to java.base to remove the use of the ASM >> instrumentation. >> >> Testing: jdk/jdk/jfr >> >> Thanks >> Erik > > Erik Gahlin has

Integrated: 8332029: Provide access to initial value of stderr via JavaLangAccess

2024-05-11 Thread Alan Bateman
On Fri, 10 May 2024 07:57:40 GMT, Alan Bateman wrote: > In preparation for JEP 471 and JEP 472, provide access to the initial value > of System.err from JavaLangAccess. The initial value of System.in is already > exposed to code in java.base with this shared secret. This pull request has now

Re: RFR: 8332084: Ensure JdkConsoleImpl.restoreEcho visibility in a shutdown hook

2024-05-11 Thread ExE Boss
On Fri, 10 May 2024 21:55:26 GMT, Naoto Sato wrote: > Making sure `restoreEcho` correctly reflects the state in the shutdown > thread, which differs from the application's thread that issues the > `readPassword()` method. src/java.base/share/classes/jdk/internal/io/JdkConsoleImpl.java line