On Thu, 31 Jul 2025 19:04:34 GMT, Chen Liang wrote:
>> Unsafe throws IAE for misusing static vs instance fields, and it's revealed
>> that AtomicXxxFieldUpdaters are using this mechanism to reject static
>> fields. This is not a good practice, but we can at least document this so we
>> don't a
On Thu, 31 Jul 2025 23:12:56 GMT, Justin Lu wrote:
> Please review this doc only PR.
>
> java.text.DecimalFormat uses an implSpec tag in the middle of the class
> description. This location was on purpose as the contents related to the
> surrounding section. However, this has caused slight ind
> - Enhance AddLShortcutTest to cover more combinations of shortcut
> configurations of the main and additional launchers.
> - Test shortcuts in the predefined app image.
>
> Additionally, rework launcher verification: move launcher icon and shortcut
> verification code from AdditionalLauncher i
> - Enhance AddLShortcutTest to cover more combinations of shortcut
> configurations of the main and additional launchers.
> - Test shortcuts in the predefined app image.
>
> Additionally, rework launcher verification: move launcher icon and shortcut
> verification code from AdditionalLauncher i
On Thu, 31 Jul 2025 21:32:16 GMT, Mohamed Issa wrote:
>> The goal of this PR is to implement an x86_64 intrinsic for
>> java.lang.Math.sinh() using libm. There is a new set of micro-benchmarks are
>> included to check the performance of specific input value ranges to help
>> prevent regression
- Enhance AddLShortcutTest to cover more combinations of shortcut
configurations of the main and additional launchers.
- Test shortcuts in the predefined app image.
Additionally, rework launcher verification: move launcher icon and shortcut
verification code from AdditionalLauncher into Launcher
On Thu, 31 Jul 2025 22:04:56 GMT, Naoto Sato wrote:
>> Enabling lenient minus sign matching when parsing numbers. In some locales,
>> e.g. Finnish, the default minus sign is the Unicode "Minus Sign" (U+2212),
>> which is not the "Hyphen Minus" (U+002D) that users type in from keyboard.
>> Thus
On Wed, 30 Jul 2025 16:26:55 GMT, Jaikiran Pai wrote:
> Hello Hao,
>
> > Hi, I encountered two jtreg failures with this new version `8` on both
> > AArch64 and x86_64 platforms.
> > Note that these two jtreg cases can pass with jtreg `7.5.2+1` version.
>
> Thank you for bringing this up. I'm a
On Wed, 30 Jul 2025 19:25:34 GMT, Coleen Phillimore wrote:
>> This change removes the intrinsic for getClassAccessFlagsRaw for reflection
>> and initializes an rawAccessFlags field in java.lang.Class instead, that
>> Java code can non-natively access.
>> Tested with tier1-4.
>
> Coleen Phillimo
Hi all,
I think the key takeaway here is that we should reduce the number of intrinsics
for easier maintenance. With the same number of unsafe Java methods, it is
still feasible to reduce the number of distinct intrinsics simply for the
reduced maintenance cost.
For example, the toBytes and getC
On Thu, 31 Jul 2025 23:12:56 GMT, Justin Lu wrote:
> Please review this doc only PR.
>
> java.text.DecimalFormat uses an implSpec tag in the middle of the class
> description. This location was on purpose as the contents related to the
> surrounding section. However, this has caused slight ind
Please review this doc only PR.
java.text.DecimalFormat uses an implSpec tag in the middle of the class
description. This location was on purpose as the contents related to the
surrounding section. However, this has caused slight indentation in the rest of
the class description below the tag (a
On Thu, 31 Jul 2025 21:32:16 GMT, Mohamed Issa wrote:
>> The goal of this PR is to implement an x86_64 intrinsic for
>> java.lang.Math.sinh() using libm. There is a new set of micro-benchmarks are
>> included to check the performance of specific input value ranges to help
>> prevent regression
On Thu, 31 Jul 2025 21:53:52 GMT, Brian Burkhalter wrote:
> as it would be used in only one place
This comment was incorrect, sorry, but I still think the `isWindows` constant
is not needed.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/26445#discussion_r2246525449
> Enabling lenient minus sign matching when parsing numbers. In some locales,
> e.g. Finnish, the default minus sign is the Unicode "Minus Sign" (U+2212),
> which is not the "Hyphen Minus" (U+002D) that users type in from keyboard.
> Thus the parsing of user input numbers may fail. This change u
> Enabling lenient minus sign matching when parsing numbers. In some locales,
> e.g. Finnish, the default minus sign is the Unicode "Minus Sign" (U+2212),
> which is not the "Hyphen Minus" (U+002D) that users type in from keyboard.
> Thus the parsing of user input numbers may fail. This change u
On Thu, 31 Jul 2025 22:08:09 GMT, Brian Burkhalter wrote:
>> Darragh Conway has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Implemented Brian's suggestion
>
> test/jdk/java/io/File/MaxPathLength.java line 208:
>
>> 206: }
>> 207: }
> There were a couple of post review comments for PR:
> https://github.com/openjdk/jdk/pull/26193 after the /integrate command was
> submitted. This issue will address those comments. Also created constants for
> hardcoded values and tests. Fixed some typos.
Darragh Conway has updated the pull
On Thu, 31 Jul 2025 20:55:01 GMT, Francesco Andreuzzi wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Address review comments
>
> src/java.base/share/classes/java/text/DecimalFormatSymbols.java line 1002:
>
>> 1000:
On Thu, 31 Jul 2025 20:50:36 GMT, Darragh Conway wrote:
>> There were a couple of post review comments for PR:
>> https://github.com/openjdk/jdk/pull/26193 after the /integrate command was
>> submitted. This issue will address those comments. Also created constants
>> for hardcoded values and
> Enabling lenient minus sign matching when parsing numbers. In some locales,
> e.g. Finnish, the default minus sign is the Unicode "Minus Sign" (U+2212),
> which is not the "Hyphen Minus" (U+002D) that users type in from keyboard.
> Thus the parsing of user input numbers may fail. This change u
On Thu, 31 Jul 2025 20:56:22 GMT, Darragh Conway wrote:
> Or is the last commit sufficient?
I don't think that there is any point in keeping the `isWindows` constant as it
would be used in only one place, thus I think that the most recent commit is
sufficient for this purpose.
-
> The goal of this PR is to implement an x86_64 intrinsic for
> java.lang.Math.sinh() using libm. There is a new set of micro-benchmarks are
> included to check the performance of specific input value ranges to help
> prevent regressions in the future.
>
> The command to run all range specific
On Wed, 30 Jul 2025 18:26:22 GMT, Sandhya Viswanathan
wrote:
>> Mohamed Issa has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Move error bound to separate section in comment header
>
> src/hotspot/cpu/x86/stubGenerator_x86_64_sinh.cpp li
On Thu, 31 Jul 2025 20:50:36 GMT, Darragh Conway wrote:
>> There were a couple of post review comments after the /integrate command was
>> submitted. This issue will address those comments. Also created constants
>> for hardcoded values and tests. Fixed some typos.
>
> Darragh Conway has update
On Thu, 31 Jul 2025 20:50:36 GMT, Darragh Conway wrote:
>> There were a couple of post review comments after the /integrate command was
>> submitted. This issue will address those comments. Also created constants
>> for hardcoded values and tests. Fixed some typos.
>
> Darragh Conway has update
On Thu, 31 Jul 2025 18:41:47 GMT, Naoto Sato wrote:
> Enabling lenient minus sign matching when parsing numbers. In some locales,
> e.g. Finnish, the default minus sign is the Unicode "Minus Sign" (U+2212),
> which is not the "Hyphen Minus" (U+002D) that users type in from keyboard.
> Thus the
On Tue, 29 Jul 2025 18:48:10 GMT, Brian Burkhalter wrote:
>> Darragh Conway has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix remaining indentation errors (From my first commit on this branch)
>
> test/jdk/java/io/File/MaxPathLength.ja
> There were a couple of post review comments after the /integrate command was
> submitted. This issue will address those comments. Also created constants for
> hardcoded values and tests. Fixed some typos.
Darragh Conway has updated the pull request incrementally with one additional
commit sin
On Thu, 31 Jul 2025 19:04:34 GMT, Chen Liang wrote:
>> Unsafe throws IAE for misusing static vs instance fields, and it's revealed
>> that AtomicXxxFieldUpdaters are using this mechanism to reject static
>> fields. This is not a good practice, but we can at least document this so we
>> don't a
> Unsafe throws IAE for misusing static vs instance fields, and it's revealed
> that AtomicXxxFieldUpdaters are using this mechanism to reject static fields.
> This is not a good practice, but we can at least document this so we don't
> accidentally introduce problems.
Chen Liang has updated th
Enabling lenient minus sign matching when parsing numbers. In some locales,
e.g. Finnish, the default minus sign is the Unicode "Minus Sign" (U+2212),
which is not the "Hyphen Minus" (U+002D) that users type in from keyboard. Thus
the parsing of user input numbers may fail. This change utilizes
> Unsafe throws IAE for misusing static vs instance fields, and it's revealed
> that AtomicXxxFieldUpdaters are using this mechanism to reject static fields.
> This is not a good practice, but we can at least document this so we don't
> accidentally introduce problems.
Chen Liang has updated th
On Tue, 29 Jul 2025 21:09:59 GMT, Chen Liang wrote:
> In #24773, people were concerned that the layout of a UTF16 byte array and a
> char array may be incompatible. In fact, they are - they are asserted in a
> corner in `LibraryCallKit::inline_string_char_access` in `library_call.cpp`.
>
> In
On Wed, 30 Jul 2025 14:18:49 GMT, Chen Liang wrote:
>> In #24773, people were concerned that the layout of a UTF16 byte array and a
>> char array may be incompatible. In fact, they are - they are asserted in a
>> corner in `LibraryCallKit::inline_string_char_access` in `library_call.cpp`.
>>
>
On Mon, 16 Jun 2025 21:19:45 GMT, Johannes Graham wrote:
>> This PR replaces construction of intermediate strings to be parsed with more
>> direct manipulation of numbers. It also has a more streamlined mechanism of
>> handling `Long.MIN_VALUE` when parsing longs by using
>> `Long.parseUnsigne
On Wed, 4 Jun 2025 18:18:39 GMT, Johannes Graham wrote:
> This PR replaces construction of intermediate strings to be parsed with more
> direct manipulation of numbers. It also has a more streamlined mechanism of
> handling `Long.MIN_VALUE` when parsing longs by using `Long.parseUnsignedLong`
>
On Wed, 30 Jul 2025 14:18:49 GMT, Chen Liang wrote:
>> In #24773, people were concerned that the layout of a UTF16 byte array and a
>> char array may be incompatible. In fact, they are - they are asserted in a
>> corner in `LibraryCallKit::inline_string_char_access` in `library_call.cpp`.
>>
>
On Wed, 30 Jul 2025 17:32:57 GMT, John R Rose wrote:
>> Chen Liang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Test to verify observed internal unsafe behaviors
>
> src/hotspot/share/prims/unsafe.cpp line 496:
>
>> 494: Symbol *
On Wed, 30 Jul 2025 18:12:03 GMT, Volkan Yazici wrote:
>> Chen Liang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add paragraph for endianness and layout
>
> src/java.base/share/classes/java/lang/StringUTF16.java line 51:
>
>> 49: //
On Wed, 30 Jul 2025 14:15:57 GMT, Chen Liang wrote:
>> A good initiative, thanks @liach.
>> Maybe some words about endianness would be useful as well.
>
> @rgiulietti: I have added a paragraph describing the layout constraints of
> UTF16 byte arrays. Please check it out.
> @liach, given the rel
On Wed, 30 Jul 2025 19:25:34 GMT, Coleen Phillimore wrote:
>> This change removes the intrinsic for getClassAccessFlagsRaw for reflection
>> and initializes an rawAccessFlags field in java.lang.Class instead, that
>> Java code can non-natively access.
>> Tested with tier1-4.
>
> Coleen Phillimo
On Thu, 31 Jul 2025 11:45:00 GMT, Coleen Phillimore wrote:
>> The VM and Java use the same logic for the value of isIdentity().
>> It is computed from as many a 5 fields/flags. At present, it has to be
>> computed on each call to Class.isIdentity().
>> It would be reasonable to compute the valu
On Mon, 16 Jun 2025 21:19:45 GMT, Johannes Graham wrote:
>> This PR replaces construction of intermediate strings to be parsed with more
>> direct manipulation of numbers. It also has a more streamlined mechanism of
>> handling `Long.MIN_VALUE` when parsing longs by using
>> `Long.parseUnsigne
On Wed, 30 Jul 2025 10:39:22 GMT, David Beaumont wrote:
>> Refactoring `ImageReader` to make it easy to add preview mode functionality
>> for Valhalla.
>>
>> This PR is a large change to `ImageReader` (effectively a rewrite) but
>> reduces the surface area of the API significantly, reduces cod
On Tue, 29 Jul 2025 17:56:00 GMT, David Beaumont wrote:
>> test/jdk/jdk/internal/jimage/JImageReadTest.java line 350:
>>
>>> 348: try (ImageReader badReader = ImageReader.open(imageFile,
>>> otherOrder)) {
>>> 349: Assert.fail("Reader should not be openable with the wrong
>
On Thu, 31 Jul 2025 13:03:40 GMT, Alan Bateman wrote:
> The jimage code is still compiled --release 8
Good point, Alan. I keep forgetting that, even when it's noted in the very file
that I commented on.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/26054#discussion_r224546
On Thu, 31 Jul 2025 08:40:40 GMT, fabioromano1 wrote:
>> This PR implements nth root computation for BigIntegers using Newton method.
>
> fabioromano1 has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains 111 commits:
>
> - Merge branch
On Thu, 31 Jul 2025 13:00:33 GMT, Jaikiran Pai wrote:
>> David Beaumont has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Convert non-visible markdown comments to JavaDoc for consistency.
>
> src/java.base/share/classes/jdk/internal/jimage
On Wed, 30 Jul 2025 10:39:22 GMT, David Beaumont wrote:
>> Refactoring `ImageReader` to make it easy to add preview mode functionality
>> for Valhalla.
>>
>> This PR is a large change to `ImageReader` (effectively a rewrite) but
>> reduces the surface area of the API significantly, reduces cod
On Thu, 31 Jul 2025 13:02:06 GMT, Raffaello Giulietti
wrote:
>> The integers are closed under positive powers, and not under positive
>> nthRoots, this is true. However, the problem remains, as if the root degree
>> `n` is negative, then for radicands that are not 1, -1 or 0 we should return
On Thu, 31 Jul 2025 13:13:39 GMT, fabioromano1 wrote:
>> src/java.base/share/classes/java/math/MutableBigInteger.java line 1921:
>>
>>> 1919: * The contents of {@code this} are not changed. The
>>> value of {@code this}
>>> 1920: * is assumed to be non-negative and the root degree {@c
On Wed, 30 Jul 2025 10:30:15 GMT, fabioromano1 wrote:
>> fabioromano1 has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update javadoc
>
> src/java.base/share/classes/java/math/MutableBigInteger.java line 1921:
>
>> 1919: * The conte
On Mon, 14 Jul 2025 16:52:31 GMT, fabioromano1 wrote:
>> fabioromano1 has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Removed useless instruction
>
> The integers are closed under positive powers, and not under positive
> nthRoots, this
On Wed, 30 Jul 2025 10:39:22 GMT, David Beaumont wrote:
>> Refactoring `ImageReader` to make it easy to add preview mode functionality
>> for Valhalla.
>>
>> This PR is a large change to `ImageReader` (effectively a rewrite) but
>> reduces the surface area of the API significantly, reduces cod
On Wed, 30 Jul 2025 10:39:22 GMT, David Beaumont wrote:
>> Refactoring `ImageReader` to make it easy to add preview mode functionality
>> for Valhalla.
>>
>> This PR is a large change to `ImageReader` (effectively a rewrite) but
>> reduces the surface area of the API significantly, reduces cod
> In this PR I added TLS groups and signature algorithms to the output of the
> show settings flag. The values are printed in a single column, like the
> cipher suites. There can be a lot of values so putting on a single line is
> ugly. I tried putting them in columns, but it is hard to read.
M
On Wed, 30 Jul 2025 10:39:22 GMT, David Beaumont wrote:
>> Refactoring `ImageReader` to make it easy to add preview mode functionality
>> for Valhalla.
>>
>> This PR is a large change to `ImageReader` (effectively a rewrite) but
>> reduces the surface area of the API significantly, reduces cod
On Thu, 24 Jul 2025 10:29:15 GMT, Galder Zamarreño wrote:
> I've added support to vectorize `MoveD2L`, `MoveL2D`, `MoveF2I` and `MoveI2F`
> nodes. The implementation follows a similar pattern to what is done with
> conversion (`Conv*`) nodes. The tests in `TestCompatibleUseDefTypeSize` have
>
On Thu, 31 Jul 2025 12:49:16 GMT, Emanuel Peter wrote:
>> I've added support to vectorize `MoveD2L`, `MoveL2D`, `MoveF2I` and
>> `MoveI2F` nodes. The implementation follows a similar pattern to what is
>> done with conversion (`Conv*`) nodes. The tests in
>> `TestCompatibleUseDefTypeSize` have
On Wed, 30 Jul 2025 19:25:34 GMT, Coleen Phillimore wrote:
>> This change removes the intrinsic for getClassAccessFlagsRaw for reflection
>> and initializes an rawAccessFlags field in java.lang.Class instead, that
>> Java code can non-natively access.
>> Tested with tier1-4.
>
> Coleen Phillimo
On Wed, 30 Jul 2025 10:39:22 GMT, David Beaumont wrote:
>> Refactoring `ImageReader` to make it easy to add preview mode functionality
>> for Valhalla.
>>
>> This PR is a large change to `ImageReader` (effectively a rewrite) but
>> reduces the surface area of the API significantly, reduces cod
On Tue, 29 Jul 2025 17:06:44 GMT, Chen Liang wrote:
>> CatchBuilder has a simple check for duplicate catch types. However, this
>> check is never comprehensive as it still allows subtypes covered by
>> supertypes, and covering that would be too costly; in addition, the
>> "illegal" duplicate c
On Thu, 31 Jul 2025 09:46:48 GMT, Maurizio Cimadamore
wrote:
>> src/java.base/share/classes/jdk/internal/ffi/util/FFMUtils.java line 51:
>>
>>> 49: public static final AddressLayout C_POINTER = ValueLayout.ADDRESS
>>> 50:
>>> .withTargetLayout(MemoryLayout.sequenceLayout(Long.M
On Wed, 30 Jul 2025 20:25:22 GMT, Roger Riggs wrote:
>> For IDENTITY, I didn't have to inject that one because the Java code knew
>> when to set it, not the JVM code reading the data out of the classfile. And
>> the logic belongs in the Java code, not the JVM. This one comes from the
>> class
On Thu, 31 Jul 2025 09:45:10 GMT, Maurizio Cimadamore
wrote:
>> This PR aims to Panamize the Java Kqueue implementation, This is based on
>> the work that was previously shared in
>> https://github.com/openjdk/jdk/pull/22307 , The main change since then is
>> that this branch takes advantage
On Fri, 30 May 2025 12:00:28 GMT, Darragh Clarke wrote:
> This PR aims to Panamize the Java Kqueue implementation, This is based on the
> work that was previously shared in https://github.com/openjdk/jdk/pull/22307
> , The main change since then is that this branch takes advantage of the
> cha
> This PR implements nth root computation for BigIntegers using Newton method.
fabioromano1 has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains 111 commits:
- Merge branch 'openjdk:master' into nth-root-branch
- Update MutableBigInteger
68 matches
Mail list logo
