On Mon, 8 Sep 2025 09:09:49 GMT, Thomas Schatzl wrote:
>> Hi all,
>>
>> please review this change that implements (currently Draft) JEP: G1:
>> Improve Application Throughput with a More Efficient Write-Barrier.
>>
>> The reason for posting this early is that this is a large change, and the
On Wed, 3 Sep 2025 18:40:26 GMT, Roger Riggs wrote:
>> Guanqiang Han has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update Class.java
>>
>> change overflow check
>
>> /reviewers 2 reviewer
>>
>> I recommend putting this PR on hold
On Tue, 9 Sep 2025 01:05:37 GMT, Guanqiang Han wrote:
>> Validate class name length immediately after GetStringUTFLength() in
>> Class.forName0. This prevents potential issues caused by overly long class
>> names before they reach later code that would reject them, throwing
>> ClassNotFoundExc
> Validate class name length immediately after GetStringUTFLength() in
> Class.forName0. This prevents potential issues caused by overly long class
> names before they reach later code that would reject them, throwing
> ClassNotFoundException early.
Guanqiang Han has updated the pull request in
On Sun, 7 Sep 2025 20:09:53 GMT, Chen Liang wrote:
>> Guanqiang Han has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Use a different native method for testNative, since the implementation of
>> forName has changed.
>
> src/java.base/shar
On Sat, 6 Sep 2025 20:44:55 GMT, Saint Wesonga wrote:
> This test fails with errors like
> >'=C:=,=ExitValue=3,PROCESSOR_ARCHITECTURE=ARM64,SystemRoot=C:\Windows,'< not
> equal to '=C:=,=ExitValue=3,SystemRoot=C:\Windows,'
>
> The test does not expect the PROCESSOR_ARCHITECTURE variable to be
On Sat, 6 Sep 2025 09:02:59 GMT, Magnus Ihse Bursie wrote:
>> I think it is per our standard. It seems the Github diff viewer expands tabs
>> to 4 spaces, which makes it looks incorrect.
>
> Turns out you can actually change the tab size setting on GitHub. They set 4
> as default but you can ch
I submitted a bug report : https://bugs.openjdk.org/browse/JDK-8367130
-phil.
On 9/8/25 11:52 AM, Philip Race wrote:
Looks like it broke all the builds. So a P1 backout is needed.
-phil.
On 9/8/25 11:27 AM, Alan Bateman wrote:
On Mon, 8 Sep 2025 18:06:54 GMT, Chen Liang wrote:
This patch r
Builds on all platforms are currently broken due to a clash between
[JDK-8366837](https://bugs.openjdk.org/browse/JDK-8366837) and
[JDK-8366455](https://bugs.openjdk.org/browse/JDK-8366455). The former changed
the name of a variable that the latter introduced a new usage of. The fix is
simple,
> This PR implements nth root computation for BigIntegers using Newton method.
fabioromano1 has updated the pull request incrementally with one additional
commit since the last revision:
Removed MBI.valueOf(double)
-
Changes:
- all: https://git.openjdk.org/jdk/pull/24898/files
On Sat, 6 Sep 2025 01:09:04 GMT, Weijun Wang wrote:
>> Ah, yes. Comment does not align with the code. I am fine either way too.
>
> Either is OK. `Optional` sounds more modern and forces me to consider the
> empty case.
Fixed the comment to agree with the code
-
PR Review Comment:
On Mon, 8 Sep 2025 09:09:49 GMT, Thomas Schatzl wrote:
>> Hi all,
>>
>> please review this change that implements (currently Draft) JEP: G1:
>> Improve Application Throughput with a More Efficient Write-Barrier.
>>
>> The reason for posting this early is that this is a large change, and the
On Wed, 3 Sep 2025 20:17:50 GMT, Magnus Ihse Bursie wrote:
> Several java classes in java.base is generated from templates using SPP, the
> "Stream Preprocessor". Unfortunately much of this code is very old and has
> survived unchanged since pre-JDK 7. It does not follow modern makefile
> stan
On Mon, 8 Sep 2025 14:34:06 GMT, fabioromano1 wrote:
>> This PR implements nth root computation for BigIntegers using Newton method.
>
> fabioromano1 has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Revision changes
Personally I tend to rem
On Mon, 8 Sep 2025 16:25:00 GMT, fabioromano1 wrote:
> An implementation of `BigDecimal.nthRoot(int, MathContext)`.
@rgiulietti Here is the PR.
-
PR Comment: https://git.openjdk.org/jdk/pull/27148#issuecomment-3267146884
> Providing a couple of utility methods using the "built-in" `Console`
> implementation to support tools that require password input, such as
> `keytool`, ensuring they work even when std0ut is redirected.
Naoto Sato has updated the pull request incrementally with one additional
commit since th
On Fri, 5 Sep 2025 23:03:08 GMT, Naoto Sato wrote:
> A small fix to a locale test regression. Auto flush was incorrectly set to
> default (= false) by the prior fix.
This pull request has now been integrated.
Changeset: 48831c65
Author:Naoto Sato
URL:
https://git.openjdk.org/jdk/co
On Fri, 5 Sep 2025 23:03:08 GMT, Naoto Sato wrote:
> A small fix to a locale test regression. Auto flush was incorrectly set to
> default (= false) by the prior fix.
Thanks for the reviews!
-
PR Comment: https://git.openjdk.org/jdk/pull/27130#issuecomment-3267052349
On Sat, 26 Apr 2025 16:15:29 GMT, fabioromano1 wrote:
> This PR implements nth root computation for BigIntegers using Newton method.
This pull request has now been integrated.
Changeset: ab12fbfd
Author:Fabio Romano
Committer: Raffaello Giulietti
URL:
https://git.openjdk.org/jdk/co
On Mon, 8 Sep 2025 15:45:07 GMT, fabioromano1 wrote:
>> This PR implements nth root computation for BigIntegers using Newton method.
>
> fabioromano1 has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Removed MBI.valueOf(double)
@fabioromano1
On Mon, 8 Sep 2025 15:08:24 GMT, Raffaello Giulietti
wrote:
>> fabioromano1 has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Revision changes
>
> Personally I tend to remove code that is not used.
> I can't recall why it was added: there
On Mon, 8 Sep 2025 14:34:06 GMT, fabioromano1 wrote:
>> This PR implements nth root computation for BigIntegers using Newton method.
>
> fabioromano1 has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Revision changes
@jddarcy @fabioromano1 I
On Mon, 8 Sep 2025 14:58:19 GMT, Raffaello Giulietti
wrote:
>> fabioromano1 has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Revision changes
>
> @jddarcy @fabioromano1 It seems that `MutableBigInteger.valueOf()` is not
> used.
@rgiuli
> This PR implements nth root computation for BigIntegers using Newton method.
fabioromano1 has updated the pull request incrementally with one additional
commit since the last revision:
Revision changes
-
Changes:
- all: https://git.openjdk.org/jdk/pull/24898/files
- new: ht
> After 8339120, gcc began catching many different instances of unused code in
> the Windows specific codebase. Some of these seem to be bugs. I've taken the
> effort to mark out all the relevant globals and locals that trigger the
> unused warnings and addressed all of them by commenting out th
On Wed, 3 Sep 2025 20:17:50 GMT, Magnus Ihse Bursie wrote:
> Several java classes in java.base is generated from templates using SPP, the
> "Stream Preprocessor". Unfortunately much of this code is very old and has
> survived unchanged since pre-JDK 7. It does not follow modern makefile
> stan
On Mon, 8 Sept 2025 at 08:34, Per-Ake Minborg
wrote:
> I think there is a more general discussion to be had that should be aligned
> with the direction of the immutable collections and any potential constructs
> with deterministic order there.
I agree, because the direction of travel for Map.of
> Hi all,
>
> please review this change that implements (currently Draft) JEP: G1:
> Improve Application Throughput with a More Efficient Write-Barrier.
>
> The reason for posting this early is that this is a large change, and the JEP
> process is already taking very long with no end in sight
On Mon, 8 Sep 2025 01:22:46 GMT, erifan wrote:
>> test/micro/org/openjdk/bench/jdk/incubator/vector/VectorExtractBenchmark.java
>> line 34:
>>
>>> 32: @Warmup(iterations = 5, time = 1)
>>> 33: @Measurement(iterations = 5, time = 1)
>>> 34: @Fork(value = 1, jvmArgs = {"--add-modules=jdk.incubato
Stable Map Background
The iteration order of `StableValue.map()` is not specified, and the returned
map is not an instance of SequencedMap. The current implementation happens to
rely on Map.of() for which the iteration order of mappings is specified to be
unspecified and subject to change (i.e.,
On Sun, 3 Aug 2025 13:42:41 GMT, Tagir F. Valeev wrote:
>> Implementation of Comparator.min and Comparator.max methods. Preliminary
>> discussion is in this thread:
>> https://mail.openjdk.org/pipermail/core-libs-dev/2025-May/145638.html
>> The specification is mostly composed of Math.min/max an
31 matches
Mail list logo
