On Mon, 15 Sep 2025 05:37:58 GMT, Guanqiang Han wrote:
> trivial fix
Marked as reviewed by fandreuzzi (Author).
-
PR Review: https://git.openjdk.org/jdk/pull/27280#pullrequestreview-3223443676
On Tue, 16 Sep 2025 22:03:54 GMT, Brian Burkhalter wrote:
>> `File.getCanonicalPath` invokes `GetFinalPathNameByHandle` on the result of
>> `canonicalize0` which causes the drive letter of a mapped drive to be
>> converted to a UNC prefix. If such a substitution is detected, this request
>> pr
On Mon, 1 Sep 2025 09:00:32 GMT, Francesco Andreuzzi wrote:
> In this PR I introduce some constants in `StackMapGenerator`. No change in
> logic is expected.
>
> Passes tests in `jdk/classfile`.
This pull request has now been integrated.
Changeset: 8a6b8751
Author: Frances
On Sat, 6 Sep 2025 13:55:03 GMT, Chen Liang wrote:
>> Francesco Andreuzzi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> inclusive
>
> Reviewer's note: This brings more parity with c++ veri
On Sat, 6 Sep 2025 13:22:56 GMT, Chen Liang wrote:
>> Francesco Andreuzzi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> inclusive
>
> src/java.base/share/classes/jdk/internal/classfile/impl/Stac
> In this PR I introduce some constants in `StackMapGenerator`. No change in
> logic is expected.
>
> Passes tests in `jdk/classfile`.
Francesco Andreuzzi has updated the pull request incrementally with one
additional commit since the last revision:
inclusive
--
> In this PR I introduce some constants in `StackMapGenerator`. No change in
> logic is expected.
>
> Passes tests in `jdk/classfile`.
Francesco Andreuzzi has updated the pull request incrementally with one
additional commit since the last revision:
Apply suggestions from
On Mon, 1 Sep 2025 09:00:32 GMT, Francesco Andreuzzi wrote:
> In this PR I introduce some constants in `StackMapGenerator`. No change in
> logic is expected.
>
> Passes tests in `jdk/classfile`.
Hi @liach, could you have a look at this PR since you opened the ticket?
-
In this PR I introduce some constants in `StackMapGenerator`. No change in
logic is expected.
Passes tests in `jdk/classfile`.
-
Commit messages:
- nn
- Merge branch 'master' into JDK-8354871
- constants
Changes: https://git.openjdk.org/jdk/pull/27029/files
Webrev: https://web
On Fri, 29 Aug 2025 20:12:42 GMT, Francesco Andreuzzi wrote:
> [JDK-8342868](https://bugs.openjdk.org/browse/JDK-8342868) commented out code
> rather than removing it. The code can be removed safely, as pointed out in
> the PR review: #21654.
This pull request has now been i
[JDK-8342868](https://bugs.openjdk.org/browse/JDK-8342868) commented out code
rather than removing it. The code can be removed safely, as pointed out in the
PR review: #21654.
-
Commit messages:
- remove commented code
Changes: https://git.openjdk.org/jdk/pull/27012/files
Webrev
On Fri, 29 Aug 2025 15:13:52 GMT, Brian Burkhalter wrote:
>> src/java.base/share/classes/java/io/File.java line 85:
>>
>>> 83: * Unless otherwise noted, {@linkplain java.nio.file##links
>>> symbolic links}
>>> 84: * are automatically redirected to the target of the link,
>>> whether they
>>
On Fri, 29 Aug 2025 15:01:51 GMT, Brian Burkhalter wrote:
> Attempt to improve the verbiage of the `java.io.File` specification to make
> it clearer whether a given method operates only on an abstract pathname or on
> the actual file system entry it denotes.
src/java.base/share/classes/java/io
On Wed, 27 Aug 2025 23:48:28 GMT, Naoto Sato wrote:
>> Providing a couple of utility methods using the "built-in" `Console`
>> implementation to support tools that require password input, such as
>> `keytool`, ensuring they work even when stdin is redirected.
>
> Naoto Sato has updated the pull
On Thu, 28 Aug 2025 01:14:20 GMT, Rui Li wrote:
> Backport of https://bugs.openjdk.org/browse/JDK-8361497
>
> Not clean due to the lack of https://bugs.openjdk.org/browse/JDK-8360884. The
> cherry pick conflict was caused by the a new test added in the JDK-8360884.,
> [code](https://github.com
On Tue, 19 Aug 2025 22:10:53 GMT, Alexander Matveev
wrote:
>> - Added following note for `--app-content` on macOS to help and man page:
>> `The value should be a directory with the "Resources" subdirectory (or any
>> other directory that is valid in the "Contents" directory of the application
On Thu, 7 Aug 2025 01:49:41 GMT, Guanqiang Han wrote:
> Clean up some stale comment references. Trivial changes.
src/hotspot/os/linux/os_linux.cpp line 4876:
> 4874: // flag set. If we don't set it, then careless 3rd party native code
> 4875: // might fork and exec without closing all app
On Tue, 5 Aug 2025 18:21:24 GMT, Roger Riggs wrote:
> The teardown of a Process launched by `ProcessBuilder` includes the closing
> of streams and ensuring the termination of the process is the responsibility
> of the caller. The `Process.close()` method provides a clear and obvious way
> to e
On Thu, 31 Jul 2025 22:08:50 GMT, Naoto Sato wrote:
>> src/java.base/share/classes/java/text/DecimalFormatSymbols.java line 1002:
>>
>>> 1000:
>>> 1001: if (loadNumberData(locale) instanceof Object[] d &&
>>> 1002: d[0] instanceof String[] numberElements) {
>>
>> Should the
On Thu, 31 Jul 2025 18:41:47 GMT, Naoto Sato wrote:
> Enabling lenient minus sign matching when parsing numbers. In some locales,
> e.g. Finnish, the default minus sign is the Unicode "Minus Sign" (U+2212),
> which is not the "Hyphen Minus" (U+002D) that users type in from keyboard.
> Thus the
20 matches
Mail list logo
