On Tue, 19 Aug 2025 22:10:53 GMT, Alexander Matveev <almat...@openjdk.org>
wrote:
>> - Added following note for `--app-content` on macOS to help and man page:
>> `The value should be a directory with the "Resources" subdirectory (or any
>> other directory that is valid in the "Contents" directory of the application
>> bundle). Otherwise, jpackage may produce invalid application bundle which
>> may fail code signing and/or notarization.`
>> - Added warning if `--app-content` if it points to non-standard subdirectory
>> in "Contents" directory.
>> - Added test to cover warning message.
>
> Alexander Matveev has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8356218: [macos] Document --app-content [v2]
src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/MacApplicationBuilder.java
line 130:
> 128: private static void validateAppContentDirs(Application app) {
> 129: for (var contentDir : app.contentDirs()) {
> 130: if (!CONTENTS_SUB_DIRS.stream()
You could replace `CONTENTS_SUB_DIRS` with a `Set<String>`, and the inspection
with `CONTENTS_SUB_DIRS.contains(contentDir.getFileName().toString())`.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26848#discussion_r2286752531
