On Tue, 3 Jan 2023 20:14:30 GMT, Justin Lu wrote:
>> Regression caused by the fix to
>> [JDK-8296239](https://bugs.openjdk.org/browse/JDK-8296239). The ISO 4217
>> Amendment 174 Update changes went into effect starting in 2023.
>>
>> _java/text/Format/NumberFormat/CurrencyFormat.java_ fails
On Mon, 2 Jan 2023 09:52:59 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which fixes the final few typos in
> test files in the core-libs area? This addresses the remaining core-libs
> related typos from the original PR https://github.com/openjdk/jdk/pull/10029.
Marked
On Mon, 19 Dec 2022 20:12:15 GMT, Roger Riggs wrote:
> Update javadoc examples to use try-with-resources and use javadoc snippet
> tags.
> The examples in ObjectInputStream and ObjectOutputStream get an update with
> try-with-resources and use of javadoc snippet tags.
> ObjectInputFilter is
On Fri, 9 Dec 2022 18:32:37 GMT, Naoto Sato wrote:
> The example in `Scanner` directly uses `System.in` which may cause unwanted
> behavior when the default charset and the console charset differ. Using
> `Console.reader()` is more appropriate. Also changed examples into snippets.
Looks good
On Thu, 1 Dec 2022 17:00:02 GMT, Liam Miller-Cushon wrote:
>> This causes jar to not compress the `META-INF/` directory entry, for
>> consistency with the handling of other directory entries and compliance with
>> `APPNOTE.TXT`, and for compatibility with other zip implementations.
>
> Liam
On Thu, 1 Dec 2022 01:29:40 GMT, Liam Miller-Cushon wrote:
>> This causes jar to not compress the `META-INF/` directory entry, for
>> consistency with the handling of other directory entries and compliance with
>> `APPNOTE.TXT`, and for compatibility with other zip implementations.
>
> Liam
On Thu, 1 Dec 2022 01:21:13 GMT, Liam Miller-Cushon wrote:
>> test/jdk/tools/jar/ManifestDirectoryCompression.java line 60:
>>
>>> 58: }
>>> 59: Files.delete(dir);
>>> 60: } catch (IOException e) {
>>
>> Have the method throw IOException and you do not need the
On Wed, 30 Nov 2022 22:09:22 GMT, Liam Miller-Cushon wrote:
>> This causes jar to not compress the `META-INF/` directory entry, for
>> consistency with the handling of other directory entries and compliance with
>> `APPNOTE.TXT`, and for compatibility with other zip implementations.
>
> Liam
On Wed, 30 Nov 2022 20:48:12 GMT, Brian Burkhalter wrote:
>> `java.io.InputStream::transferTo` could conceivably return a negative value
>> if the count of bytes transferred overflows a `long`. Modify the method to
>> limit the number of bytes transferred to `Long.MAX_VALUE` per invocation.
>
On Wed, 30 Nov 2022 18:48:30 GMT, Liam Miller-Cushon wrote:
> This causes jar to not compress the `META-INF/` directory entry, for
> consistency with the handling of other directory entries and compliance with
> `APPNOTE.TXT`, and for compatibility with other zip implementations.
I don't
On Wed, 30 Nov 2022 17:33:17 GMT, Brian Burkhalter wrote:
> > Can you check ZipInputStream.transferTo?
>
> That implementation just calls the overridden method, but the single sentence
> added to the `InputStream::transferTo` javadoc should probably be inserted
> here as well. Do you concur?
On Mon, 28 Nov 2022 17:53:43 GMT, Justin Lu wrote:
> Problem: Javadoc in Locale.lookup is incorrect. Javadoc should match the
> parameter arguments. See lines 3562-3563.
>
> Fix: For `@throws NullPointerException` replace `if priorityList or tags is
> null` with `if priorityList or locales is
On Mon, 28 Nov 2022 10:02:47 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which fixes the typos in the test
>> packages? @mernst submitted this as a separate PR
>> https://github.com/openjdk/jdk/pull/10029 but given the number of areas and
>> files that other PR
On Tue, 22 Nov 2022 00:50:51 GMT, Brent Christian wrote:
>> [JDK-8290036](https://bugs.openjdk.org/browse/JDK-8290036) documented the
>> shutdown sequence, noting that calling Runtime.halt() skips the shutdown
>> sequence and immediately terminates the VM. Thus, "threads' current methods
>>
On Fri, 18 Nov 2022 06:44:03 GMT, Jaikiran Pai wrote:
> Can I please get a review for this doc only change which fixes the javadoc of
> java.util.zip.Inflater class? As noted in
> https://bugs.openjdk.org/browse/JDK-8297129, there's a typo in the javadoc.
> This commit fixes that.
Marked as
On Thu, 17 Nov 2022 20:32:15 GMT, Brent Christian wrote:
>> [JDK-8290036](https://bugs.openjdk.org/browse/JDK-8290036) documented the
>> shutdown sequence, noting that calling Runtime.halt() skips the shutdown
>> sequence and immediately terminates the VM. Thus, "threads' current methods
>>
On Thu, 17 Nov 2022 19:25:42 GMT, Brent Christian wrote:
> [JDK-8290036](https://bugs.openjdk.org/browse/JDK-8290036) documented the
> shutdown sequence, noting that calling Runtime.halt() skips the shutdown
> sequence and immediately terminates the VM. Thus, "threads' current methods
> do
On Thu, 17 Nov 2022 19:39:09 GMT, Brian Burkhalter wrote:
> `try-with-resource` or `try-with-resources`?
Agree should be
[try-with-resources](https://docs.oracle.com/javase/8/docs/technotes/guides/language/try-with-resources.html)
-
PR: https://git.openjdk.org/jdk/pull/11218
On Wed, 9 Nov 2022 14:22:02 GMT, Raffaello Giulietti
wrote:
>> A small spec change to match established behavior.
>
> Raffaello Giulietti has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8296292: Document the default behavior of '$' in
On Mon, 3 Oct 2022 20:03:42 GMT, Justin Lu wrote:
> Problem: IANA Language subtag registry is outdated
> Fix: Updated from version 2022-03-02 to 2022-08-08 -> [IANA
> registry](https://www.iana.org/assignments/language-subtag-registry/language-subtag-registry)
Marked as reviewed by lancea
On Fri, 4 Nov 2022 18:13:23 GMT, Lance Andersen wrote:
> Please review the following PR which updates several of the ZipInputStream
> methods whose javadoc is inherited to clarify the methods are acting on the
> current ZIP Entry.
>
> There are no changes in behavior. The m
On Mon, 14 Nov 2022 21:00:16 GMT, Brian Burkhalter wrote:
> Nitpick: should the `InputStream` import precede that of `IOException`?
Gonna leave this as is as IntelliJ keeps changing it and not worth fighting
> src/java.base/share/classes/java/util/zip/ZipInputStream.java line 178:
>
>> 176:
en copied has been clarified and the remaining doc is the
> same.
Lance Andersen has updated the pull request incrementally with one additional
commit since the last revision:
Changed return to returns
-
Changes:
- all: https://git.openjdk.org/jdk/pull/10995
en copied has been clarified and the remaining doc is the
> same.
Lance Andersen has updated the pull request incrementally with one additional
commit since the last revision:
Remove always from available()
-
Changes:
- all: https://git.openjdk.org/jdk/pull/10995
On Mon, 14 Nov 2022 19:48:43 GMT, Alan Bateman wrote:
> The updated wording looks okay. One small thing is that I think it would be a
> bit better if the word "always" were dropped.
Removed always and just pushed another commit with that change. Thank you for
the feedback
-
PR:
On Mon, 14 Nov 2022 11:08:25 GMT, Lance Andersen wrote:
>> src/java.base/share/classes/java/util/zip/ZipInputStream.java line 179:
>>
>>> 177: * {@link #closeEntry()} has been called, otherwise always return
>>> 1.
>>> 178: * I thin
en copied has been clarified and the remaining doc is the
> same.
Lance Andersen has updated the pull request incrementally with one additional
commit since the last revision:
Additional wordsmithing on available()
-
Changes:
- all: https://git.openjdk.org/jdk/pull/10995
On Mon, 14 Nov 2022 07:17:01 GMT, Alan Bateman wrote:
> A comment from the PR has been pasted here :-)
> Ignoring that, the updated description for the "available" method looks okay
> but might be clearer to say that closeEntry has been called on the current
> entry.
whoops, fixed :-)
en copied has been clarified and the remaining doc is the
> same.
Lance Andersen has updated the pull request incrementally with one additional
commit since the last revision:
Remove rogue comment
-
Changes:
- all: https://git.openjdk.org/jdk/pull/10995/files
- new: https:
On Sat, 12 Nov 2022 12:27:30 GMT, Alan Bateman wrote:
> I think it will need to say that input stream for the current ZIP entry has
> been read to end of stream, or the ZIP entry has been closed with closeEntry.
> That will cover the two cases where it returns 0.
Thank you Alan. I have
en copied has been clarified and the remaining doc is the
> same.
Lance Andersen has updated the pull request incrementally with one additional
commit since the last revision:
Tweak available() javadoc
-
Changes:
- all: https://git.openjdk.org/jdk/pull/10995
On Fri, 11 Nov 2022 17:46:08 GMT, Alan Bateman wrote:
> I think it would be useful to generate the javadoc and see if there are
> terminology or wording differences between the existing and new descriptions
> being copied down from input stream.
>
> For example, the no-arg read is "Reads a
en copied has been clarified and the remaining doc is the
> same.
Lance Andersen has updated the pull request incrementally with one additional
commit since the last revision:
Updated a javadoc for more consistentcy
-
Changes:
- all: https://git.openjdk.org/jdk/pull/10995
On Fri, 11 Nov 2022 12:22:32 GMT, Alan Bateman wrote:
>> Lance Andersen has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Addressed latest set of input on the javadoc
>
> src/java.base/share/classes/java/uti
On Fri, 4 Nov 2022 18:13:23 GMT, Lance Andersen wrote:
> Please review the following PR which updates several of the ZipInputStream
> methods whose javadoc is inherited to clarify the methods are acting on the
> current ZIP Entry.
>
> There are no changes in behavior. The m
en copied has been clarified and the remaining doc is the
> same.
Lance Andersen has updated the pull request incrementally with one additional
commit since the last revision:
Addressed latest set of input on the javadoc
-
Changes:
- all: https://git.openjdk.org/jdk/pul
On Thu, 10 Nov 2022 01:10:13 GMT, Jonathan Gibbons wrote:
> Please review a "somewhat automated" change to insert `@spec` tags into doc
> comments, as appropriate, to leverage the recent new javadoc feature to
> generate a new page listing the references to all external specifications
>
On Mon, 7 Nov 2022 10:08:16 GMT, Jaikiran Pai wrote:
>> src/java.base/share/classes/java/util/zip/ZipInputStream.java line 210:
>>
>>> 208: * Reads all remaining bytes from the input stream for the current
>>> ZIP entry.
>>> 209: * This method blocks until all remaining bytes have
On Mon, 7 Nov 2022 09:58:03 GMT, Jaikiran Pai wrote:
>> Please review the following PR which updates several of the ZipInputStream
>> methods whose javadoc is inherited to clarify the methods are acting on
>> the current ZIP Entry.
>>
>> There are no changes in behavior. The main
Please review the following PR which updates several of the ZipInputStream
methods whose javadoc is inherited to clarify the methods are acting on the
current ZIP Entry.
There are no changes in behavior. The main description for the method's
javadoc that has been copied has been clarified
On Wed, 2 Nov 2022 14:04:45 GMT, Lance Andersen wrote:
> Hi
>
> Please review this update to the jar man page which removes the "=" for the
> non GNU style options
>
> Best
> Lance
This pull request has now been integrated.
Changeset: 68209adf
Author:La
On Wed, 2 Nov 2022 12:37:26 GMT, Lance Andersen wrote:
> Hi all,
>
> This PR will update the javadoc to clarify the existing behavior of
> InflaterInputStream::fill as it currently omits the possibility that a
> EOFException may be thrown and that the protected `len` field
On Wed, 2 Nov 2022 20:12:04 GMT, Alan Bateman wrote:
> Thanks for the update, this wording looks okay, I'm just wondering if we
> should add implSpec as "This method will read ..." is really "Implementation
> Specification".
Sure thing added the tag
-
PR:
> Hi all,
>
> This PR will update the javadoc to clarify the existing behavior of
> InflaterInputStream::fill as it currently omits the possibility that a
> EOFException may be thrown and that the protected `len` field is also updated
> by this method.
Lance Andersen ha
On Wed, 2 Nov 2022 20:00:55 GMT, Joe Wang wrote:
>> Fixed an issue where the condition check for limit=0 was missed.
>
> Joe Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> source changes
Looks fine as discussed
-
On Wed, 2 Nov 2022 19:32:47 GMT, Joe Wang wrote:
> Fixed an issue where the condition check for limit=0 was missed.
Marked as reviewed by lancea (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/10958
> Hi all,
>
> This PR will update the javadoc to clarify the existing behavior of
> InflaterInputStream::fill as it currently omits the possibility that a
> EOFException may be thrown and that the protected `len` field is also updated
> by this method.
Lance Andersen ha
> Hi all,
>
> This PR will update the javadoc to clarify the existing behavior of
> InflaterInputStream::fill as it currently omits the possibility that a
> EOFException may be thrown and that the protected `len` field is also updated
> by this method.
Lance Andersen ha
On Wed, 2 Nov 2022 17:17:40 GMT, Alan Bateman wrote:
> I don't think an apiNote will work here as it need to be normative text. I
> suspect this issue will require specifying fill to read up to buf.length
> bytes into buf starting at element 0 and setting len to the number of bytes.
Revised
> Hi all,
>
> This PR will update the javadoc to clarify the existing behavior of
> InflaterInputStream::fill as it currently omits the possibility that a
> EOFException may be thrown and that the protected `len` field is also updated
> by this method.
Lance Andersen ha
Hi
Please review this update to the jar man page which removes the "=" for the non
GNU style options
Best
Lance
-
Commit messages:
- add space for -i option
- add space between option
- address typos in jar man page
Changes: https://git.openjdk.org/jdk/pull/10947/files
Hi all,
This PR will update the javadoc to clarify the existing behavior of
InflaterInputStream::fill as it currently omits the possibility that a
EOFException may be thrown and that the protected `len` field is also updated
by this method.
-
Commit messages:
- Clarify the
On Mon, 31 Oct 2022 17:50:47 GMT, Justin Lu wrote:
>> Issue: Duplication of methods between Basic*.java test classes, due to auto
>> generation by genBasic.sh
>>
>> Fix: Reorganize parts of Basic-X.java.template into base class in
>> Basic.java. Toggled -nel flag for generation script
On Wed, 26 Oct 2022 21:00:43 GMT, Justin Lu wrote:
>> Issue: java/util/Formatter/Basic regression test emits lots of warning
>> messages (~60).
>>
>> Fix: Made adjustments to Basic-X.java.template as the BasicXXX.java files
>> where the errors originate from are generated from the template.
On Mon, 24 Oct 2022 16:37:56 GMT, Justin Lu wrote:
>> Issue: Resource bundle name does not follow proper naming conventions
>> according to [getBundle
>>
On Mon, 24 Oct 2022 17:54:20 GMT, Brent Christian wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Use data provider for getBundle test
>
> test/jdk/javax/sql/resourceBundleTests/ValidateGetBundle.java line 81:
>
>>
On Fri, 21 Oct 2022 17:35:22 GMT, Justin Lu wrote:
>> Issue: Resource bundle name does not follow proper naming conventions
>> according to [getBundle
>>
On Wed, 19 Oct 2022 16:45:12 GMT, Lance Andersen wrote:
> Hi all,
>
> Please review this PR which will update the Zlib Data Compression Library
> from 1.2.11 to 1.2.13.
>
> - I have run all of the Mach5 tiers which did not show any issues related to
> the upgrade.
>
On Thu, 20 Oct 2022 19:56:04 GMT, Justin Lu wrote:
>> Issue: Formatter unit tests are launched via basic.sh
>>
>> Fix: Replace basic.sh with a Java test launcher
>>
>> Note: Java.internal.math was included in the original configuration of
>> Basic, but I removed it as it was not used within
On Thu, 20 Oct 2022 02:02:40 GMT, Jaikiran Pai wrote:
>> Hi all,
>>
>> Please review this PR which will update the Zlib Data Compression Library
>> from 1.2.11 to 1.2.13.
>>
>> - I have run all of the Mach5 tiers which did not show any issues related to
>> the upgrade.
>> - The JCK zip/jar
On Wed, 19 Oct 2022 18:02:45 GMT, Alan Bateman wrote:
> Can you confirm that this is exactly the 1.2.13 code, no patches/changes,
> right?
That is correct, there are no patches on top of the 1.2.13
-
PR: https://git.openjdk.org/jdk/pull/10773
Hi all,
Please review this PR which will update the Zlib Data Compression Library from
1.2.11 to 1.2.13.
- I have run all of the Mach5 tiers which did not show any issues related to
the upgrade.
- The JCK zip/jar tests also continue to pass.
- Jai ran his macOS aarch64 test(for
On Tue, 18 Oct 2022 20:59:41 GMT, Joe Darcy wrote:
>> "the the" -> "the"
>>
>> I'll reflow the paragraph before pushing.
>
> Joe Darcy has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Reflow
looks looks good good ;-)
-
On Tue, 18 Oct 2022 17:36:24 GMT, Brent Christian wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Use data provider, drop exception
>
> test/jdk/java/util/Formatter/BasicTestLauncher.java line 35:
>
>> 33: *
On Tue, 18 Oct 2022 17:28:49 GMT, Brent Christian wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Use data provider, drop exception
>
> test/jdk/java/util/Formatter/BasicTestLauncher.java line 47:
>
>> 45:
On Tue, 18 Oct 2022 17:05:08 GMT, Justin Lu wrote:
>> Issue: Formatter unit tests are launched via basic.sh
>>
>> Fix: Replace basic.sh with a Java test launcher
>>
>> Note: Java.internal.math was included in the original configuration of
>> Basic, but I removed it as it was not used within
On Tue, 18 Oct 2022 17:26:52 GMT, Brent Christian wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Use data provider, drop exception
>
> test/jdk/java/util/Formatter/Basic.java line 93:
>
>> 91:
On Fri, 14 Oct 2022 20:38:32 GMT, Justin Lu wrote:
> Issue: Formatter unit tests are launched via basic.sh
>
> Fix: Replace basic.sh with a Java test launcher
>
> Note: Java.internal.math was included in the original configuration of Basic,
> but I removed it as it was not used within the
On Wed, 12 Oct 2022 20:03:05 GMT, Naoto Sato wrote:
> Fixed to utilize `StaticProperty` so that the system property value for
> `java.locale.useOldISOCodes` set on the command line is honored even with
> lazy `Locale` initialization.
Marked as reviewed by lancea (Reviewer).
-
On Tue, 11 Oct 2022 17:11:49 GMT, Pavel Rappo wrote:
> Please review this utmost trivial fix for an issue discovered while working
> on something else in jdk.javadoc. As far as I can see, this is the only case
> of `{@inheritDoc}` not being the sole content of a `@throws` description in
>
On Thu, 6 Oct 2022 20:43:30 GMT, Justin Lu wrote:
>> Problem: Outdated doc does not match code. Claimed to throw exception and
>> compared to Long method.
>> Fix: Update doc to match code, compared to Double.parseDouble() accordingly.
>
> Justin Lu has updated the pull request incrementally
On Wed, 5 Oct 2022 21:26:09 GMT, Justin Lu wrote:
>> Problem: Outdated doc does not match code. Claimed to throw exception and
>> compared to Long method.
>> Fix: Update doc to match code, compared to Double.parseDouble() accordingly.
>
> Justin Lu has updated the pull request incrementally
On Wed, 5 Oct 2022 20:49:52 GMT, Justin Lu wrote:
>> Problem: Outdated doc does not match code. Claimed to throw exception and
>> compared to Long method.
>> Fix: Update doc to match code, compared to Double.parseDouble() accordingly.
>
> Justin Lu has updated the pull request incrementally
On Fri, 30 Sep 2022 20:08:10 GMT, Justin Lu wrote:
>> Problem: Unnecessary instances of StringBuffer within java.text (internal
>> only)
>>
>> Fix: StringBuffer Replaced with StringBuilder, and adjusted variable/method
>> names
>
> Justin Lu has updated the pull request incrementally with two
On Thu, 29 Sep 2022 22:29:10 GMT, Naoto Sato wrote:
> > Understand, I guess I don't see the difference from moving the tags to the
> > actual test but there could be a subtlety I am missing (wouldn't be the
> > first time ;-) )
>
> The runner has a @library/@build tag to build the test case
On Thu, 29 Sep 2022 23:19:16 GMT, Justin Lu wrote:
> Problem: Amendment number outdated
>
> Fix: Update amendment number + date in properties file and test case data file
looks good to me
-
Marked as reviewed by lancea (Reviewer).
PR: https://git.openjdk.org/jdk/pull/10499
On Thu, 29 Sep 2022 22:07:48 GMT, Naoto Sato wrote:
> AFAICT, the reason is described in the test class description, i.e., tweak to
> be in `java.text` package so that it can test the internal `hashCode` method.
Understand, I guess I don't see the difference from moving the tags to the
actual
On Thu, 29 Sep 2022 22:15:00 GMT, Justin Lu wrote:
>> Problem: Unnecessary instances of StringBuffer within java.text (internal
>> only)
>>
>> Fix: StringBuffer Replaced with StringBuilder, and adjusted variable/method
>> names
>
> Justin Lu has updated the pull request incrementally with one
On Thu, 29 Sep 2022 21:49:05 GMT, Brent Christian wrote:
> > should we update
> > test/jdk/sun/text/IntHashtable/patch-src/java.base/java/text/Bug4170614Test.java
> > to include `@test, @bug, @run, @summary`?
>
> ```
> /*
> (this test doesn't have an at-test tag because it's run by
>
On Wed, 28 Sep 2022 22:54:33 GMT, Justin Lu wrote:
> Problem: Unnecessary instances of StringBuffer within java.text (internal
> only)
>
> Fix: StringBuffer Replaced with StringBuilder, and adjusted variable/method
> names
Looks good.
should we update
On Fri, 26 Aug 2022 15:48:55 GMT, Lance Andersen wrote:
> Please review this PR which updates the JarInputStream class description to
> clarify when the Manifest is accessible via JarInputStream::getManifest and
> JarInputStream::get[Jar]Entry.
>
> It is worth noting that w
On Mon, 26 Sep 2022 19:12:16 GMT, Andrey Turbanov wrote:
> Found this redundant suppressions by IntelliJ IDEA inspection.
> Seems initially `Chronology` was generic class?
Marked as reviewed by lancea (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/10433
On Mon, 26 Sep 2022 18:25:34 GMT, Justin Lu wrote:
> Problem: Unnecessary instances of StringBuffer + .toString()
>
> Fix: StringBuffer Replaced with StringBuilder, and .toString() removed when
> possible
>
> Other: Line 698 in RuleBasedCollator.java also uses a .toString() conversion,
> but
On Sat, 17 Sep 2022 21:43:04 GMT, Andrey Turbanov wrote:
> There a few unnecessary usages of StringBuffer in SQLOutputImpl class.
> All of them create StringBuffer from single character and then concatenate
> with String. Instead of this, we can concatenate character directly.
The changes seem
On Mon, 26 Sep 2022 16:51:36 GMT, Michael Ernst wrote:
>> 8294321: Fix typos in files under test/jdk/java, test/jdk/jdk, test/jdk/jni
>
> Michael Ernst has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains six commits:
>
> - Reinstate
On Tue, 30 Aug 2022 09:31:07 GMT, Alan Bateman wrote:
>> 8294321: Fix typos in files under test/jdk/java, test/jdk/jdk, test/jdk/jni
>
> src/java.base/share/native/libzip/zlib/zlib.h line 756:
>
>> 754:If this is done, the old level and strategy will be applied to the
>> data
>> 755:
On Fri, 23 Sep 2022 17:38:47 GMT, Sean Mullan wrote:
> As a side comment, I notice that `JarInputStream` capitalizes "JAR", whereas
> `JarFile` does not ("jar"). We should really be consistent in our javadocs. I
> think "JAR" is more correct, mainly because that is what the Jar File
>
On Wed, 21 Sep 2022 09:23:31 GMT, Alan Bateman wrote:
> > Assuming we are set with the other changes, did you want to add the
> > following paragraph (or similar) at line 58 to make it clear that if the
> > Manifest is not found, then the JarEntry attributes will not be available:
>
> This is
On Tue, 20 Sep 2022 17:47:03 GMT, Lance Andersen wrote:
>> Please review this PR which updates the JarInputStream class description to
>> clarify when the Manifest is accessible via JarInputStream::getManifest and
>> JarInputStream::get[Jar]Entry.
>>
On Tue, 20 Sep 2022 17:53:27 GMT, Sean Mullan wrote:
> Now that this API has a section about signed JARs, I think it is very
> important to include the following sentences which are copied from `JarFile`:
>
> "Please note that the verification process does not include validating the
>
or that dates back to when this class was added to JDK 1.2
>
>
> Best,
> Lance
Lance Andersen has updated the pull request incrementally with one additional
commit since the last revision:
Added the verification note from JarFile
-
Changes:
- all: https://git.op
On Tue, 20 Sep 2022 17:37:50 GMT, Alan Bateman wrote:
>>> > OK, will make another pass at this today
>>>
>>> I looked at the latest draft
>>> ([2bafc00](https://github.com/openjdk/jdk/commit/2bafc00cc462b7af3f724371ac1bef5fd99c989c)).
>>> I think it would help if the section "Verifying a
or that dates back to when this class was added to JDK 1.2
>
>
> Best,
> Lance
Lance Andersen has updated the pull request incrementally with one additional
commit since the last revision:
More wordsmithing to the signed jar section
-
Changes:
- all: https://git.op
or that dates back to when this class was added to JDK 1.2
>
>
> Best,
> Lance
Lance Andersen has updated the pull request incrementally with one additional
commit since the last revision:
Address comments regarding Verifying a JarInputStreams
-
Changes:
- all: ht
On Mon, 19 Sep 2022 20:30:48 GMT, Weijun Wang wrote:
> Does this mean that the "Verifying a JarInputStream" should also avoid
> mentioning "getManifest method returns the manifest"? I understand precisely
> it should be "getManifest method is able to return the manifest if you call
> it".
On Tue, 20 Sep 2022 06:56:49 GMT, Alan Bateman wrote:
>>> I realise you've had a few iterations with Max on this section but I'm
>>> concerned that the text is telling the reader that they should use the
>>> 2-arg constructor to verify the signatures when a JAR is signed. The
>>> default is
On Mon, 19 Sep 2022 19:26:53 GMT, Sean Mullan wrote:
>> Lance Andersen has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Minor clarification for verifying an JarInputStream
>
> src/java.base/share/classes/jav
On Mon, 19 Sep 2022 20:04:18 GMT, Lance Andersen wrote:
>> Please review this PR which updates the JarInputStream class description to
>> clarify when the Manifest is accessible via JarInputStream::getManifest and
>> JarInputStream::get[Jar]Entry.
>>
or that dates back to when this class was added to JDK 1.2
>
>
> Best,
> Lance
Lance Andersen has updated the pull request incrementally with one additional
commit since the last revision:
Address Sean's input
-
Changes:
- all: https://git.openjdk.org/jdk/p
On Mon, 19 Sep 2022 06:34:00 GMT, Alan Bateman wrote:
> > I can remove, but I am not sure I agree we need to describe main vs
> > attribute here given we are pointing to the Jar spec and if there is any
> > discussion of Pre-entry attributes, it should be in JarEntry IMHO. I guess
> > the
401 - 500 of 579 matches
Mail list logo
