On Wed, 4 Jan 2023 08:48:56 GMT, Per Minborg wrote:
> Currently, `java.io.Bits` is using explicit logic to read/write various
> primitive types to/from byte arrays. Switching to the use of `VarHandle`
> access would provide better performance and less code.
>
> Also, using
Currently, `java.io.Bits` is using explicit logic to read/write various
primitive types to/from byte arrays. Switching to the use of `VarHandle` access
would provide better performance and less code.
Also, using a standard API for these conversions means future `VarHandle`
improvements will
On Tue, 13 Dec 2022 09:11:10 GMT, Per Minborg wrote:
> This PR suggests improving performance for read and write operations for the
> longer primitives in `RandomAccessFile`.
>
> These improvements would also propagate to other JDK classes relying on these
> improved `R
> This PR suggests improving performance for read and write operations for the
> longer primitives in `RandomAccessFile`.
>
> These improvements would also propagate to other JDK classes relying on these
> improved `RandomAccessFile` operations.
Per Minborg has updated t
> This PR suggests improving performance for read and write operations for the
> longer primitives in `RandomAccessFile`.
>
> These improvements would also propagate to other JDK classes relying on these
> improved `RandomAccessFile` operations.
Per Minborg has updated t
On Thu, 15 Dec 2022 10:43:35 GMT, Maurizio Cimadamore
wrote:
> This patch fixes some inconsistencies in the javadoc for restricted methods:
>
> * ModuleLayer.Controller::addEnableNativeAccess has a shorted text in its
> `@throws` clause. This shorted text is now used everywhere.
> * One
On Thu, 15 Dec 2022 09:56:37 GMT, Per Minborg wrote:
>> This PR suggests improving performance for read and write operations for the
>> longer primitives in `RandomAccessFile`.
>>
>> These improvements would also propagate to other JDK classes relying on
>> th
> This PR suggests improving performance for read and write operations for the
> longer primitives in `RandomAccessFile`.
>
> These improvements would also propagate to other JDK classes relying on these
> improved `RandomAccessFile` operations.
Per Minborg has updated t
On Wed, 14 Dec 2022 09:30:21 GMT, Per Minborg wrote:
> This PR proposes changing variable names from `session` to `scope`. The
> proposed changes are only for the FFM API and not other parts like the Vector
> API and test classes.
This pull request has now been integrated.
This PR proposes changing variable names from `session` to `scope`. The
proposed changes are only for the FFM API and not other parts like the Vector
API and test classes.
-
Commit messages:
- Replace session with scope for FFM access
Changes:
On Thu, 8 Dec 2022 14:11:29 GMT, Per Minborg wrote:
> This PR proposes changing variable names and text from "session" to "scope".
> The proposed changes are only for the FFM API and not other parts like the
> Vector API and test classes.
This pull request
On Mon, 12 Dec 2022 08:37:02 GMT, Per Minborg wrote:
> This PR proposes declaring `AArch64Architecture` and `X86_64Architecture`
> `final` and creating a `private` constructor so that this redundant byte code
> can be eliminated:
>
>
> public jdk.internal.foreign.abi.x64.
On Mon, 12 Dec 2022 08:37:02 GMT, Per Minborg wrote:
> This PR proposes declaring `AArch64Architecture` and `X86_64Architecture`
> `final` and creating a `private` constructor so that this redundant byte code
> can be eliminated:
>
>
> public jdk.internal.foreign.abi.x64.
> This PR suggests improving performance for read and write operations for the
> longer primitives in `RandomAccessFile`.
>
> These improvements would also propagate to other JDK classes relying on these
> improved `RandomAccessFile` operations.
Per Minborg has updated t
This PR suggests improving performance for read and write operations for the
longer primitives in `RandomAccessFile`.
These improvements would also propagate to other JDK classes relying on these
improved `RandomAccessFile` operations.
-
Commit messages:
- Perform I/O operations
On Mon, 12 Dec 2022 12:48:47 GMT, Per Minborg wrote:
> This PR proposes making a field in `RandomAccessFile` final. Also, it
> modernises a switch statement.
This pull request has now been integrated.
Changeset: 81f57d56
Author: Per Minborg
Committer: Roger Riggs
URL:
> This PR proposes making a field in `RandomAccessFile` final. Also, it
> modernises a switch statement.
Per Minborg has updated the pull request incrementally with one additional
commit since the last revision:
Remove redundant check
-
Changes:
- all: https://git.openj
> This PR proposes making a field in `RandomAccessFile` final. Also, it
> modernises a switch statement.
Per Minborg has updated the pull request incrementally with one additional
commit since the last revision:
Make the field rw final
-
Changes:
- all:
This PR proposes making a field in `RandomAccessFile` final. Also, it
modernises a switch statement.
-
Commit messages:
- Reclare field final and modernize switch
Changes: https://git.openjdk.org/jdk/pull/11632/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=11632=00
Issue:
This PR proposes declaring `AArch64Architecture` and `X86_64Architecture`
`final` and creating a `private` constructor so that this redundant byte code
can be eliminated:
public jdk.internal.foreign.abi.x64.X86_64Architecture();
Code:
0: aload_0
1: invokespecial #1 //
> This PR proposes changing variable names and text from "session" to "scope".
> The proposed changes are only for the FFM API and not other parts like the
> Vector API and test classes.
Per Minborg has updated the pull request incrementally with one additional
c
On Thu, 8 Dec 2022 14:36:52 GMT, Maurizio Cimadamore
wrote:
>> src/java.base/share/classes/jdk/internal/foreign/abi/Binding.java line 255:
>>
>>> 253: * the context's allocator is accessed.
>>> 254: */
>>> 255: public static Context ofScope() {
>>
>> I think
This PR proposes changing variable names and text from "session" to "scope".
The proposed changes are only for the FFM API and not other parts like the
Vector API and test classes.
-
Commit messages:
- Rename session to scope
Changes: https://git.openjdk.org/jdk/pull/11593/files
On Thu, 8 Dec 2022 08:17:44 GMT, Per Minborg wrote:
>> This PR suggests renaming various names from "session" to "scope" in
>> accordance with https://openjdk.org/jeps/434
>>
>> The PRs contains changes for several sub-components.
>
> Per
On Wed, 7 Dec 2022 21:55:43 GMT, Per Minborg wrote:
> This PR suggests renaming various names from "session" to "scope" in
> accordance with https://openjdk.org/jeps/434
>
> The PRs contains changes for several sub-components.
This pull request has been
> This PR suggests renaming various names from "session" to "scope" in
> accordance with https://openjdk.org/jeps/434
>
> The PRs contains changes for several sub-components.
Per Minborg has updated the pull request incrementally with one additional
commit si
This PR suggests renaming various names from "session" to "scope" in accordance
with https://openjdk.org/jeps/434
The PRs contains changes for several sub-components.
-
Commit messages:
- Rename session to scope
Changes: https://git.openjdk.org/jdk/pull/11573/files
Webrev:
On Mon, 21 Nov 2022 10:53:07 GMT, Per Minborg wrote:
> This PR proposes the introduction of **guarding** of the use of
> `DirectBuffer::address` within the JDK. With the introduction of the Foreign
> Function and Memory access, it is possible to derive Buffer instances that
>
be guarded. It can be discussed if this is preferable or not.
>
> This PR spawns several areas of responsibility and so, I expect more than one
> reviewer before promoting the PR.
Per Minborg has updated the pull request with a new target base due to a merge
or a rebase. The pull request now co
On Tue, 29 Nov 2022 09:40:58 GMT, Per Minborg wrote:
>> This PR proposes the introduction of **guarding** of the use of
>> `DirectBuffer::address` within the JDK. With the introduction of the Foreign
>> Function and Memory access, it is possible to derive Buffer instances t
be guarded. It can be discussed if this is preferable or not.
>
> This PR spawns several areas of responsibility and so, I expect more than one
> reviewer before promoting the PR.
Per Minborg has updated the pull request incrementally with one additional
commit since the last revision:
Rem
On Mon, 28 Nov 2022 19:35:24 GMT, Paul Sandoz wrote:
> I prefer methods that do not expose the scope implementation so access is
> limited to just to the acquire/release methods, but i am unsure of the
> performance implications. These methods might not reliably inline, and we may
> need to
On Wed, 23 Nov 2022 17:33:06 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-434 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] -
ss` method, that the use of the returned
> address needs to be guarded. It can be discussed if this is preferable or not.
>
> This PR spawns several areas of responsibility and so, I expect more than one
> reviewer before promoting the PR.
Per Minborg has updated the pull request incrementa
ss` method, that the use of the returned
> address needs to be guarded. It can be discussed if this is preferable or not.
>
> This PR spawns several areas of responsibility and so, I expect more than one
> reviewer before promoting the PR.
Per Minborg has updated the pull request incremental
On Thu, 24 Nov 2022 16:21:42 GMT, Per Minborg wrote:
>> This PR proposes the introduction of **guarding** of the use of
>> `DirectBuffer::address` within the JDK. With the introduction of the Foreign
>> Function and Memory access, it is possible to derive Buffer instances t
On Wed, 16 Nov 2022 15:02:08 GMT, Per Minborg wrote:
> This PR proposes to opt in for graphic rendering of the sealed hierarchy of
> the ConstantDesc class.
>
> Rendering capability was added via https://bugs.openjdk.org/browse/JDK-8295653
>
>
> Here is how it would
On Wed, 16 Nov 2022 16:17:01 GMT, Per Minborg wrote:
> This PR proposes to opt in for graphic rendering of the sealed hierarchy of
> the CallSite class.
>
> Rendering capability was added via https://bugs.openjdk.org/browse/JDK-8295653
>
> Here is how it would look like
On Wed, 16 Nov 2022 16:52:50 GMT, Per Minborg wrote:
> This PR proposes to opt in for graphic rendering of the sealed hierarchy of
> the `Reference` class.
>
> Rendering capability was added via https://bugs.openjdk.org/browse/JDK-8295653
>
> Here is how it would look like
ss` method, that the use of the returned
> address needs to be guarded. It can be discussed if this is preferable or not.
>
> This PR spawns several areas of responsibility and so, I expect more than one
> reviewer before promoting the PR.
Per Minborg has updated the pull request incrementally
On Thu, 24 Nov 2022 12:06:44 GMT, Alan Bateman wrote:
>> Per Minborg has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove redundant method
>
> src/java.base/share/classes/sun/nio/ch/IOUtil.java l
On Thu, 24 Nov 2022 11:58:12 GMT, Maurizio Cimadamore
wrote:
>> Separately, also (optional) stylistic: the indenting on this and following
>> class is a bit odd. There is a certain tendency to compress lines - e.g. to
>> reach for one-liners, when in reality the body is not that trivial. If I
ss` method, that the use of the returned
> address needs to be guarded. It can be discussed if this is preferable or not.
>
> This PR spawns several areas of responsibility and so, I expect more than one
> reviewer before promoting the PR.
Per Minborg has updated the pull request incrementall
On Wed, 23 Nov 2022 16:14:52 GMT, Maurizio Cimadamore
wrote:
>> Per Minborg has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Cleanup
>
> src/java.base/share/classes/jdk/internal/access/JavaNioAccess.java li
ss` method, that the use of the returned
> address needs to be guarded. It can be discussed if this is preferable or not.
>
> This PR spawns several areas of responsibility and so, I expect more than one
> reviewer before promoting the PR.
Per Minborg has updated the pull request inc
ss` method, that the use of the returned
> address needs to be guarded. It can be discussed if this is preferable or not.
>
> This PR spawns several areas of responsibility and so, I expect more than one
> reviewer before promoting the PR.
Per Minborg has updated the pull request incrementally
ss` method, that the use of the returned
> address needs to be guarded. It can be discussed if this is preferable or not.
>
> This PR spawns several areas of responsibility and so, I expect more than one
> reviewer before promoting the PR.
Per Minborg has updated the pull request incrementally
On Tue, 22 Nov 2022 09:23:40 GMT, Maurizio Cimadamore
wrote:
>> Per Minborg has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Rework Acquisition
>
> src/java.base/share/classes/com/sun/crypto/provider/Galo
On Mon, 21 Nov 2022 20:06:20 GMT, Alan Bateman wrote:
>>> > Although this looks much simpler and concise, it means "a new object is
>>> > created for each invocation"
>>>
>>> My comment was actually to see if DirectBuffer could extend AutoCloseable
>>> so that the acquire returns "this" for
ss` method, that the use of the returned
> address needs to be guarded. It can be discussed if this is preferable or not.
>
> This PR spawns several areas of responsibility and so, I expect more than one
> reviewer before promoting the PR.
Per Minborg has updated the pull request incrementally
On Mon, 21 Nov 2022 14:07:38 GMT, Alan Bateman wrote:
>> Per Minborg has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Rename methods
>
> src/java.base/share/classes/java/util/zip/Adler32.java line 105:
&g
ss` method, that the use of the returned
> address needs to be guarded. It can be discussed if this is preferable or not.
>
> This PR spawns several areas of responsibility and so, I expect more than one
> reviewer before promoting the PR.
Per Minborg has updated the pull request incrementally
On Mon, 21 Nov 2022 14:14:14 GMT, Alan Bateman wrote:
>> Per Minborg has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Update src/java.base/share/classes/jdk/internal/access/JavaNioAccess.java
>>
ss` method, that the use of the returned
> address needs to be guarded. It can be discussed if this is preferable or not.
>
> This PR spawns several areas of responsibility and so, I expect more than one
> reviewer before promoting the PR.
Per Minborg has refreshed the contents of this pull r
ss` method, that the use of the returned
> address needs to be guarded. It can be discussed if this is preferable or not.
>
> This PR spawns several areas of responsibility and so, I expect more than one
> reviewer before promoting the PR.
Per Minborg has updated the pull request increment
On Mon, 21 Nov 2022 13:32:43 GMT, ExE Boss wrote:
>> Per Minborg has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Rename methods
>
> src/java.base/share/classes/sun/nio/ch/DirectBuffer.java line 4
ss` method, that the use of the returned
> address needs to be guarded. It can be discussed if this is preferable or not.
>
> This PR spawns several areas of responsibility and so, I expect more than one
> reviewer before promoting the PR.
Per Minborg has updated the pull request incremen
ss` method, that the use of the returned
> address needs to be guarded. It can be discussed if this is preferable or not.
>
> This PR spawns several areas of responsibility and so, I expect more than one
> reviewer before promoting the PR.
Per Minborg has updated the pull request incrementa
On Mon, 21 Nov 2022 12:19:21 GMT, Alan Bateman wrote:
>> maybe just `bufferLock` and and just `acquireBuffer` ?
>
> Would it be possible to re-examine acquireSession returning Runnable and
> acquireSessionAsAutoCloseable returning AutoCloseable. The naming is bit
> awkward at most of the use
ss` method, that the use of the returned
> address needs to be guarded. It can be discussed if this is preferable or not.
>
> This PR spawns several areas of responsibility and so, I expect more than one
> reviewer before promoting the PR.
Per Minborg has updated the pull request incremental
ss` method, that the use of the returned
> address needs to be guarded. It can be discussed if this is preferable or not.
>
> This PR spawns several areas of responsibility and so, I expect more than one
> reviewer before promoting the PR.
Per Minborg has updated the pull request incrementally with
On Mon, 21 Nov 2022 11:32:35 GMT, Alan Bateman wrote:
>> This PR proposes the introduction of **guarding** of the use of
>> `DirectBuffer::address` within the JDK. With the introduction of the Foreign
>> Function and Memory access, it is possible to derive Buffer instances that
>> are backed
On Mon, 21 Nov 2022 11:29:07 GMT, Alan Bateman wrote:
>> This PR proposes the introduction of **guarding** of the use of
>> `DirectBuffer::address` within the JDK. With the introduction of the Foreign
>> Function and Memory access, it is possible to derive Buffer instances that
>> are backed
This PR proposes the introduction of **guarding** of the use of
`DirectBuffer::address` within the JDK. With the introduction of the Foreign
Function and Memory access, it is possible to derive Buffer instances that are
backed by native memory that, in turn, can be closed asynchronously by the
On Wed, 16 Nov 2022 16:41:18 GMT, Joe Darcy wrote:
> Helpful improvement.
>
> Are the type names in the diagram links?
The diagram is an SVG image rendered via the DOT description language. I think,
in theory, it would be possible to add links. I did some experiments with this
but decided we
This PR proposes to opt in for graphic rendering of the sealed hierarchy of the
`Reference` class.
Rendering capability was added via https://bugs.openjdk.org/browse/JDK-8295653
Here is how it would look like:
This PR proposes to opt in for graphic rendering of the sealed hierarchy of the
CallSite class.
Rendering capability was added via https://bugs.openjdk.org/browse/JDK-8295653
Here is how it would look like:
This PR proposes to opt in for graphic rendering of the sealed hierarchy of the
ConstantDesc class.
Rendering capability was added via https://bugs.openjdk.org/browse/JDK-8295653
Here is how it would look like:
On Tue, 15 Nov 2022 12:34:43 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-434 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] -
On Tue, 15 Nov 2022 12:34:43 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-434 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] -
On Tue, 15 Nov 2022 12:34:43 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-434 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] -
On Tue, 15 Nov 2022 12:34:43 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-434 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] -
On Tue, 15 Nov 2022 12:34:43 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-434 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] -
On Tue, 15 Nov 2022 12:34:43 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-434 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] -
On Tue, 15 Nov 2022 14:49:30 GMT, Per Minborg wrote:
>> Maurizio Cimadamore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add `since` tag in Module/ModuleLayer preview methods
>
> src/java.base/s
On Tue, 15 Nov 2022 12:34:43 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-434 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] -
On Tue, 15 Nov 2022 12:34:43 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-434 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] -
On Tue, 15 Nov 2022 12:34:43 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-434 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] -
601 - 678 of 678 matches
Mail list logo
