On Thu, 24 Nov 2022 11:58:12 GMT, Maurizio Cimadamore <[email protected]>
wrote:
>> Separately, also (optional) stylistic: the indenting on this and following
>> class is a bit odd. There is a certain tendency to compress lines - e.g. to
>> reach for one-liners, when in reality the body is not that trivial. If I
>> were to write the code I'd insert a newline after the `{` and I'd also break
>> apart initialization (e.g. no two statements separated by `;` in the same
>> line).
>>
>> Also, I noted that you start the body of the record (e.g. `{`) on a new
>> line, which I also find odd.
>
> (to be clear, some of the above comments refer to the code that was already
> there before your changes)
I also found the above as a bit odd but tried to stick with the existing
implementation and style as much as possible.
-------------
PR: https://git.openjdk.org/jdk/pull/11260
