On Mon, 18 Jul 2022 18:19:48 GMT, Ryan Ernst wrote:
>> This commit adds additional clarification to the javadocs of
>> ModuleReader::list about needing to close the stream. The new wording is
>> similar to that used in Files::find and other similar methods.
>
> Ryan Ernst has updated the pull
On Mon, 18 Jul 2022 19:48:02 GMT, Mark Reinhold wrote:
> It’s odd to mix adding some advice to the Javadoc with adopting that advice
> in the code base. Consider opening a new issue and PR for the actual code
> changes.
[JDK-8290504][1] has been filed to track the implementation changes.
On Mon, 18 Jul 2022 18:19:48 GMT, Ryan Ernst wrote:
>> This commit adds additional clarification to the javadocs of
>> ModuleReader::list about needing to close the stream. The new wording is
>> similar to that used in Files::find and other similar methods.
>
> Ryan Ernst has updated the pull
> This commit adds additional clarification to the javadocs of
> ModuleReader::list about needing to close the stream. The new wording is
> similar to that used in Files::find and other similar methods.
Ryan Ernst has updated the pull request incrementally with two additional
commits since the
On Mon, 18 Jul 2022 14:06:00 GMT, Ryan Ernst wrote:
> This commit adds additional clarification to the javadocs of
> ModuleReader::list about needing to close the stream. The new wording is
> similar to that used in Files::find and other similar methods.
I relaxed the wording in
On Mon, 18 Jul 2022 14:53:19 GMT, Chris Hegarty wrote:
>> This commit adds additional clarification to the javadocs of
>> ModuleReader::list about needing to close the stream. The new wording is
>> similar to that used in Files::find and other similar methods.
>
>
On Mon, 18 Jul 2022 14:06:00 GMT, Ryan Ernst wrote:
> This commit adds additional clarification to the javadocs of
> ModuleReader::list about needing to close the stream. The new wording is
> similar to that used in Files::find and other similar methods.
Given the recommendation to close
On Mon, 18 Jul 2022 14:06:00 GMT, Ryan Ernst wrote:
> This commit adds additional clarification to the javadocs of
> ModuleReader::list about needing to close the stream. The new wording is
> similar to that used in Files::find and other similar methods.
This commit adds additional clarification to the javadocs of
ModuleReader::list about needing to close the stream. The new wording is
similar to that used in Files::find and other similar methods.
-
Commit messages:
- 8290353: Clarify the streams returned by ModuleReader::list
