Re: RFR: 8294961: Convert java.base/java.lang.reflect.ProxyGenerator to use the Classfile API to generate proxy classes [v5]

2024-01-08 Thread Adam Sotona
On Sun, 7 Jan 2024 18:16:05 GMT, Chen Liang wrote: >> Original code has been significant in profiler. >> >> >> MethodTypeDesc desc = MethodTypeDesc.of(toClassDesc(returnType), >> >> Arrays.stream(parameterTypes).map(ProxyGenerator::toClassDesc).toArray(ClassDesc[]::new));

Re: RFR: 8294961: Convert java.base/java.lang.reflect.ProxyGenerator to use the Classfile API to generate proxy classes [v5]

2024-01-07 Thread Chen Liang
On Wed, 3 Jan 2024 12:25:29 GMT, Adam Sotona wrote: >> src/java.base/share/classes/java/lang/reflect/ProxyGenerator.java line 737: >> >>> 735: private void generateMethod(ClassBuilder clb, ClassEntry >>> className) { >>> 736: var cp = clb.constantPool(); >>> 737:

Re: RFR: 8294961: Convert java.base/java.lang.reflect.ProxyGenerator to use the Classfile API to generate proxy classes [v5]

2024-01-03 Thread Adam Sotona
On Sun, 24 Dec 2023 03:14:44 GMT, Chen Liang wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> minor StackCounter fix > > src/java.base/share/classes/java/lang/reflect/ProxyGenerator.java line 737: > >> 735:

Re: RFR: 8294961: Convert java.base/java.lang.reflect.ProxyGenerator to use the Classfile API to generate proxy classes [v5]

2024-01-03 Thread Adam Sotona
On Sun, 24 Dec 2023 04:07:07 GMT, Chen Liang wrote: >> This code is part of the **ClassFile API**’s internals, and so it doesn’t >> have access to `ProxyGenerator`’s cached `MethodTypeDesc`s, only the  >> underlying `Utf8Entry`, so it’d need to be parsed. > > I see that now Class return type

Re: RFR: 8294961: Convert java.base/java.lang.reflect.ProxyGenerator to use the Classfile API to generate proxy classes [v5]

2023-12-23 Thread Chen Liang
On Sat, 23 Dec 2023 15:24:55 GMT, ExE Boss wrote: >> src/java.base/share/classes/jdk/internal/classfile/impl/StackCounter.java >> line 49: >> >>> 47: dcb, >>> 48: dcb.methodInfo.methodName(), >>> 49: dcb.methodInfo.methodType(), >> >> Can you

Re: RFR: 8294961: Convert java.base/java.lang.reflect.ProxyGenerator to use the Classfile API to generate proxy classes [v5]

2023-12-23 Thread Chen Liang
On Thu, 21 Dec 2023 13:32:12 GMT, Adam Sotona wrote: >> java.base java.lang.reflect.ProxyGenerator uses ASM to generate proxy >> classes. >> >> This patch converts it to use Classfile API. >> >> It is continuation of https://github.com/openjdk/jdk/pull/10991 >> >> Any comments and

Re: RFR: 8294961: Convert java.base/java.lang.reflect.ProxyGenerator to use the Classfile API to generate proxy classes [v5]

2023-12-23 Thread ExE Boss
On Sat, 23 Dec 2023 12:40:33 GMT, Chen Liang wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> minor StackCounter fix > > src/java.base/share/classes/jdk/internal/classfile/impl/StackCounter.java > line 49: > >>

Re: RFR: 8294961: Convert java.base/java.lang.reflect.ProxyGenerator to use the Classfile API to generate proxy classes [v5]

2023-12-23 Thread Chen Liang
On Thu, 21 Dec 2023 13:32:12 GMT, Adam Sotona wrote: >> java.base java.lang.reflect.ProxyGenerator uses ASM to generate proxy >> classes. >> >> This patch converts it to use Classfile API. >> >> It is continuation of https://github.com/openjdk/jdk/pull/10991 >> >> Any comments and

Re: RFR: 8294961: Convert java.base/java.lang.reflect.ProxyGenerator to use the Classfile API to generate proxy classes [v5]

2023-12-21 Thread Adam Sotona
> java.base java.lang.reflect.ProxyGenerator uses ASM to generate proxy classes. > > This patch converts it to use Classfile API. > > It is continuation of https://github.com/openjdk/jdk/pull/10991 > > Any comments and suggestions are welcome. > > Please review. > > Thank you, > Adam Adam

Re: RFR: 8294961: Convert java.base/java.lang.reflect.ProxyGenerator to use the Classfile API to generate proxy classes [v5]

2023-03-22 Thread Adam Sotona
On Thu, 9 Mar 2023 17:53:05 GMT, Mandy Chung wrote: >> Adam Sotona has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 195 commits: >> >> - Merge branch 'master' into JDK-8294961-proxy >> - Merge branch 'JDK-8294982' into