On Thu, 21 Dec 2023 13:32:12 GMT, Adam Sotona <asot...@openjdk.org> wrote:
>> java.base java.lang.reflect.ProxyGenerator uses ASM to generate proxy >> classes. >> >> This patch converts it to use Classfile API. >> >> It is continuation of https://github.com/openjdk/jdk/pull/10991 >> >> Any comments and suggestions are welcome. >> >> Please review. >> >> Thank you, >> Adam > > Adam Sotona has updated the pull request incrementally with one additional > commit since the last revision: > > minor StackCounter fix src/java.base/share/classes/jdk/internal/classfile/impl/StackCounter.java line 49: > 47: dcb, > 48: dcb.methodInfo.methodName(), > 49: dcb.methodInfo.methodType(), Can you enlighten me on why this actually leads to a performance improvement? Don't we already generate the methods with MethodTypeDesc symbols in ProxyGenerator so that they should be cached? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/17121#discussion_r1435592097
