Re: RFR: 8295017: Remove Windows specific workaround in JLI_Snprintf [v2]

2022-10-10 Thread Julian Waters
On Mon, 10 Oct 2022 05:06:00 GMT, David Holmes wrote: >> src/java.base/share/native/libjli/jli_util.h line 91: >> >>> 89: * https://learn.microsoft.com/en-us/cpp/c-runtime-library/reference >>> 90: * /snprintf-snprintf-snprintf-l-snwprintf-snwprintf-l?view=msvc-170 >>> 91: */ >> >> I don't

Re: RFR: 8295017: Remove Windows specific workaround in JLI_Snprintf [v2]

2022-10-09 Thread David Holmes
On Sun, 9 Oct 2022 17:58:37 GMT, Kim Barrett wrote: >> Julian Waters has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Comment formatting > > src/java.base/share/native/libjli/jli_util.h line 91: > >> 89: *

Re: RFR: 8295017: Remove Windows specific workaround in JLI_Snprintf [v2]

2022-10-09 Thread David Holmes
On Sun, 9 Oct 2022 08:17:15 GMT, Julian Waters wrote: >> The C99 snprintf is available with Visual Studio 2015 and above, alongside >> Windows 10 and the UCRT, and is no longer identical to the outdated Windows >> _snprintf. Since support for the Visual C++ 2017 compiler was removed a >>

Re: RFR: 8295017: Remove Windows specific workaround in JLI_Snprintf [v2]

2022-10-09 Thread Kim Barrett
On Sun, 9 Oct 2022 08:17:15 GMT, Julian Waters wrote: >> The C99 snprintf is available with Visual Studio 2015 and above, alongside >> Windows 10 and the UCRT, and is no longer identical to the outdated Windows >> _snprintf. Since support for the Visual C++ 2017 compiler was removed a >>

Re: RFR: 8295017: Remove Windows specific workaround in JLI_Snprintf [v2]

2022-10-09 Thread Julian Waters
> The C99 snprintf is available with Visual Studio 2015 and above, alongside > Windows 10 and the UCRT, and is no longer identical to the outdated Windows > _snprintf. Since support for the Visual C++ 2017 compiler was removed a while > ago, we can now safely remove the compatibility workaround