Re: RFR: 8303891: Speed up Zip64SizeTest using a small ZIP64 file [v6]

2024-02-09 Thread Eirik Bjørsnøs
On Fri, 9 Feb 2024 11:59:13 GMT, Lance Andersen wrote: > Again minor but perhaps articulate that after this call, the extra data will > be(obvious to you and I but probably not to others...) Added `zipdetails` describing the resulting ZIP64 structure to the `updateCENHeaderToZip64` method

Re: RFR: 8303891: Speed up Zip64SizeTest using a small ZIP64 file [v6]

2024-02-09 Thread Eirik Bjørsnøs
On Fri, 9 Feb 2024 11:55:16 GMT, Lance Andersen wrote: >> Eirik Bjørsnøs has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Spell fix for "Contents" >> - Add comments to explain how we temporarily use the 'unknown' tag to >> prevent

Re: RFR: 8303891: Speed up Zip64SizeTest using a small ZIP64 file [v6]

2024-02-09 Thread Eirik Bjørsnøs
On Fri, 9 Feb 2024 12:17:17 GMT, Eirik Bjørsnøs wrote: >> test/jdk/java/util/zip/ZipFile/Zip64SizeTest.java line 114: >> >>> 112: >>> 113: // Make an extra field with the correct size for an 8-byte >>> 'uncompressed size' >>> 114: // Zip64 field. Temporarily use the

Re: RFR: 8303891: Speed up Zip64SizeTest using a small ZIP64 file [v6]

2024-02-09 Thread Lance Andersen
On Fri, 9 Feb 2024 10:33:30 GMT, Eirik Bjørsnøs wrote: >> Please review this PR which suggests we speed up the `Zip64SizeTest` using a >> small-sized ZIP64 ZIP file specifically created to reproduce the issue being >> tested. >> >> The disk space requirement of this test is known to cause

Re: RFR: 8303891: Speed up Zip64SizeTest using a small ZIP64 file [v6]

2024-02-09 Thread Eirik Bjørsnøs
> Please review this PR which suggests we speed up the `Zip64SizeTest` using a > small-sized ZIP64 ZIP file specifically created to reproduce the issue being > tested. > > The disk space requirement of this test is known to cause problems in some > builds, see