On Fri, 23 Jun 2023 08:03:45 GMT, Artem Semenov wrote:
>> When using the clang compiler to build OpenJDk on Linux, we encounter
>> various "warnings as errors".
>> They can be fixed with small changes.
>
> Artem Semenov has updated the pull request incrementally with one additional
> commit sin
On Fri, 23 Jun 2023 06:19:31 GMT, Daniel Jeliński wrote:
>> make/modules/java.desktop/lib/Awt2dLibraries.gmk line 241:
>>
>>> 239: DISABLED_WARNINGS_gcc_OGLPaints.c :=
>>> format-nonliteral, \
>>> 240: DISABLED_WARNINGS_gcc_sun_awt_X11_GtkFileDialogPeer.c
>>> :=
> When using the clang compiler to build OpenJDk on Linux, we encounter various
> "warnings as errors".
> They can be fixed with small changes.
Artem Semenov has updated the pull request incrementally with one additional
commit since the last revision:
update
-
Changes:
- all:
On Thu, 22 Jun 2023 09:58:19 GMT, Daniel Jeliński wrote:
>> Artem Semenov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> update
>
> make/modules/java.desktop/lib/Awt2dLibraries.gmk line 241:
>
>> 239: DISABLED_WARNINGS_
> When using the clang compiler to build OpenJDk on Linux, we encounter various
> "warnings as errors".
> They can be fixed with small changes.
Artem Semenov has updated the pull request incrementally with one additional
commit since the last revision:
update
-
Changes:
- all:
On Thu, 22 Jun 2023 09:58:49 GMT, Daniel Jeliński wrote:
>> Artem Semenov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> update
>
> make/modules/java.desktop/lib/Awt2dLibraries.gmk line 260:
>
>> 258: DISABLED_WARNINGS_clang_ai
On Thu, 22 Jun 2023 09:13:21 GMT, Artem Semenov wrote:
>> When using the clang compiler to build OpenJDk on Linux, we encounter
>> various "warnings as errors".
>> They can be fixed with small changes.
>
> Artem Semenov has updated the pull request incrementally with one additional
> commit sin
On Wed, 21 Jun 2023 07:35:16 GMT, Daniel Jeliński wrote:
>> Artem Semenov has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains five commits:
>>
>> - update
>> - update
>> - update
>> - update
>> - 8308286 Fix clang warnings in lin
> When using the clang compiler to build OpenJDk on Linux, we encounter various
> "warnings as errors".
> They can be fixed with small changes.
Artem Semenov has updated the pull request incrementally with one additional
commit since the last revision:
update
-
Changes:
- all:
On Sun, 11 Jun 2023 16:38:31 GMT, Artem Semenov wrote:
>> When using the clang compiler to build OpenJDk on Linux, we encounter
>> various "warnings as errors".
>> They can be fixed with small changes.
>
> Artem Semenov has updated the pull request with a new target base due to a
> merge or a r
On Sun, 11 Jun 2023 16:38:31 GMT, Artem Semenov wrote:
>> When using the clang compiler to build OpenJDk on Linux, we encounter
>> various "warnings as errors".
>> They can be fixed with small changes.
>
> Artem Semenov has updated the pull request with a new target base due to a
> merge or a r
> When using the clang compiler to build OpenJDk on Linux, we encounter various
> "warnings as errors".
> They can be fixed with small changes.
Artem Semenov has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains five commits:
- update
-
On Tue, 6 Jun 2023 17:47:02 GMT, Weijun Wang wrote:
>> This is rarely used in the code and is not the essence of the current
>> changes.
>> If you introduce such changes, then throughout the code.
>> Moreover, this can lead to problems, such as, for example, here:
>> https://bugs.openjdk.org/br
On Thu, 1 Jun 2023 15:01:37 GMT, Artem Semenov wrote:
>> When using the clang compiler to build OpenJDk on Linux, we encounter
>> various "warnings as errors".
>> They can be fixed with small changes.
>
> Artem Semenov has updated the pull request incrementally with one additional
> commit sinc
On Tue, 6 Jun 2023 17:32:35 GMT, Artem Semenov wrote:
>> I didn't ask to revert the change. It's
>> `s/TARGET_OS_MAC/defined(__APPLE__)/`.
>
> This is rarely used in the code and is not the essence of the current changes.
> If you introduce such changes, then throughout the code.
> Moreover, thi
On Thu, 1 Jun 2023 15:04:09 GMT, Weijun Wang wrote:
>> done
>
> I didn't ask to revert the change. It's `s/TARGET_OS_MAC/defined(__APPLE__)/`.
This is rarely used in the code and is not the essence of the current changes.
If you introduce such changes, then throughout the code.
Moreover, this ca
On Wed, 31 May 2023 13:52:39 GMT, Weijun Wang wrote:
>> Artem Semenov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> update
>
> src/java.security.jgss/share/native/libj2gss/gssapi.h line 47:
>
>> 45:
>> 46: // Condition was copied fro
On Thu, 1 Jun 2023 15:02:16 GMT, Artem Semenov wrote:
>> src/java.security.jgss/share/native/libj2gss/gssapi.h line 47:
>>
>>> 45:
>>> 46: // Condition was copied from
>>> 47: //
>>> Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/gssapi/gssapi.h
>>
> When using the clang compiler to build OpenJDk on Linux, we encounter various
> "warnings as errors".
> They can be fixed with small changes.
Artem Semenov has updated the pull request incrementally with one additional
commit since the last revision:
update
-
Changes:
- all:
On Wed, 31 May 2023 13:37:06 GMT, Artem Semenov wrote:
>> When using the clang compiler to build OpenJDk on Linux, we encounter
>> various "warnings as errors".
>> They can be fixed with small changes.
>
> Artem Semenov has updated the pull request incrementally with one additional
> commit sin
On Tue, 30 May 2023 08:14:59 GMT, Alexey Ushakov wrote:
>> Artem Semenov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> update
>
> src/jdk.hotspot.agent/linux/native/libsaproc/ps_core.c line 655:
>
>> 653: // linker loaded it. We
On Sun, 28 May 2023 03:57:40 GMT, Kim Barrett wrote:
>> Artem Semenov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> update
>
> src/java.desktop/unix/native/libawt_xawt/awt/gtk2_interface.c line 1163:
>
>> 1161: #if defined(__clang__)
> When using the clang compiler to build OpenJDk on Linux, we encounter various
> "warnings as errors".
> They can be fixed with small changes.
Artem Semenov has updated the pull request incrementally with one additional
commit since the last revision:
update
-
Changes:
- all:
On Mon, 29 May 2023 22:29:26 GMT, Artem Semenov wrote:
>> When using the clang compiler to build OpenJDk on Linux, we encounter
>> various "warnings as errors".
>> They can be fixed with small changes.
>
> Artem Semenov has updated the pull request incrementally with one additional
> commit sin
> When using the clang compiler to build OpenJDk on Linux, we encounter various
> "warnings as errors".
> They can be fixed with small changes.
Artem Semenov has updated the pull request incrementally with one additional
commit since the last revision:
update
-
Changes:
- all:
On Wed, 17 May 2023 12:28:47 GMT, Artem Semenov wrote:
> When using the clang compiler to build OpenJDk on Linux, we encounter various
> "warnings as errors".
> They can be fixed with small changes.
All of the -Wformat-nonliteral changes make me wonder why we're seeing these
with clang but not
On Fri, 26 May 2023 07:48:06 GMT, Daniel Jeliński wrote:
> According to our docs, [clang is a supported compiler for
> Linux](https://github.com/openjdk/jdk/blob/master/doc/building.md#native-compiler-toolchain-requirements).
I think that's aspirational rather than actual. Clang has been inclu
On Wed, 17 May 2023 12:28:47 GMT, Artem Semenov wrote:
> When using the clang compiler to build OpenJDk on Linux, we encounter various
> "warnings as errors".
> They can be fixed with small changes.
According to our docs, [clang is a supported compiler for
Linux](https://github.com/openjdk/jdk
On Wed, 17 May 2023 12:28:47 GMT, Artem Semenov wrote:
> When using the clang compiler to build OpenJDk on Linux, we encounter various
> "warnings as errors".
> They can be fixed with small changes.
I don't like this approach at all. if github had a "reject" button I'd be
pushing it now.
updat
On Wed, 17 May 2023 12:28:47 GMT, Artem Semenov wrote:
> When using the clang compiler to build OpenJDk on Linux, we encounter various
> "warnings as errors".
> They can be fixed with small changes.
I would suggest either disable warnings on per file basis or rewrite
problematic code. Disabli
When using the clang compiler to build OpenJDk on Linux, we encounter various
"warnings as errors".
They can be fixed with small changes.
-
Commit messages:
- 8308286 Fix clang warnings in linux code
Changes: https://git.openjdk.org/jdk/pull/14033/files
Webrev: https://webrevs.ope
31 matches
Mail list logo
