On Mon, 11 Sep 2023 14:24:31 GMT, Martin Doerr wrote:
>@offamitkumar, @deepa181, @JoKern65, @TOatGithub: You may want to check
>performance impact on s390x and AIX.
@TheRealMDoerr Testing on s390 is not possible for now, as build is broken due
to field resolution changes.
-
PR
On Fri, 8 Sep 2023 20:36:31 GMT, 温绍锦 wrote:
>> [PR 14578 ](https://github.com/openjdk/jdk/pull/14578) still has unresolved
>> discussions, continue to make improvements.
>>
>> # Benchmark Result
>>
>>
>> sh make/devkit/createJMHBundle.sh
>> bash configure --with-jmh=build/jmh/jars
>> make
On Mon, 11 Sep 2023 13:32:07 GMT, Martin Doerr wrote:
>> 温绍锦 has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> lo | hi => hi | lo
>
> I have run a couple of tests on linux Big Endian. They have passed. So, it's
> probably correct.
On Sun, 10 Sep 2023 18:54:33 GMT, Roger Riggs wrote:
>> 温绍锦 has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> lo | hi => hi | lo
>
> Given the endian-ness issues with https://git.openjdk.org/jdk/pull/14699.
> I'll need to run a more
On Fri, 8 Sep 2023 20:36:31 GMT, 温绍锦 wrote:
>> [PR 14578 ](https://github.com/openjdk/jdk/pull/14578) still has unresolved
>> discussions, continue to make improvements.
>>
>> # Benchmark Result
>>
>>
>> sh make/devkit/createJMHBundle.sh
>> bash configure --with-jmh=build/jmh/jars
>> make
On Fri, 8 Sep 2023 20:36:31 GMT, 温绍锦 wrote:
>> [PR 14578 ](https://github.com/openjdk/jdk/pull/14578) still has unresolved
>> discussions, continue to make improvements.
>>
>> # Benchmark Result
>>
>>
>> sh make/devkit/createJMHBundle.sh
>> bash configure --with-jmh=build/jmh/jars
>> make
On Fri, 8 Sep 2023 20:36:31 GMT, 温绍锦 wrote:
>> [PR 14578 ](https://github.com/openjdk/jdk/pull/14578) still has unresolved
>> discussions, continue to make improvements.
>>
>> # Benchmark Result
>>
>>
>> sh make/devkit/createJMHBundle.sh
>> bash configure --with-jmh=build/jmh/jars
>> make
On Sun, 10 Sep 2023 15:59:05 GMT, 温绍锦 wrote:
>> Filed https://bugs.openjdk.org/browse/JDK-8315968 - we should also get
>> @JimLaskey to weigh in here (who's recently authored the `java.util.Digits`
>> code). Tl;dr: I think it'd be good to consolidate and share the code to
>> produce these
On Sun, 10 Sep 2023 15:19:51 GMT, Claes Redestad wrote:
>> Please help me create an issue, and I will submit a new PR to modify it.
>
> Filed https://bugs.openjdk.org/browse/JDK-8315968 - we should also get
> @JimLaskey to weigh in here (who's recently authored the `java.util.Digits`
> code).
On Sat, 9 Sep 2023 07:59:30 GMT, 温绍锦 wrote:
>> Perhaps you could extract the `digitPair` method you're adding in #1 to
>> a separate PR and use that to remove `HexDigits::DIGITS`?
>
> Please help me create an issue, and I will submit a new PR to modify it.
Filed
On Sat, 9 Sep 2023 07:11:01 GMT, Claes Redestad wrote:
>> src/java.base/share/classes/java/util/HexDigits.java line 42:
>>
>>> 40: * hex relative to its index, for example:
>>> 41: *
>>> 42: * 0 -> '00' -> '0' | ('0' << 8) -> 0x3030
>>
>> AFAICT this is now a copy of
On Sat, 9 Sep 2023 07:08:07 GMT, Claes Redestad wrote:
>> 温绍锦 has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> lo | hi => hi | lo
>
> src/java.base/share/classes/java/util/HexDigits.java line 42:
>
>> 40: * hex relative to its
On Fri, 8 Sep 2023 20:36:31 GMT, 温绍锦 wrote:
>> [PR 14578 ](https://github.com/openjdk/jdk/pull/14578) still has unresolved
>> discussions, continue to make improvements.
>>
>> # Benchmark Result
>>
>>
>> sh make/devkit/createJMHBundle.sh
>> bash configure --with-jmh=build/jmh/jars
>> make
On Fri, 8 Sep 2023 23:49:04 GMT, Chen Liang wrote:
>> src/java.base/share/classes/java/util/HexDigits.java line 66:
>>
>>> 64: */
>>> 65: @Stable
>>> 66: private static final short[] DIGITS;
>>
>> Maybe it should be `char[]` instead since it’s encoded using unsigned 16‑bit
>>
On Fri, 8 Sep 2023 21:06:25 GMT, ExE Boss wrote:
>> 温绍锦 has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> lo | hi => hi | lo
>
> src/java.base/share/classes/java/util/HexDigits.java line 66:
>
>> 64: */
>> 65: @Stable
>> 66:
On Fri, 8 Sep 2023 20:36:31 GMT, 温绍锦 wrote:
>> [PR 14578 ](https://github.com/openjdk/jdk/pull/14578) still has unresolved
>> discussions, continue to make improvements.
>>
>> # Benchmark Result
>>
>>
>> sh make/devkit/createJMHBundle.sh
>> bash configure --with-jmh=build/jmh/jars
>> make
> [PR 14578 ](https://github.com/openjdk/jdk/pull/14578) still has unresolved
> discussions, continue to make improvements.
>
> # Benchmark Result
>
>
> sh make/devkit/createJMHBundle.sh
> bash configure --with-jmh=build/jmh/jars
> make test TEST="micro:java.util.UUIDBench.toString"
>
>
> ##
17 matches
Mail list logo
