On Fri, 15 Sep 2023 20:24:35 GMT, Justin Lu wrote:
>> Please review this PR which is a continuation of
>> [JDK-6453901](https://bugs.openjdk.org/browse/JDK-6453901) to remove unused
>> code from the _sun.util.Calendar_ classes.
>>
>> `forceStandardTime` is always false.
>>
>> In addition,
On Sat, 16 Sep 2023 07:37:37 GMT, Andrey Turbanov wrote:
>> src/java.base/share/classes/sun/util/calendar/ImmutableGregorianDate.java
>> line 160:
>>
>>> 158: unsupported();
>>> 159: }
>>> 160:
>>
>> This removal does not look right. The class claims `immutable`, and yet it
>>
On Fri, 15 Sep 2023 23:31:16 GMT, Naoto Sato wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> cleanup existing typos
>
> src/java.base/share/classes/sun/util/calendar/ImmutableGregorianDate.java
> line 160:
>
>>
On Fri, 15 Sep 2023 20:24:35 GMT, Justin Lu wrote:
>> Please review this PR which is a continuation of
>> [JDK-6453901](https://bugs.openjdk.org/browse/JDK-6453901) to remove unused
>> code from the _sun.util.Calendar_ classes.
>>
>> `forceStandardTime` is always false.
>>
>> In addition,
> Please review this PR which is a continuation of
> [JDK-6453901](https://bugs.openjdk.org/browse/JDK-6453901) to remove unused
> code from the _sun.util.Calendar_ classes.
>
> `forceStandardTime` is always false.
>
> In addition, `locale` is never by used by _CalendarDate_ or any inheritors
On Fri, 15 Sep 2023 18:54:19 GMT, Justin Lu wrote:
>> Please review this PR which is a continuation of
>> [JDK-6453901](https://bugs.openjdk.org/browse/JDK-6453901) to remove unused
>> code from the _sun.util.Calendar_ classes.
>>
>> `forceStandardTime` is always false.
>>
>> In addition,
On Fri, 15 Sep 2023 19:05:12 GMT, Justin Lu wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Clarify implementation after removal of if else block
>
>
On Fri, 15 Sep 2023 18:54:19 GMT, Justin Lu wrote:
>> Please review this PR which is a continuation of
>> [JDK-6453901](https://bugs.openjdk.org/browse/JDK-6453901) to remove unused
>> code from the _sun.util.Calendar_ classes.
>>
>> `forceStandardTime` is always false.
>>
>> In addition,
> Please review this PR which is a continuation of
> [JDK-6453901](https://bugs.openjdk.org/browse/JDK-6453901) to remove unused
> code from the _sun.util.Calendar_ classes.
>
> `forceStandardTime` is always false.
>
> In addition, `locale` is never by used by _CalendarDate_ or any inheritors
On Wed, 13 Sep 2023 20:21:20 GMT, Justin Lu wrote:
>> Please review this PR which is a continuation of
>> [JDK-6453901](https://bugs.openjdk.org/browse/JDK-6453901) to remove unused
>> code from the _sun.util.Calendar_ classes.
>>
>> `forceStandardTime` is always false.
>>
>> In addition,
> Please review this PR which is a continuation of
> [JDK-6453901](https://bugs.openjdk.org/browse/JDK-6453901) to remove unused
> code from the _sun.util.Calendar_ classes.
>
> `forceStandardTime` is always false.
>
> In addition, `locale` is never by used by _CalendarDate_ or any inheritors
On Wed, 13 Sep 2023 19:46:08 GMT, Justin Lu wrote:
>> Please review this PR which is a continuation of
>> [JDK-6453901](https://bugs.openjdk.org/browse/JDK-6453901) to remove unused
>> code from the _sun.util.Calendar_ classes.
>>
>> `forceStandardTime` is always false.
>>
>> In addition,
On Wed, 13 Sep 2023 19:40:04 GMT, Justin Lu wrote:
>> Please review this PR which is a continuation of
>> [JDK-6453901](https://bugs.openjdk.org/browse/JDK-6453901) to remove unused
>> code from the _sun.util.Calendar_ classes.
>>
>> `forceStandardTime` is always false.
>>
>> In addition,
> Please review this PR which is a continuation of
> [JDK-6453901](https://bugs.openjdk.org/browse/JDK-6453901) to remove unused
> code from the _sun.util.Calendar_ classes.
>
> `forceStandardTime` is always false.
>
> In addition, `locale` is never by used by _CalendarDate_ or any inheritors
On Wed, 13 Sep 2023 17:52:13 GMT, Justin Lu wrote:
> Please review this PR which is a continuation of
> [JDK-6453901](https://bugs.openjdk.org/browse/JDK-6453901) to remove unused
> code from the _sun.util.Calendar_ classes.
>
> `forceStandardTime` is always false.
>
> In addition, `locale`
Please review this PR which is a continuation of
[JDK-6453901](https://bugs.openjdk.org/browse/JDK-6453901) to remove unused
code from the _sun.util.Calendar_ classes.
`forceStandardTime` is always false.
In addition, `locale` is never by used by _CalendarDate_ or any inheritors and
can be
16 matches
Mail list logo
