Re: RFR: JDK-8315458 Implement JEP 463: Implicitly Declared Classes and Instance Main Method (Second Preview) [v19]

2023-11-21 Thread Pavel Rappo
On Tue, 21 Nov 2023 12:58:42 GMT, Jim Laskey wrote: >> @JimLaskey, in my experiments for JDK-8308715 (Create a mechanism for >> Implicitly Declared Class javadoc), I found that >> `javax.lang.model.util.Elements.getOrigin` reports `Origin.EXPLICIT` for the >> implicitly declared class and

Re: RFR: JDK-8315458 Implement JEP 463: Implicitly Declared Classes and Instance Main Method (Second Preview) [v19]

2023-11-21 Thread Joe Darcy
On Tue, 21 Nov 2023 10:38:36 GMT, Pavel Rappo wrote: >> Look at the spec https://bugs.openjdk.org/browse/JDK-8319252 under 7.3 >> Compilation Units. >> >> - It is not abstract (8.1.1.1 ⇗). >> - It is final (8.1.1.2 ⇗). >> - It is a member of an unnamed package (7.4.2 ⇗) and **has package

Re: RFR: JDK-8315458 Implement JEP 463: Implicitly Declared Classes and Instance Main Method (Second Preview) [v19]

2023-11-21 Thread Jim Laskey
On Tue, 21 Nov 2023 10:38:36 GMT, Pavel Rappo wrote: >> Look at the spec https://bugs.openjdk.org/browse/JDK-8319252 under 7.3 >> Compilation Units. >> >> - It is not abstract (8.1.1.1 ⇗). >> - It is final (8.1.1.2 ⇗). >> - It is a member of an unnamed package (7.4.2 ⇗) and **has package

Re: RFR: JDK-8315458 Implement JEP 463: Implicitly Declared Classes and Instance Main Method (Second Preview) [v19]

2023-11-21 Thread Pavel Rappo
On Wed, 15 Nov 2023 15:54:26 GMT, Jim Laskey wrote: >> Jim Laskey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Filter abstract main methods and search interfaces for default main >> methods. > > Look at the spec

Re: RFR: JDK-8315458 Implement JEP 463: Implicitly Declared Classes and Instance Main Method (Second Preview) [v19]

2023-11-15 Thread Jim Laskey
On Tue, 14 Nov 2023 13:35:46 GMT, Jim Laskey wrote: >> Address changes from JEP 445 to JEP 463. >> >> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class. >> >> - Don't mark class on read. >> >> - Remove reflection and annotation processing related to unnamed classes. >> >> -

Re: RFR: JDK-8315458 Implement JEP 463: Implicitly Declared Classes and Instance Main Method (Second Preview) [v19]

2023-11-14 Thread Jim Laskey
> Address changes from JEP 445 to JEP 463. > > - Move from a SYNTHETIC unnamed class to a MANDATED implicit class. > > - Don't mark class on read. > > - Remove reflection and annotation processing related to unnamed classes. > > - Simplify main method search. Jim Laskey has updated the pull