On Fri, 24 May 2024 12:16:25 GMT, Ludvig Janiuk wrote:
> Adding commetns to clarify that the failure_handler selftests are intended to
> be run manually. Ideally this would include a more thorough description of
> the exepcted outputs, but this is what I have time to add right now.
test/failur
On Thu, 30 May 2024 19:14:43 GMT, Magnus Ihse Bursie wrote:
> The original way of building static libraries in the JDK was to use the
> configure argument --enable-static-build, which set the value of the make
> variable STATIC_BUILD. (Note that this is not the same as the source code
> defini
On Tue, 4 Jun 2024 07:47:46 GMT, SendaoYan wrote:
> Hi all,
> This PR several extra empty spaces and extra empty lines in several
> Makefiles. It's trivial fix, no risk.
>
> Thanks.
Marked as reviewed by erikj (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/19537#pull
On Wed, 5 Jun 2024 17:31:44 GMT, Severin Gehwolf wrote:
>> Please review this patch which adds a jlink mode to the JDK which doesn't
>> need the packaged modules being present. A.k.a run-time image based jlink.
>> Fundamentally this patch adds an option to use `jlink` even though your JDK
>> i
On Fri, 7 Jun 2024 07:29:39 GMT, SendaoYan wrote:
>> Hi all,
>> This PR several extra empty spaces and extra empty lines in several
>> Makefiles. It's trivial fix, no risk.
>>
>> Thanks.
>
> SendaoYan has updated the pull request incrementally with one additional
> commit since the last revi
On Fri, 7 Jun 2024 12:37:48 GMT, Julian Waters wrote:
>> SendaoYan has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> delete extra empty trailing blank line in
>> test/jdk/java/rmi/reliability/benchmark/bench/Makefile
>
> test/jdk/java/rmi
On Thu, 2 May 2024 09:48:51 GMT, Christian Stein wrote:
> Please review the change to update to using `jtreg` **7.4**.
>
> The primary change is to the `jib-profiles.js` file, which specifies the
> version of jtreg to use, for those systems that rely on this file. In
> addition, the `requiredV
On Wed, 19 Jun 2024 15:15:43 GMT, Magnus Ihse Bursie wrote:
>> This patch contains a set of changes to improve static builds. They will
>> pave the way for implementing a full static-only java launcher. The changes
>> here will:
>>
>> 1) Make sure non-exported symbols are made local in the sta
On Mon, 26 Aug 2024 02:07:39 GMT, David Holmes wrote:
> I understand the cost overhead experienced by any individual Java run may be
> lost in the noise, but it still impacts every single Java run just to save
> some time/resources for the handful of builders of statically linked VMs. I
> am n
On Wed, 28 Aug 2024 15:17:52 GMT, Magnus Ihse Bursie wrote:
>> Currently, we issue -Wno-unused for all files in gcc, which is a rather big
>> sledgehammer to get rid of some warnings that proliferate in a few areas of
>> the build.
>>
>> We should instead leave -Wunused turned on (as done by -
On Thu, 29 Aug 2024 13:14:35 GMT, Magnus Ihse Bursie wrote:
> Currently, we issue -Wno-unused for all files in clang, which is a rather big
> sledgehammer to get rid of some warnings that proliferate in a few areas of
> the build.
>
> We should instead leave -Wunused turned on (as done by -Wal
On Fri, 30 Aug 2024 11:35:51 GMT, Magnus Ihse Bursie wrote:
>> Currently, we issue -Wno-unused for all files in clang, which is a rather
>> big sledgehammer to get rid of some warnings that proliferate in a few areas
>> of the build.
>>
>> We should instead leave -Wunused turned on (as done by
On Tue, 3 Sep 2024 12:50:01 GMT, Magnus Ihse Bursie wrote:
> As a prerequisite for Hermetic Java, we need a statically linked `java`
> launcher. It should behave like the normal, dynamically linked `java`
> launcher, except that all JDK native libraries should be statically, not
> dynamically,
On Tue, 27 Sep 2022 08:32:09 GMT, Magnus Ihse Bursie wrote:
>> After [JDK-8294281](https://bugs.openjdk.org/browse/JDK-8294281), it is now
>> possible to disable warnings for individual files instead for whole
>> libraries. I used this opportunity to go through all disabled warnings in
>> java
On Wed, 12 Oct 2022 09:44:54 GMT, Magnus Ihse Bursie wrote:
> Markdown files are basically source code for documentation. It should have
> the same whitespace checks as all other source code, so we don't get spurious
> trailing whitespace changes.
Thank you! Since I enabled visible whitespace
On Mon, 17 Oct 2022 14:41:06 GMT, Julian Waters wrote:
>> Some external libraries required by native code are linked via linker
>> comments embedded in pragmas. Searching for which libraries are linked can
>> then become frustrating and confusing since they may be included in an
>> obscure pla
On Mon, 17 Oct 2022 17:16:21 GMT, Alexey Semenyuk wrote:
> The change looks harmless. Howevere I don't understand how searching for the
> standard Windows libs can then become frustrating.
I believe this is part of the effort for
https://bugs.openjdk.org/browse/JDK-8288293.
-
PR:
On Thu, 20 Oct 2022 11:58:58 GMT, Magnus Ihse Bursie wrote:
> Properties files is essentially source code. It should have the same
> whitespace checks as all other source code, so we don't get spurious trailing
> whitespace changes.
>
> With the new Skara jcheck, it is possible to increase the
On Thu, 20 Oct 2022 11:58:58 GMT, Magnus Ihse Bursie wrote:
> Properties files is essentially source code. It should have the same
> whitespace checks as all other source code, so we don't get spurious trailing
> whitespace changes.
>
> With the new Skara jcheck, it is possible to increase the
On Fri, 21 Oct 2022 08:17:46 GMT, Magnus Ihse Bursie wrote:
>> Properties files is essentially source code. It should have the same
>> whitespace checks as all other source code, so we don't get spurious
>> trailing whitespace changes.
>>
>> With the new Skara jcheck, it is possible to increas
On Fri, 21 Oct 2022 16:55:28 GMT, Naoto Sato wrote:
> This is to update the CLDR data from version 41 to version 42. The vast
> majority of the changes are basically replacing the CLDR data, along with
> tools/testcase alignments to those upstream changes:
>
> https://unicode-org.atlassian.net
On Fri, 28 Oct 2022 07:19:31 GMT, Jie Fu wrote:
>> Hi all,
>>
>> As discussed here
>> https://github.com/openjdk/jdk/pull/10807#pullrequestreview-1150314487 , it
>> would be better to add the vector api tests in GHA.
>>
>> Thanks.
>> Best regards,
>> Jie
>
> Jie Fu has updated the pull reques
On Tue, 1 Nov 2022 05:49:25 GMT, Joe Darcy wrote:
> Usual start-of-release updates. Symbol updates in initial version reflect JDK
> 20 build 21.
Marked as reviewed by erikj (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/10924
On Tue, 29 Nov 2022 14:44:12 GMT, Christian Stein wrote:
> Please review the change to update to using jtreg `7.1`.
>
> The primary change is to the `jib-profiles.js` file, which specifies the
> version of jtreg to use, for those systems that rely on this file. In
> addition, the requiredVersi
On Wed, 23 Nov 2022 15:38:29 GMT, Roger Riggs wrote:
> > /issue add JDK-8296302
>
> The BOT comment at the top says /issue cannot refer to a CSR. You'll need to
> /issue remove it before integration.
Roger is correct, please do not add CSR issues with `/issue add`. The bot
should auto discove
On Tue, 6 Dec 2022 16:07:44 GMT, Christian Stein wrote:
> Please review the change to update to using jtreg 7.1.1.
>
> The primary change is to the `jib-profiles.js` file, which specifies the
> version of jtreg to use, for those systems that rely on this file. In
> addition, the requiredVersio
On Fri, 9 Dec 2022 06:53:31 GMT, Justin King wrote:
> Allow building OpenJDK with UBSan. Currently the build fails when optimizing
> the image due to lots of undefined behavior (it invokes the built JVM).
> Follow up PRs will either replace the undefined behavior with well defined
> behavior o
On Fri, 9 Dec 2022 06:53:31 GMT, Justin King wrote:
> Allow building OpenJDK with UBSan. Currently the build fails when optimizing
> the image due to lots of undefined behavior (it invokes the built JVM).
> Follow up PRs will either replace the undefined behavior with well defined
> behavior o
On Fri, 9 Dec 2022 14:34:37 GMT, Erik Joelsson wrote:
>> Allow building OpenJDK with UBSan. Currently the build fails when optimizing
>> the image due to lots of undefined behavior (it invokes the built JVM).
>> Follow up PRs will either replace the undefined behavior
On Tue, 13 Dec 2022 08:17:09 GMT, Justin King wrote:
> I tried to use a single file, but the build logic attempts to compile as
> either C or C++ based on file extensions, and has logic based on it. So if I
> use `.cpp` and the target is all `.c` odd things happen. The same for the
> inverse.
On Tue, 13 Dec 2022 13:45:04 GMT, Justin King wrote:
> Nope. Some targets end up passing C++ flags to the C compiler, causing a
> failure.
Ah right, we (mis)use CFLAGS (instead of CXXFLAGS) in some
SetupNativeCompilation calls when all source files are C++. In that case, your
suggested patch
On Tue, 3 Jan 2023 09:39:59 GMT, Aleksey Shipilev wrote:
> This should help to speed up tests significantly. Currently, if we run "make
> test" with a subset of tests, JTReg would still read the entirety of test
> root to report on tests that were not run. Even with current suite of tests
> it
On Mon, 23 Jan 2023 13:53:38 GMT, Per Minborg wrote:
> Some variables are declared using old-style declarations. These should be
> modified to conform to modern style.
>
> This is a task derived from https://github.com/openjdk/jdk/pull/11848
Something is causing high contention in the bot, it
On Mon, 13 Feb 2023 10:21:05 GMT, Ludvig Janiuk wrote:
>> Update open/test/failure_handler/src/share/conf/(linux,mac).properties to
>> handle core dumps more correctly.
>
> Ludvig Janiuk has updated the pull request incrementally with one additional
> commit since the last revision:
>
> add
On Thu, 2 Mar 2023 05:54:52 GMT, Joe Darcy wrote:
> While the review of https://github.com/openjdk/jdk/pull/12800 finishes up, I
> thought I'd get out for the review the next phase of the FDLIBM port:
> removing the FDLIBM C sources from the repo.
>
> A repo with the changes for JDK-8302027 an
On Wed, 8 Mar 2023 19:15:16 GMT, Roger Riggs wrote:
> Improvements to support OS specific customization for JDK internal use:
> - To select values and code; allowing elimination of unused code and values
> - Optionally evaluated by build processes, compilation, or archiving (i.e.
> CDS)
> - S
On Wed, 8 Mar 2023 22:21:08 GMT, Mandy Chung wrote:
>> Improvements to support OS specific customization for JDK internal use:
>> - To select values and code; allowing elimination of unused code and values
>> - Optionally evaluated by build processes, compilation, or archiving (i.e.
>> CDS)
>>
On Thu, 9 Mar 2023 20:09:46 GMT, Eirik Bjorsnos wrote:
> The Make target 'build-test-lib-target' is broken in a few ways:
>
> - make/test/BuildTestLib.gmk references the directory
> $(TEST_LIB_SOURCE_DIR)/sun which does not seem to exist. This can be fixed by
> removing the reference.
> - Some
On Mon, 13 Mar 2023 21:16:24 GMT, Naoto Sato wrote:
> Proposing accessor methods to Emoji properties defined in [Unicode Technical
> Standard #51](https://unicode.org/reports/tr51/) in `java.lang.Character`
> class. This is per a request from the client group, as well as refining the
> current
On Fri, 17 Mar 2023 15:42:56 GMT, Per Minborg wrote:
> API changes for the FFM API (third preview)
>
> Specdiff:
> https://cr.openjdk.org/~pminborg/panama/21/v1/specdiff/overview-summary.html
>
> Javadoc:
> https://cr.openjdk.org/~pminborg/panama/21/v1/javadoc/java.base/module-summary.html
Bui
On Mon, 27 Mar 2023 09:40:22 GMT, Severin Gehwolf wrote:
>> Please review this change for symbol visibility of static library artefacts.
>> This fixes an issue when
>> OpenJDK is being used as a base for generating native images preventing the
>> symbols from being
>> exported and looked up fro
On Sat, 1 Apr 2023 18:08:44 GMT, Joe Darcy wrote:
> This PR is a redo of JDK-8302801: Remove fdlibm C sources. The problem with
> JDK-8302801 was that it neglected (mea culpa) to include a Java
> implementation of IEEEremainder before the FDLIBM C implementation was
> deleted. Such an implemen
On Wed, 5 Apr 2023 15:58:08 GMT, Roger Riggs wrote:
> Define an internal jdk.internal.util.Architecture enumeration and static
> methods to replace uses of the system property `os.arch`.
> The enumeration values are defined to match those used in the build.
> The initial values are: `X64, X86, I
On Fri, 14 Apr 2023 14:31:31 GMT, Roger Riggs wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixed isPPC64().
>> Consolidated switch cases in ArchTest.
>> Moved mapping of build TARGET_OS and TARGET_CPU to the
On Mon, 17 Apr 2023 14:56:16 GMT, Christian Stein wrote:
> Please review the change to update to using jtreg 7.2.
>
> The primary change is to the `jib-profiles.js` file, which specifies the
> version of jtreg to use, for those systems that rely on this file. In
> addition, the requiredVersion
On Mon, 17 Apr 2023 20:59:06 GMT, Roger Riggs wrote:
>> Define an internal jdk.internal.util.Architecture enumeration and static
>> methods to replace uses of the system property `os.arch`.
>> The enumeration values are defined to match those used in the build.
>> The initial values are: `X64, X
On Thu, 27 Apr 2023 17:57:05 GMT, Antonios Printezis wrote:
> Fix is to exclude hsdis when building the buildjdk.
This looks like it should work, but I would like to avoid sprinkling any more
CREATING_BUILDJDK conditionals throughout the build than absolutely necessary.
I think it would be bet
On Thu, 27 Apr 2023 20:08:29 GMT, Antonios Printezis wrote:
>> Fix is to exclude hsdis when building the buildjdk.
>
> Antonios Printezis has updated the pull request incrementally with one
> additional commit since the last revision:
>
> changes based on Erik's feedback
make/autoconf/buildj
On Thu, 27 Apr 2023 20:53:25 GMT, Antonios Printezis wrote:
>> Fix is to exclude hsdis when building the buildjdk.
>
> Antonios Printezis has updated the pull request incrementally with one
> additional commit since the last revision:
>
> updated
Marked as reviewed by erikj (Reviewer).
On Thu, 27 Apr 2023 21:04:42 GMT, Erik Joelsson wrote:
>> Antonios Printezis has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> updated
>
> Marked as reviewed by erikj (Reviewer).
> @erikj79 Thanks! I
On Fri, 28 Apr 2023 01:03:28 GMT, Jiangli Zhou wrote:
> Initial implementation for supporting building a fully statically linked
> (with a desired set of JDK native libraries and libjvm) Java launcher
> executable, which is named as 'javastatic'.
>
> In this PR, the support is only added for t
On Fri, 28 Apr 2023 11:59:52 GMT, Alan Bateman wrote:
> If I understand the make file changes proposed here, it runs the native
> linker to create "javastatic" with the launcher, libjvm and other JNI libs
> linked into one executable, this is generated and copied into the run-time
> image crea
On Fri, 28 Apr 2023 01:03:28 GMT, Jiangli Zhou wrote:
> Initial implementation for supporting building a fully statically linked
> (with a desired set of JDK native libraries and libjvm) Java launcher
> executable, which is named as 'javastatic'.
>
> In this PR, the support is only added for t
On Fri, 28 Apr 2023 22:32:34 GMT, Jiangli Zhou wrote:
> Erik, could you please share your
> `support/native/java.base/java/BUILD_LAUNCHER_javastatic_static_link.cmdline`?
> This generated .cmdline file contains the static linking command. Here is
> the linking command from my build:
I can't s
On Fri, 28 Apr 2023 23:25:17 GMT, Erik Joelsson wrote:
>>> I pulled this PR and had a go at building it. For me it failed with errors
>>> like this:
>>>
>>> ```
>>> /home/erik/git/jdk/build/linux-x64/images/static-libs/lib/libjvm.a(os_
On Wed, 3 May 2023 02:09:22 GMT, Jiangli Zhou wrote:
> This PR is branched from the makefile changes for
> https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for
> handling the JDK/VM static libraries:
>
> - Create libjvm.a together with other JDK static libraries when buil
On Wed, 3 May 2023 02:09:22 GMT, Jiangli Zhou wrote:
> This PR is branched from the makefile changes for
> https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for
> handling the JDK/VM static libraries:
>
> - Create libjvm.a together with other JDK static libraries when buil
On Wed, 3 May 2023 17:58:25 GMT, Jiangli Zhou wrote:
>> This PR is branched from the makefile changes for
>> https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for
>> handling the JDK/VM static libraries:
>>
>> - Create libjvm.a together with other JDK static libraries when
On Wed, 3 May 2023 17:05:29 GMT, Severin Gehwolf wrote:
>> Jiangli Zhou has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update based on @erikj79 review comments and suggestions:
>> - Change to copy libjvm.a for $(JVM_VARIANT_MAIN) only
On Fri, 5 May 2023 16:52:22 GMT, Jiangli Zhou wrote:
>> This PR is branched from the makefile changes for
>> https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for
>> handling the JDK/hotspot static libraries:
>>
>> - Introduce new make target(s) for creating image/bundle c
On Tue, 9 May 2023 21:46:42 GMT, Jiangli Zhou wrote:
>> This PR is branched from the makefile changes for
>> https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for
>> handling the JDK/hotspot static libraries:
>>
>> - Introduce new make target(s) for creating image/bundle c
On Tue, 9 May 2023 23:06:23 GMT, Jiangli Zhou wrote:
>> This PR is branched from the makefile changes for
>> https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for
>> handling the JDK/hotspot static libraries:
>>
>> - Introduce new make target(s) for creating image/bundle c
On Wed, 10 May 2023 17:13:13 GMT, Jiangli Zhou wrote:
>> This PR is branched from the makefile changes for
>> https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for
>> handling the JDK/hotspot static libraries:
>>
>> - Build hotspot libjvm.a and JDK static libraries for
>>
On Wed, 10 May 2023 20:38:50 GMT, Jiangli Zhou wrote:
> > This change caused all our builds but Linux to fail. Did you verify on
> > other platforms than Linux at all? I see you have GHA turned off.
>
> Sorry about the issue. There were failed workflows after I merged with the
> latest JDK mas
On Mon, 15 May 2023 08:38:54 GMT, Adam Sotona wrote:
> Package `jdk.internal.classfile.java.lang.constant` containing `ModuleDesc`
> and `PackageDesc` become obsolete after
> [JDK-8306729](https://bugs.openjdk.org/browse/JDK-8306729).
> All references to `jdk.internal.classfile.java.lang.const
On Fri, 19 May 2023 20:18:53 GMT, Jiangli Zhou wrote:
> Original description for JDK-8307194 change:
> -
> This PR is branched from the makefile changes for
> https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for
> handling the JDK/hotspot static libraries:
>
> - Buil
On Fri, 19 May 2023 21:13:24 GMT, Erik Joelsson wrote:
>> Original description for JDK-8307194 change:
>> -
>> This PR is branched from the makefile changes for
>> https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for
>> handling th
On Mon, 22 May 2023 10:01:55 GMT, Adam Sotona wrote:
> This patch disables temporary use of language preview features in JDK.
> Temporary enabled language preview features (to allow Pattern Matching for
> switch use in the Classfile API library) are no more necessary.
> All redundant use of --en
On Mon, 22 May 2023 19:21:52 GMT, Jiangli Zhou wrote:
>> Thanks @erikj79. Could you please help provide some more info on the build
>> failure:
>>
>> Which macOs version ran into the build issue? My mac is on Ventura 13.3.1
>> (a). It builds successfully for the `static-libs-image` target.
>>
On Mon, 22 May 2023 19:40:00 GMT, Jiangli Zhou wrote:
>> Original description for JDK-8307194 change:
>> -
>> This PR is branched from the makefile changes for
>> https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for
>> handling the JDK/hotspot static libraries:
>>
>>
On Thu, 20 Apr 2023 20:28:18 GMT, Joe Darcy wrote:
> Time to get JDK 22 underway...
Marked as reviewed by erikj (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/13567#pullrequestreview-1440532444
On Fri, 19 May 2023 21:20:19 GMT, Erik Joelsson wrote:
>> Jiangli Zhou has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> - Add $$($1_LD) $$($1_SYSROOT_LDFLAGS) to $1_VARDEPS if $(TOOLCHAIN_TYPE)
>> is
On Mon, 22 May 2023 21:27:58 GMT, Jiangli Zhou wrote:
>> Original description for JDK-8307194 change:
>> -
>> This PR is branched from the makefile changes for
>> https://bugs.openjdk.org/browse/JDK-8303796 and contains the following for
>> handling the JDK/hotspot static libraries:
>>
>>
On Wed, 24 May 2023 20:29:09 GMT, Erik Joelsson wrote:
> My build job is still running, but it has failed in two distinct ways
> already. See below for mac fix. Our cross build of arm32 fails with this
> message:
>
> ```
> [2023-05-24T19:25:15,310Z]
> /opt/mach5/meso
On Fri, 22 Jul 2022 16:45:55 GMT, Jorn Vernee wrote:
>> This patch removes the use of std::thread from the `java.lang.foreign`
>> tests, and switches to the OS specific thread APIs, in order to change
>> things such as the stack size on some platforms where this is required in
>> the future (s
On Thu, 28 Jul 2022 02:20:26 GMT, Julian Waters wrote:
> CoreLibraries.gmk is missing a check for MSVCR_DLL. This results in a
> defined, but empty macro in libjli if it is not defined in the build system,
> which is incorrect
Marked as reviewed by erikj (Reviewer).
-
PR: https:/
On Mon, 19 Sep 2022 12:55:47 GMT, Julian Waters wrote:
> Replaces hardcoding of object file suffixes in make, to ensure they are
> always reliably set from a single place in autoconf.
Marked as reviewed by erikj (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/10341
On Tue, 20 Sep 2022 21:45:05 GMT, Magnus Ihse Bursie wrote:
> The ant detection in bin/idea.sh is very rudimentary. It fails at a modern
> aarch64 macOS installation.
Marked as reviewed by erikj (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/10364
On Fri, 23 Sep 2022 22:10:03 GMT, Naoto Sato wrote:
> The current makefile for `tzdb.dat` won't recompile if some dependent files
> (e.g. `VERSION`) are updated. Adding all files under the tzdb directory to
> the dependency will fix this issue.
make/modules/java.base/gendata/GendataTZDB.gmk li
On Mon, 26 Sep 2022 01:39:41 GMT, Hao Sun wrote:
>> This warning seems to be a false positive, because 1) array "fq" with
>> elements from index 0 to "jz" has already been initialized as "fw" at line
>> 290 [1], and 2) variable "jz" should be non-negative from the comment at
>> line 99 [2].
>>
On Mon, 26 Sep 2022 15:31:53 GMT, Magnus Ihse Bursie wrote:
> After [JDK-8294281](https://bugs.openjdk.org/browse/JDK-8294281), it is now
> possible to disable warnings for individual files instead for whole
> libraries. I used this opportunity to go through all disabled warnings in
> java.bas
On Mon, 26 Sep 2022 16:37:33 GMT, Naoto Sato wrote:
>> The current makefile for `tzdb.dat` won't recompile if some dependent files
>> (e.g. `VERSION`) are updated. Adding all files under the tzdb directory to
>> the dependency will fix this issue.
>
> Naoto Sato has updated the pull request inc
On Mon, 26 Sep 2022 16:32:43 GMT, Naoto Sato wrote:
>> make/modules/java.base/gendata/GendataTZDB.gmk line 33:
>>
>>> 31: TZDATA_DIR := $(MODULE_SRC)/share/data/tzdata
>>> 32: TZDATA_TZFILE := africa antarctica asia australasia europe northamerica
>>> southamerica backward etcetera gmt jdk11_ba
On Fri, 26 May 2023 20:26:02 GMT, Jiangli Zhou wrote:
> > Another possibility might be the user provided `BUILD_LDCXX` includes extra
> > options in the testing build (?). If that's the case, we probably could
> > define a separate `BUILD_LD_PARTIAL` with no added options. In our
> > prototype
On Thu, 1 Jun 2023 23:38:03 GMT, Jiangli Zhou wrote:
> Sounds good for solving the macosx `ar` limitation differently. I'll change
> that. We can also exclude the partial linking part for gcc (due the older
> tool issue that you've found). Any concerns with including partial linking
> step for
On Mon, 5 Jun 2023 19:12:52 GMT, Tom Rodriguez wrote:
> This allows bin/idea.sh to properly see the JVMCI files again.
Marked as reviewed by erikj (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/14318#pullrequestreview-1463324474
; command if relative path is used.
> - Merge branch 'master' into JDK-8307858
> - Address comments/suggestions from @erikj79:
>- Only do partial linking step for building static libraries with clang on
> linux.
>- On macosx, workaround the lon
mments/suggestions from @erikj79:
>- Only do partial linking step for building static libraries with clang on
> linux.
>- On macosx, workaround the long argument issue for 'AR' with relative
> path.
>
>Tested building jdk-image and static-libs-image on li
On Sun, 11 Jun 2023 16:38:31 GMT, Artem Semenov wrote:
>> When using the clang compiler to build OpenJDk on Linux, we encounter
>> various "warnings as errors".
>> They can be fixed with small changes.
>
> Artem Semenov has updated the pull request with a new target base due to a
> merge or a r
On Tue, 13 Jun 2023 12:48:12 GMT, Jorn Vernee wrote:
> Update the make/autoconf/lib-ffi.m4 script to support using libffi on Windows
> and Mac.
>
> For Windows I had to tweak `fallbackLinker.c` to be able to build: there was
> an import of `stdint.h` missing, and since it was using `WSAGetLast
On Tue, 13 Jun 2023 17:09:30 GMT, Jorn Vernee wrote:
>> Update the make/autoconf/lib-ffi.m4 script to support using libffi on
>> Windows and Mac.
>>
>> For Windows I had to tweak `fallbackLinker.c` to be able to build: there was
>> an import of `stdint.h` missing, and since it was using `WSAGe
On Fri, 16 Jun 2023 20:36:07 GMT, Jiangli Zhou wrote:
> 8307858: [REDO] JDK-8307194 Add make target for optionally building a
> complete set of all JDK and hotspot libjvm static libraries
The changes look ok.
-
Marked as reviewed by erikj (Reviewer).
PR Review: https://git.openjd
On Fri, 16 Jun 2023 22:10:08 GMT, Daniel D. Daugherty
wrote:
> @erikj - You did a round of Mach5 testing on the JDK22 version of this fix.
> Do you have plans to redo that testing for the JDK21 backport?
I have done testing of the JDK 21 version of the patch and it's running cleanly.
On Wed, 21 Jun 2023 15:18:19 GMT, Matthias Baesken wrote:
> There are a few references to rt.jar in comments and in the codebase itself.
> Some of them might be removed or adjusted.
The update to Java.gmk is good.
-
Marked as reviewed by erikj (Reviewer).
PR Review: https://git.o
On Sat, 24 Jun 2023 06:47:48 GMT, Vladimir Sitnikov
wrote:
> I've posted the suggetion to add .editorconfig on ide-support-dev, however,
> the list does not seem to be active:
> https://mail.openjdk.org/pipermail/ide-support-dev/2023-June/000281.html
I think that sounds like a reasonable idea
On Wed, 28 Jun 2023 16:54:51 GMT, Leo Korinth wrote:
> Remove trailing "blank" lines in source files.
>
> I like to use global-whitespace-cleanup-mode, but I can not use it if the
> files are "dirty" to begin with. This fix will make more files "clean". I
> also considered adding a check for t
On Thu, 29 Jun 2023 07:41:11 GMT, David Holmes wrote:
> This seems to run contrary to the requirement that files end in a newline,
> which git will complain about if the newline is missing.
The patch is leaving exactly one newline at the end of the file.
-
PR Comment: https://git.
On Tue, 1 Aug 2023 10:29:06 GMT, Jorn Vernee wrote:
> This patch contains the implementation of the foreign linker & memory API JEP
> for Java 22. The initial patch is composed of commits brought over directly
> from the [panama-foreign repo](https://github.com/openjdk/panama-foreign).
> The m
On Thu, 17 Aug 2023 07:24:14 GMT, Christian Stein wrote:
> Please review the change to update to using jtreg 7.3,1.
>
> The primary change is to the `jib-profiles.js` file, which specifies the
> version of jtreg to use, for those systems that rely on this file. In
> addition, the `requiredVers
In the JDK build we have various build tools that generate source code from
data files. For most of these tools, the source files are based on template
files, which already have copyright headers, but for some, the complete source
file is generated by the tool, which is providing the copyright h
1 - 100 of 252 matches
Mail list logo
