On Wed, 3 May 2023 17:05:29 GMT, Severin Gehwolf <sgehw...@openjdk.org> wrote:
>> Jiangli Zhou has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update based on @erikj79 review comments and suggestions: >> - Change to copy libjvm.a for $(JVM_VARIANT_MAIN) only in >> make/StaticLibsImage.gmk. >> - Use $(OBJ_SUFFIX) instead of .o in >> make/modules/java.base/lib/CoreLibraries.gmk. > > make/Main.gmk line 1060: > >> 1058: symbols-image: $(LIBS_TARGETS) $(LAUNCHER_TARGETS) >> 1059: >> 1060: static-libs-image: hotspot-static-libs $(STATIC_LIBS_TARGETS) > > Could we decouple `hotspot-static-libs` from `static-libs-image` somehow, > please? `static-libs-image` is used by the `graal-builder-image` target and > it would be good if it didn't include hotspot static libs as they are not > needed for it. > > Would it be sufficient to just use `hotspot-static-libs` directly? Like: > `make static-libs-image hotspot-static-libs`? Failing that, could we > introduce a new target that produces both? I'm hoping to get input from the graal team on the impact of this change. The exact usage of the new libjvm.a file is still under discussion so I share you concern about changing things for the current static libs usecase before we fully understand where this is going. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/13768#discussion_r1184107079
