RFR: 8198755: Reduce cost of InvokerBytecodeGenerator::isStaticallyInvocable/-Nameable

Hi, when generating LF classes with InvokerBytecodeGenerator, almost 5% of executed code is concerned with determining if members and parameters are statically invocable and/or nameable, which we can assert is always true for MethodHandle arguments. Since MethodHandle targets and parameters

Re: RFR: 8198755: Reduce cost of InvokerBytecodeGenerator::isStaticallyInvocable/-Nameable

Looks good. On Feb 27, 2018, at 8:42 AM, Paul Sandoz wrote: > > > >> On Feb 27, 2018, at 7:42 AM, Claes Redestad >> wrote: >> >> Hi, >> >> when generating LF classes with InvokerBytecodeGenerator, almost 5% of >> executed code is

Re: RFR: 8198755: Reduce cost of InvokerBytecodeGenerator::isStaticallyInvocable/-Nameable

On 2018-02-27 17:53, John Rose wrote: Looks good. Thanks! I'll revert for-loop (it was a remnant of an earlier experiment to see if getting rid of the ptypes.clone() mattered for startup: it didn't, really) /Claes

Re: RFR: 8198755: Reduce cost of InvokerBytecodeGenerator::isStaticallyInvocable/-Nameable

> On Feb 27, 2018, at 7:42 AM, Claes Redestad wrote: > > Hi, > > when generating LF classes with InvokerBytecodeGenerator, almost 5% of > executed code is concerned with determining if members and parameters are > statically invocable and/or nameable, which we can

Re: RFR(XXS) : 8190679 : java/util/Arrays/TimSortStackSize2.java fails with "Initial heap size set to a larger value than the maximum heap size"

Hi David, I have set Xmx equal to Xms, the test passes w/ different externally passed combinations of Xmx, Xms and UseCompressedOops. http://cr.openjdk.java.net/~iignatyev//8190679/webrev.01/index.html Thanks, -- Igor > On

Re: RFR (JDK11) 8137326: Methods for comparing CharSequence, StringBuilder, and StringBuffer

+1 On 2/27/18, 11:37 AM, Joe Wang wrote: Hi Sherman and all, Thanks for the further reviews! Here's the latest webrev with boundary checks in StringLatin1/StringUTF16: JBS: https://bugs.openjdk.java.net/browse/JDK-8137326 webrev: http://cr.openjdk.java.net/~joehw/jdk11/8137326/webrev/

Re: [JDK 11] RFR 8196759: Move two java/text/Normalizer tests into OpenJDK

Looks good. Naoto On 2/26/18 10:51 PM, Chris Yin wrote: Please review the changes to move two java/text/Normalizer tests to OpenJDK jdk_text group, thanks bug: https://bugs.openjdk.java.net/browse/JDK-8196759 webrev:

Re: RFR (JDK11) 8137326: Methods for comparing CharSequence, StringBuilder, and StringBuffer

Hi Sherman and all, Thanks for the further reviews! Here's the latest webrev with boundary checks in StringLatin1/StringUTF16: JBS: https://bugs.openjdk.java.net/browse/JDK-8137326 webrev: http://cr.openjdk.java.net/~joehw/jdk11/8137326/webrev/ Best, Joe On 2/22/2018 6:07 PM, Joe Wang wrote:

Re: [PATCH] RFR Bug-pending: Enable Hotspot to Track Native Memory Usage for Direct Byte Buffers

Hi Alan, Peter, The main bit of data I wanted out of this was the sum total of native memory being used to store DirectByteBuffers, and to have that information printed in diagnostic cores. Thanks for pointing out Bits. I will investigate if there is a way to make that data available to the

Re: RFR: Here are some URLClassPath patches

Looks good. Thanks, David On 28/02/2018 3:03 PM, Martin Buchholz wrote: 8198808: jdi tests failing after JDK-8198484 http://cr.openjdk.java.net/~martin/webrevs/jdk/jdi-ProblemList/ https://bugs.openjdk.java.net/browse/JDK-8198808

RFR: JDK-8190187: C++ code calling JNI_CreateJavaVM can be killed by Java

Resending. Bump. :) On 14/02/2018 14:13, Adam Farley8 wrote: >> Hi All, >> >> -- Short version -- >> >> Could a committer please take the fix for JDK-8190187 (full code included >> in the bug) and: >> >> 1) Complete the CSR process for the new JNI Return code. >> 2) Commit the changes that

Re: RFR: JDK-8190187: C++ code calling JNI_CreateJavaVM can be killed by Java

On 27/02/2018 15:04, Adam Farley8 wrote: Resending. Bump. :) On 14/02/2018 14:13, Adam Farley8 wrote: >> Hi All, >> >> -- Short version -- >> >> Could a committer please take the fix for JDK-8190187 (full code included >> in the bug) and: >> >> 1) Complete the CSR process for the new JNI

Re: RFR 7183985: Class.getAnnotation() throws an ArrayStoreException when the annotation class not present

Hi Liam, On 2/24/2018 5:14 PM, Liam Miller-Cushon wrote: Hi, thanks for the comments. The updated webrev is at: http://cr.openjdk.java.net/~cushon/7183985/webrev.02/ On Fri, Feb 23, 2018 at 4:29 PM, Joseph D. Darcy

Re: [JDK 11] RFR 8196759: Move two java/text/Normalizer tests into OpenJDK

Thank you, Naoto Regards, Chris > On 28 Feb 2018, at 2:39 AM, Naoto Sato wrote: > > Looks good. > > Naoto > > On 2/26/18 10:51 PM, Chris Yin wrote: >> Please review the changes to move two java/text/Normalizer tests to OpenJDK >> jdk_text group, thanks >> bug:

Re: RFR: Here are some URLClassPath patches

I should probably do more testing than usual when touching classloading... We have a jdi test that does this (hg blame finds duke as only author): public static ClassLoader classLoaderValue; { try { urls[0] = new URL("hi there"); } catch

Re: RFR: Here are some URLClassPath patches

Hi Martin, Until we figure out the best course of action, please problem list the failing test. Thanks, -Joe On 2/27/2018 7:02 PM, Martin Buchholz wrote: I should probably do more testing than usual when touching classloading... We have a jdi test that does this (hg blame finds duke as

Re: RFR: Here are some URLClassPath patches

Hi Martin, On 28/02/2018 1:02 PM, Martin Buchholz wrote: I should probably do more testing than usual when touching classloading... We have a jdi test that does this (hg blame finds duke as only author):     public static ClassLoader classLoaderValue;     {         try {            

Re: RFR(XXS) : 8190679 : java/util/Arrays/TimSortStackSize2.java fails with "Initial heap size set to a larger value than the maximum heap size"

On 28/02/2018 7:17 AM, Igor Ignatyev wrote: Hi David, I have set Xmx equal to Xms, the test passes w/ different externally passed combinations of Xmx, Xms and UseCompressedOops. http://cr.openjdk.java.net/~iignatyev//8190679/webrev.01/index.html Looks good! Thanks, David Thanks, -- Igor

Re: RFR: Here are some URLClassPath patches

8198808: jdi tests failing after JDK-8198484 http://cr.openjdk.java.net/~martin/webrevs/jdk/jdi-ProblemList/ https://bugs.openjdk.java.net/browse/JDK-8198808

Re: RFR: Here are some URLClassPath patches

On 2/27/18 9:03 PM, Martin Buchholz wrote: 8198808: jdi tests failing after JDK-8198484 http://cr.openjdk.java.net/~martin/webrevs/jdk/jdi-ProblemList/ https://bugs.openjdk.java.net/browse/JDK-8198808 +1 Mandy