Re: Raw String Literal Library Support

On 13/03/2018 13:47, Jim Laskey wrote: : We are recommending that trimLeft and trimRight use UWS, leave trim alone to avoid breaking the world and then possibly introduce trimWhitespace that uses UWS. Right, it would too risky to change rim() as it goes all the way back to JDK 1.0. If you

Re: RFR 8180410: ByteArrayOutputStream should not throw IOExceptions

Hi Roger, On Mar 15, 2018, at 7:33 AM, Roger Riggs wrote: > BAOS.java: > > line 163: ok but I don't think I would keep using the expanded 'byte array > output stream" phrase > instead of the proper noun: ByteArrayOutputStream. (except for consistency) I don’t like it

Re: RFR 8193033 remove terminally deprecated sun.misc.Unsafe.defineClass

> On 15 Mar 2018, at 17:06, Paul Sandoz wrote: > > Hi, > > Please review this patch to remove sun.misc.Unsafe.defineClass in 11. > > There has been much outreach, by Alan and the Jigsaw team, about its public > replacement MethodHandles.Lookup.defineClass. > > CSR is

Re: RFR 8193033 remove terminally deprecated sun.misc.Unsafe.defineClass

+1 Mandy On 3/15/18 10:06 AM, Paul Sandoz wrote: Hi, Please review this patch to remove sun.misc.Unsafe.defineClass in 11. There has been much outreach, by Alan and the Jigsaw team, about its public replacement MethodHandles.Lookup.defineClass. CSR is here:

Re: RFR 8193033 remove terminally deprecated sun.misc.Unsafe.defineClass

On 15/03/2018 17:06, Paul Sandoz wrote: Hi, Please review this patch to remove sun.misc.Unsafe.defineClass in 11. There has been much outreach, by Alan and the Jigsaw team, about its public replacement MethodHandles.Lookup.defineClass. CSR is here:

Re: [PATCH] 8188240: Reflection Proxy should skip static methods

On 03/15/2018 05:26 PM, mandy chung wrote: > On 3/15/18 3:58 AM, Aleksey Shipilev wrote: >> On 03/15/2018 10:38 AM, David Holmes wrote: >>> To be pedantic, talking about "overriding static methods" is as wrong as >>> talking about "inheriting >>> static methods. They can't be inherited and so

RFR 8193033 remove terminally deprecated sun.misc.Unsafe.defineClass

Hi, Please review this patch to remove sun.misc.Unsafe.defineClass in 11. There has been much outreach, by Alan and the Jigsaw team, about its public replacement MethodHandles.Lookup.defineClass. CSR is here: https://bugs.openjdk.java.net/browse/JDK-8199699 Thanks, Paul. diff -r

Re: [PATCH] 8188240: Reflection Proxy should skip static methods

On 3/15/18 3:58 AM, Aleksey Shipilev wrote: On 03/15/2018 10:38 AM, David Holmes wrote: To be pedantic, talking about "overriding static methods" is as wrong as talking about "inheriting static methods. They can't be inherited and so can't be overridden. In this context perhaps "intercept"

Re: RFR 8193033 remove terminally deprecated sun.misc.Unsafe.defineClass

> On Mar 15, 2018, at 10:39 AM, Alan Bateman wrote: > > On 15/03/2018 17:06, Paul Sandoz wrote: >> Hi, >> >> Please review this patch to remove sun.misc.Unsafe.defineClass in 11. >> >> There has been much outreach, by Alan and the Jigsaw team, about its public >>

RFR 8199616: Fix @module declarations in tier1 tests

Hi, Please take a quick look on fix adding missing module dependencies to tests in :tier1 jdk tests. Webrev: http://cr.openjdk.java.net/~shurailine/8199616/webrev.00 Shura.

Re: RFR 8199616: Fix @module declarations in tier1 tests

On 3/15/18 3:40 PM, Alexandre (Shura) Iline wrote: Hi, Please take a quick look on fix adding missing module dependencies to tests in :tier1 jdk tests. Webrev: http://cr.openjdk.java.net/~shurailine/8199616/webrev.00 Looks okay.   But I'm surprised that

Re: RFR 8199616: Fix @module declarations in tier1 tests

How did you find the missing module dependencies? Why was it only noticed now? Can we automatically prevent backsliding? On Thu, Mar 15, 2018 at 3:40 PM Alexandre (Shura) Iline < alexandre.il...@oracle.com> wrote: > Hi, > > Please take a quick look on fix adding missing module dependencies to >

Re: RFR 8199616: Fix @module declarations in tier1 tests

> On Mar 15, 2018, at 4:15 PM, mandy chung wrote: > > > > On 3/15/18 3:40 PM, Alexandre (Shura) Iline wrote: >> Hi, >> >> Please take a quick look on fix adding missing module dependencies to tests >> in :tier1 jdk tests. >> >> Webrev: >>

Re: RFR 8180410: ByteArrayOutputStream should not throw IOExceptions

On Mar 15, 2018, at 8:56 AM, Brian Burkhalter wrote: > On Mar 15, 2018, at 7:33 AM, Roger Riggs wrote: > >> BAOS.java: >> >> line 163: ok but I don't think I would keep using the expanded 'byte array >> output stream" phrase >> instead of

Re: RFR 8199616: Fix @module declarations in tier1 tests

> On Mar 15, 2018, at 7:14 PM, Martin Buchholz wrote: > > Interesting. > > Is the end goal to have jtreg itself validate the @modules tag or to execute > each test as its own module? It seems like the sort of checking your tool is > doing belongs in jtreg itself. That

Re: RFR 8199616: Fix @module declarations in tier1 tests

On 3/15/18 4:35 PM, Alexandre (Shura) Iline wrote: Actually java/lang/ProcessHandle/JavaChild.java has a dependency on com.sun.management.OperatingSystemMXBean. I see.  Thanks Mandy

Re: RFR 8199616: Fix @module declarations in tier1 tests

Martin, > On Mar 15, 2018, at 4:30 PM, Martin Buchholz wrote: > > How did you find the missing module dependencies? I have a tool which runs tests one by one like this (I am simplifying): - run test with -javaoptions:”—limit-modules …” with only the modules listed

Re: RFR 8199616: Fix @module declarations in tier1 tests

Interesting. Is the end goal to have jtreg itself validate the @modules tag or to execute each test as its own module? It seems like the sort of checking your tool is doing belongs in jtreg itself. On Thu, Mar 15, 2018 at 5:12 PM Alexandre (Shura) Iline < alexandre.il...@oracle.com> wrote: >

Re: [PATCH] 8188240: Reflection Proxy should skip static methods

On 15/03/2018 5:56 PM, Peter Levart wrote: Hi Aleksey, In test, the following comment:   26  * @summary This is a test to ensure that proxies do not inherit static methods. I think the word "inherit" is not correct here. Interface static methods can not be inherited. VM already ensures

Re: [PATCH] 8188240: Reflection Proxy should skip static methods

On 03/15/2018 10:38 AM, David Holmes wrote: > On 15/03/2018 5:56 PM, Peter Levart wrote: >> Hi Aleksey, >> >> In test, the following comment: >> >>    26  * @summary This is a test to ensure that proxies do not inherit >> static methods. >> >> I think the word "inherit" is not correct here.

Re: [PATCH] 8188240: Reflection Proxy should skip static methods

On 03/15/2018 09:57 AM, Aleksey Shipilev wrote: On 03/15/2018 08:56 AM, Peter Levart wrote: Hi Aleksey, In test, the following comment:   26  * @summary This is a test to ensure that proxies do not inherit static methods. I think the word "inherit" is not correct here. Interface static

Re: [PATCH] 8188240: Reflection Proxy should skip static methods

Hi Aleksey, In test, the following comment:   26  * @summary This is a test to ensure that proxies do not inherit static methods. I think the word "inherit" is not correct here. Interface static methods can not be inherited. VM already ensures that. Perhaps the comment should be:    

Re: GetPrimitiveArrayCritical vs GetByteArrayRegion: 140x slow-down using -Xcheck:jni and java.util.zip.DeflaterOutputStream

Hi, On Thu, 2018-03-15 at 01:00 +, Ian Rogers wrote: > An old data point on how large a critical region should be comes from > java.nio.Bits. In JDK 9 the code migrated into unsafe, but in JDK 8 > the copies within a critical region were bound at most copying 1MB: >

Re: [PATCH] 8188240: Reflection Proxy should skip static methods

On 03/15/2018 08:56 AM, Peter Levart wrote: > Hi Aleksey, > > In test, the following comment: > >   26  * @summary This is a test to ensure that proxies do not inherit static > methods. > > I think the word "inherit" is not correct here. Interface static methods can > not be inherited. VM >

Re: Raw String Literal Library Support

On 14 March 2018 at 23:55, Stuart Marks wrote: > So, how about we define trimLeft, trimRight, and trimWhitespace > all in terms of Character.isWhitespace? This seems like a reasonable approach. I'd expect tab to be trimmed for example. Commons-Lang is a good source to

Re: RFR 8180410: ByteArrayOutputStream should not throw IOExceptions

Hi Brian, BAOS.java: line 163: ok but I don't think I would keep using the expanded 'byte array output stream" phrase instead of the proper noun: ByteArrayOutputStream. (except for consistency) In the Write.java test: line 60:  Probably "-" in the message should be "--" for consistency