Re: jpackage problem submitting to Apple Store

> On Jan 25, 2021, at 6:36 AM, John Crowley wrote: > > As an alternate, a link to Google Drive - > https://drive.google.com/drive/folders/1SgLhlovuH2x18gRh-ffhZCHVeXt1AOXo?usp=sharing > > > The

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v2]

On Mon, 25 Jan 2021 14:40:09 GMT, Coleen Phillimore wrote: >> Anton Kozlov has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Address feedback for signature generators >> - Enable -Wformat-nonliteral back > >

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v2]

On Mon, 25 Jan 2021 15:01:25 GMT, Anton Kozlov wrote: >> src/hotspot/share/jfr/instrumentation/jfrJvmtiAgent.cpp line 87: >> >>> 85: JavaThread* jt = JavaThread::thread_from_jni_environment(jni_env); >>> 86: DEBUG_ONLY(JfrJavaSupport::check_java_thread_in_native(jt));; >>> 87:

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v2]

On Sun, 24 Jan 2021 15:32:59 GMT, Anton Kozlov wrote: >> Please review the implementation of JEP 391: macOS/AArch64 Port. >> >> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and >> windows/aarch64. >> >> Major changes are in: >> * src/hotspot/cpu/aarch64: support of

Re: RFR: 8260329: Update references to TAOCP to latest edition

On Mon, 25 Jan 2021 06:10:29 GMT, Joe Darcy wrote: > Updating and regularizing several references to Knuth's The Art of Computer > Programming. Marked as reviewed by bpb (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/2215

Re: RFR: 8260329: Update references to TAOCP to latest edition [v2]

> Updating and regularizing several references to Knuth's The Art of Computer > Programming. Joe Darcy has updated the pull request incrementally with one additional commit since the last revision: 8260329 - Changes: - all: https://git.openjdk.java.net/jdk/pull/2215/files -

Re: RFR: 8260337: Optimize ImageReader lookup, used by Class.getResource [v2]

On Mon, 25 Jan 2021 15:47:37 GMT, Alan Bateman wrote: >> Claes Redestad has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Copyrights and rename containsLocation > > src/java.base/share/classes/jdk/internal/module/SystemModuleFinders.java

Does "strictfp" affect called/intrinsified Math functions?

Hi, Can I just check my understanding is correct, in that the following example will not actually return a "strictfp" value, because the Math.exp() is not strictfp and by default is a non-strictfp Intrinsic inline implementation? Thanks Andrew private strictfp double strictfpMathExp(double

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v2]

On Mon, 25 Jan 2021 09:52:00 GMT, Andrew Haley wrote: >> Hello >> Why is it not nice ? >> linux_aarch64 uses some linux specific tls function >> _ZN10JavaThread25aarch64_get_thread_helperEv from >> hotspot/os_cpu/linux_aarch64/threadLS_linux_aarch64.s >> which clobbers only r0 and r1 >>

Integrated: 8260329: Update references to TAOCP to latest edition

On Mon, 25 Jan 2021 06:10:29 GMT, Joe Darcy wrote: > Updating and regularizing several references to Knuth's The Art of Computer > Programming. This pull request has now been integrated. Changeset: 73c78c8a Author:Joe Darcy URL: https://git.openjdk.java.net/jdk/commit/73c78c8a

Re: RFR: 8260337: Optimize ImageReader lookup, used by Class.getResource

On Mon, 25 Jan 2021 00:05:52 GMT, Claes Redestad wrote: > This patch optimizes the code paths exercised by > `String.class.getResource("String.class")` by: > > - Adding an ASCII fast-path to methods verifying strings in the jimage, which > can then be done allocation-free > - Avoiding the

Re: RFR: 8260337: Optimize ImageReader lookup, used by Class.getResource

On Mon, 25 Jan 2021 00:05:52 GMT, Claes Redestad wrote: > This patch optimizes the code paths exercised by > `String.class.getResource("String.class")` by: > > - Adding an ASCII fast-path to methods verifying strings in the jimage, which > can then be done allocation-free > - Avoiding the

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v2]

On Sun, 24 Jan 2021 15:50:01 GMT, Anton Kozlov wrote: >> src/hotspot/cpu/aarch64/interpreterRT_aarch64.cpp line 86: >> >>> 84: >>> 85: switch (_num_int_args) { >>> 86: case 0: >> >> I don't think you need such a large switch statement. I think this can be >> expressed as >> if

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v3]

> Please review the implementation of JEP 391: macOS/AArch64 Port. > > It's heavily based on existing ports to linux/aarch64, macos/x86_64, and > windows/aarch64. > > Major changes are in: > * src/hotspot/cpu/aarch64: support of the new calling convention (subtasks > JDK-8253817, JDK-8253818)

Re: RFR: JDK-8183372 : Refactor java/lang/Class shell tests to java [v2]

On Fri, 22 Jan 2021 18:09:43 GMT, Mandy Chung wrote: >> Mahendra Chhipa has updated the pull request incrementally with one >> additional commit since the last revision: >> >> NonJavaName Tests updated >> Used newInstance() method to create the different EnclosingClasses at >> runtime > >

Re: Does "strictfp" affect called/intrinsified Math functions?

Hi Andrew, On 1/25/2021 11:22 AM, Andrew Leonard wrote: Hi, Can I just check my understanding is correct, in that the following example will not actually return a "strictfp" value, because the Math.exp() is not strictfp and by default is a non-strictfp Intrinsic inline implementation? Thanks

Re: RFR: JDK-8183372 : Refactor java/lang/Class shell tests to java [v3]

> https://bugs.openjdk.java.net/browse/JDK-8183372 Mahendra Chhipa has updated the pull request incrementally with one additional commit since the last revision: Implemented the review comments. - Changes: - all: https://git.openjdk.java.net/jdk/pull/2170/files - new:

Re: RFR: JDK-8183372 : Refactor java/lang/Class shell tests to java [v2]

On Fri, 22 Jan 2021 18:17:33 GMT, Mandy Chung wrote: >> Mahendra Chhipa has updated the pull request incrementally with one >> additional commit since the last revision: >> >> NonJavaName Tests updated >> Used newInstance() method to create the different EnclosingClasses at >> runtime > >

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v3]

On Mon, 25 Jan 2021 19:38:16 GMT, Anton Kozlov wrote: >> Please review the implementation of JEP 391: macOS/AArch64 Port. >> >> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and >> windows/aarch64. >> >> Major changes are in: >> * src/hotspot/cpu/aarch64: support of

Re: RFR: JDK-8183372 : Refactor java/lang/Class shell tests to java [v2]

On Fri, 22 Jan 2021 17:59:33 GMT, Mandy Chung wrote: >> Mahendra Chhipa has updated the pull request incrementally with one >> additional commit since the last revision: >> >> NonJavaName Tests updated >> Used newInstance() method to create the different EnclosingClasses at >> runtime > >

Re: RFR: JDK-8183372 : Refactor java/lang/Class shell tests to java [v2]

On Fri, 22 Jan 2021 18:16:54 GMT, Mandy Chung wrote: >> Mahendra Chhipa has updated the pull request incrementally with one >> additional commit since the last revision: >> >> NonJavaName Tests updated >> Used newInstance() method to create the different EnclosingClasses at >> runtime > >

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v3]

On Mon, 25 Jan 2021 21:18:59 GMT, Vladimir Kempik wrote: >> Hello >> I believe it was a workaround for issues with xcode 12.2 in early beta days. >> Those issues were fixed later in upstream jdk, so most likely we need to >> remove these workarounds. > > It seems these workarounds are still

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v3]

On Mon, 25 Jan 2021 20:54:38 GMT, Vladimir Kempik wrote: >> make/modules/java.desktop/lib/Awt2dLibraries.gmk line 573: >> >>> 571: EXTRA_HEADER_DIRS := $(LIBFONTMANAGER_EXTRA_HEADER_DIRS), \ >>> 572: WARNINGS_AS_ERRORS_xlc := false, \ >>> 573: DISABLED_WARNINGS_clang :=

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v3]

On Mon, 25 Jan 2021 19:42:41 GMT, Phil Race wrote: >> Anton Kozlov has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Refactor CDS disabling >> - Redo builsys support for aarch64-darwin > >

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v3]

On Mon, 25 Jan 2021 22:25:48 GMT, Vladimir Kempik wrote: >> Are you doing something somewhere to change the target version of macOS or >> SDK ? I had no such problem. >> I think we currently target a macOS 10.9 and if you are changing that it >> would need discussion. >> If you are changing it

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v3]

On Mon, 25 Jan 2021 22:47:33 GMT, Vladimir Kempik wrote: >> 1) I meant change to NSWindowStyleMaskBorderless from NSBorderlessWindowMask >> 2) So maybe rather than the deprecation suppression you could change both >> constants to the new ones. >> Ordinarily I'd say let someone else do that but

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v3]

On Mon, 25 Jan 2021 23:34:04 GMT, Phil Race wrote: >> that sounds good to me, I am just afraid to break intel mac on older macos >> versions with this change. > > That may actually be a valid concern. Both say macOS 10.12+ ... which might > conflict with the 10.9 target. Maybe you should

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v3]

On Mon, 25 Jan 2021 22:22:06 GMT, Phil Race wrote: >> It seems these workarounds are still needed: >> >> jdk/src/java.desktop/macosx/native/libsplashscreen/splashscreen_sys.m:300:39: >> error: 'NSAlphaFirstBitmapFormat' is deprecated: first deprecated in macOS >> 10.14

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v3]

On Mon, 25 Jan 2021 19:38:16 GMT, Anton Kozlov wrote: >> Please review the implementation of JEP 391: macOS/AArch64 Port. >> >> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and >> windows/aarch64. >> >> Major changes are in: >> * src/hotspot/cpu/aarch64: support of

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v3]

On Mon, 25 Jan 2021 22:42:40 GMT, Phil Race wrote: >> Min_macos version is changed to 11.0 for macos_aarch64 >> >> https://github.com/openjdk/jdk/pull/2200/files/0c2cb0a372bf1a8607810d773b53d6959616a816#diff-7cd97cdbeb3053597e5d6659016cdf0f60b2c412bd39934a43817ee0b717b7a7R136 > > 1) I meant

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v3]

On Mon, 25 Jan 2021 19:38:16 GMT, Anton Kozlov wrote: >> Please review the implementation of JEP 391: macOS/AArch64 Port. >> >> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and >> windows/aarch64. >> >> Major changes are in: >> * src/hotspot/cpu/aarch64: support of

Re: bug jpackage in JDK 15

On 1/24/2021 9:27 AM, Michael Hall wrote: /usr/libexec/java_home -v 14 --exec jpackage --version WARNING: Using incubator modules: jdk.incubator.jpackage 14.0.2 If of interest to anyone I still haven’t figured out signing. It errored giving some indication that the JDK had already been

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v2]

On Mon, 25 Jan 2021 13:23:27 GMT, Magnus Ihse Bursie wrote: >> Anton Kozlov has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Address feedback for signature generators >> - Enable -Wformat-nonliteral back > > Changes requested by ihse

RFR: 8260337: Optimize ImageReader lookup, used by Class.getResource

This patch optimizes the code paths exercised by `String.class.getResource("String.class")` by: - Adding an ASCII fast-path to methods verifying strings in the jimage, which can then be done allocation-free - Avoiding the allocation of the `long[8]` attributes when verifying only for the

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v2]

On Sun, 24 Jan 2021 15:32:59 GMT, Anton Kozlov wrote: >> Please review the implementation of JEP 391: macOS/AArch64 Port. >> >> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and >> windows/aarch64. >> >> Major changes are in: >> * src/hotspot/cpu/aarch64: support of

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v2]

On Mon, 25 Jan 2021 14:36:35 GMT, Coleen Phillimore wrote: >> Anton Kozlov has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Address feedback for signature generators >> - Enable -Wformat-nonliteral back > >

Re: RFR: 8260337: Optimize ImageReader lookup, used by Class.getResource [v2]

> This patch optimizes the code paths exercised by > `String.class.getResource("String.class")` by: > > - Adding an ASCII fast-path to methods verifying strings in the jimage, which > can then be done allocation-free > - Avoiding the allocation of the `long[8]` attributes when verifying only

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v2]

On Mon, 25 Jan 2021 14:03:40 GMT, Per Liden wrote: > In `make/autoconf/jvm-features.m4` I notice that you haven't enabled ZGC for > macos/aarch64. Is that just an oversight, or is there a reason for that? because it does not work processor_id has no "official docs"-friendly implementation,

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v2]

On Sun, 24 Jan 2021 15:32:59 GMT, Anton Kozlov wrote: >> Please review the implementation of JEP 391: macOS/AArch64 Port. >> >> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and >> windows/aarch64. >> >> Major changes are in: >> * src/hotspot/cpu/aarch64: support of

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v2]

On Mon, 25 Jan 2021 13:30:55 GMT, Vladimir Kempik wrote: >> make/modules/jdk.hotspot.agent/Lib.gmk line 34: >> >>> 32: >>> 33: else ifeq ($(call isTargetOs, macosx), true) >>> 34: SA_CFLAGS := -D_GNU_SOURCE -mno-omit-leaf-frame-pointer \ >> >> Is this really proper for macos-x64? I thought

Re: jpackage problem submitting to Apple Store

Trying again. Changed the name of pkg1.sh to just pkg1 in case email is dropping any executable attachment. John Crowley Charlotte, NC 203-856-2396 j.crow...@computer.org > On Jan 24, 2021, at 9:20 PM, Michael Hall wrote: > > > >> On Jan 24, 2021, at 8:28 AM, John Crowley wrote: >> >>

Re: jpackage problem submitting to Apple Store

As an alternate, a link to Google Drive - https://drive.google.com/drive/folders/1SgLhlovuH2x18gRh-ffhZCHVeXt1AOXo?usp=sharing Thanks, John Crowley Charlotte, NC 203-856-2396 j.crow...@computer.org >

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v3]

On Mon, 25 Jan 2021 23:35:52 GMT, Phil Race wrote: >> That may actually be a valid concern. Both say macOS 10.12+ ... which might >> conflict with the 10.9 target. > > Maybe you should just file a bug after all for this to be dealt with > separately. > Certainly if it is NOT fixed now such a

RE: [11u] RFR: 7146776: deadlock between URLStreamHandler.getHostAddress and file.Handler.openconnection

Hi Götz, thanks for the review! Best regards, Martin From: Lindenmaier, Goetz Sent: Montag, 25. Januar 2021 10:49 To: Doerr, Martin ; core-libs-dev ; jdk-updates-...@openjdk.java.net Cc: Langer, Christoph Subject: RE: [11u] RFR: 7146776: deadlock between URLStreamHandler.getHostAddress and

RE: [11u] RFR: 7146776: deadlock between URLStreamHandler.getHostAddress and file.Handler.openconnection

Hi, Thanks for downporting this, looks good. Best regards, Goetz. From: Doerr, Martin Sent: Tuesday, January 19, 2021 6:44 PM To: core-libs-dev ; jdk-updates-...@openjdk.java.net Cc: Lindenmaier, Goetz ; Langer, Christoph Subject: [11u] RFR: 7146776: deadlock between

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v2]

On Sun, 24 Jan 2021 16:29:31 GMT, Vladimir Kempik wrote: >> src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp line 5272: >> >>> 5270: void MacroAssembler::get_thread(Register dst) { >>> 5271: RegSet saved_regs = RegSet::range(r0, r1) + >>> BSD_ONLY(RegSet::range(r2, r17)) + lr - dst; >>>

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v2]

On Sun, 24 Jan 2021 16:10:44 GMT, Anton Kozlov wrote: >> src/hotspot/cpu/aarch64/interpreterRT_aarch64.cpp line 394: >> >>> 392: >>> 393: class SlowSignatureHandler >>> 394: : public NativeSignatureIterator { >> >> SlowSignatureHandler is turning into a maintenance nightmare. This isn't the

RFR: 8242456: PreviewFeature.Feature enum removal of TEXT_BLOCKS

The enum constant is unused, and can be removed. The class is not an API. - Commit messages: - 8242456: PreviewFeature.Feature enum removal of TEXT_BLOCKS Changes: https://git.openjdk.java.net/jdk/pull/2218/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=2218=00 Issue:

Re: RFR: 8242456: PreviewFeature.Feature enum removal of TEXT_BLOCKS

On Mon, 25 Jan 2021 11:55:42 GMT, Jan Lahoda wrote: > The enum constant is unused, and can be removed. The class is not an API. Marked as reviewed by jlaskey (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/2218

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v2]

On Sun, 24 Jan 2021 15:32:59 GMT, Anton Kozlov wrote: >> Please review the implementation of JEP 391: macOS/AArch64 Port. >> >> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and >> windows/aarch64. >> >> Major changes are in: >> * src/hotspot/cpu/aarch64: support of

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v2]

On Mon, 25 Jan 2021 13:18:34 GMT, Magnus Ihse Bursie wrote: >> Anton Kozlov has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Address feedback for signature generators >> - Enable -Wformat-nonliteral back > >