On Thu, 9 Sep 2021 14:31:19 GMT, Magnus Ihse Bursie wrote:
>> Currently, the build system defaults the libjvm.so location to "server".
>> This makes looking for `libjvm.so` awkward, see JDK-8273487 for example. We
>> need to see if moving the libjvm.so to a proper location breaks anything.
On Thu, 9 Sep 2021 10:14:48 GMT, kabutz
wrote:
> …of MAX_PRIORITY-2 during refactoring
>
> Appears in Java 17 for the first time.
>
> During refactoring, the priority was changed from Thread.MAX_PRIORITY - 2 to
> instead state Thread.MIN_PRIORITY - 2, which results in a negative priority,
On Thu, 9 Sep 2021 13:24:27 GMT, Andrey Turbanov
wrote:
>> Update code checks both non-null and instance of a class in java.naming
>> module classes.
>> The checks and explicit casts could also be replaced with pattern matching
>> for the instanceof operator.
>> For example:
>> The
> The commit in this PR implements the proposal for enhancement that was
> discussed in the core-libs-dev mailing list recently[1], for
> https://bugs.openjdk.java.net/browse/JDK-8231640
>
> At a high level - the `store()` APIs in `Properties` have been modified to
> now look for the
On Thu, 9 Sep 2021 12:25:17 GMT, Jovan Stevanovic
wrote:
>> GraalVM Native Image supports loading classes at runtime if they are known
>> during image build (class predefinition). This is achieved by the JVMTI
>> agent that registers dynamically generated classes in a regular HotSpot run.
>>
On Thu, 9 Sep 2021 20:14:01 GMT, Andy Herrick wrote:
> backport from jdk-18
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.java.net/jdk17/pull/306
On Thu, 9 Sep 2021 20:14:01 GMT, Andy Herrick wrote:
> backport from jdk-18
This must _not_ be integrated into this repo.
See [JDK-8273592](https://bugs.openjdk.java.net/browse/JDK-8273592) for an
explanation as to why. There is no more content approved for JDK 17. This
should go into
A similar issue on Ubuntu has been fixed by
[JDK-8238953](https://bugs.openjdk.java.net/browse/JDK-8238953). However,
tools/jpackage tests do not work on Debian Linux or other apt-based Linux, when
rpm package is installed. This issue proposes a general fix for apt-based Linux.
-
> Simple spec clarification. A CSR has also been drafted
> (https://bugs.openjdk.java.net/browse/JDK-8273296).
Naoto Sato has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The
Could you please review the 8233674 bug fixes?
This problem is caused by the antivirus software opening the file for a short
time, so CreateFile() should be retried.
-
Commit messages:
- 8233674: JarURLConnection.getJarFile throws Exception if some process is
holding the file
On Fri, 10 Sep 2021 11:07:52 GMT, Matthias Baesken wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8266490
>> extended the OSContainer API in order to also support the pids controller of
>> cgroups. However only pids.max output was added with 8266490.
>> There is a second parameter
On Thu, 9 Sep 2021 22:02:55 GMT, Aleksei Efimov wrote:
> Hi,
> The following fix changes type of exception thrown when an LDAP operation
> fails for reasons like read timeout or connection closure/cancellation:
> instead of throwing a general `NamingException`, the internal LDAP connection
>
On Thu, 9 Sep 2021 09:21:59 GMT, Matthias Baesken wrote:
> https://bugs.openjdk.java.net/browse/JDK-8266490
> extended the OSContainer API in order to also support the pids controller of
> cgroups. However only pids.max output was added with 8266490.
> There is a second parameter pids.current ,
> https://bugs.openjdk.java.net/browse/JDK-8266490
> extended the OSContainer API in order to also support the pids controller of
> cgroups. However only pids.max output was added with 8266490.
> There is a second parameter pids.current , see
>
On Thu, 9 Sep 2021 10:17:02 GMT, Aleksey Shipilev wrote:
> Currently, the build system defaults the libjvm.so location to "server".
> This makes looking for `libjvm.so` awkward, see JDK-8273487 for example. We
> need to see if moving the libjvm.so to a proper location breaks anything.
>
>
On 10/09/2021 08:01, Robert Scholte wrote:
Looking at the discussion I see a fear of extending the Properties
API, where every solution comes with its own little ugliness.
There's one topic that hasn't been mentioned yet: is Properties
responsible for writing its own content?
While breaking
On Thu, 9 Sep 2021 10:14:48 GMT, kabutz
wrote:
> …of MAX_PRIORITY-2 during refactoring
>
> Appears in Java 17 for the first time.
>
> During refactoring, the priority was changed from Thread.MAX_PRIORITY - 2 to
> instead state Thread.MIN_PRIORITY - 2, which results in a negative priority,
On Fri, 10 Sep 2021 13:18:49 GMT, Andy Herrick wrote:
> JDK-8271868 was pushed to JDK17 instead of jdk17u.
> This change is to back it out
This pull request has now been integrated.
Changeset: 4afbcaf5
Author:Andy Herrick
URL:
On Fri, 10 Sep 2021 10:15:45 GMT, Jaikiran Pai wrote:
>> The commit in this PR implements the proposal for enhancement that was
>> discussed in the core-libs-dev mailing list recently[1], for
>> https://bugs.openjdk.java.net/browse/JDK-8231640
>>
>> At a high level - the `store()` APIs in
On Fri, 10 Sep 2021 10:15:45 GMT, Jaikiran Pai wrote:
>> The commit in this PR implements the proposal for enhancement that was
>> discussed in the core-libs-dev mailing list recently[1], for
>> https://bugs.openjdk.java.net/browse/JDK-8231640
>>
>> At a high level - the `store()` APIs in
On Fri, 10 Sep 2021 12:21:41 GMT, Naoto Sato wrote:
>> Simple spec clarification. A CSR has also been drafted
>> (https://bugs.openjdk.java.net/browse/JDK-8273296).
>
> Naoto Sato has updated the pull request with a new target base due to a merge
> or a rebase. The incremental webrev excludes
On Fri, 10 Sep 2021 13:18:49 GMT, Andy Herrick wrote:
> JDK-8271868 was pushed to JDK17 instead of jdk17u.
> This change is to back it out
Marked as reviewed by asemenyuk (Reviewer).
-
PR: https://git.openjdk.java.net/jdk17/pull/307
Hi,
It does move the responsibility for that specific compatibility to the
person defining the system property.
I would document it as conventionally having the date in the format
expected.
In the context of a reproducible build, where the property is expected
to be used, the builder would
On Thu, 9 Sep 2021 14:31:19 GMT, Magnus Ihse Bursie wrote:
>> Currently, the build system defaults the libjvm.so location to "server".
>> This makes looking for `libjvm.so` awkward, see JDK-8273487 for example. We
>> need to see if moving the libjvm.so to a proper location breaks anything.
> The commit in this PR implements the proposal for enhancement that was
> discussed in the core-libs-dev mailing list recently[1], for
> https://bugs.openjdk.java.net/browse/JDK-8231640
>
> At a high level - the `store()` APIs in `Properties` have been modified to
> now look for the
Based on these inputs, I have now updated the PR to use the value of
this new system property verbatim while writing out the comment. I
realize you mentioned that we should use this value if it is non-null
and non-empty. In my updated PR, I instead use this value only if it is
non-null and
On Fri, 10 Sep 2021 16:48:15 GMT, Alexey Semenyuk wrote:
>> A similar issue on Ubuntu has been fixed by
>> [JDK-8238953](https://bugs.openjdk.java.net/browse/JDK-8238953). However,
>> tools/jpackage tests do not work on Debian Linux or other apt-based Linux,
>> when rpm package is installed.
On Tue, 7 Sep 2021 18:18:49 GMT, Naoto Sato wrote:
> Please review the fix to the issue. Avoiding overflow by not calling
> nanosUntil() directly, which will overflow beyond Long.MAX_VALUE difference
> in nano unit.
This pull request has now been integrated.
Changeset: 81d2acee
Author:
JDK-8271868 was pushed to JDK17 instead of jdk17u.
This change is to back it out
-
Commit messages:
- JDK-8273592: Backout JDK-8271868
Changes: https://git.openjdk.java.net/jdk17/pull/307/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk17=307=00
Issue:
On Fri, 10 Sep 2021 13:18:49 GMT, Andy Herrick wrote:
> JDK-8271868 was pushed to JDK17 instead of jdk17u.
> This change is to back it out
I fetched the PR commit and confirmed that it is a correct backout (revert) of
JDK-8271868.
-
Marked as reviewed by kcr (Author).
PR:
On Fri, 10 Sep 2021 12:03:48 GMT, Ao Qi wrote:
> A similar issue on Ubuntu has been fixed by
> [JDK-8238953](https://bugs.openjdk.java.net/browse/JDK-8238953). However,
> tools/jpackage tests do not work on Debian Linux or other apt-based Linux,
> when rpm package is installed. This issue
On Thu, 9 Sep 2021 13:37:45 GMT, Aleksey Shipilev wrote:
> This looks good. @cl4es might want to confirm that change was not intentional.
Completely unintentional, and perplexing since it's not a simple copy-paste
error..
-
PR: https://git.openjdk.java.net/jdk/pull/5439
On Thu, 9 Sep 2021 22:02:55 GMT, Aleksei Efimov wrote:
> Hi,
> The following fix changes type of exception thrown when an LDAP operation
> fails for reasons like read timeout or connection closure/cancellation:
> instead of throwing a general `NamingException`, the internal LDAP connection
>
On 10/09/21 7:59 pm, Roger Riggs wrote:
On Fri, 10 Sep 2021 10:15:45 GMT, Jaikiran Pai wrote:
The commit in this PR implements the proposal for enhancement that was
discussed in the core-libs-dev mailing list recently[1], for
https://bugs.openjdk.java.net/browse/JDK-8231640
At a high
On Fri, 10 Sep 2021 12:03:48 GMT, Ao Qi wrote:
> A similar issue on Ubuntu has been fixed by
> [JDK-8238953](https://bugs.openjdk.java.net/browse/JDK-8238953). However,
> tools/jpackage tests do not work on Debian Linux or other apt-based Linux,
> when rpm package is installed. This issue
On Thu, 9 Sep 2021 22:02:55 GMT, Aleksei Efimov wrote:
> Hi,
> The following fix changes type of exception thrown when an LDAP operation
> fails for reasons like read timeout or connection closure/cancellation:
> instead of throwing a general `NamingException`, the internal LDAP connection
>
8273616: Fix trivial doc typos in the java.base module
-
Commit messages:
- Initial commit
Changes: https://git.openjdk.java.net/jdk/pull/5475/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=5475=00
Issue: https://bugs.openjdk.java.net/browse/JDK-8273616
Stats: 55
On Fri, 10 Sep 2021 15:51:30 GMT, Jaikiran Pai wrote:
>> The commit in this PR implements the proposal for enhancement that was
>> discussed in the core-libs-dev mailing list recently[1], for
>> https://bugs.openjdk.java.net/browse/JDK-8231640
>>
>> At a high level - the `store()` APIs in
On Fri, 10 Sep 2021 12:03:48 GMT, Ao Qi wrote:
> A similar issue on Ubuntu has been fixed by
> [JDK-8238953](https://bugs.openjdk.java.net/browse/JDK-8238953). However,
> tools/jpackage tests do not work on Debian Linux or other apt-based Linux,
> when rpm package is installed. This issue
On Fri, 10 Sep 2021 18:11:37 GMT, Joe Wang wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Reflecting review comment.
>
> src/java.base/share/classes/java/util/spi/LocaleServiceProvider.java line 120:
>
>> 118: *
> Small spec clarification. Corresponding CSR has also been drafted.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Reflecting review comment.
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/5457/files
- new:
On Fri, 10 Sep 2021 20:57:34 GMT, Ian Graves wrote:
>> The duplicate condition in this chain of expressions needs to be shrunk to
>> drop a couple of character that are not excluded spacing marks.
>
> Ian Graves has updated the pull request incrementally with one additional
> commit since the
On Thu, 9 Sep 2021 08:31:30 GMT, Jaikiran Pai wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> update javadoc to match latest changes
>
> Hello Magnus,
>
>> Am I the only one thinking there should also be a way
On Thu, 9 Sep 2021 18:01:04 GMT, Jim Laskey wrote:
> RandomSupport.AbstractSplittableWithBrineGenerator. makeSplitsSpliterator is
> intending to create a salt from a random long. The salt should have random
> letters of size 4 for each consecutive 4 bits and then the last 4 bits as ff,
> i.e.
On Thu, 9 Sep 2021 15:56:04 GMT, Joe Wang wrote:
>> Jovan Stevanovic has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains one additional
>> commit
On Wed, 1 Sep 2021 13:28:34 GMT, Jovan Stevanovic
wrote:
> GraalVM Native Image supports loading classes at runtime if they are known
> during image build (class predefinition). This is achieved by the JVMTI agent
> that registers dynamically generated classes in a regular HotSpot run. The
>
On Fri, 10 Sep 2021 20:32:03 GMT, Naoto Sato wrote:
>> src/java.base/share/classes/java/util/spi/LocaleServiceProvider.java line
>> 120:
>>
>>> 118: * the locale sensitive services separated by a comma. It is only read
>>> and cached at
>>> 119: * the initialization of this class, so the
On Fri, 10 Sep 2021 20:35:25 GMT, Naoto Sato wrote:
>> Small spec clarification. Corresponding CSR has also been drafted.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Reflecting review comment.
Marked as reviewed by
On Thu, 9 Sep 2021 16:30:29 GMT, Ian Graves wrote:
>> Relaxing some assertion bounds to allow for small error values that still
>> show improvement over previous summation method.
>
> Ian Graves has updated the pull request incrementally with one additional
> commit since the last revision:
>
> The duplicate condition in this chain of expressions needs to be shrunk to
> drop a couple of character that are not excluded spacing marks.
Ian Graves has updated the pull request incrementally with one additional
commit since the last revision:
Refactoring test to whitebox
-
On Thu, 9 Sep 2021 18:01:04 GMT, Jim Laskey wrote:
> RandomSupport.AbstractSplittableWithBrineGenerator. makeSplitsSpliterator is
> intending to create a salt from a random long. The salt should have random
> letters of size 4 for each consecutive 4 bits and then the last 4 bits as ff,
> i.e.
On Thu, 9 Sep 2021 18:01:04 GMT, Jim Laskey wrote:
> RandomSupport.AbstractSplittableWithBrineGenerator. makeSplitsSpliterator is
> intending to create a salt from a random long. The salt should have random
> letters of size 4 for each consecutive 4 bits and then the last 4 bits as ff,
> i.e.
On Thu, 9 Sep 2021 23:29:24 GMT, Naoto Sato wrote:
> Small spec clarification. Corresponding CSR has also been drafted.
src/java.base/share/classes/java/util/spi/LocaleServiceProvider.java line 120:
> 118: * the locale sensitive services separated by a comma. It is only read
> and cached at
On Fri, 10 Sep 2021 14:08:05 GMT, Claes Redestad wrote:
> > This looks good. @cl4es might want to confirm that change was not
> > intentional.
>
> Completely unintentional, and perplexing since it's not a simple copy-paste
> error..
The thread priorities in Java are the wrong way round,
On Fri, 10 Sep 2021 20:57:34 GMT, Ian Graves wrote:
>> The duplicate condition in this chain of expressions needs to be shrunk to
>> drop a couple of character that are not excluded spacing marks.
>
> Ian Graves has updated the pull request incrementally with one additional
> commit since the
On Fri, 10 Sep 2021 21:16:19 GMT, Pavel Rappo wrote:
> 8273616: Fix trivial doc typos in the java.base module
Approved, except for two changes commented above: the original "it need only
force" is correct usage, and "it needs only force" is not good usage, but "it
only needs to force" would
On Wed, 1 Sep 2021 20:56:59 GMT, Mandy Chung wrote:
> Improve the specification to document the cases when
> `Lookup::ensureInitialized` returns as specified JVMS 5.5 and matches the
> implementation.
>
> Please also review CSR: https://bugs.openjdk.java.net/browse/JDK-8273253
This pull
On Thu, 9 Sep 2021 23:44:49 GMT, Brian Burkhalter wrote:
>> Raffaello Giulietti has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8271602: Add Math.ceilDiv() family parallel to Math.floorDiv() family
>
>
> This PR ideally continues #5285, which has been closed as a consequence of
> inadvertently removing the branch on my repo. See there for initial
> discussion.
>
> Sorry for the mess.
Raffaello Giulietti has updated the pull request incrementally with one
additional commit since the last
On Fri, 10 Sep 2021 21:52:36 GMT, John R Rose wrote:
>> Pavel Rappo has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Revert two fixes
>
> src/java.base/share/classes/java/nio/channels/FileChannel.java line 567:
>
>> 565: *
> 8273616: Fix trivial doc typos in the java.base module
Pavel Rappo has updated the pull request incrementally with one additional
commit since the last revision:
Revert two fixes
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/5475/files
- new:
On Fri, 10 Sep 2021 23:20:11 GMT, Pavel Rappo wrote:
>> 8273616: Fix trivial doc typos in the java.base module
>
> Pavel Rappo has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Revert two fixes
Marked as reviewed by iris (Reviewer).
On Fri, 10 Sep 2021 18:42:07 GMT, Raffaello Giulietti
wrote:
>> This PR ideally continues #5285, which has been closed as a consequence of
>> inadvertently removing the branch on my repo. See there for initial
>> discussion.
>>
>> Sorry for the mess.
>
> Raffaello Giulietti has updated the
On Fri, 10 Sep 2021 21:51:45 GMT, John R Rose wrote:
>> 8273616: Fix trivial doc typos in the java.base module
>
> src/java.base/share/classes/java/nio/channels/AsynchronousFileChannel.java
> line 399:
>
>> 397: * If {@code true} then this method is required to force
>> changes
…of MAX_PRIORITY-2 during refactoring
Appears in Java 17 for the first time.
During refactoring, the priority was changed from Thread.MAX_PRIORITY - 2 to
instead state Thread.MIN_PRIORITY - 2, which results in a negative priority,
and is thus set to Thread.NORM_PRIORITY. Thus the Cleaner by
On Thu, 9 Sep 2021 10:14:48 GMT, kabutz
wrote:
> …of MAX_PRIORITY-2 during refactoring
>
> Appears in Java 17 for the first time.
>
> During refactoring, the priority was changed from Thread.MAX_PRIORITY - 2 to
> instead state Thread.MIN_PRIORITY - 2, which results in a negative priority,
On Thu, 9 Sep 2021 10:14:48 GMT, kabutz
wrote:
> …of MAX_PRIORITY-2 during refactoring
>
> Appears in Java 17 for the first time.
>
> During refactoring, the priority was changed from Thread.MAX_PRIORITY - 2 to
> instead state Thread.MIN_PRIORITY - 2, which results in a negative priority,
On Thu, 9 Sep 2021 13:38:32 GMT, Aleksey Shipilev wrote:
>> …of MAX_PRIORITY-2 during refactoring
>>
>> Appears in Java 17 for the first time.
>>
>> During refactoring, the priority was changed from Thread.MAX_PRIORITY - 2
>> to instead state Thread.MIN_PRIORITY - 2, which results in a
On Thu, 9 Sep 2021 10:14:48 GMT, kabutz
wrote:
> …of MAX_PRIORITY-2 during refactoring
>
> Appears in Java 17 for the first time.
>
> During refactoring, the priority was changed from Thread.MAX_PRIORITY - 2 to
> instead state Thread.MIN_PRIORITY - 2, which results in a negative priority,
On Thu, 9 Sep 2021 13:37:23 GMT, Aleksey Shipilev wrote:
>> …of MAX_PRIORITY-2 during refactoring
>>
>> Appears in Java 17 for the first time.
>>
>> During refactoring, the priority was changed from Thread.MAX_PRIORITY - 2
>> to instead state Thread.MIN_PRIORITY - 2, which results in a
On Thu, 9 Sep 2021 15:36:08 GMT, Lance Andersen wrote:
>> src/java.base/share/classes/jdk/internal/ref/CleanerImpl.java line 228:
>>
>>> 226: super(cleaner, cleaner);
>>> 227: }
>>> 228: java
>>
>> Stray change.
>
> Not sure what the "java" is for here seems like a typo
On Thu, 9 Sep 2021 10:14:48 GMT, kabutz
wrote:
> …of MAX_PRIORITY-2 during refactoring
>
> Appears in Java 17 for the first time.
>
> During refactoring, the priority was changed from Thread.MAX_PRIORITY - 2 to
> instead state Thread.MIN_PRIORITY - 2, which results in a negative priority,
Looking at the discussion I see a fear of extending the Properties API,
where every solution comes with its own little ugliness.
There's one topic that hasn't been mentioned yet: is Properties
responsible for writing its own content?
While breaking up the JDK into modules, an weird thing was
On Thu, 9 Sep 2021 10:14:48 GMT, kabutz
wrote:
> …of MAX_PRIORITY-2 during refactoring
>
> Appears in Java 17 for the first time.
>
> During refactoring, the priority was changed from Thread.MAX_PRIORITY - 2 to
> instead state Thread.MIN_PRIORITY - 2, which results in a negative priority,
On Fri, 10 Sep 2021 12:03:48 GMT, Ao Qi wrote:
> A similar issue on Ubuntu has been fixed by
> [JDK-8238953](https://bugs.openjdk.java.net/browse/JDK-8238953). However,
> tools/jpackage tests do not work on Debian Linux or other apt-based Linux,
> when rpm package is installed. This issue
On Fri, 10 Sep 2021 12:21:41 GMT, Naoto Sato wrote:
>> Simple spec clarification. A CSR has also been drafted
>> (https://bugs.openjdk.java.net/browse/JDK-8273296).
>
> Naoto Sato has updated the pull request with a new target base due to a merge
> or a rebase. The incremental webrev excludes
76 matches
Mail list logo
