On Fri, 13 May 2022 01:35:40 GMT, Xiaohong Gong wrote:
>> Checking whether the indexes of masked lanes are inside of the valid memory
>> boundary is necessary for masked vector memory access. However, this could
>> be saved if the given offset is inside of the vector range that could make
>>
Hi all,
Some tests fail with Shenandoah GC after JDK-8282191.
The reason is that the assert in `ShenandoahControlThread::request_gc` misses
the case of `GCCause::_codecache_GC_threshold`.
It would be better to fix it.
Thanks.
Best regards,
Jie
-
Commit messages:
-
On Wed, 11 May 2022 16:30:41 GMT, Roger Riggs wrote:
>> PR#8599 8244681: proposes to add compiler warnings for possible lossy
>> conversions
>> From the CSR:
>>
>> "If the type of the right-hand operand of a compound assignment is not
>> assignment compatible with the type of the variable, a
> Checking whether the indexes of masked lanes are inside of the valid memory
> boundary is necessary for masked vector memory access. However, this could be
> saved if the given offset is inside of the vector range that could make sure
> no IOOBE (IndexOutOfBoundaryException) happens. The
On Thu, 12 May 2022 03:36:31 GMT, Paul Sandoz wrote:
>> Thanks for the review @PaulSandoz ! For the
>> `VectorIntrinsics.checkFromIndexSize`, I'm afraid it's not suitable to be
>> used here because the `outOfBounds` exception will be thrown if the offset
>> is not inside of the valid array
On Wed, 4 May 2022 03:56:10 GMT, Alexander Matveev wrote:
> - No changes to code provided by original fix.
> - Added ad hoc signing on macOS aarch64, since macOS aarch64 cannot execute
> unsigned code and code should be at least ad hoc signed.
> - Signing of app bundle produced by
> - No changes to code provided by original fix.
> - Added ad hoc signing on macOS aarch64, since macOS aarch64 cannot execute
> unsigned code and code should be at least ad hoc signed.
> - Signing of app bundle produced by AppContentTest.java fails, since it has
> invalid app bundle structure
On Fri, 13 May 2022 04:41:03 GMT, ExE Boss wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Updated copyrights
>> Fixed cast style to add a space after cast, (where consistent with file
>> style)
>> Improved
On Thu, 12 May 2022 16:47:43 GMT, Roger Riggs wrote:
> Updates to modules java.rmi and java.smartcardio to remove warnings about
> lossy-conversions introduced by PR#8599.
>
> Explicit casts are inserted where implicit casts occur.
>
> 8286393: Address possibly lossy conversions in java.rmi
>
On Fri, 13 May 2022 01:27:18 GMT, Xiaohong Gong wrote:
>> Maybe we could use `a.length - vsp.length() > 0 && offset u< a.length -
>> vsp.length()` which would hoist the first check outside of the loop.
>> Thanks.
>
>> Maybe we could use `a.length - vsp.length() > 0 && offset u< a.length -
>>
On Thu, 12 May 2022 16:07:54 GMT, Paul Sandoz wrote:
> Yes, the tests were run in debug mode. The reporting of the missing constant
> occurs for the compiled method that is called from the method where the
> constants are declared e.g.:
>
> ```
> 719 240b
On Thu, 12 May 2022 16:47:43 GMT, Roger Riggs wrote:
> Updates to modules java.rmi and java.smartcardio to remove warnings about
> lossy-conversions introduced by PR#8599.
>
> Explicit casts are inserted where implicit casts occur.
>
> 8286393: Address possibly lossy conversions in java.rmi
>
On Thu, 12 May 2022 08:43:56 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change to the build system which now makes
> bundled zlib as the default for macos aarch64 systems?
>
> We have been running into various intermittent failures on macos aarch64
> systems for several
On Thu, 12 May 2022 08:43:56 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change to the build system which now makes
> bundled zlib as the default for macos aarch64 systems?
>
> We have been running into various intermittent failures on macos aarch64
> systems for several
On Thu, 12 May 2022 09:49:17 GMT, Quan Anh Mai wrote:
> Maybe we could use `a.length - vsp.length() > 0 && offset u< a.length -
> vsp.length()` which would hoist the first check outside of the loop. Thanks.
Thanks for the review @merykitty ! We need the check `offset >= 0` which I
think is
ClassTransformer.java is duplicated because ClassTransformer.java was copied
from test/jdk/com/sun/jdi/lib/jdb to test/lib/jdk/test/lib/util at
[JDK-8240908](https://bugs.openjdk.java.net/browse/JDK-8240908).
test/lib/jdk/test/lib/util/ClassTransformer.java should be deleted and
On Tue, 10 May 2022 12:29:10 GMT, Severin Gehwolf wrote:
> Please review this change to the cgroup v1 subsystem which makes it more
> resilient on some of the stranger systems. Unfortunately, I wasn't able to
> re-create a similar system as the reporter. The idea of using the longest
>
On Wed, 11 May 2022 05:22:22 GMT, Shruthi wrote:
>> Removing the Duplicate keys present in XSLTErrorResources.java and
>> XPATHErrorResources.java
>>
>> The bug report for the same: https://bugs.openjdk.java.net/browse/JDK-8285097
>
> Shruthi has updated the pull request incrementally with one
On Thu, 12 May 2022 08:43:56 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change to the build system which now makes
> bundled zlib as the default for macos aarch64 systems?
>
> We have been running into various intermittent failures on macos aarch64
> systems for several
On Thu, 12 May 2022 08:23:11 GMT, Nick Gasson wrote:
>> src/hotspot/cpu/aarch64/foreign_globals_aarch64.cpp line 3:
>>
>>> 1: /*
>>> 2: * Copyright (c) 2020, 2021, Oracle and/or its affiliates. All rights
>>> reserved.
>>> 3: * Copyright (c) 2019, 2021, Arm Limited. All rights reserved.
>>
On Thu, 5 May 2022 23:39:30 GMT, Brian Burkhalter wrote:
>> Modify native multi-byte read-write code used by the `java.io` classes to
>> limit the size of the allocated native buffer thereby decreasing off-heap
>> memory footprint and increasing throughput.
>
> Brian Burkhalter has updated the
On Thu, 12 May 2022 03:34:19 GMT, David Holmes wrote:
>> Jorn Vernee has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 26 commits:
>>
>> - Block async exceptions during upcalls
>> - Merge branch 'foreign-preview-m' into
> set memory.swappiness to 0,swap space will not be used
> determine the value of memory.swappiness
> https://www.kernel.org/doc/Documentation/cgroup-v1/memory.txt
>
>
> Memory Limit: 50.00M
> Memory Soft Limit: Unlimited
> Memory & Swap Limit: 100.00M
> Maximum Processes Limit:
On Thu, 12 May 2022 06:11:03 GMT, Ioi Lam wrote:
>> Please review this change to the cgroup v1 subsystem which makes it more
>> resilient on some of the stranger systems. Unfortunately, I wasn't able to
>> re-create a similar system as the reporter. The idea of using the longest
>> substring
On Thu, 12 May 2022 03:32:15 GMT, David Holmes wrote:
>> Is it possible for these upcalls to be nested? If yes, we could add a
>> boolean to context to avoid unsetting the flag in those nested cases. And
>> now that I think we should probably add that check in
>> NoAsyncExceptionDeliveryMark
> Hi,
>
> This PR updates the VM implementation of the foreign linker, by bringing over
> commits from the panama-foreign repo.
>
> This is split off from the main JEP integration for 19, since we have limited
> resources to handle this. As such, this PR might fall over to 20, but it
> would
On Thu, 12 May 2022 09:50:39 GMT, xpbob wrote:
>> set memory.swappiness to 0,swap space will not be used
>> determine the value of memory.swappiness
>> https://www.kernel.org/doc/Documentation/cgroup-v1/memory.txt
>>
>>
>> Memory Limit: 50.00M
>> Memory Soft Limit: Unlimited
>>
On Wed, 11 May 2022 11:38:31 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which fixes build failures on macos
> when using `--with-zlib=bundled`?
>
> With this change the build now passes (tested both with bundled and system
> zlib variants).
>
> tier1, tier2 and tier3
On Wed, 11 May 2022 20:47:52 GMT, Brian Burkhalter wrote:
> Modify the specification of `SequenceInputStream.read(byte[],int,int)` to
> indicate that `-1` is returned at the EOF of the last stream even if `len` is
> zero.
Also, in the current implementation, when the end of the last contained
On Tue, 10 May 2022 01:23:55 GMT, Xiaohong Gong wrote:
> Checking whether the indexes of masked lanes are inside of the valid memory
> boundary is necessary for masked vector memory access. However, this could be
> saved if the given offset is inside of the vector range that could make sure
>
On Wed, 11 May 2022 16:00:32 GMT, Maxim Kartashev
wrote:
> This change seem to have made this group of declarations obsolete:
> `src/java.desktop/windows/native/libawt/windows/awt_Toolkit.h:157` (follow
> the
>
(cc:ing build-dev.)
On 2022-05-12 00:17, Michael Hall wrote:
Is this restricted somehow to Mac App Store applications?
Is a warning issued as stripping native commands may break application
functionality?
Is it not possible for the user to provide their own Info.plist with a
different
On Thu, 12 May 2022 08:43:56 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change to the build system which now makes
> bundled zlib as the default for macos aarch64 systems?
>
> We have been running into various intermittent failures on macos aarch64
> systems for several
On Wed, 20 Oct 2021 13:35:22 GMT, Martin Balao wrote:
> I'd like to propose a fix for JDK-8275535. This fix reverts the behavior to
> the state previous to JDK-8160768, where an authentication failure stops from
> trying other LDAP servers with the same credentials [1]. After JDK-8160768 we
>
On Thu, 12 May 2022 04:25:24 GMT, David Holmes wrote:
>> This change seem to have made this group of declarations obsolete:
>> `src/java.desktop/windows/native/libawt/windows/awt_Toolkit.h:157` (follow
>> the [link](
>>
On Thu, 12 May 2022 06:13:47 GMT, Ioi Lam wrote:
> I just started to look at the code so just one comment for now.
Sure, thanks for the review!
-
PR: https://git.openjdk.java.net/jdk/pull/8629
On 2022-05-12 13:17, Michael Hall wrote:
I had read this but possibly didn’t grok the issue myself. If I
understand correctly now the conflict isn’t within the application but
across applications to some other application that has already been
added to the Mac App Store that included the
>
> My primary suggestion would to be to use an UUID for the unique ID. They are
> of fixed length, are for all intents and purposes unique and you can conjure
> them up from your hat. (An alternative is that the user needs to specify a
> unique ID, but that is probably a less ideal
On Thu, 12 May 2022 09:50:39 GMT, xpbob wrote:
>> set memory.swappiness to 0,swap space will not be used
>> determine the value of memory.swappiness
>> https://www.kernel.org/doc/Documentation/cgroup-v1/memory.txt
>>
>>
>> Memory Limit: 50.00M
>> Memory Soft Limit: Unlimited
>>
On Thu, 12 May 2022 09:24:23 GMT, Jorn Vernee wrote:
> Do nothing special for async exceptions. i.e. if they happen anywhere between
> 1. and 6. they will end up in one of the fallback handlers and the VM will be
> terminated.
My understanding is that if they materialize while we're executing
On 2022-05-12 04:58, Magnus Ihse Bursie wrote:
On 2022-05-12 13:17, Michael Hall wrote:
A solution like including a bundle identifier something like
net.java.openjdk.MYAPP.java would be possible at packaging time but
not at build time.
To fix this at build time you would need to generate a
On Thu, 12 May 2022 13:32:03 GMT, xpbob wrote:
>> set memory.swappiness to 0,swap space will not be used
>> determine the value of memory.swappiness
>> https://www.kernel.org/doc/Documentation/cgroup-v1/memory.txt
>>
>>
>> Memory Limit: 50.00M
>> Memory Soft Limit: Unlimited
>>
On Thu, 12 May 2022 08:43:56 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change to the build system which now makes
> bundled zlib as the default for macos aarch64 systems?
>
> We have been running into various intermittent failures on macos aarch64
> systems for several
> This is a (preliminary) patch for javac implementation for the third preview
> of pattern matching for switch (type patterns in switches).
>
> Draft JLS:
>
> On May 12, 2022, at 4:42 AM, Magnus Ihse Bursie
> wrote:
>
>> Some further spelunking reveals the issue. Consider this:
>>
>> % otool -s __TEXT __info_plist -v
>> APP_NAME.app/Contents/runtime/Contents/Home/bin/java
>> …
>>
>> CFBundleIdentifier
>> net.java.openjdk.java
>> …
>>
On Thu, 12 May 2022 08:23:11 GMT, Nick Gasson wrote:
>> src/hotspot/cpu/aarch64/foreign_globals_aarch64.cpp line 3:
>>
>>> 1: /*
>>> 2: * Copyright (c) 2020, 2021, Oracle and/or its affiliates. All rights
>>> reserved.
>>> 3: * Copyright (c) 2019, 2021, Arm Limited. All rights reserved.
>>
> set memory.swappiness to 0,swap space will not be used
> determine the value of memory.swappiness
> https://www.kernel.org/doc/Documentation/cgroup-v1/memory.txt
>
>
> Memory Limit: 50.00M
> Memory Soft Limit: Unlimited
> Memory & Swap Limit: 100.00M
> Maximum Processes Limit:
On Thu, 12 May 2022 13:32:03 GMT, xpbob wrote:
>> set memory.swappiness to 0,swap space will not be used
>> determine the value of memory.swappiness
>> https://www.kernel.org/doc/Documentation/cgroup-v1/memory.txt
>>
>>
>> Memory Limit: 50.00M
>> Memory Soft Limit: Unlimited
>>
On Thu, 12 May 2022 01:29:13 GMT, Yasumasa Suenaga wrote:
>> Yasumasa Suenaga has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Calculate char offset before realloc()
>
> Thanks for all to review this PR! I think we should separate this
> Despite the hash value being cached for Strings, computing the hash still
> represents a significant CPU usage for applications handling lots of text.
>
> Even though it would be generally better to do it through an enhancement to
> the autovectorizer, the complexity of doing it by hand is
> Despite the hash value being cached for Strings, computing the hash still
> represents a significant CPU usage for applications handling lots of text.
>
> Even though it would be generally better to do it through an enhancement to
> the autovectorizer, the complexity of doing it by hand is
> On May 12, 2022, at 8:10 AM, Michael Hall wrote:
>
>
>
>>
>> My primary suggestion would to be to use an UUID for the unique ID. They are
>> of fixed length, are for all intents and purposes unique and you can conjure
>> them up from your hat. (An alternative is that the user needs to
On Wed, 20 Oct 2021 13:35:22 GMT, Martin Balao wrote:
> I'd like to propose a fix for JDK-8275535. This fix reverts the behavior to
> the state previous to JDK-8160768, where an authentication failure stops from
> trying other LDAP servers with the same credentials [1]. After JDK-8160768 we
>
On Wed, 11 May 2022 19:13:55 GMT, Paul Sandoz wrote:
>> Ludovic Henry has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 18 commits:
>>
>> - Fix overlapping registers
>> - Actually fix h when hashcode is vectorized
>> - Merge
On Wed, 11 May 2022 20:40:30 GMT, Joe Darcy wrote:
> While doing a CSR review of another issue, I noticed some cases in
> InputStream and OutputStream what would benefit from being upgraded to
> implSpec and related javadoc tags.
>
> The "A subclass must provide an implementation of this
On Thu, 12 May 2022 08:43:56 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change to the build system which now makes
> bundled zlib as the default for macos aarch64 systems?
>
> We have been running into various intermittent failures on macos aarch64
> systems for several
> set memory.swappiness to 0,swap space will not be used
> determine the value of memory.swappiness
> https://www.kernel.org/doc/Documentation/cgroup-v1/memory.txt
>
>
> Memory Limit: 50.00M
> Memory Soft Limit: Unlimited
> Memory & Swap Limit: 100.00M
> Maximum Processes Limit:
On Thu, 12 May 2022 13:32:03 GMT, xpbob wrote:
>> set memory.swappiness to 0,swap space will not be used
>> determine the value of memory.swappiness
>> https://www.kernel.org/doc/Documentation/cgroup-v1/memory.txt
>>
>>
>> Memory Limit: 50.00M
>> Memory Soft Limit: Unlimited
>>
On Fri, 6 May 2022 23:30:44 GMT, Jonathan Gibbons wrote:
> Please review a small doc fix to update incorrect use of `{@link}` on arrays
> of primitive types.
This is fixed in 8282191 (JEP 424), which is already integrated.
-
PR: https://git.openjdk.java.net/jdk/pull/8584
Updates to modules java.rmi and java.smartcardio to remove warnings about
lossy-conversions introduced by PR#8599.
Explicit casts are inserted where implicit casts occur.
8286393: Address possibly lossy conversions in java.rmi
8286388: Address possibly lossy conversions in java.smartcardio
On Thu, 12 May 2022 00:10:28 GMT, Joe Darcy wrote:
> Noticed by inspection during a CSR review, small refactoring to use a
> message-cause exception constructor when one is available.
>
> Will update the copyright before a push.
This pull request has now been integrated.
Changeset: 160944bc
On Thu, 12 May 2022 15:58:57 GMT, Severin Gehwolf wrote:
>> src/hotspot/os/linux/cgroupV1Subsystem_linux.cpp line 113:
>>
>>> 111: }
>>> 112: buf[MAXPATHLEN-1] = '\0';
>>> 113: _path = os::strdup(buf);
>>
>> I think this code can be simplified a lot with
> Please review this change to the cgroup v1 subsystem which makes it more
> resilient on some of the stranger systems. Unfortunately, I wasn't able to
> re-create a similar system as the reporter. The idea of using the longest
> substring match for the cgroupv1 file paths was based on the fact
On Mon, 21 Mar 2022 10:45:27 GMT, Maurizio Cimadamore
wrote:
> This PR contains the API and implementation changes for JEP-424 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] -
On Wed, 20 Oct 2021 13:35:22 GMT, Martin Balao wrote:
> I'd like to propose a fix for JDK-8275535. This fix reverts the behavior to
> the state previous to JDK-8160768, where an authentication failure stops from
> trying other LDAP servers with the same credentials [1]. After JDK-8160768 we
>
On Thu, 10 Feb 2022 15:25:09 GMT, Aleksei Efimov wrote:
>>> The concerns are two folds:
>>>
>>> * without a regression test, you have to trust that the source changes
>>> actually work, and there's typically no verification possible
>>> * without a regression test, the next refactoring change
On Thu, 12 May 2022 16:01:17 GMT, Jorn Vernee wrote:
>> Hi,
>>
>> This PR updates the VM implementation of the foreign linker, by bringing
>> over commits from the panama-foreign repo.
>>
>> This is split off from the main JEP integration for 19, since we have
>> limited resources to handle
> Hi,
>
> This PR updates the VM implementation of the foreign linker, by bringing over
> commits from the panama-foreign repo.
>
> This is split off from the main JEP integration for 19, since we have limited
> resources to handle this. As such, this PR might fall over to 20, but it
> would
On Thu, 12 May 2022 16:01:50 GMT, Brian Burkhalter wrote:
>> Modify the specification of `SequenceInputStream.read(byte[],int,int)` to
>> indicate that `-1` is returned at the EOF of the last stream even if `len`
>> is zero.
>
> Brian Burkhalter has updated the pull request incrementally with
On Thu, 12 May 2022 16:47:43 GMT, Roger Riggs wrote:
> Updates to modules java.rmi and java.smartcardio to remove warnings about
> lossy-conversions introduced by PR#8599.
>
> Explicit casts are inserted where implicit casts occur.
>
> 8286393: Address possibly lossy conversions in java.rmi
>
> Removing the Duplicate keys present in XSLTErrorResources.java and
> XPATHErrorResources.java
>
> The bug report for the same: https://bugs.openjdk.java.net/browse/JDK-8285097
Shruthi has refreshed the contents of this pull request, and previous commits
have been removed. The incremental
On Thu, 12 May 2022 04:06:44 GMT, David Holmes wrote:
>> Ioi Lam has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> @AlanBateman comments - remove thros IllegalArgumentException clause
>
> Nice cleanup! I checked back in JDK 7 and couldn't
On Wed, 11 May 2022 23:08:32 GMT, Ioi Lam wrote:
> The API `jdk.internal.perf.Perf.::attach(String user, int lvmid)` is never
> used. It should be removed, and all the handling of a specified user name
> should be removed.
This pull request has now been integrated.
Changeset: 74eee28a
On Thu, 12 May 2022 14:08:11 GMT, Alan Bateman wrote:
>> Ioi Lam has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> @AlanBateman comments - remove thros IllegalArgumentException clause
>
>
> Noticed by inspection during a CSR review, small refactoring to use a
> message-cause exception constructor when one is available.
>
> Will update the copyright before a push.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Update
On Tue, 10 May 2022 21:32:10 GMT, Roger Riggs wrote:
> PR#8599 8244681: proposes to add compiler warnings for possible lossy
> conversions
> From the CSR:
>
> "If the type of the right-hand operand of a compound assignment is not
> assignment compatible with the type of the variable, a cast
> The API `jdk.internal.perf.Perf.::attach(String user, int lvmid)` is never
> used. It should be removed, and all the handling of a specified user name
> should be removed.
Ioi Lam has updated the pull request incrementally with one additional commit
since the last revision:
@AlanBateman
On Thu, 12 May 2022 12:10:53 GMT, Maurizio Cimadamore
wrote:
>> Okay, I see. I think I acted a little too hastily on this yesterday. I'll
>> revert the change that uses this blocking mechanism.
>>
>> The stack more or less looks like this during an upcall:
>>
>>
>> | ---
>> | |
>> | ---
On Thu, 12 May 2022 04:15:50 GMT, Alexander Matveev
wrote:
>> - It is not possible to support native JDK commands such as "java" inside
>> Mac App Store bundles due to embedded info.plist. Workarounds suggested in
>> JDK-8286122 does not seems to be visible.
>> - With proposed fix we will
On Thu, 12 May 2022 16:47:43 GMT, Roger Riggs wrote:
> Updates to modules java.rmi and java.smartcardio to remove warnings about
> lossy-conversions introduced by PR#8599.
>
> Explicit casts are inserted where implicit casts occur.
>
> 8286393: Address possibly lossy conversions in java.rmi
>
Hi,
This PR brings over commits from the panama-foreign repo. These commits mostly
pertain to the switch to ASM and away from MethodHandle combinators for the
binding recipe specialization. But, there is one more commit which adds freeing
of downcall stubs, since those changes were mostly Java
On Thu, 12 May 2022 17:17:37 GMT, Jorn Vernee wrote:
> Hi,
>
> This PR brings over commits from the panama-foreign repo. These commits
> mostly pertain to the switch to ASM and away from MethodHandle combinators
> for the binding recipe specialization. But, there is one more commit which
>
On Thu, 12 May 2022 13:07:24 GMT, David Holmes wrote:
>> I think the Arm Ltd one was probably changed by me in one of the PRs in the
>> Panama repo.
>
> That's fine, just needed to check. But as these are now being committed to
> mainline the year does need to change to 2022 - at least in
On Wed, 11 May 2022 23:08:32 GMT, Ioi Lam wrote:
> The API `jdk.internal.perf.Perf.::attach(String user, int lvmid)` is never
> used. It should be removed, and all the handling of a specified user name
> should be removed.
Marked as reviewed by alanb (Reviewer).
On Thu, 12 May 2022 13:55:20 GMT, Nick Gasson wrote:
>> That's fine, just needed to check. But as these are now being committed to
>> mainline the year does need to change to 2022 - at least in Oracle
>> copyright. @nick-arm will have to advise what he thinks should be done with
>> the ARM
> Hi,
>
> This PR updates the VM implementation of the foreign linker, by bringing over
> commits from the panama-foreign repo.
>
> This is split off from the main JEP integration for 19, since we have limited
> resources to handle this. As such, this PR might fall over to 20, but it
> would
On Wed, 11 May 2022 15:32:38 GMT, Christoph Langer wrote:
> This augments the ZipException upon rejecting a Zip File containing entry
> names with "." or ".." elements.
>
> It furthermore tries to clean up & compact the logic for detecting "." and
> ".." and it adds a method
> This PR contains the API and implementation changes for JEP-424 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.java.net/jeps/424
Maurizio Cimadamore has updated the pull
On Fri, 29 Apr 2022 08:29:52 GMT, Guoxiong Li wrote:
>>> Remind: please use the command `/jep JEP-424` [1] to mark this PR.
>>>
>>> [1]
>>> https://wiki.openjdk.java.net/display/SKARA/Pull+Request+Commands#PullRequestCommands-/jep
>>
>> Question: I'm willing to try it out. If something goes
On Tue, 10 May 2022 12:29:10 GMT, Severin Gehwolf wrote:
> Please review this change to the cgroup v1 subsystem which makes it more
> resilient on some of the stranger systems. Unfortunately, I wasn't able to
> re-create a similar system as the reporter. The idea of using the longest
>
On Thu, 10 Mar 2022 08:52:17 GMT, Сергей Цыпанов wrote:
>> `List.of()` along with `Set.of()` create unmodifiable `List/Set` but with
>> smaller footprint comparing to `Arrays.asList()` / `new HashSet()` when
>> called with vararg of size 0, 1, 2.
>>
>> In general replacement of
> Hi,
>
> This PR updates the VM implementation of the foreign linker, by bringing over
> commits from the panama-foreign repo.
>
> This is split off from the main JEP integration for 19, since we have limited
> resources to handle this. As such, this PR might fall over to 20, but it
> would
On Thu, 12 May 2022 14:53:03 GMT, Jorn Vernee wrote:
>> Hi,
>>
>> This PR updates the VM implementation of the foreign linker, by bringing
>> over commits from the panama-foreign repo.
>>
>> This is split off from the main JEP integration for 19, since we have
>> limited resources to handle
> Hi,
>
> This PR updates the VM implementation of the foreign linker, by bringing over
> commits from the panama-foreign repo.
>
> This is split off from the main JEP integration for 19, since we have limited
> resources to handle this. As such, this PR might fall over to 20, but it
> would
On Thu, 12 May 2022 13:55:20 GMT, Nick Gasson wrote:
>> That's fine, just needed to check. But as these are now being committed to
>> mainline the year does need to change to 2022 - at least in Oracle
>> copyright. @nick-arm will have to advise what he thinks should be done with
>> the ARM
> Modify the specification of `SequenceInputStream.read(byte[],int,int)` to
> indicate that `-1` is returned at the EOF of the last stream even if `len` is
> zero.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8286200: Change
On Thu, 12 May 2022 08:41:47 GMT, Raffaello Giulietti
wrote:
> Also, in the current implementation, when the end of the last contained
> stream has been reached and `-1` is returned, none of the arguments is
> checked, so a caller can pass `null` for `b` or out of bounds indices `off`
> and
On Thu, 12 May 2022 15:48:47 GMT, Brian Burkhalter wrote:
>> Modify the specification of `SequenceInputStream.read(byte[],int,int)` to
>> indicate that `-1` is returned at the EOF of the last stream even if `len`
>> is zero.
>
> Brian Burkhalter has updated the pull request incrementally with
On Thu, 12 May 2022 14:00:44 GMT, Thomas Stuefe wrote:
>> Please review this change to the cgroup v1 subsystem which makes it more
>> resilient on some of the stranger systems. Unfortunately, I wasn't able to
>> re-create a similar system as the reporter. The idea of using the longest
>>
On Thu, 12 May 2022 15:50:47 GMT, Raffaello Giulietti
wrote:
> I think the same change shall apply to the `@throws NullPointerException`
> clause.
Yeah looks like it.
-
PR: https://git.openjdk.java.net/jdk/pull/8664
1 - 100 of 124 matches
Mail list logo
