On Fri, 27 May 2022 05:31:28 GMT, Stuart Marks wrote:
>> XenoAmess has updated the pull request with a new target base due to a merge
>> or a rebase. The pull request now contains 16 commits:
>>
>> - Merge branch 'master' of https://git.openjdk.java.net/jdk into fix_8284780
>> - Merge
> as title.
XenoAmess has updated the pull request incrementally with two additional
commits since the last revision:
- Merge remote-tracking branch 'stuart-marks/pull/8302' into fix_8284780
# Conflicts:
#src/java.base/share/classes/java/util/HashSet.java
#
> as title.
XenoAmess has updated the pull request incrementally with six additional
commits since the last revision:
- Update src/java.base/share/classes/java/util/LinkedHashSet.java
Co-authored-by: liach <7806504+li...@users.noreply.github.com>
- Update
On Thu, 26 May 2022 23:05:32 GMT, Joe Darcy wrote:
>> Time to start getting ready for JDK 20...
>
> Joe Darcy has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Respond to review feedback.
Marked as reviewed by dholmes (Reviewer).
> The bespoke caching scheme in `jl.invoke.LambdaFormEditor.TransformKey`
> allows keys to be compacted when all byte values of the key fit in 4 bits,
> otherwise a byte array is allocated and used. This means that all transforms
> with a kind value above 15 will be forced to allocate and use
On Wed, 25 May 2022 09:38:08 GMT, Claes Redestad wrote:
> The bespoke caching scheme in `jl.invoke.LambdaFormEditor.TransformKey`
> allows keys to be compacted when all byte values of the key fit in 4 bits,
> otherwise a byte array is allocated and used. This means that all transforms
> with
On Wed, 25 May 2022 14:13:52 GMT, Claes Redestad wrote:
>> The bespoke caching scheme in `jl.invoke.LambdaFormEditor.TransformKey`
>> allows keys to be compacted when all byte values of the key fit in 4 bits,
>> otherwise a byte array is allocated and used. This means that all transforms
>>
On Fri, 27 May 2022 14:18:19 GMT, Claes Redestad wrote:
> In preparation of #8855 this PR refactors the conversions from `List` to
> array and array to `List`, reducing the number of conversions when calling
> `MethodHandles.dropArguments` in particular. This remove about ~5% of
> allocations
On Fri, 27 May 2022 10:29:14 GMT, Maurizio Cimadamore
wrote:
> This patch fix a missing rethrow in `MemorySessionImpl::addOrCleanupIfFail`.
> As noted in the JBS issue, this bug does not affect correctness, but it
> delays error reporting.
>
> Writing a test for this is nearly impossible,
This patch fix a missing rethrow in `MemorySessionImpl::addOrCleanupIfFail`. As
noted in the JBS issue, this bug does not affect correctness, but it delays
error reporting.
Writing a test for this is nearly impossible, given that (a) a memory resource
created against a closed session would be
On Wed, 25 May 2022 23:08:38 GMT, Brian Burkhalter wrote:
> If only a leftover `char` remains in the stream, do not add `-1` to the
> return value in `lockedRead()`.
Looks fine to me.
-
Marked as reviewed by jpai (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/8895
On Wed, 25 May 2022 00:35:24 GMT, Joe Darcy wrote:
>> This is an early review of changes to better model JVM access flags, that is
>> "modifiers" like public, protected, etc. but explicitly at a VM level.
>>
>> Language level modifiers and JVM level access flags are closely related, but
>>
On Wed, 25 May 2022 23:08:38 GMT, Brian Burkhalter wrote:
> If only a leftover `char` remains in the stream, do not add `-1` to the
> return value in `lockedRead()`.
This pull request has now been integrated.
Changeset: 6520843f
Author:Brian Burkhalter
URL:
Test change to silently pass if the test environment encounters a
NoRouteToHostException. These are intermittent at the moment but I will attempt
to find an alternative to the use of example.com in some follow up work.
-
Commit messages:
- 8281695: jtreg test
On Fri, 27 May 2022 06:14:13 GMT, XenoAmess wrote:
>> as title.
>
> XenoAmess has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Merge remote-tracking branch 'stuart-marks/pull/8302' into fix_8284780
>
># Conflicts:
>#
On Thu, 26 May 2022 23:05:32 GMT, Joe Darcy wrote:
>> Time to start getting ready for JDK 20...
>
> Joe Darcy has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Respond to review feedback.
Marked as reviewed by erikj (Reviewer).
On Wed, 25 May 2022 23:08:38 GMT, Brian Burkhalter wrote:
> If only a leftover `char` remains in the stream, do not add `-1` to the
> return value in `lockedRead()`.
Marked as reviewed by rriggs (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/8895
On Fri, 27 May 2022 14:18:19 GMT, Claes Redestad wrote:
> In preparation of #8855 this PR refactors the conversions from `List` to
> array and array to `List`, reducing the number of conversions when calling
> `MethodHandles.dropArguments` in particular. This remove about ~5% of
> allocations
In preparation of #8855 this PR refactors the conversions from `List` to array
and array to `List`, reducing the number of conversions when calling
`MethodHandles.dropArguments` in particular. This remove about ~5% of
allocations on the `StringConcatFactoryBootstraps` microbenchmark.
On Fri, 27 May 2022 14:18:19 GMT, Claes Redestad wrote:
> In preparation of #8855 this PR refactors the conversions from `List` to
> array and array to `List`, reducing the number of conversions when calling
> `MethodHandles.dropArguments` in particular. This remove about ~5% of
> allocations
On Fri, 27 May 2022 14:18:19 GMT, Claes Redestad wrote:
> In preparation of #8855 this PR refactors the conversions from `List` to
> array and array to `List`, reducing the number of conversions when calling
> `MethodHandles.dropArguments` in particular. This remove about ~5% of
> allocations
On Fri, 27 May 2022 14:38:27 GMT, Claes Redestad wrote:
>> src/java.base/share/classes/java/lang/invoke/MethodHandles.java line 5266:
>>
>>> 5264: */
>>> 5265: public static MethodHandle dropArguments(MethodHandle target, int
>>> pos, List> valueTypes) {
>>> 5266: return
On Wed, 11 May 2022 05:58:31 GMT, Yasumasa Suenaga wrote:
> I saw some compiler warnings when I tried to build OpenJDK with GCC 12.0.1 on
> Fedora 36.
> As you can see, the warnings spreads several areas. Let me know if I should
> separate them by area.
>
> * -Wstringop-overflow
> *
The new assertion in src/hotspot/share/utilities/globalDefinitions.hpp
inline const char* type2name(BasicType t) {
assert((uint)t < T_CONFLICT + 1, "invalid type");
return type2name_tab[t];
}
is failing with test
compiler/jvmci/errors/TestInvalidDebugInfo.java
I have filed:
On Wed, 25 May 2022 00:35:24 GMT, Joe Darcy wrote:
>> This is an early review of changes to better model JVM access flags, that is
>> "modifiers" like public, protected, etc. but explicitly at a VM level.
>>
>> Language level modifiers and JVM level access flags are closely related, but
>>
On Thu, 26 May 2022 18:02:14 GMT, Raffaello Giulietti
wrote:
> BigDecimal(String) currently fails to accept some strings produced by
> BigDecimal.toString(). This PR removes this limitation.
test/jdk/java/math/BigDecimal/StringConstructor.java line 69:
> 67:
On Fri, 27 May 2022 01:12:18 GMT, Joe Wang wrote:
> Addresses an insufficiency of error handling in the XPath implementation.
> Some cleanup where appropriate, without attempting to do too much as this is
> a component that hasn't had much changes for 15 years, a fairly stable
> application.
On Sun, 17 Apr 2022 16:17:30 GMT, liach wrote:
> Convert dynamic proxies to hidden classes. Modifies the serialization of
> proxies (requires change in "Java Object Serialization Specification"). Makes
> the proxies hidden in stack traces. Removes duplicate logic in proxy building.
>
> The
> BigDecimal(String) currently fails to accept some strings produced by
> BigDecimal.toString(). This PR removes this limitation.
Raffaello Giulietti has updated the pull request incrementally with one
additional commit since the last revision:
8233760: Result of BigDecimal.toString throws
On Thu, 26 May 2022 23:05:32 GMT, Joe Darcy wrote:
>> Time to start getting ready for JDK 20...
>
> Joe Darcy has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Respond to review feedback.
Marked as reviewed by iris (Reviewer).
> as title.
XenoAmess has updated the pull request incrementally with one additional commit
since the last revision:
do it as naotoj said
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/8302/files
- new:
8287353: Use snippet tag instead of pre tag in Javadoc of InterruptedException
-
Commit messages:
- Use snippet tag instead of pre tag
Changes: https://git.openjdk.java.net/jdk/pull/8400/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=8400=00
Issue:
On Tue, 26 Apr 2022 15:04:15 GMT, Thiago Henrique Hüpner
wrote:
> 8287353: Use snippet tag instead of pre tag in Javadoc of InterruptedException
If this is a valid change, could someone please create a Jira issue to link to
it?
-
PR: https://git.openjdk.java.net/jdk/pull/8400
On Tue, 26 Apr 2022 15:04:15 GMT, Thiago Henrique Hüpner
wrote:
> 8287353: Use snippet tag instead of pre tag in Javadoc of InterruptedException
(not a maintainer) You can make one yourself in https://bugreport.java.com.
-
PR: https://git.openjdk.java.net/jdk/pull/8400
On Wed, 25 May 2022 00:35:24 GMT, Joe Darcy wrote:
>> This is an early review of changes to better model JVM access flags, that is
>> "modifiers" like public, protected, etc. but explicitly at a VM level.
>>
>> Language level modifiers and JVM level access flags are closely related, but
>>
On Fri, 27 May 2022 22:00:24 GMT, Brent Christian wrote:
>> Please review this change to replace the finalizer in
>> `AbstractLdapNamingEnumeration` with a Cleaner.
>>
>> The pieces of state required for cleanup (`LdapCtx homeCtx`, `LdapResult
>> res`, and `LdapClient enumClnt`) are moved to
On Fri, 27 May 2022 01:12:18 GMT, Joe Wang wrote:
> Addresses an insufficiency of error handling in the XPath implementation.
> Some cleanup where appropriate, without attempting to do too much as this is
> a component that hasn't had much changes for 15 years, a fairly stable
> application.
The change is trivial, but I'll need help from someone to create a JBS issue &
sponsor this PR.
-
Commit messages:
- Copy edit: remove pleonasm
Changes: https://git.openjdk.java.net/jdk/pull/8766/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=8766=00
Issue:
> In preparation of #8855 this PR refactors the conversions from `List` to
> array and array to `List`, reducing the number of conversions when calling
> `MethodHandles.dropArguments` in particular. This remove about ~5% of
> allocations on the `StringConcatFactoryBootstraps` microbenchmark.
On Fri, 27 May 2022 20:16:12 GMT, Joe Darcy wrote:
>> Raffaello Giulietti has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8233760: Result of BigDecimal.toString throws overflow exception on new
>> BigDecimal(str)
>
>
On Fri, 27 May 2022 01:12:18 GMT, Joe Wang wrote:
> Addresses an insufficiency of error handling in the XPath implementation.
> Some cleanup where appropriate, without attempting to do too much as this is
> a component that hasn't had much changes for 15 years, a fairly stable
> application.
On Fri, 27 May 2022 16:19:56 GMT, Naoto Sato wrote:
>> XenoAmess has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Merge remote-tracking branch 'stuart-marks/pull/8302' into fix_8284780
>>
>># Conflicts:
>>#
On Wed, 18 May 2022 11:45:46 GMT, Anthony Vanelverdinghe
wrote:
> The change is trivial, but I'll need help from someone to create a JBS issue
> & sponsor this PR.
Marked as reviewed by darcy (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/8766
On Wed, 18 May 2022 11:45:46 GMT, Anthony Vanelverdinghe
wrote:
> The change is trivial, but I'll need help from someone to create a JBS issue
> & sponsor this PR.
Marked as reviewed by iris (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/8766
> Please review this change to replace the finalizer in
> `AbstractLdapNamingEnumeration` with a Cleaner.
>
> The pieces of state required for cleanup (`LdapCtx homeCtx`, `LdapResult
> res`, and `LdapClient enumClnt`) are moved to a static inner class . From
> there, the change is fairly
> Addresses an insufficiency of error handling in the XPath implementation.
> Some cleanup where appropriate, without attempting to do too much as this is
> a component that hasn't had much changes for 15 years, a fairly stable
> application.
>
> Test: tier2 passed
> JCK: JCK XML tests passed
On Fri, 27 May 2022 01:12:18 GMT, Joe Wang wrote:
> Addresses an insufficiency of error handling in the XPath implementation.
> Some cleanup where appropriate, without attempting to do too much as this is
> a component that hasn't had much changes for 15 years, a fairly stable
> application.
On Fri, 27 May 2022 16:08:03 GMT, liach wrote:
> If `parameterList` is too slow for `List.of` copies the backing parameter
> types array, wouldn't calling
> `JavaUtilCollectionAccess::listFromTrustedArray` a better alternative, as it
> only allocates one wrapper and has better performance on
On Fri, 27 May 2022 19:27:44 GMT, ExE Boss wrote:
> If `parameterList` is too slow for `List.of` copies the backing parameter
> types array, wouldn't calling
> `JavaUtilCollectionAccess::listFromTrustedArray` a better alternative, as it
> only allocates one wrapper and has better performance
> 8287353: Use snippet tag instead of pre tag in Javadoc of InterruptedException
Thiago Henrique Hüpner has updated the pull request incrementally with one
additional commit since the last revision:
Fix pull request comment
-
Changes:
- all:
On Wed, 18 May 2022 11:45:46 GMT, Anthony Vanelverdinghe
wrote:
> The change is trivial, but I'll need help from someone to create a JBS issue
> & sponsor this PR.
Hello @anthonyvdotbe, I've created
https://bugs.openjdk.java.net/browse/JDK-8287440 for this change. Please edit
the title of
On Wed, 25 May 2022 00:35:24 GMT, Joe Darcy wrote:
>> This is an early review of changes to better model JVM access flags, that is
>> "modifiers" like public, protected, etc. but explicitly at a VM level.
>>
>> Language level modifiers and JVM level access flags are closely related, but
>>
On Fri, 27 May 2022 17:17:28 GMT, Joe Wang wrote:
>> Addresses an insufficiency of error handling in the XPath implementation.
>> Some cleanup where appropriate, without attempting to do too much as this is
>> a component that hasn't had much changes for 15 years, a fairly stable
>>
On Thu, 26 May 2022 18:50:07 GMT, Xue-Lei Andrew Fan wrote:
> Hi,
>
> May I have this test update reviewed?
>
> The ForceGC could be enhanced by using smaller wait/sleep time, and shared
> cleaner.
>
> Thanks,
> Xuelei
Marked as reviewed by bchristi (Reviewer).
-
PR:
On Fri, 27 May 2022 10:29:14 GMT, Maurizio Cimadamore
wrote:
> This patch fix a missing rethrow in `MemorySessionImpl::addOrCleanupIfFail`.
> As noted in the JBS issue, this bug does not affect correctness, but it
> delays error reporting.
>
> Writing a test for this is nearly impossible,
On Wed, 25 May 2022 00:35:24 GMT, Joe Darcy wrote:
>> This is an early review of changes to better model JVM access flags, that is
>> "modifiers" like public, protected, etc. but explicitly at a VM level.
>>
>> Language level modifiers and JVM level access flags are closely related, but
>>
> Please review this change to replace the finalizer in
> `AbstractLdapNamingEnumeration` with a Cleaner.
>
> The pieces of state required for cleanup (`LdapCtx homeCtx`, `LdapResult
> res`, and `LdapClient enumClnt`) are moved to a static inner class . From
> there, the change is fairly
On Tue, 26 Apr 2022 15:04:15 GMT, Thiago Henrique Hüpner
wrote:
> 8287353: Use snippet tag instead of pre tag in Javadoc of InterruptedException
src/java.base/share/classes/java/lang/InterruptedException.java line 35:
> 33: * this exception. The following code can be used to achieve
> 34:
On Fri, 27 May 2022 21:53:38 GMT, Roger Riggs wrote:
> As for retaining SUPER, both SUPER and IDENTITY have location class and
> according to the BasicAccessFlagTest, the bit patterns should be disjoint
If the defined set of class locations, considered over time, have non-disjoint
59 matches
Mail list logo
