On Tue, 15 Sep 2020 09:39:29 GMT, Daniel Fuchs wrote:
>> There are some little flaws in LdapDNSProvider and auxilliary classes,
>> mostly in Javadoc.
>>
>> In detail:
>> src/java.naming/share/classes/com/sun/jndi/ldap/DefaultLdapDnsProvider.java:
>> Unnecessary import
>>
On Tue, 15 Sep 2020 07:47:54 GMT, Christoph Langer wrote:
> There are some little flaws in LdapDNSProvider and auxilliary classes, mostly
> in Javadoc.
>
> In detail:
> src/java.naming/share/classes/com/sun/jndi/ldap/DefaultLdapDnsProvider.java:
> Unnecessary import
>
On Tue, 22 Sep 2020 13:39:38 GMT, Aleksei Efimov wrote:
>> test/jdk/com/sun/jndi/ldap/DeadSSLLdapTimeoutTest.java line 171:
>>
>>> 169: System.err.println("Server socket. Failure to accept
>>> connection:");
>>> 170:
On Tue, 22 Sep 2020 20:19:21 GMT, Alexey Bakhtin wrote:
>> Hi,
>>
>> Plaese review JDK-8245527 fix which implements LDAP Channel Binding support
>> for Java GSS/Kerberos.
>> Initial review is available at core-devs:
>>
On Fri, 18 Sep 2020 12:59:07 GMT, Aleksei Efimov wrote:
> Hi,
>
> Please help to review
> [JDK-8251188](https://bugs.openjdk.java.net/browse/JDK-8251188) fix which
> helps to improve LDAP
> tests stability. The list of changes: 1. Usages of wildcard address have been
> r
ttps://bugs.openjdk.java.net/browse/JDK-8169942). Before the
> fix the failure rate was 1 out of 4 runs.
> After the fix it was executed 400+ times alongside to other LDAP tests, and
> showed no failures, and therefore removed
> from the problem list. Thank you, Aleksei
Aleksei Efimov
On Tue, 22 Sep 2020 12:30:47 GMT, Daniel Fuchs wrote:
>> Hi,
>>
>> Please help to review
>> [JDK-8251188](https://bugs.openjdk.java.net/browse/JDK-8251188) fix which
>> helps to improve LDAP
>> tests stability. The list of changes: 1. Usages of wildcard address have
>> been replaced with
Hi,
Please help to review
[JDK-8251188](https://bugs.openjdk.java.net/browse/JDK-8251188) fix which helps
to improve LDAP
tests stability. The list of changes: 1. Usages of wildcard address have been
replaced with loopback address. This
change includes addition of `LDAPTestUtils.initEnv`
On Sat, 5 Sep 2020 18:55:53 GMT, Andrey Turbanov
wrote:
> 8258422: Cleanup unnecessary null comparison before instanceof check in
> java.base
Hi @turbanoff,
This PR is ready for integration - `JDK-8258657` has been resolved.
You can proceed with issuing `integrate` bot command. Then I will
On Mon, 11 Jan 2021 23:29:53 GMT, Aleksei Efimov wrote:
>> @AlekseiEfimov `HttpClientImpl` is not in `java.base` module. So I think
>> it's better to not touch it under this PR.
>
> To double check that docs build will be stable after integration the
> following action
On Mon, 11 Jan 2021 17:12:24 GMT, Andrey Turbanov
wrote:
>> Hi @turbanoff,
>> This PR is ready for integration - `JDK-8258657` has been resolved.
>> You can proceed with issuing `integrate` bot command. Then I will `sponsor`
>> it.
>> But before that, I would like to ask if you would like to
On Wed, 16 Dec 2020 10:32:12 GMT, Andrey Turbanov
wrote:
>> 8258422: Cleanup unnecessary null comparison before instanceof check in
>> java.base
>
> Andrey Turbanov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8258422: Cleanup
On Wed, 16 Dec 2020 09:44:37 GMT, Chris Hegarty wrote:
>> Andrey Turbanov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8258422: Cleanup unnecessary null comparison before instanceof check in
>> java.base
>> use instanceof pattern
On Wed, 2 Dec 2020 20:15:02 GMT, Andrey Turbanov
wrote:
>> This seems like a reasonable change, which improves readability.
>>
>> My preference is to wait a little longer (hopefully no more than a couple of
>> weeks), until [JEP 394](https://openjdk.java.net/jeps/394) - "Pattern
>> Matching
On Mon, 9 Nov 2020 09:19:44 GMT, Jie Fu wrote:
> Hi all,
>
> May I get reviews for this change?
>
> com/sun/jndi/dns/ConfigTests/PortUnreachable.java fails occasionally on some
> of our testing platforms.
> The reason is that the hard coded Threshold (1000 ms) [1] is a little smaller
> than
On Sat, 19 Dec 2020 10:29:23 GMT, Chris Hegarty wrote:
>> Thank you for checking `HttpURLConnection` and `Socket`.
>> The latest version looks good to me.
>
> This issue is blocked by [8258657][1]. It should not be integrated until
> after 8258657 has been resolved. The JIRA issues have been
On Thu, 21 Jan 2021 19:57:04 GMT, Alexey Bakhtin wrote:
>> Please review a small patch to enable LDAP TLS Channel Binding with StartTLS
>> Extension.
>> Test from the bug report and jtreg javax/naming tests are passed.
>
> Alexey Bakhtin has updated the pull request incrementally with one
On Fri, 22 Jan 2021 14:42:10 GMT, Alexey Bakhtin wrote:
>> Please review a small patch to enable LDAP TLS Channel Binding with StartTLS
>> Extension.
>> Test from the bug report and jtreg javax/naming tests are passed.
>
> Alexey Bakhtin has updated the pull request incrementally with one
On Wed, 20 Jan 2021 14:41:26 GMT, Daniel Fuchs wrote:
>> Please review a small patch to enable LDAP TLS Channel Binding with StartTLS
>> Extension.
>> Test from the bug report and jtreg javax/naming tests are passed.
>
> That look reasonable to me. But what would happen if at some point after
On Thu, 21 Jan 2021 13:13:38 GMT, Alexey Bakhtin wrote:
>> Please review a small patch to enable LDAP TLS Channel Binding with StartTLS
>> Extension.
>> Test from the bug report and jtreg javax/naming tests are passed.
>
> Alexey Bakhtin has updated the pull request incrementally with one
On Wed, 27 Jan 2021 12:15:43 GMT, Claes Redestad wrote:
> Some small modernizations and cleanups that ultimately help startup of apps
> using JNDI/InitialContext
Marked as reviewed by aefimov (Committer).
-
PR: https://git.openjdk.java.net/jdk/pull/2259
On Wed, 27 Jan 2021 16:03:48 GMT, Daniel Fuchs wrote:
>> Some small modernizations and cleanups that ultimately help startup of apps
>> using JNDI/InitialContext
>
> Looks fine to me. I have satisfied myself that `c` couldn't be a primitive
> type if we reach here.
> Please make sure to run
On Tue, 22 Jun 2021 16:07:12 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review the second half of my update for the `java.time`
>> package to make use of switch expressions?
>>
>> This PR was split into two parts due to the large number of files affected.
>>
>> Kind
On Tue, 22 Jun 2021 17:50:05 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review the second half of my update for the `java.time`
>> package to make use of switch expressions?
>>
>> This PR was split into two parts due to the large number of files affected.
>>
>> Kind
On Tue, 22 Jun 2021 10:50:17 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review the second half of my update for the `java.time`
> package to make use of switch expressions?
>
> This PR was split into two parts due to the large number of files affected.
>
> Kind regards,
>
On Thu, 24 Jun 2021 12:01:04 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review the second half of my update for the `java.time`
>> package to make use of switch expressions?
>>
>> This PR was split into two parts due to the large number of files affected.
>>
>> Kind
d no failures related
> to the change were observed.
Aleksei Efimov has updated the pull request incrementally with one additional
commit since the last revision:
Add bug id to Timeout.java jtreg header
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/4227/files
- new: ht
On Thu, 27 May 2021 15:33:00 GMT, Daniel Fuchs wrote:
> LGTM. I really wish git had a better `diff` !
> Can you add `@bug 8265309` to com/sun/jndi/dns/ConfigTests/Timeout.java since
> this is a product change?
Thanks for the review and the suggestion @dfuch . Bug ID has been added.
Hi,
`com/sun/jndi/dns/ConfigTests/Timeout.java ` was seen failing intermittently
with "Address already in use" `BindException`. The reason of this failure is
that `disconnect` call in JNDI `DnsClient` fails to rebind the datagram socket
to the original port during `disconnect` call (the
On Thu, 27 May 2021 15:02:01 GMT, Aleksei Efimov wrote:
> Hi,
>
> `com/sun/jndi/dns/ConfigTests/Timeout.java ` was seen failing intermittently
> with "Address already in use" `BindException`. The reason of this failure is
> that `disconnect` call in JNDI `D
Current fix tries to tackle an issue with URL connection referencing
non-existing Jar file entries:
If an entry that doesn't exist is specified in an URL connection the underlying
Jar file is still cached even if an exception is thrown after that. Such
behavior prevents the caller, for
ests
> - ``:jdk_core:`` tests
> - `api/java_util`,`api/java_net` JCK tests
Aleksei Efimov has updated the pull request incrementally with one additional
commit since the last revision:
JDK-8264048: Remove old version of RemoveJar test
-
Changes:
- all: htt
On Wed, 31 Mar 2021 11:24:02 GMT, Daniel Fuchs wrote:
>> Current fix tries to tackle an issue with URL connection referencing
>> non-existing Jar file entries:
>> If an entry that doesn't exist is specified in an URL connection the
>> underlying Jar file is still cached even if an exception is
On Tue, 30 Mar 2021 11:30:48 GMT, Aleksei Efimov wrote:
> Current fix tries to tackle an issue with URL connection referencing
> non-existing Jar file entries:
> If an entry that doesn't exist is specified in an URL connection the
> underlying Jar file is still cached even if
On Tue, 16 Mar 2021 08:56:29 GMT, Aleksey Shipilev wrote:
>> Seems fine. Lets hope no caller relies on this throwing AIOOBE.
>>
>> ..Thomas
>
>> This looks right but I'm surprised it isn't caught by tests (@AlekseiEfimov
>> - do you have suggests for tests that would be useful to add here?)
>
On Fri, 12 Mar 2021 13:25:31 GMT, Aleksey Shipilev wrote:
> SonarCloud rightfully says:
> The length of "values" is always ">=0", so update this test to either "==0"
> or ">0".
>
> // make sure at least one value was returned
> if(values.length < 0) { // <--- here
>
On Fri, 19 Mar 2021 17:13:58 GMT, Alex Blewitt
wrote:
>> As with #2993 changing the order of `final static` to `static final` for the
>> `java.management`, `java.management.rmi` and `java.naming` modules.
>
> Alex Blewitt has updated the pull request incrementally with one additional
> commit
On Mon, 12 Apr 2021 14:09:55 GMT, Conor Cleary wrote:
>> ### Description
>> This fix is part of a previous effort to both cleanup/modernise JNDI code,
>> the details of which can be seen in
>> [JDK-8048091](https://bugs.openjdk.java.net/browse/JDK-8048091). A number
>> JNDI methods under
On Tue, 13 Apr 2021 10:04:19 GMT, Conor Cleary wrote:
>> ### Description
>> This fix is part of a previous effort to both cleanup/modernise JNDI code,
>> the details of which can be seen in
>> [JDK-8048091](https://bugs.openjdk.java.net/browse/JDK-8048091). A number
>> JNDI methods under
On Thu, 26 Aug 2021 07:04:45 GMT, Andrey Turbanov
wrote:
> Usage of thread-safe collection Vector is unnecessary. It's recommended to
> use ArrayList/array if a thread-safe implementation is not needed. In
> post-BiasedLocking times, this is gets worse, as every access is synchronized.
> I
On Mon, 6 Sep 2021 08:08:33 GMT, Andrey Turbanov
wrote:
> Update code checks both non-null and instance of a class in java.naming
> module classes.
> The checks and explicit casts could also be replaced with pattern matching
> for the instanceof operator.
> For example:
> The following
On Thu, 9 Sep 2021 13:24:27 GMT, Andrey Turbanov
wrote:
>> Update code checks both non-null and instance of a class in java.naming
>> module classes.
>> The checks and explicit casts could also be replaced with pattern matching
>> for the instanceof operator.
>> For example:
>> The
On Thu, 9 Sep 2021 22:02:55 GMT, Aleksei Efimov wrote:
> Hi,
> The following fix changes type of exception thrown when an LDAP operation
> fails for reasons like read timeout or connection closure/cancellation:
> instead of throwing a general `NamingException`, the internal LDA
On Fri, 10 Sep 2021 17:04:58 GMT, Michael Osipov
wrote:
>> Hi,
>> The following fix changes type of exception thrown when an LDAP operation
>> fails for reasons like read timeout or connection closure/cancellation:
>> instead of throwing a general `NamingException`, the internal LDAP
>>
Hi,
The following fix changes type of exception thrown when an LDAP operation fails
for reasons like read timeout or connection closure/cancellation: instead of
throwing a general `NamingException`, the internal LDAP connection class will
throw a
kupPolicy` - a class whose instances describe the
> characteristics of one forward lookup operation.
>
> More details in [JEP-418](https://openjdk.java.net/jeps/418).
>
> Testing: new and existing `tier1:tier3` tests
Aleksei Efimov has updated the pull request incrementally w
kupPolicy` - a class whose instances describe the
> characteristics of one forward lookup operation.
>
> More details in [JEP-418](https://openjdk.java.net/jeps/418).
>
> Testing: new and existing `tier1:tier3` tests
Aleksei Efimov has updated the pull request incrementally wi
On Wed, 20 Oct 2021 18:47:32 GMT, Alan Bateman wrote:
>> Aleksei Efimov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Change InetAddressResolver method names
>
> src/java.base/share/classes/java
On Sat, 16 Oct 2021 10:48:32 GMT, Mark Sheppard wrote:
> What’s in a name? I find the method names of the InetAddressResolver
> interface a bit ambiguous. Typically in this DNS problem space one speaks of
> lookup to resolve a hostname to its associated addresses and reverse lookup
> to
On Sat, 16 Oct 2021 12:30:44 GMT, Mark Sheppard wrote:
> So Suggestion is refector remove Configuration to simplify the interface and
> provide the BULITIN_RESOLVER and hostname as parameters to the
> InetAddressResolverProvider::get method
During work on this JEP we've examined the approach
On Fri, 15 Oct 2021 17:09:46 GMT, Daniel Fuchs wrote:
>> Aleksei Efimov has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Add @since tags to new API classes
>> - Add checks and test for empty stream reso
On Sun, 17 Oct 2021 21:39:06 GMT, Mark Sheppard wrote:
> I think that a hostname is constant while a host is up, but it can be
> changed, and when changed a host restart is required. I don't think it is
> quite as dynamic as has been suggested, but I open to correction.
It is possible to
kupPolicy` - a class whose instances describe the
> characteristics of one forward lookup operation.
>
> More details in [JEP-418](https://openjdk.java.net/jeps/418).
>
> Testing: new and existing `tier1:tier3` tests
Aleksei Efimov has updated the pull request increme
On Fri, 15 Oct 2021 14:25:02 GMT, Daniel Fuchs wrote:
>> Aleksei Efimov has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Add @since tags to new API classes
>> - Add checks and test for empty stream reso
On Fri, 15 Oct 2021 17:19:26 GMT, Daniel Fuchs wrote:
>> Aleksei Efimov has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Add @since tags to new API classes
>> - Add checks and test for empty stream res
On Sun, 17 Oct 2021 21:03:56 GMT, Mark Sheppard wrote:
> getByName requires a hostname lookup and getByAdress requires (eventually - I
> know the docs says there’s no reverse lookup) an address reverse lookup.
> Thus, a logical mapping is getByName —> lookupHostname, and getByAddr —>
>
kupPolicy` - a class whose instances describe the
> characteristics of one forward lookup operation.
>
> More details in [JEP-418](https://openjdk.java.net/jeps/418).
>
> Testing: new and existing `tier1:tier3` tests
Aleksei Efimov has updated the pull request incrementally wi
kupPolicy` - a class whose instances describe the
> characteristics of one forward lookup operation.
>
> More details in [JEP-418](https://openjdk.java.net/jeps/418).
>
> Testing: new and existing `tier1:tier3` tests
Aleksei Efimov has updated the pull request with a new tar
This change implements a new service provider interface for host name and
address resolution, so that java.net.InetAddress API can make use of resolvers
other than the platform's built-in resolver.
The following API classes are added to `java.net.spi` package to facilitate
this:
-
On Wed, 20 Oct 2021 15:41:35 GMT, Daniel Fuchs wrote:
>> Aleksei Efimov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Change InetAddressResolver method names
>
> Marked as reviewed by dfuchs (R
kupPolicy` - a class whose instances describe the
> characteristics of one forward lookup operation.
>
> More details in [JEP-418](https://openjdk.java.net/jeps/418).
>
> Testing: new and existing `tier1:tier3` tests
Aleksei Efimov has updated the pull request incrementally
On Tue, 5 Oct 2021 12:00:15 GMT, Aleksei Efimov wrote:
> This change implements a new service provider interface for host name and
> address resolution, so that java.net.InetAddress API can make use of
> resolvers other than the platform's built-in resolver.
>
> The follow
Hi Andrew,
I've logged a JBS bug for your change:
https://bugs.openjdk.java.net/browse/JDK-8276939
You can use it to update your PR title to address the following jcheck error:
The commit message does not reference any issue. To add an issue reference to
this PR, edit the title to be of the
On Wed, 20 Oct 2021 13:35:22 GMT, Martin Balao wrote:
> I'd like to propose a fix for JDK-8275535. This fix reverts the behavior to
> the state previous to JDK-8160768, where an authentication failure stops from
> trying other LDAP servers with the same credentials [1]. After JDK-8160768 we
>
kupPolicy` - a class whose instances describe the
> characteristics of one forward lookup operation.
>
> More details in [JEP-418](https://openjdk.java.net/jeps/418).
>
> Testing: new and existing `tier1:tier3` tests
Aleksei Efimov has updated the pull request with a new t
On Tue, 26 Oct 2021 12:49:30 GMT, Aleksei Efimov wrote:
>> src/java.base/share/classes/java/net/spi/InetAddressResolverProvider.java
>> line 45:
>>
>>> 43: * system-wide resolver instance, which is used by
>>> 44: * >> href="{@docRoot}/java.base
On Sat, 23 Oct 2021 06:19:46 GMT, Alan Bateman wrote:
>> Aleksei Efimov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> More javadoc updates to API classes
>
> src/java.base/share/classes/java/net/InetAd
kupPolicy` - a class whose instances describe the
> characteristics of one forward lookup operation.
>
> More details in [JEP-418](https://openjdk.java.net/jeps/418).
>
> Testing: new and existing `tier1:tier3` tests
Aleksei Efimov has updated the pull request incrementally
On Tue, 26 Oct 2021 15:04:54 GMT, Daniel Fuchs wrote:
>> Aleksei Efimov has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request cont
kupPolicy` - a class whose instances describe the
> characteristics of one forward lookup operation.
>
> More details in [JEP-418](https://openjdk.java.net/jeps/418).
>
> Testing: new and existing `tier1:tier3` tests
Aleksei Efimov has updated the pull request incrementally wit
On Wed, 27 Oct 2021 16:23:29 GMT, Michael McMahon wrote:
>> Aleksei Efimov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add @ throws NPE to hosts file resolver javadoc
>
> src/java.base/share/classes/
On Sat, 23 Oct 2021 06:33:52 GMT, Alan Bateman wrote:
>> src/java.base/share/classes/java/net/spi/InetAddressResolverProvider.java
>> line 52:
>>
>>> 50: /**
>>> 51: * Initialise and return the {@link InetAddressResolver} provided by
>>> 52: * this provider. This method is called
kupPolicy` - a class whose instances describe the
> characteristics of one forward lookup operation.
>
> More details in [JEP-418](https://openjdk.java.net/jeps/418).
>
> Testing: new and existing `tier1:tier3` tests
Aleksei Efimov has updated the pull request with a new tar
On Sat, 23 Oct 2021 12:51:15 GMT, Andrey Turbanov wrote:
> 8276042: Remove unused local variables in java.naming
Hi Andrey,
Thanks for cleaning up the code.
Changes look good to me, with one suggestion below.
src/java.naming/share/classes/com/sun/jndi/toolkit/ctx/PartialCompositeContext.java
kupPolicy` - a class whose instances describe the
> characteristics of one forward lookup operation.
>
> More details in [JEP-418](https://openjdk.java.net/jeps/418).
>
> Testing: new and existing `tier1:tier3` tests
Aleksei Efimov has updated the pull request with a new tar
kupPolicy` - a class whose instances describe the
> characteristics of one forward lookup operation.
>
> More details in [JEP-418](https://openjdk.java.net/jeps/418).
>
> Testing: new and existing `tier1:tier3` tests
Aleksei Efimov has updated the pull request with a new t
On Thu, 4 Nov 2021 11:09:42 GMT, Magnus Ihse Bursie wrote:
> I ran bin/blessed-modifier-order.sh on source owned by core-libs. This
> scripts verifies that modifiers are in the "blessed" order, and fixes it
> otherwise. I have manually checked the changes made by the script to make
> sure
On Thu, 4 Nov 2021 11:31:50 GMT, Pavel Rappo wrote:
> I can see that this PR changes java.naming. Another bug to change
> java.naming, JDK-8276552, was filed yesterday. Please check with its reporter
> and coordinate this effort if necessary.
@magicus I'm ok with having `java.naming` changes
On Wed, 27 Oct 2021 15:42:32 GMT, Andrey Turbanov wrote:
>> 8276042: Remove unused local variables in java.naming
>
> Andrey Turbanov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8276042: Remove unused local variables in java.naming
>
On Tue, 14 Dec 2021 15:26:54 GMT, Rob McKenna wrote:
>> This fix attemps to resolve an issue where threads can stack up on each
>> other while waiting to get a connection from the ldap pool to an unreachable
>> server. It does this by having each thread start a countdown prior to
>> holding
On Wed, 12 Jan 2022 05:48:26 GMT, Masanori Yano wrote:
> I have fixed the javadoc comments as the definition. Could you review this
> fix?
Hi @masyano,
Thanks for fixing `java.naming` module javadoc. The fix looks fine to me.
-
Marked as reviewed by aefimov (Committer).
PR:
Hi,
JNDI's `DnsClient` can fail with `UncheckedIOException` during `connect` or
`disconnect` method calls. It is a [know
behavior](https://bugs.openjdk.java.net/browse/JDK-8236076) of `DatagramSocket`.
Currently, `DnsClient` method is fast-fails when `UncheckedIOException` is
observed during
On Wed, 20 Oct 2021 13:35:22 GMT, Martin Balao wrote:
> I'd like to propose a fix for JDK-8275535. This fix reverts the behavior to
> the state previous to JDK-8160768, where an authentication failure stops from
> trying other LDAP servers with the same credentials [1]. After JDK-8160768 we
>
On Wed, 9 Feb 2022 19:47:19 GMT, Martin Balao wrote:
> Thanks, that was what I initially thought but wanted to check if I was
> missing something else given the previous discussion. I should be able to
> generate a build for the user and ask him to test in his real environment. As
> for the
On Fri, 4 Feb 2022 15:36:35 GMT, Aleksei Efimov wrote:
> Hi,
>
> JNDI's `DnsClient` can fail with `UncheckedIOException` during `connect` or
> `disconnect` method calls. It is a [know
> behavior](https://bugs.openjdk.java.net/browse/JDK-8236076) of
> `DatagramSocke
On Fri, 21 Jan 2022 13:06:40 GMT, Rob McKenna wrote:
>> This fix attemps to resolve an issue where threads can stack up on each
>> other while waiting to get a connection from the ldap pool to an unreachable
>> server. It does this by having each thread start a countdown prior to
>> holding
On Sun, 29 May 2022 14:00:20 GMT, Andrey Turbanov wrote:
> `String.contains` was introduced in Java 5.
> Some code in java.naming still uses old approach with `String.indexOf` to
> check if String contains specified substring.
> I propose to migrate such usages. Makes code shorter and easier to
On Sun, 29 May 2022 21:57:46 GMT, Andrey Turbanov wrote:
> StringBuffer is a legacy synchronized class. StringBuilder is a direct
> replacement to StringBuffer which generally have better performance.
> There are some code that still uses StringBuffer in java.naming which could
> be migrated
On Sun, 29 May 2022 21:57:46 GMT, Andrey Turbanov wrote:
> StringBuffer is a legacy synchronized class. StringBuilder is a direct
> replacement to StringBuffer which generally have better performance.
> There are some code that still uses StringBuffer in java.naming which could
> be migrated
On Wed, 1 Jun 2022 15:41:57 GMT, Rob McKenna wrote:
> Test change to silently pass if the test environment encounters a
> NoRouteToHostException. These are intermittent at the moment but I will
> attempt to find an alternative to the use of example.com in some follow up
> work.
Looks good to
On Fri, 27 May 2022 15:24:46 GMT, Rob McKenna wrote:
> Test change to silently pass if the test environment encounters a
> NoRouteToHostException. These are intermittent at the moment but I will
> attempt to find an alternative to the use of example.com in some follow up
> work.
The change
On Wed, 20 Oct 2021 13:35:22 GMT, Martin Balao wrote:
> I'd like to propose a fix for JDK-8275535. This fix reverts the behavior to
> the state previous to JDK-8160768, where an authentication failure stops from
> trying other LDAP servers with the same credentials [1]. After JDK-8160768 we
>
On Sun, 29 May 2022 20:22:55 GMT, Andrey Turbanov wrote:
> In [JDK-8273098](https://bugs.openjdk.java.net/browse/JDK-8273098) I missed
> one place, where Vector could be replaced with ArrayList.
> Usage of thread-safe collection `Vector` is unnecessary. It's recommended to
> use `ArrayList` if
93 matches
Mail list logo
