er fix (asPredicate) too. Hope that
is fine.
Regards
Vivek
*From:*Roger Riggs
*Sent:* Thursday, April 12, 2018 7:43 PM
*To:* Vivek Theeyarath
*Cc:* Core-Libs-Dev
*Subject:* Re: RFR: 8184692: add Pattern.asMatchPredicate
Hi Vivek,
ok,
Generally, I like to see an updated webrev so that an old non
Theeyarath
Cc: Core-Libs-Dev
Subject: Re: RFR: 8184692: add Pattern.asMatchPredicate
Hi Vivek,
ok,
Generally, I like to see an updated webrev so that an old non-final webrev
isn't left around to be a source of questions.
Its easy enough to create a simple script to create the webrev and co
t;
> Regards
> Vivek
> -Original Message-
> From: Paul Sandoz
> Sent: Thursday, April 12, 2018 12:40 AM
> To: Vivek Theeyarath
> Cc: Roger Riggs ; Core-Libs-Dev
>
> Subject: Re: RFR: 8184692: add Pattern.asMatchPredicate
>
> HI,
>
> Hopefully thi
18 12:40 AM
To: Vivek Theeyarath
Cc: Roger Riggs ; Core-Libs-Dev
Subject: Re: RFR: 8184692: add Pattern.asMatchPredicate
HI,
Hopefully this is the last update :-)
To align with asPredicate and Roger’s prior guidance on that method i think you
can just say this:
Creates a predicate that tes
t;
> Regards
> Vivek
> -Original Message-
> From: Paul Sandoz
> Sent: Monday, April 09, 2018 9:25 PM
> To: Roger Riggs
> Cc: Core-Libs-Dev
> Subject: Re: RFR: 8184692: add Pattern.asMatchPredicate
>
>
>
>> On Apr 9, 2018, at 8:41 AM, Roger Riggs wr
t;
> Regards
> Vivek
> -Original Message-
> From: Paul Sandoz
> Sent: Monday, April 09, 2018 9:25 PM
> To: Roger Riggs
> Cc: Core-Libs-Dev
> Subject: Re: RFR: 8184692: add Pattern.asMatchPredicate
>
>
>
>> On Apr 9, 2018, at 8:41 AM, Roger Riggs wr
Subject: Re: RFR: 8184692: add Pattern.asMatchPredicate
> On Apr 9, 2018, at 8:41 AM, Roger Riggs wrote:
>
> Hi Vivek,
>
> As with Pattern.asPredicate the first sentence can be improved.
>
> Creates a predicate that tests if this pattern matches the entire region.
>
Th
> On Apr 9, 2018, at 9:17 AM, Xueming Shen wrote:
>
>
> Paul,
>
> I don't recall any particular reason why we did Predicate
> asPredicate() instead
> of Predicate asPredicate() back 1.8? mutability?
>
Hmm… me neither i would like to think it was not an oversight :-)
Mutability should not
ue
https://bugs.openjdk.java.net/browse/JDK-8201308 .
Regards
Vivek
-Original Message-
From: Paul Sandoz
Sent: Friday, April 06, 2018 6:55 AM
To: Vivek Theeyarath
Cc: Core-Libs-Dev
Subject: Re: RFR: 8184692: add Pattern.asMatchPredicate
On Apr 4, 2018, at 10:47 AM, Vivek Theeyarath
://cr.openjdk.java.net/~vtheeyarath/8184692/webrev.02/
>>
>> Also, I have created a csr for this issue
>> https://bugs.openjdk.java.net/browse/JDK-8201308 .
>>
>> Regards
>> Vivek
>> -Original Message-
>> From: Paul Sandoz
>> Sent: Frid
mments.
http://cr.openjdk.java.net/~vtheeyarath/8184692/webrev.02/
Also, I have created a csr for this issue
https://bugs.openjdk.java.net/browse/JDK-8201308 .
Regards
Vivek
-Original Message-
From: Paul Sandoz
Sent: Friday, April 06, 2018 6:55 AM
To: Vivek Theeyarath
Cc: Core-Libs-
andoz
Sent: Friday, April 06, 2018 6:55 AM
To: Vivek Theeyarath
Cc: Core-Libs-Dev
Subject: Re: RFR: 8184692: add Pattern.asMatchPredicate
> On Apr 4, 2018, at 10:47 AM, Vivek Theeyarath
> wrote:
>
> Hi All,
>
> Please review.
>
> Bug: https://bugs.openjd
> On Apr 4, 2018, at 10:47 AM, Vivek Theeyarath
> wrote:
>
> Hi All,
>
> Please review.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8184692
>
> Webrev : http://cr.openjdk.java.net/~vtheeyarath/8184692/webrev.00/
>
Like with your other patch, alignment to ~80 chars wo
13 matches
Mail list logo
