RE: RFR (S): 8235750: [jpackage] Cleanup imports in WinMsiBundler.java
Thanks, Andy and Alexey for the reviews. I've pushed it. Cheers Christoph > -Original Message- > From: core-libs-dev On Behalf > Of Andy Herrick > Sent: Mittwoch, 11. Dezember 2019 15:25 > To: core-libs-dev@openjdk.java.net > Subject: Re: RFR (S): 8235750: [jpackage] Cleanup imports in > WinMsiBundler.java > > looks good - thank you. > > /Andy > > On 12/11/2019 5:02 AM, Langer, Christoph wrote: > > Hi, > > > > please review this import statements cleanup for > src/jdk.incubator.jpackage/windows/classes/jdk/incubator/jpackage/interna > l/WinMsiBundler.java. I stumbled over an issue when I imported the > jpackage project into Eclipse. > > > > Due to importing both, static > jdk.incubator.jpackage.internal.StandardBundlerParam.* and static > jdk.incubator.jpackage.internal.WindowsBundlerParam.*, Eclipse thinks > some symbols are ambiguous. > > > > I would also remove an unused list object. > > > > Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8235750.0/ > > Bug: https://bugs.openjdk.java.net/browse/JDK-8235750 > > > > Thanks > > Christoph > >
Re: RFR (S): 8235750: [jpackage] Cleanup imports in WinMsiBundler.java
Looks good. - Alexey On 12/11/2019 9:25 AM, Andy Herrick wrote: looks good - thank you. /Andy On 12/11/2019 5:02 AM, Langer, Christoph wrote: Hi, please review this import statements cleanup for src/jdk.incubator.jpackage/windows/classes/jdk/incubator/jpackage/internal/WinMsiBundler.java. I stumbled over an issue when I imported the jpackage project into Eclipse. Due to importing both, static jdk.incubator.jpackage.internal.StandardBundlerParam.* and static jdk.incubator.jpackage.internal.WindowsBundlerParam.*, Eclipse thinks some symbols are ambiguous. I would also remove an unused list object. Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8235750.0/ Bug: https://bugs.openjdk.java.net/browse/JDK-8235750 Thanks Christoph
Re: RFR (S): 8235750: [jpackage] Cleanup imports in WinMsiBundler.java
looks good - thank you. /Andy On 12/11/2019 5:02 AM, Langer, Christoph wrote: Hi, please review this import statements cleanup for src/jdk.incubator.jpackage/windows/classes/jdk/incubator/jpackage/internal/WinMsiBundler.java. I stumbled over an issue when I imported the jpackage project into Eclipse. Due to importing both, static jdk.incubator.jpackage.internal.StandardBundlerParam.* and static jdk.incubator.jpackage.internal.WindowsBundlerParam.*, Eclipse thinks some symbols are ambiguous. I would also remove an unused list object. Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8235750.0/ Bug: https://bugs.openjdk.java.net/browse/JDK-8235750 Thanks Christoph
RFR (S): 8235750: [jpackage] Cleanup imports in WinMsiBundler.java
Hi, please review this import statements cleanup for src/jdk.incubator.jpackage/windows/classes/jdk/incubator/jpackage/internal/WinMsiBundler.java. I stumbled over an issue when I imported the jpackage project into Eclipse. Due to importing both, static jdk.incubator.jpackage.internal.StandardBundlerParam.* and static jdk.incubator.jpackage.internal.WindowsBundlerParam.*, Eclipse thinks some symbols are ambiguous. I would also remove an unused list object. Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8235750.0/ Bug: https://bugs.openjdk.java.net/browse/JDK-8235750 Thanks Christoph
