Re: RFR 8166501 : compilation error in stackwalk.cpp on some gccs

2016-09-22 Thread David Holmes
This is the second example I've seen in two days concerning misuse of CHECK_ macros. They expand into an if statement after the call, so can not appear on calls that are part of a return statement, or a conditional statement, or likely a number of other places, as the if code either becomes unr

Re: RFR 8166501 : compilation error in stackwalk.cpp on some gccs

2016-09-22 Thread Dmitry Samersoff
Brent, Looks good for me. -Dmitry On 2016-09-22 19:04, Brent Christian wrote: > Hi, > > Looks like my 8165372 change broke the slowdebug build. Please review > my fix (which also breaks up a pretty long line): > > --- a/src/share/vm/prims/stackwalk.cpp > +++ b/src/share/vm/prims/stackwalk.cpp

RFR 8166501 : compilation error in stackwalk.cpp on some gccs

2016-09-22 Thread Brent Christian
Hi, Looks like my 8165372 change broke the slowdebug build. Please review my fix (which also breaks up a pretty long line): --- a/src/share/vm/prims/stackwalk.cpp +++ b/src/share/vm/prims/stackwalk.cpp @@ -331,10 +331,12 @@ assert (use_frames_array(mode), "Bad mode for get live frame");