Re: 7056815: test/java/lang/ClassLoader/deadlock/TestOneWayDelegate.sh times out intermittently on busy machine

2011-06-20 Thread Mandy Chung 

 Alan,

The fix to remove the timeout value looks okay to me.  While you're 
there, I wonder if the test passes on Windows with Cygwin and looks like 
this test might have a similar bug:
   6981005: TEST BUG: java/lang/ClassLoader/TestCrossDelegate.sh 
timeout on windows


that the cygwin path should be converted to windows path.  The changeset 
for 6981005 is:

   http://hg.openjdk.java.net/jdk7/tl/jdk/rev/6586ab5b79f4

Mandy

On 6/20/11 6:21 PM, Alan Bateman wrote:


I need a reviewer for a small update to a test that has timed out 
several times for me when running many tests concurrently. The problem 
is the specified timeout (10s) is too low unless scaled with the 
-timeoutFactor option. I don't see any any reason for this test to 
override the default timeout so the following patch removes it.


-Alan

diff --git a/test/java/lang/ClassLoader/deadlock/TestOneWayDelegate.sh 
b/test/java/lang/ClassLoader/deadlock/TestOneWayDelegate.sh

--- a/test/java/lang/ClassLoader/deadlock/TestOneWayDelegate.sh
+++ b/test/java/lang/ClassLoader/deadlock/TestOneWayDelegate.sh
@@ -25,7 +25,7 @@
# @summary (cl) ClassLoader.loadClass locks all instances in chain
#  when delegating
#
-# @run shell/timeout=10 TestOneWayDelegate.sh
+# @run shell TestOneWayDelegate.sh

# if running by hand on windows, change TESTSRC and TESTCLASSES to .
if [ ${TESTSRC} =  ] ; then

Re: 7056815: test/java/lang/ClassLoader/deadlock/TestOneWayDelegate.sh times out intermittently on busy machine

2011-06-20 Thread Alan Bateman 

Mandy Chung wrote:

 Alan,

The fix to remove the timeout value looks okay to me.  While you're 
there, I wonder if the test passes on Windows with Cygwin and looks 
like this test might have a similar bug:
   6981005: TEST BUG: java/lang/ClassLoader/TestCrossDelegate.sh 
timeout on windows


that the cygwin path should be converted to windows path.  The 
changeset for 6981005 is:

   http://hg.openjdk.java.net/jdk7/tl/jdk/rev/6586ab5b79f4

Mandy
There is another bug asking that the ClassLoader tests be updated to 
work with cygwin:


7036526: TEST_BUG: add cygwin support to tests in 
test/closed/java/lang/ClassLoader


I don't really have time at the moment to fix these tests and the only 
reason I picked on TestOneWayDelegate.sh is because I see it fail 
regularly when running tests concurrency in jtreg's new -agentvm mode. I 
don't think I've seen it fail on a system that is only running tests. So 
if it's okay with you, I'll fix the timeout on this test and move on.


-Alan.

Re: 7056815: test/java/lang/ClassLoader/deadlock/TestOneWayDelegate.sh times out intermittently on busy machine

2011-06-20 Thread Mandy Chung 

 On 6/20/11 9:15 PM, Alan Bateman wrote:
There is another bug asking that the ClassLoader tests be updated to 
work with cygwin:


7036526: TEST_BUG: add cygwin support to tests in 
test/closed/java/lang/ClassLoader


I don't really have time at the moment to fix these tests and the only 
reason I picked on TestOneWayDelegate.sh is because I see it fail 
regularly when running tests concurrency in jtreg's new -agentvm mode. 
I don't think I've seen it fail on a system that is only running 
tests. So if it's okay with you, I'll fix the timeout on this test and 
move on.




I'm fine with your timeout fix and have 7036526 to fix the cygwin path 
issue.


Mandy