Hi David,
On 01/06/2020 23:43, David Holmes wrote:
Sorry the weekend got in the way :)
No problem David. I pushed with your suggestion (not using
SoftReference) since that appeared to be working too.
If it fails again I can revisit :-)
best regards,
-- daniel
Hi Daniel,
Sorry the weekend got in the way :)
On 29/05/2020 7:01 pm, Daniel Fuchs wrote:
Hi David,
Thanks for the feedback!
On 29/05/2020 00:36, David Holmes wrote:
This seems to be assuming that the GC will clear all SoftReferences
when it needs to clear any SoftReference. I don't think
On 29/05/2020 16:53, Lance Andersen wrote:
Hi Daniel,
Do you still need the SoftReference import given you are no longer using
it with memory.add()?
No - I removed it.
cheers,
-- daniel
Best
Lance
Hi Daniel,
Do you still need the SoftReference import given you are no longer using it
with memory.add()?
Best
Lance
> On May 29, 2020, at 11:39 AM, Daniel Fuchs wrote:
>
> Hi,
>
> I have updated the webrev as suggested by David:
>
>
On 5/29/20 11:39 AM, Daniel Fuchs wrote:
Hi,
I have updated the webrev as suggested by David:
http://cr.openjdk.java.net/~dfuchs/webrev_8245867/webrev.01
test/jdk/java/util/logging/Logger/bundleLeak/BundleTest.java
No comments.
Thumbs up.
Dan
Unless I hear any objection I'll push
Hi,
I have updated the webrev as suggested by David:
http://cr.openjdk.java.net/~dfuchs/webrev_8245867/webrev.01
Unless I hear any objection I'll push that new version if the
tests come back successful.
best regards,
-- daniel
(tier1 and 2 passed, tier5 still running)
On 29/05/2020 00:36,
Hi David,
Thanks for the feedback!
On 29/05/2020 00:36, David Holmes wrote:
This seems to be assuming that the GC will clear all SoftReferences when
it needs to clear any SoftReference. I don't think that is at all
guaranteed. In theory your memory eating loop could be satisfied by
clearing
Hi Daniel,
This caught my eye ...
On 28/05/2020 6:50 pm, Daniel Fuchs wrote:
Hi,
Please find an almost trivial fix for:
8245867: Logger/bundleLeak/BundleTest.java fails due
to "OutOfMemoryError: Java heap space"
https://bugs.openjdk.java.net/browse/JDK-8245867
webrev:
Hi Daniel,
The change looks reasonable. Thank you for addressing so quickly.
Best
Lance
> On May 28, 2020, at 4:50 AM, Daniel Fuchs wrote:
>
> Hi,
>
> Please find an almost trivial fix for:
>
> 8245867: Logger/bundleLeak/BundleTest.java fails due
> to "OutOfMemoryError: Java heap
