Re: Miscellaneous minor patches: javadoc typos, javac warnings, etc.
On 09/11/2011 12:41, Lance Andersen - Oracle wrote: I looked at the core and sql changes and they are fine. I will great a bug for these and submit the change-set. Thanks Lance. I quickly scanned the changes in the Core and SQL webrevs and they looks fine to me. Joe might want to look at the Float and Double changes, might be more consistent if constructors were this.value = -Alan.
Re: Miscellaneous minor patches: javadoc typos, javac warnings, etc.
Hello, On 11/10/2011 1:29 AM, Alan Bateman wrote: On 09/11/2011 12:41, Lance Andersen - Oracle wrote: I looked at the core and sql changes and they are fine. I will great a bug for these and submit the change-set. Thanks Lance. I quickly scanned the changes in the Core and SQL webrevs and they looks fine to me. Joe might want to look at the Float and Double changes, might be more consistent if constructors were this.value = The Float and Double changes look fine. I don't know why the constructors were coded up that way; I double checked the history and they have been that way since before the transitions to Mercurial. Writing the constructors as this.value = would be fine too. -Joe
Re: Miscellaneous minor patches: javadoc typos, javac warnings, etc.
Le 10/11/11 16:24, Joe Darcy a écrit : The Float and Double changes look fine. I don't know why the constructors were coded up that way; Maybe because the Float(String) / Double(String) constructors were coded in Java 1.0, while the parseFloat(String) / parseDouble(String) methods were added (at least in public API) only in Java 1.2 and someone forgot to revisit the constructors at that time... Martin
Fwd: Re: Miscellaneous minor patches: javadoc typos, javac warnings, etc.
Does anyone have cycles to review and sponsor the Core and SQL clean-ups? They should be trivial to review and push as one change-set, leaving the client area changes for review on the 2d or other list. -Alan. Original Message Subject: Re: Miscellaneous minor patches: javadoc typos, javac warnings, etc. Date: Wed, 09 Nov 2011 11:46:48 +0100 From: Martin Desruisseaux martin.desruisse...@geomatys.fr Organization: Geomatys CC: jdk8-...@openjdk.java.net Hello all It took me a while, but I finally posted the patches that I submitted last month as webrev pages. I tried to split them according different groups (core, Java2D...) to the best of my knowledge: http://webrev.geomatys.com/ I also signed the Oracle Contributor Agreement (OCA) and send it by email to oracle-ca...@oracle.com. In the core classes, most patches can be grouped in two categories: * Documentation fixes (Class, Attributes) * Avoid creation of unnecessary temporary objects (AssertionError, Float, Double) The only real bug fix is in Java 2D (AffineTransform.hashCode() inconsistent with equals(Object) when some coefficients mix positive and negative zeros). However I'm not yet registered on the Java2D mailing list. Should I register on the mailing list of each group for which I may propose a patch? Regards, Martin
Re: Miscellaneous minor patches: javadoc typos, javac warnings, etc.
I looked at the core and sql changes and they are fine. I will great a bug for these and submit the change-set. Best lance On Nov 9, 2011, at 6:30 AM, Alan Bateman wrote: Does anyone have cycles to review and sponsor the Core and SQL clean-ups? They should be trivial to review and push as one change-set, leaving the client area changes for review on the 2d or other list. -Alan. Original Message Subject: Re: Miscellaneous minor patches: javadoc typos, javac warnings, etc. Date: Wed, 09 Nov 2011 11:46:48 +0100 From: Martin Desruisseaux martin.desruisse...@geomatys.fr Organization: Geomatys CC: jdk8-...@openjdk.java.net Hello all It took me a while, but I finally posted the patches that I submitted last month as webrev pages. I tried to split them according different groups (core, Java2D...) to the best of my knowledge: http://webrev.geomatys.com/ I also signed the Oracle Contributor Agreement (OCA) and send it by email to oracle-ca...@oracle.com. In the core classes, most patches can be grouped in two categories: * Documentation fixes (Class, Attributes) * Avoid creation of unnecessary temporary objects (AssertionError, Float, Double) The only real bug fix is in Java 2D (AffineTransform.hashCode() inconsistent with equals(Object) when some coefficients mix positive and negative zeros). However I'm not yet registered on the Java2D mailing list. Should I register on the mailing list of each group for which I may propose a patch? Regards, Martin Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com
Re: Fwd: Re: Miscellaneous minor patches: javadoc typos, javac warnings, etc.
Martin, Please do register on 2d-dev and propose the 2D changes there. The hashcode change definitely needs discussion, I think there may be views on the NaN comparison as my understanding is that this is supposed to always be not equal. Could be a spec. change for the class if its admissible. Further discussion on this should be on 2d-dev. -phil. PS this is such an unrelated set of changes, I am not sure it should be under one CR, even for 2D. On 11/9/2011 3:30 AM, Alan Bateman wrote: Does anyone have cycles to review and sponsor the Core and SQL clean-ups? They should be trivial to review and push as one change-set, leaving the client area changes for review on the 2d or other list. -Alan. Original Message Subject: Re: Miscellaneous minor patches: javadoc typos, javac warnings, etc. Date: Wed, 09 Nov 2011 11:46:48 +0100 From: Martin Desruisseaux martin.desruisse...@geomatys.fr Organization: Geomatys CC: jdk8-...@openjdk.java.net Hello all It took me a while, but I finally posted the patches that I submitted last month as webrev pages. I tried to split them according different groups (core, Java2D...) to the best of my knowledge: http://webrev.geomatys.com/ I also signed the Oracle Contributor Agreement (OCA) and send it by email to oracle-ca...@oracle.com. In the core classes, most patches can be grouped in two categories: * Documentation fixes (Class, Attributes) * Avoid creation of unnecessary temporary objects (AssertionError, Float, Double) The only real bug fix is in Java 2D (AffineTransform.hashCode() inconsistent with equals(Object) when some coefficients mix positive and negative zeros). However I'm not yet registered on the Java2D mailing list. Should I register on the mailing list of each group for which I may propose a patch? Regards, Martin
Re: Miscellaneous minor patches: javadoc typos, javac warnings, etc.
Hello Phil Le 09/11/11 18:37, Phil Race a écrit : Please do register on 2d-dev and propose the 2D changes there. Registration done, I will post in a few minutes. The hashcode change definitely needs discussion, I think there may be views on the NaN comparison as my understanding is that this is supposed to always be not equal. The proposed change is consistent with the java.lang.Double.equals(Object) behavior. It seems to me the only way to be compliant with the reflexivity contract documented in Object.equals javadoc, apart doing a if (other == this) return true check. Maybe whatever full compliance with Object.equals is strongly desired or not can be a question for the core group? I would like to note that incomplete compliance may be a risk when AffineTransform (or any other object) is used as keys in Hashtable: in current implementation, if an AffineTransform object with at least one NaN value is added in a Hashtable, it is impossible to remove it by a call to Hashtable.remove(Object) (we can still remove it by Iterator.remove()). (Note: my example uses Hashtable instead of HashMap because HashMap has a clever implementation that check for object references before to invoke Object.equals, which invalidate my argument. However not all implementations are that safe). PS this is such an unrelated set of changes, I am not sure it should be under one CR, even for 2D. Actually this is 8 distinct change sets, but webrev merged all my change sets in a single one. Since it is the first time I'm using webrev, I'm probably not using it in the right way. But I still have the 8 distinct changes set on my local Mercurial clone, so I can probably recreate new webrev pages if I learn how to use webrev better... Regards, Martin
