Re: RFR: 8245024: Simplify and eagerly initialize StringConcatFactory

Ah, it's unrelated to JDK-8155659. The change looks okay.  Minor: it might worth adding the getClassName method in BSBS class. I also agree with Paul that we should examine if it's time to remove the non-default strategies if they are mostly unused. Mandy On 5/14/20 2:27 PM, Claes

Re: RFR: 8245024: Simplify and eagerly initialize StringConcatFactory

Hi Mandy, I haven't looked at JDK-8155659 in years - and lambda bootstrap has been simplified a lot since. Maybe there's a way to pre-initializate a few classes to avoid the issues similarly now. It's not been a priority to fix since it isn't a regression in behavior like JDK-8155090 was -

Re: RFR: 8245024: Simplify and eagerly initialize StringConcatFactory

Hi Claes, Is the bootstrapping issue contributed by Class::getDeclaredConstructors call in InnerClassLambdaMetafactory::buildCallSite? I wonder how much performance gain compared to using Lookup::findConstructor for non-capturing lambda case.   If LMF uses Lookup::findConstructor, it does

Re: RFR: 8245024: Simplify and eagerly initialize StringConcatFactory

On 2020-05-14 17:28, Paul Sandoz wrote: Looks good. Thanks! — Separately, not for this issue, the code changes you made impact what is mostly unused code. I don’t recall us ever changing the default strategy, nor I am aware of others changing it via a system property (except for our

Re: RFR: 8245024: Simplify and eagerly initialize StringConcatFactory

Looks good. — Separately, not for this issue, the code changes you made impact what is mostly unused code. I don’t recall us ever changing the default strategy, nor I am aware of others changing it via a system property (except for our tests), are you? At the time when we introduced this

Re: RFR: 8245024: Simplify and eagerly initialize StringConcatFactory

On 2020-05-14 17:05, Jim Laskey wrote: Will this have an effect on JDK-8218173  ? Interesting that you ask, since this cleanup was extracted from an attempted fix for 8218173. _Potentially_ this helps. But it won't fix it. Ensuring

Re: RFR: 8245024: Simplify and eagerly initialize StringConcatFactory

Will this have an effect on JDK-8218173 ? > On May 14, 2020, at 11:39 AM, Claes Redestad > wrote: > > Hi, > > JDK-8155090 added some measures to StringConcatFactory to prevent > certain bootstrapping issues. I think we should consider