Re: RFR: 8277493: [REDO] Quarantined jpackage apps are labeled as "damaged" [v2]

2022-05-13 Thread Alexey Semenyuk 
On Fri, 13 May 2022 05:06:21 GMT, Alexander Matveev  
wrote:

>> - No changes to code provided by original fix.
>>  - Added ad hoc signing on macOS aarch64, since macOS aarch64 cannot execute 
>> unsigned code and code should be at least ad hoc signed.
>>  - Signing of app bundle produced by AppContentTest.java fails, since it has 
>> invalid app bundle structure with added files into Content folder. Thus test 
>> is executed but failure is always expected on macOS aarch64.
>
> Alexander Matveev has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   8277493: [REDO] Quarantined jpackage apps are labeled as "damaged" [v2]

Marked as reviewed by asemenyuk (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/8527

Re: RFR: 8277493: [REDO] Quarantined jpackage apps are labeled as "damaged"

2022-05-12 Thread Alexander Matveev 
On Wed, 4 May 2022 03:56:10 GMT, Alexander Matveev  wrote:

> - No changes to code provided by original fix.
>  - Added ad hoc signing on macOS aarch64, since macOS aarch64 cannot execute 
> unsigned code and code should be at least ad hoc signed.
>  - Signing of app bundle produced by AppContentTest.java fails, since it has 
> invalid app bundle structure with added files into Content folder. Thus test 
> is executed but failure is always expected on macOS aarch64.

8277493: [REDO] Quarantined jpackage apps are labeled as "damaged" [v2]
 - Modified test to use Parameter instead of Parameters
 - Combined unsignAppBundle(), signAppBundle() and signAdHocAppBundle() into 
one function to reduce code duplication. Calling signAppBundle() without any 
identity will result in just unsigning app.

-

PR: https://git.openjdk.java.net/jdk/pull/8527

Re: RFR: 8277493: [REDO] Quarantined jpackage apps are labeled as "damaged" [v2]

2022-05-12 Thread Alexander Matveev 
> - No changes to code provided by original fix.
>  - Added ad hoc signing on macOS aarch64, since macOS aarch64 cannot execute 
> unsigned code and code should be at least ad hoc signed.
>  - Signing of app bundle produced by AppContentTest.java fails, since it has 
> invalid app bundle structure with added files into Content folder. Thus test 
> is executed but failure is always expected on macOS aarch64.

Alexander Matveev has updated the pull request incrementally with one 
additional commit since the last revision:

  8277493: [REDO] Quarantined jpackage apps are labeled as "damaged" [v2]

-

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/8527/files
  - new: https://git.openjdk.java.net/jdk/pull/8527/files/c163503a..e71647b5

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk=8527=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk=8527=00-01

  Stats: 291 lines in 2 files changed: 20 ins; 219 del; 52 mod
  Patch: https://git.openjdk.java.net/jdk/pull/8527.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/8527/head:pull/8527

PR: https://git.openjdk.java.net/jdk/pull/8527

Re: RFR: 8277493: [REDO] Quarantined jpackage apps are labeled as "damaged"

2022-05-11 Thread Alexey Semenyuk 
On Wed, 4 May 2022 03:56:10 GMT, Alexander Matveev  wrote:

> - No changes to code provided by original fix.
>  - Added ad hoc signing on macOS aarch64, since macOS aarch64 cannot execute 
> unsigned code and code should be at least ad hoc signed.
>  - Signing of app bundle produced by AppContentTest.java fails, since it has 
> invalid app bundle structure with added files into Content folder. Thus test 
> is executed but failure is always expected on macOS aarch64.

Any chance logic traversing runtime and adjusting the permissions of its files 
in `unsignAppBundle()` and ` signAdHocAppBundle()` can be moved to a single 
function instead of being duplicated in both of them?

-

PR: https://git.openjdk.java.net/jdk/pull/8527

Re: RFR: 8277493: [REDO] Quarantined jpackage apps are labeled as "damaged"

2022-05-11 Thread Alexey Semenyuk 
On Wed, 4 May 2022 03:56:10 GMT, Alexander Matveev  wrote:

> - No changes to code provided by original fix.
>  - Added ad hoc signing on macOS aarch64, since macOS aarch64 cannot execute 
> unsigned code and code should be at least ad hoc signed.
>  - Signing of app bundle produced by AppContentTest.java fails, since it has 
> invalid app bundle structure with added files into Content folder. Thus test 
> is executed but failure is always expected on macOS aarch64.

test/jdk/tools/jpackage/macosx/SigningAppImageTest.java line 72:

> 70: @Parameters
> 71: public static List data() {
> 72: return List.of(new Object[][] {{"true"}, {"false"}});

I'd replace use of `@Parameters` with `@Parameter` as follows:

@Test
@Parameter("true")
@Parameter("false")
public static void test(boolean doSign) {...}

-

PR: https://git.openjdk.java.net/jdk/pull/8527