Re: RFR: 8281695: jtreg test com/sun/jndi/ldap/LdapPoolTimeoutTest.java fails intermittently in nightly run

2022-06-01 Thread Daniel Fuchs 
On Fri, 27 May 2022 15:24:46 GMT, Rob McKenna  wrote:

> Test change to silently pass if the test environment encounters a 
> NoRouteToHostException. These are intermittent at the moment but I will 
> attempt to find an alternative to the use of example.com in some follow up 
> work.

test/jdk/com/sun/jndi/ldap/LdapTimeoutTest.java line 135:

> 133: failedCount++;
> 134: cause.printStackTrace(System.out);
> 135: }

Maybe this could be simplified as:


  Throwable cause = e.getCause();
  // don't fail if we get NoRouteToHostException
  if (cause instanceof NoRouteToHostException) continue;
  if (cause != null && cause.getCause() != null) cause = cause.getCause();
  if (cause instanceof NoRouteToHostException) continue;
  failedCount++;
  cause.printStackTrace(System.out);

-

PR: https://git.openjdk.java.net/jdk/pull/8925

Re: RFR: 8281695: jtreg test com/sun/jndi/ldap/LdapPoolTimeoutTest.java fails intermittently in nightly run

2022-06-01 Thread Aleksei Efimov 
On Fri, 27 May 2022 15:24:46 GMT, Rob McKenna  wrote:

> Test change to silently pass if the test environment encounters a 
> NoRouteToHostException. These are intermittent at the moment but I will 
> attempt to find an alternative to the use of example.com in some follow up 
> work.

The change looks fine, given it is a temporary workaround until an alternative 
to the use of example.com is found.

-

Marked as reviewed by aefimov (Committer).

PR: https://git.openjdk.java.net/jdk/pull/8925