Re: RFR: 8284780: Need methods to create pre-sized HashSet and LinkedHashSet [v14]
On Fri, 27 May 2022 06:09:59 GMT, XenoAmess wrote: >> Thanks for the updates. I've made a couple minor changes to the specs; >> please merge the latest commit from this branch: >> >> https://github.com/stuart-marks/jdk/tree/pull/8302 >> >> I've created a CSR and have included these changes in it. Please review: >> [JDK-8287419](https://bugs.openjdk.java.net/browse/JDK-8287419) >> >> I'll look at the test changes later. I wanted to get the CSR moving first, >> since it will take a few days (and a long weekend in the US is coming up). > > @stuart-marks @liach done. @XenoAmess Please merge the latest commit from https://github.com/stuart-marks/jdk/commits/pull/8302 which contains changes requested during the CSR review. Thanks. - PR: https://git.openjdk.java.net/jdk/pull/8302
Re: RFR: 8284780: Need methods to create pre-sized HashSet and LinkedHashSet [v14]
On Fri, 27 May 2022 05:31:28 GMT, Stuart Marks wrote: >> XenoAmess has updated the pull request with a new target base due to a merge >> or a rebase. The pull request now contains 16 commits: >> >> - Merge branch 'master' of https://git.openjdk.java.net/jdk into fix_8284780 >> - Merge remote-tracking branch 'openjdk/master' into fix_8284780 >> >># Conflicts: >># test/jdk/java/util/HashMap/WhiteBoxResizeTest.java >> - add 8284780 to test >> - redo the tests >> - rename items to elements >> - add test for newHashSet and newLinkedHashSet >> - revert much too changes for newHashSet >> - add more replaces >> - add more replaces >> - add more replaces >> - ... and 6 more: >> https://git.openjdk.java.net/jdk/compare/7cb368b3...117918f4 > > Thanks for the updates. I've made a couple minor changes to the specs; please > merge the latest commit from this branch: > > https://github.com/stuart-marks/jdk/tree/pull/8302 > > I've created a CSR and have included these changes in it. Please review: > [JDK-8287419](https://bugs.openjdk.java.net/browse/JDK-8287419) > > I'll look at the test changes later. I wanted to get the CSR moving first, > since it will take a few days (and a long weekend in the US is coming up). @stuart-marks @liach done. - PR: https://git.openjdk.java.net/jdk/pull/8302
Re: RFR: 8284780: Need methods to create pre-sized HashSet and LinkedHashSet [v14]
On Thu, 26 May 2022 18:08:13 GMT, XenoAmess wrote: >> as title. > > XenoAmess has updated the pull request with a new target base due to a merge > or a rebase. The pull request now contains 16 commits: > > - Merge branch 'master' of https://git.openjdk.java.net/jdk into fix_8284780 > - Merge remote-tracking branch 'openjdk/master' into fix_8284780 > ># Conflicts: ># test/jdk/java/util/HashMap/WhiteBoxResizeTest.java > - add 8284780 to test > - redo the tests > - rename items to elements > - add test for newHashSet and newLinkedHashSet > - revert much too changes for newHashSet > - add more replaces > - add more replaces > - add more replaces > - ... and 6 more: > https://git.openjdk.java.net/jdk/compare/7cb368b3...117918f4 Thanks for the updates. I've made a couple minor changes to the specs; please merge the latest commit from this branch: https://github.com/stuart-marks/jdk/tree/pull/8302 I've created a CSR and have included these changes in it. Please review: [JDK-8287419](https://bugs.openjdk.java.net/browse/JDK-8287419) I'll look at the test changes later. I wanted to get the CSR moving first, since it will take a few days (and a long weekend in the US is coming up). - PR: https://git.openjdk.java.net/jdk/pull/8302
Re: RFR: 8284780: Need methods to create pre-sized HashSet and LinkedHashSet [v14]
On Thu, 26 May 2022 18:08:13 GMT, XenoAmess wrote:
>> as title.
>
> XenoAmess has updated the pull request with a new target base due to a merge
> or a rebase. The pull request now contains 16 commits:
>
> - Merge branch 'master' of https://git.openjdk.java.net/jdk into fix_8284780
> - Merge remote-tracking branch 'openjdk/master' into fix_8284780
>
># Conflicts:
># test/jdk/java/util/HashMap/WhiteBoxResizeTest.java
> - add 8284780 to test
> - redo the tests
> - rename items to elements
> - add test for newHashSet and newLinkedHashSet
> - revert much too changes for newHashSet
> - add more replaces
> - add more replaces
> - add more replaces
> - ... and 6 more:
> https://git.openjdk.java.net/jdk/compare/7cb368b3...117918f4
src/java.base/share/classes/java/util/HashSet.java line 130:
> 128: * @apiNote
> 129: * To create a {@code HashSet} with an initial capacity that
> accommodates
> 130: * an expected number of items, use {@link #newHashSet(int)
> newHashSet}.
Suggestion:
* an expected number of elements, use {@link #newHashSet(int) newHashSet}.
src/java.base/share/classes/java/util/HashSet.java line 147:
> 145: * @apiNote
> 146: * To create a {@code HashSet} with an initial capacity that
> accommodates
> 147: * an expected number of items, use {@link #newHashSet(int)
> newHashSet}.
Suggestion:
* an expected number of elements, use {@link #newHashSet(int) newHashSet}.
src/java.base/share/classes/java/util/HashSet.java line 391:
> 389: *
> 390: * @param numElementsthe expected number of elements
> 391: * @param the type of keys maintained by this set
Suggestion:
* @param the type of elements maintained by this set
src/java.base/share/classes/java/util/LinkedHashSet.java line 131:
> 129: * @apiNote
> 130: * To create a {@code LinkedHashSet} with an initial capacity that
> accommodates
> 131: * an expected number of items, use {@link #newLinkedHashSet(int)
> newLinkedHashSet}.
Suggestion:
* an expected number of elements, use {@link #newLinkedHashSet(int)
newLinkedHashSet}.
src/java.base/share/classes/java/util/LinkedHashSet.java line 148:
> 146: * @apiNote
> 147: * To create a {@code LinkedHashSet} with an initial capacity that
> accommodates
> 148: * an expected number of items, use {@link #newLinkedHashSet(int)
> newLinkedHashSet}.
Suggestion:
* an expected number of elements, use {@link #newLinkedHashSet(int)
newLinkedHashSet}.
src/java.base/share/classes/java/util/LinkedHashSet.java line 212:
> 210: *
> 211: * @param numElementsthe expected number of elements
> 212: * @param the type of keys maintained by this set
Suggestion:
* @param the type of elements maintained by this set
-
PR: https://git.openjdk.java.net/jdk/pull/8302
Re: RFR: 8284780: Need methods to create pre-sized HashSet and LinkedHashSet [v14]
> as title. XenoAmess has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 16 commits: - Merge branch 'master' of https://git.openjdk.java.net/jdk into fix_8284780 - Merge remote-tracking branch 'openjdk/master' into fix_8284780 # Conflicts: #test/jdk/java/util/HashMap/WhiteBoxResizeTest.java - add 8284780 to test - redo the tests - rename items to elements - add test for newHashSet and newLinkedHashSet - revert much too changes for newHashSet - add more replaces - add more replaces - add more replaces - ... and 6 more: https://git.openjdk.java.net/jdk/compare/7cb368b3...117918f4 - Changes: https://git.openjdk.java.net/jdk/pull/8302/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=8302=13 Stats: 162 lines in 31 files changed: 120 ins; 0 del; 42 mod Patch: https://git.openjdk.java.net/jdk/pull/8302.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/8302/head:pull/8302 PR: https://git.openjdk.java.net/jdk/pull/8302
