Re: RFR: 8285452: Add a new test library API to replace a file content using FileUtils.java [v5]

2022-05-02 Thread Jaikiran Pai
On Mon, 2 May 2022 13:13:02 GMT, Weijun Wang wrote: >> `lines.remove()` and `lines.subList()` will throw the correct exception. >> Since you asked, we can add it. > > Now that we call `subList` at the beginning, I think there's no need to > explicitly perform a check. Hello Weijun, the change

Re: RFR: 8285452: Add a new test library API to replace a file content using FileUtils.java [v5]

2022-05-02 Thread Weijun Wang
On Fri, 29 Apr 2022 15:51:12 GMT, Weijun Wang wrote: >> test/lib/jdk/test/lib/util/FileUtils.java line 389: >> >>> 387: * @throws IOException >>> 388: */ >>> 389: public static void patch(Path path, int fromLine, int toLine, >>> String from, String to) throws IOException { >> >>

Re: RFR: 8285452: Add a new test library API to replace a file content using FileUtils.java [v5]

2022-04-29 Thread Weijun Wang
On Fri, 29 Apr 2022 12:02:59 GMT, Jaikiran Pai wrote: >> Sibabrata Sahoo has updated the pull request incrementally with one >> additional commit since the last revision: >> >> updated to add space character in begining of multiline string > > test/lib/jdk/test/lib/util/FileUtils.java line

Re: RFR: 8285452: Add a new test library API to replace a file content using FileUtils.java [v5]

2022-04-29 Thread Jaikiran Pai
On Fri, 29 Apr 2022 10:46:31 GMT, Sibabrata Sahoo wrote: >> A new API to support replacing selective lines with desired content. > > Sibabrata Sahoo has updated the pull request incrementally with one > additional commit since the last revision: > > updated to add space character in begining

Re: RFR: 8285452: Add a new test library API to replace a file content using FileUtils.java [v5]

2022-04-29 Thread Jim Laskey
On Fri, 29 Apr 2022 10:46:58 GMT, Sibabrata Sahoo wrote: >> Sibabrata Sahoo has updated the pull request incrementally with one >> additional commit since the last revision: >> >> updated to add space character in begining of multiline string > >

Re: RFR: 8285452: Add a new test library API to replace a file content using FileUtils.java [v5]

2022-04-29 Thread Sibabrata Sahoo
On Fri, 29 Apr 2022 10:46:31 GMT, Sibabrata Sahoo wrote: >> A new API to support replacing selective lines with desired content. > > Sibabrata Sahoo has updated the pull request incrementally with one > additional commit since the last revision: > > updated to add space character in begining

Re: RFR: 8285452: Add a new test library API to replace a file content using FileUtils.java [v5]

2022-04-29 Thread Sibabrata Sahoo
> A new API to support replacing selective lines with desired content. Sibabrata Sahoo has updated the pull request incrementally with one additional commit since the last revision: updated to add space character in begining of multiline string - Changes: - all: