On Fri, 29 Apr 2022 12:02:59 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
>> Sibabrata Sahoo has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> updated to add space character in begining of multiline string
>
> test/lib/jdk/test/lib/util/FileUtils.java line 389:
>
>> 387: * @throws IOException
>> 388: */
>> 389: public static void patch(Path path, int fromLine, int toLine,
>> String from, String to) throws IOException {
>
> Should this method check whether the `fromLine` and `toLine` are valid
> values? Things like, negative value or 0 or `toLine` being less than
> `fromLine`. I'm not familiar with the expectations of test library code -
> maybe those checks aren't necessary since this is a test util?
`lines.remove()` and `lines.subList()` will throw the correct exception. Since
you asked, we can add it.
-------------
PR: https://git.openjdk.java.net/jdk/pull/8360
