On Wed, 11 May 2022 14:24:38 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which fixes build failures on macos
>> when using `--with-zlib=bundled`?
>>
>> With this change the build now passes (tested both with bundled and system
>> zlib variants).
>>
>> tier1, tier2
On Wed, 11 May 2022 22:03:38 GMT, Magnus Ihse Bursie wrote:
> It would not make sense to set the disabled warning in the configure script,
> no. The current code looks perfectly fine. Disabled warnings per module are
> set in the makefiles.
OK, that you for your feedback regarding the
On Wed, 11 May 2022 14:24:38 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which fixes build failures on macos
>> when using `--with-zlib=bundled`?
>>
>> With this change the build now passes (tested both with bundled and system
>> zlib variants).
>>
>> tier1, tier2
On Wed, 11 May 2022 19:14:54 GMT, Lance Andersen wrote:
>> make/autoconf/lib-bundled.m4 line 220:
>>
>>> 218: if test "x$USE_EXTERNAL_LIBZ" = "xfalse"; then
>>> 219: LIBZ_CFLAGS="$LIBZ_CFLAGS
>>> -I$TOPDIR/src/java.base/share/native/libzip/zlib"
>>> 220: if test "x$OPENJDK_TARGET_OS"
On Wed, 11 May 2022 15:03:56 GMT, Lance Andersen wrote:
>> Jaikiran Pai has updated the pull request incrementally with four additional
>> commits since the last revision:
>>
>> - copyright years
>> - disable format-nonliteral warning when building LIBSPLASHSCREEN with
>> bundled zlib
>> -
On Wed, 11 May 2022 14:24:38 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which fixes build failures on macos
>> when using `--with-zlib=bundled`?
>>
>> With this change the build now passes (tested both with bundled and system
>> zlib variants).
>>
>> tier1, tier2
On Wed, 11 May 2022 15:03:56 GMT, Lance Andersen wrote:
>> Jaikiran Pai has updated the pull request incrementally with four additional
>> commits since the last revision:
>>
>> - copyright years
>> - disable format-nonliteral warning when building LIBSPLASHSCREEN with
>> bundled zlib
>> -
On Wed, 11 May 2022 14:24:38 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which fixes build failures on macos
>> when using `--with-zlib=bundled`?
>>
>> With this change the build now passes (tested both with bundled and system
>> zlib variants).
>>
>> tier1, tier2
On Wed, 11 May 2022 14:25:39 GMT, Jaikiran Pai wrote:
>> I agree with Magnus and try to avoid changing the imported zlib code.
>
>> I did these changes locally but for some reason this format-nonliteral is
>> not getting picked up while building that library.
>
> Turns out that was slightly
On Wed, 11 May 2022 11:52:55 GMT, Magnus Ihse Bursie wrote:
>> Jaikiran Pai has updated the pull request incrementally with four additional
>> commits since the last revision:
>>
>> - copyright years
>> - disable format-nonliteral warning when building LIBSPLASHSCREEN with
>> bundled zlib
On Wed, 11 May 2022 12:50:39 GMT, Alan Bateman wrote:
>> Thank you for these useful inputs Magnus. I did these changes locally but
>> for some reason this format-nonliteral is not getting picked up while
>> building that library. I will investigate and see what's going on. Will
>> update the
> Can I please get a review of this change which fixes build failures on macos
> when using `--with-zlib=bundled`?
>
> With this change the build now passes (tested both with bundled and system
> zlib variants).
>
> tier1, tier2 and tier3 testing has been done and no related failures have
>
12 matches
Mail list logo
