Re: RFR: JDK-8235252: Repair run_tests.sh by locating jtreg locally

2019-12-11 Thread Andy Herrick
looks good /Andy On 12/11/2019 3:59 PM, Alexander Matveev wrote: webrev.01 is incorrect, since it uses JTREG_ prefix for variables name. Correct webrev is http://cr.openjdk.java.net/~almatvee/8235252/webrev.02/ It is identical to webrev.01, except prefix of variable names changed to JT_.

Re: RFR: JDK-8235252: Repair run_tests.sh by locating jtreg locally

2019-12-11 Thread Alexander Matveev
webrev.01 is incorrect, since it uses JTREG_ prefix for variables name. Correct webrev is http://cr.openjdk.java.net/~almatvee/8235252/webrev.02/ It is identical to webrev.01, except prefix of variable names changed to JT_. Thanks, Alexander On 12/10/19 3:54 PM, Alexander Matveev wrote:

Re: RFR: JDK-8235252: Repair run_tests.sh by locating jtreg locally

2019-12-10 Thread Alexander Matveev
http://cr.openjdk.java.net/~almatvee/8235252/webrev.01/ - Updated script to use JT_HOME first if set, then use JT_BUNDLE_URL if set. - Also, renamed JTREG_ to JT_ in variables names to align with rest of JDK. Not sure why we did not use jtreg used by all the other tests. run_tests.sh used for

Re: RFR: JDK-8235252: Repair run_tests.sh by locating jtreg locally

2019-12-10 Thread Alexey Semenyuk
http://cr.openjdk.java.net/~almatvee/8235252/webrev.01/ looks good. - Alexey On 12/10/2019 4:49 PM, Jonathan Gibbons wrote: This seems ... surprising. Why is the instance of jtreg used for all the other tests not good enough here? -- Jon On 12/10/19 1:35 PM, Alexander Matveev wrote:

Re: RFR: JDK-8235252: Repair run_tests.sh by locating jtreg locally

2019-12-10 Thread Jonathan Gibbons
This seems ... surprising. Why is the instance of jtreg used for all the other tests not good enough here? -- Jon On 12/10/19 1:35 PM, Alexander Matveev wrote: Please review simple script fix [2] for jpackage bug [1].  - Modified script to download jtreg bundle from URL provided by