Re: RFR[8245658]: 'Arrays.java has two occurrences of bad unicode constants in Javadoc.'

[Daniel Fuchs]

Looks good to me Conor!

best regards,

-- daniel

On 29/05/2020 10:37, Conor Cleary wrote:

Hi,

Could someone please review my webrev for JDK-8245658 'Arrays.java has 
two occurrences of bad unicode constants in Javadoc.'?


In Arrays.java Javadoc, there were two instances of bad Unicode 
formatting where the null character constant was incorrectly specified 
with '\u000' (another zero is required). This fix displays the correct 
Unicode constants in the Javadoc so that outputted docs display '\u'.


bug: https://bugs.openjdk.java.net/browse/JDK-8245658
webrev: 
http://cr.openjdk.java.net/~pconcannon/ccleary/8245658/webrevs/webrev.01/



Regards,
Conor

Re: RFR[8245658]: 'Arrays.java has two occurrences of bad unicode constants in Javadoc.'

[Pavel Rappo]

There were two issues with this sequence in the resulting HTML pages. The first 
one, which you mentioned and fixed, was a missing zero. The second one, which 
you fixed but didn't mention, was an extra slash symbol.

Looks good to me.

P.S. There seem to be more cases where authors assumed the contents of the 
{@code} inline tags are not in any way interpreted. While this is certainly 
true for HTML entities and special symbols, it doesn't eliminate translation of 
\u sequences performed by the compiler.

-Pavel

> On 29 May 2020, at 10:37, Conor Cleary  wrote:
> 
> Hi,
> 
> Could someone please review my webrev for JDK-8245658 'Arrays.java has two 
> occurrences of bad unicode constants in Javadoc.'?
> 
> In Arrays.java Javadoc, there were two instances of bad Unicode formatting 
> where the null character constant was incorrectly specified with '\u000' 
> (another zero is required). This fix displays the correct Unicode constants 
> in the Javadoc so that outputted docs display '\u'.
> 
> bug: https://bugs.openjdk.java.net/browse/JDK-8245658
> webrev: 
> http://cr.openjdk.java.net/~pconcannon/ccleary/8245658/webrevs/webrev.01/
> 
> 
> Regards,
> Conor
> 

Re: RFR[8245658]: 'Arrays.java has two occurrences of bad unicode constants in Javadoc.'

[Lance Andersen]

looks fine Connor

> On May 29, 2020, at 5:37 AM, Conor Cleary  wrote:
> 
> Hi,
> 
> Could someone please review my webrev for JDK-8245658 'Arrays.java has two 
> occurrences of bad unicode constants in Javadoc.'?
> 
> In Arrays.java Javadoc, there were two instances of bad Unicode formatting 
> where the null character constant was incorrectly specified with '\u000' 
> (another zero is required). This fix displays the correct Unicode constants 
> in the Javadoc so that outputted docs display '\u'.
> 
> bug: https://bugs.openjdk.java.net/browse/JDK-8245658
> webrev: 
> http://cr.openjdk.java.net/~pconcannon/ccleary/8245658/webrevs/webrev.01/
> 
> 
> Regards,
> Conor
> 

 
  

 Lance Andersen| 
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
lance.ander...@oracle.com 

Re: RFR[8245658]: 'Arrays.java has two occurrences of bad unicode constants in Javadoc.'

[Lance Andersen]

Hi Connor,

You will want to add the label noreg-doc to the issue before you push for fix

Best
Lance

> On May 29, 2020, at 6:25 AM, Lance Andersen  wrote:
> 
> looks fine Connor
> 
>> On May 29, 2020, at 5:37 AM, Conor Cleary  wrote:
>> 
>> Hi,
>> 
>> Could someone please review my webrev for JDK-8245658 'Arrays.java has two 
>> occurrences of bad unicode constants in Javadoc.'?
>> 
>> In Arrays.java Javadoc, there were two instances of bad Unicode formatting 
>> where the null character constant was incorrectly specified with '\u000' 
>> (another zero is required). This fix displays the correct Unicode constants 
>> in the Javadoc so that outputted docs display '\u'.
>> 
>> bug: https://bugs.openjdk.java.net/browse/JDK-8245658
>> webrev: 
>> http://cr.openjdk.java.net/~pconcannon/ccleary/8245658/webrevs/webrev.01/
>> 
>> 
>> Regards,
>> Conor
>> 
> 
> 
>  
> 
> Lance Andersen| 
> Principal Member of Technical Staff | +1.781.442.2037
> Oracle Java Engineering 
> 1 Network Drive 
> Burlington, MA 01803
> lance.ander...@oracle.com 
> 
> 
> 

 
  

 Lance Andersen| 
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
lance.ander...@oracle.com 

Re: RFR[8245658]: 'Arrays.java has two occurrences of bad unicode constants in Javadoc.'

[James Laskey]

+1



> On May 29, 2020, at 6:37 AM, Conor Cleary  wrote:
> 
> Hi,
> 
> Could someone please review my webrev for JDK-8245658 'Arrays.java has two 
> occurrences of bad unicode constants in Javadoc.'?
> 
> In Arrays.java Javadoc, there were two instances of bad Unicode formatting 
> where the null character constant was incorrectly specified with '\u000' 
> (another zero is required). This fix displays the correct Unicode constants 
> in the Javadoc so that outputted docs display '\u'.
> 
> bug: https://bugs.openjdk.java.net/browse/JDK-8245658
> webrev: 
> http://cr.openjdk.java.net/~pconcannon/ccleary/8245658/webrevs/webrev.01/
> 
> 
> Regards,
> Conor
>